Skip to content

Running verify-std no longer changes Cargo files - #3577

Merged
celinval merged 3 commits into
model-checking:mainfrom
celinval:issue-3574-std-cargo
Oct 8, 2024
Merged

Running verify-std no longer changes Cargo files#3577
celinval merged 3 commits into
model-checking:mainfrom
celinval:issue-3574-std-cargo

Conversation

@celinval

Copy link
Copy Markdown
Contributor

In order to create a dummy crate we were using cargo init command. However, this command will interact with any existing workspace.

Instead, explicitly create a dummy Cargo.toml and src/lib.rs.

Resolves#3574

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT licenses.

@celinval
celinval requested a review from a team as a code ownerOctober 7, 2024 22:07
@celinvalcelinval changed the title Issue 3574 std cargoRunning verify-std no longer changes Cargo filesOct 7, 2024

@carolynzechcarolynzech left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Just a few nits.

Comment threadkani-driver/src/call_cargo.rs
Comment threadkani-driver/src/call_cargo.rs
Comment threadkani-driver/src/call_cargo.rs Outdated
@celinval
celinval enabled auto-merge October 7, 2024 23:49
@celinval
celinval added this pull request to the merge queueOct 8, 2024
Merged via the queue into model-checking:main with commit 91044dbOct 8, 2024
@celinvalcelinval mentioned this pull request Oct 8, 2024
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Unexpected behavior for verify-std when run inside library directory

2 participants

@celinval@carolynzech