Skip to content

Contracts and Harnesses for <*const T>::add, sub and offset - #166

Merged
tautschnig merged 61 commits into
model-checking:mainfrom
stogaru:verify/ptr_const
Dec 3, 2024
Merged

Contracts and Harnesses for <*const T>::add, sub and offset#166
tautschnig merged 61 commits into
model-checking:mainfrom
stogaru:verify/ptr_const

Conversation

@xsxszab

@xsxszabxsxszab commented Nov 15, 2024

Copy link
Copy Markdown

Towards #76

Summary

  • Adds contracts for <*const T>::add, sub and offset.
  • Adds proof for contracts for above methods, verifying following pointee types:
    • All integer types
    • Tuples (representing composite types)
    • Slices
    • Unit type

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT licenses.

szlee118and others added 30 commits September 12, 2024 18:34
@szlee118
Add verification contract for *const T::add and *const T::add
500f249
@xsxszab
Update const_ptr.rs
99701ff
@stogaru
Merge branch 'model-checking:main' into test
31c82a9
@stogaru
Changes generic type to i32 in proof.
f84b7a6
Refactors by removing unused crates and importing safety crate
@szlee118
Remove unneeded file
a839820
xsxszxsxsz
added comments for function contracts and harnesses
21e0ab8
@stogaru
Merge branch 'main' into verify/ptr_const_offset
b54ce9e
@xsxszab
reverted library code format change and removed unnecessary comments
0c0078f
@xsxszab
added macros for verifying all integer types for offset and add
a192129
@xsxszab
implemented function contract and integer type proofs for fn sub
2ef5923
@szlee118
Add verification of slice type proofs for fn offset
f1602aa
@xsxszab
add TODOs for proof for contracts
1b467d5
@xsxszab
verified *mut T::offset for all integer types
9461027
@szlee118
Add verification of slice type proofs for fn add and sub
159137b
@szlee118
Remove commented code
df56d18
@xsxszab
removed unnecessary comments
eab0a15
@xsxszab
reverted changes to mut_ptr.rs
e07040f
@xsxszab
removed necessary comments
0ff52b5
@xsxszab
aligned format for mut_ptr.rs
ccd5c3c
@xsxszab
aligned format for mut_ptr.rs
180a276
@xsxszab
Merge pull request#1from stogaru/verify/ptr_const_integer_types
6a85e3e
Verify/ptr const integer types
@xsxszab
Merge branch 'model-checking:main' into verify/ptr_const_offset
6853284
@stogaru
Adds proofs for composite type - tuple
fb79caf
@stogaru
Change function proof names
7d05c96
@stogaru
Merge pull request#2from stogaru/verify/ptr_const_composite
8e49dcd
Adds proofs for composite type - tuple
@szlee118
Merge branch 'verify/ptr_const_offset' into verify/ptr_const_slice_type
9af0e39
@szlee118
Merge pull request#4from stogaru/verify/ptr_const_slice_type
31532c9
Verify/ptr const slice type
@MayureshJoshi25
Added changes for *const T::add & *const::sub verifying unit type
f9f5371
@MayureshJoshi25
Updated proofs for const ptr (unit type)
eab900e
@stogaru
Merge branch 'verify/ptr_const' into verify/ptr_const_unit_type
05c0fdd
@feliperodrifeliperodri removed their assignment Nov 27, 2024
@feliperodri

feliperodri commented Nov 28, 2024

Copy link
Copy Markdown
Member

@xsxszab could you solve the conflicts?

@szlee118

szlee118 commented Nov 28, 2024

Copy link
Copy Markdown

@feliperodri Conflicts resolved, and I removed the comment stating performance reason improperly.

@szlee118szlee118 mentioned this pull request Nov 28, 2024
Merged
feliperodri
feliperodri reviewed Nov 28, 2024
View reviewed changes
Comment threadlibrary/core/src/ptr/const_ptr.rs Outdated
Comment threadlibrary/core/src/ptr/const_ptr.rs Outdated
Comment threadlibrary/core/src/ptr/const_ptr.rs Outdated
Comment threadlibrary/core/src/ptr/const_ptr.rs Outdated
Comment threadlibrary/core/src/ptr/const_ptr.rs Outdated
tautschnig
tautschnig approved these changes Dec 1, 2024
View reviewed changes
Comment threadlibrary/core/src/ptr/const_ptr.rs Outdated
Comment threadlibrary/core/src/ptr/const_ptr.rs Outdated
Comment threadlibrary/core/src/ptr/const_ptr.rs Outdated
feliperodri
feliperodri approved these changes Dec 3, 2024
View reviewed changes
Comment threadlibrary/core/src/ptr/const_ptr.rs Outdated
celinval
celinval reviewed Dec 3, 2024
View reviewed changes
Comment threadlibrary/core/src/ptr/const_ptr.rs Outdated
@xsxszabxsxszab mentioned this pull request Dec 3, 2024
Merged
@tautschnig
tautschnig enabled auto-merge (squash) December 3, 2024 14:20
@tautschnig
tautschnig merged commit d0d9de2 into model-checking:mainDec 3, 2024
tautschnig pushed a commit that referenced this pull request Dec 4, 2024
@xsxszab
Refactor Contracts and Harnesses for <*mut T>::add, sub and `offs…
2338dad
…et` (#203)
**Summary**
This PR synchronizes updates from PR #166 and applies them to `mut`
function contracts and proof for contracts.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@feliperodrifeliperodrifeliperodri approved these changes
@tautschnigtautschnigtautschnig approved these changes
+3 more reviewers
@Eh2406Eh2406Eh2406 left review comments
@szlee118szlee118szlee118 left review comments
@celinvalcelinvalcelinval left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

@xsxszabxsxszab

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@xsxszab@stogaru@feliperodri@szlee118@tautschnig@Eh2406@celinval@MayureshJoshi25