Skip to content

NonZero (count_one & cmp) Proof - #201

Closed
lang280 wants to merge 6 commits into
model-checking:mainfrom
lang280:nonezero_count_ones_cmp
Closed

NonZero (count_one & cmp) Proof#201
lang280 wants to merge 6 commits into
model-checking:mainfrom
lang280:nonezero_count_ones_cmp

Conversation

@lang280

@lang280 lang280 commented Dec 1, 2024

Copy link
Copy Markdown

Working on #71 (Safety of NonZero)

We are looking for feedback on our proof for count_one and cmp.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT licenses.

@lang280
lang280 requested a review from a team as a code owner December 1, 2024 22:26
Comment thread library/core/src/num/nonzero.rs Outdated
@lang280 lang280 changed the title NonZero (count_one & cmp) Proof (Init) NonZero (count_one & cmp) Proof Dec 4, 2024

@carolynzech carolynzech left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Instead of having a module for each function, can you move all of these harnesses inside of mod verify?

@lang280

lang280 commented Dec 10, 2024

Copy link
Copy Markdown
Author

Nice! Instead of having a module for each function, can you move all of these harnesses inside of mod verify?

Done in NonZero (rotate_left & rotate_right) Proof #202

}

#[cfg(kani)]
mod macro_nonzero_check_count_ones {

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As in the other PRs: please do as you did in #202.

@carolynzech

Copy link
Copy Markdown

Closing because this work got incorporated into #202

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants