Skip to content

Close Challenges 6 & 14; remove optional correctness work in Challenge 12 - #247

Merged
carolynzech merged 23 commits into
model-checking:mainfrom
thanhnguyen-aws:refinechallenges
Mar 21, 2025
Merged

Close Challenges 6 & 14; remove optional correctness work in Challenge 12#247
carolynzech merged 23 commits into
model-checking:mainfrom
thanhnguyen-aws:refinechallenges

Conversation

@thanhnguyen-aws

@thanhnguyen-awsthanhnguyen-aws commented Feb 17, 2025•
edited by carolynzech
Loading

Copy link
Copy Markdown

In this PR, I refined the existing challenges by:

  • Added the missing contracts and harnesses for 3 functions write, write_bytes, write_unaligned for the NonNull challenge, then changed the status of this challenge to "resolved".
  • Edited some descriptions of smallsort
  • Removed the (optional) correctness checking in NonZero challenge.
  • Resolved the Safety of Primitive Conversions challenge.
    I don't add more functions to existing challenge to keep each challenge under manageable size. I will create other challenges for functions inside the same modules as the existing ones.

Resolves#53
Resolves#220

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT licenses.

@thanhnguyen-aws
thanhnguyen-aws requested a review from a team as a code ownerFebruary 17, 2025 18:11
carolynzech
carolynzech reviewed Feb 17, 2025
View reviewed changes
Comment threaddoc/src/challenges/0012-nonzero.md Outdated
carolynzech
carolynzech suggested changes Feb 17, 2025
View reviewed changes
Comment threaddoc/src/challenges/0006-nonnull.md
Comment threaddoc/src/challenges/0014-convert-num.md
carolynzech
carolynzech suggested changes Mar 3, 2025
View reviewed changes

@carolynzechcarolynzech left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't reviewed the harnesses in-depth yet; focused on the contracts and other changes for now.

Comment threadlibrary/Cargo.lock
Comment threaddoc/src/challenges/0006-nonnull.md Outdated
Comment threaddoc/src/challenges/0014-convert-num.md
Comment threadlibrary/core/src/ptr/non_null.rs Outdated
Comment threadlibrary/core/src/ptr/non_null.rs
Comment threadlibrary/core/src/ptr/non_null.rs Outdated
Comment threadlibrary/core/src/ptr/non_null.rs Outdated
Comment threadlibrary/core/src/ptr/non_null.rs Outdated
carolynzech
carolynzech reviewed Mar 17, 2025
View reviewed changes
Comment threaddoc/src/challenges/0012-nonzero.md Outdated
Comment threaddoc/src/challenges/0012-nonzero.md Outdated
Comment threaddoc/src/challenges/0014-convert-num.md
Comment threadlibrary/core/src/ptr/non_null.rs
tautschnig
tautschnig reviewed Mar 18, 2025
View reviewed changes
Comment threaddoc/src/challenges/0008-smallsort.md
@tautschnigtautschnig self-assigned this Mar 18, 2025
tautschnig
tautschnig reviewed Mar 18, 2025
View reviewed changes
Comment threaddoc/src/challenges/0005-linked-list.md Outdated
@tautschnigtautschnig removed their assignment Mar 18, 2025
@carolynzechcarolynzech changed the title Refine challengesClose Challenges 6 & 14; remove optional correctness work in Challenge 12Mar 21, 2025
@carolynzech
carolynzech added this pull request to the merge queueMar 21, 2025
Merged via the queue into model-checking:main with commit 00169b7Mar 21, 2025
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tautschnigtautschnigtautschnig approved these changes
+1 more reviewer
@carolynzechcarolynzechcarolynzech approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@carolynzechcarolynzech

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Challenge 14: Safety of Primitive Conversions Challenge 6: Safety of NonNull

3 participants

@thanhnguyen-aws@tautschnig@carolynzech