Uh oh!
There was an error while loading. Please reload this page.
Subtree Update Automation Fixes - #250
Conversation
carolynzech
commented
Feb 20, 2025
Thanks for the quick PR. Are you also planning to fix the first item in the issue? We shouldn't mark this PR as resolving the issue until it fixes both. |
carolynzech
commented
Feb 21, 2025
Could you also incorporate these changes https://github.com/carolynzech/rust/tree/fix-subtree-bugs in this PR? (It skips the PR creations if they already exist, avoiding situations where we force push over commits that people have made to those PR branches since). |
carolynzech
commented
Feb 21, 2025
It'd also be nice to automate updating the Kani version in |
tautschnig
commented
Feb 21, 2025
Oh, we could actually easily get the Kani commit id from the first step in the automation, which works in the Kani repository anyway. |
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Co-authored-by: Carolyn Zech <cmzech@amazon.com>
carolynzech
left a comment
There was a problem hiding this comment.
Can you update the PR description and title to document the changes you made?
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Can you please make these changes, then I'll approve? Perhaps @tautschnig or @qinheping could review as well.
I have not tested these suggested changes locally; please run it on your fork to make sure I'm right :)
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Co-authored-by: Carolyn Zech <cmzech@amazon.com>
Co-authored-by: Carolyn Zech <cmzech@amazon.com>
thanhnguyen-aws
commented
Mar 3, 2025
I ran this fixed Subtree Update on my fork and see that:
|
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
This restores a fix from model-checking#250 that was deemed no longer necessary with the move to subtree split (in model-checking#270), but this proved to be wrong. (See model-checking@ab648fe for such an example of an unintended change.)
This restores a fix from #250 that was deemed no longer necessary with the move to subtree split (in #270), but this proved to be wrong. (See ab648fe for such an example of an unintended change.) By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT licenses. Co-authored-by: thanhnguyen-aws <ntson@amazon.com>
Improvements to the workflow to update the subtree:
Resolves#249
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT licenses.