Skip to content

align_to and align_to_mut contract and harnesses - #405

Merged
tautschnig merged 8 commits into
model-checking:mainfrom
AlexLB99:check_align_to
Jul 24, 2025
Merged

align_to and align_to_mut contract and harnesses#405
tautschnig merged 8 commits into
model-checking:mainfrom
AlexLB99:check_align_to

Conversation

@AlexLB99

Copy link
Copy Markdown

Towards solving #19

This PR adds harnesses and contracts for align_to() and align_to_mut(). For the contract for align_to_mut(), we're using a wrapper and writing a contract for that instead, due to model-checking/kani#3764.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT licenses.

@AlexLB99
AlexLB99 requested a review from a team as a code ownerJuly 2, 2025 16:01
@tautschnig

Copy link
Copy Markdown
Member

Thank you! We should have a fix for the Kani issue with model-checking/kani#4151 really soon, so I'd love to hold off on this one for about a week so that we can get the Kani fix merged and have this repository use the updated Kani version.

@tautschnigtautschnig self-assigned this Jul 3, 2025
Comment threadlibrary/core/src/slice/mod.rs
Comment threadlibrary/core/src/slice/mod.rs Outdated
@tautschnig

Copy link
Copy Markdown
Member

Thank you! We should have a fix for the Kani issue with model-checking/kani#4151 really soon, so I'd love to hold off on this one for about a week so that we can get the Kani fix merged and have this repository use the updated Kani version.

@AlexLB99 We now have the Kani fix merged and the version of Kani that this repository uses includes this fix. Could you please adjust your implementation so as not to use a workaround anymore?

@AlexLB99

Copy link
Copy Markdown
Author

Thank you! We should have a fix for the Kani issue with model-checking/kani#4151 really soon, so I'd love to hold off on this one for about a week so that we can get the Kani fix merged and have this repository use the updated Kani version.

@AlexLB99 We now have the Kani fix merged and the version of Kani that this repository uses includes this fix. Could you please adjust your implementation so as not to use a workaround anymore?

Thanks for letting me know -- I've added a new commit that removes the workaround (so now align_to_mut itself has a contract)

@tautschnigtautschnig left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please review what changes are actually intended.

Comment threadlibrary/core/src/slice/mod.rs Outdated
Comment threadlibrary/core/src/slice/mod.rs
Comment threadlibrary/core/src/slice/mod.rs
@AlexLB99

AlexLB99 commented Jul 23, 2025

Copy link
Copy Markdown
Author

Yes those were definitely the result of a mis-merge; it should be fixed now

@tautschnig
tautschnig added this pull request to the merge queueJul 24, 2025
Merged via the queue into model-checking:main with commit 099ad08Jul 24, 2025
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@AlexLB99@tautschnig@thanhnguyen-aws