Uh oh!
There was an error while loading. Please reload this page.
CI and rng seeds - #472
Closed
maximebuyse wants to merge 5 commits into
Closed
Conversation
* Provided more detailed description for how to model and test intrinsics * Restored static asserts which were in the upstream code * Switched the use of u64 back to u32 to make it closer to upstream * Defined functions like `transpose` to reduce visual diffs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses part of the feedback in the PR to the upstream repo:
I also added some logging of input value on assertion failures which might also be useful to debug test failures.