Skip to content

Add DistributedCacheEventStreamStore - #1136

Merged
MackinnonBuck merged 26 commits into
mainfrom
mbuck/distributed-sse-event-stream-store
Feb 3, 2026
Merged

Add DistributedCacheEventStreamStore#1136
MackinnonBuck merged 26 commits into
mainfrom
mbuck/distributed-sse-event-stream-store

Conversation

@MackinnonBuck

@MackinnonBuckMackinnonBuck commented Jan 10, 2026•
edited
Loading

Copy link
Copy Markdown
Contributor

Introduces a new distributed cache-backed implementation for ISseEventStreamStore.

Follow-up to #510

stephentoub
stephentoub reviewed Jan 12, 2026
View reviewed changes
Comment threadsrc/ModelContextProtocol.Core/ModelContextProtocol.Core.csproj Outdated
Comment threadsrc/ModelContextProtocol/Server/DistributedCacheEventIdFormatter.cs
Comment threadsrc/ModelContextProtocol/Server/DistributedCacheEventIdFormatter.cs
Comment threadsrc/ModelContextProtocol.Core/Server/DistributedCacheEventStreamStore.cs Outdated
@MackinnonBuckMackinnonBuck mentioned this pull request Jan 13, 2026
Merged
Base automatically changed from mbuck/resumability-redelivery to mainJanuary 15, 2026 06:54
@MackinnonBuck
MackinnonBuckforce-pushed the mbuck/distributed-sse-event-stream-store branch from e01c4f4 to 80b2cb4CompareJanuary 15, 2026 20:25
@MackinnonBuck
MackinnonBuck marked this pull request as ready for review January 20, 2026 16:34
halter73
halter73 reviewed Feb 3, 2026
View reviewed changes

@halter73halter73 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks really good. The cache structure timeout handling seems well thought out. I think stateless support for stream resumption (#1131) might be the next thing to consider for this, and I think this design should work well for that.

Comment threadsrc/ModelContextProtocol/Server/DistributedCacheEventStreamStore.cs Outdated
Comment threadsrc/ModelContextProtocol/Server/DistributedCacheEventStreamStoreOptions.cs Outdated
Comment threadsrc/ModelContextProtocol/Server/DistributedCacheEventStreamStoreOptions.cs Outdated
Comment threadsrc/ModelContextProtocol/Server/DistributedCacheEventStreamStore.cs Outdated
Comment threadsrc/ModelContextProtocol/Server/DistributedCacheEventStreamStore.cs Outdated
Comment threadtests/ModelContextProtocol.Tests/Server/DistributedCacheEventStreamStoreTests.cs Outdated
halter73
halter73 approved these changes Feb 3, 2026
View reviewed changes

@halter73halter73 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@MackinnonBuck
MackinnonBuck merged commit d5c6b0d into mainFeb 3, 2026
16 of 17 checks passed
@MackinnonBuck
MackinnonBuck deleted the mbuck/distributed-sse-event-stream-store branch February 3, 2026 23:48
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@halter73halter73halter73 approved these changes
@stephentoubstephentoubstephentoub left review comments
+1 more reviewer
@scutuatua-cryptoscutuatua-cryptoscutuatua-crypto approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@MackinnonBuckMackinnonBuck

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@MackinnonBuck@halter73@stephentoub@scutuatua-crypto@jeffhandley