Skip to content

Fix _meta properties to use JsonObject#1341

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
stephentoub merged 2 commits into from
Feb 21, 2026
Merged

Fix _meta properties to use JsonObject #1341

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
257acad
Initial plan
Copilot Feb 21, 2026
22ff067
Change Root.Meta from JsonElement? to JsonObject? for consistency wit…
Copilot Feb 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/ModelContextProtocol.Core/Protocol/Root.cs
View file
Open in desktop
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
using System.Diagnostics.CodeAnalysis;
using System.Text.Json;
using System.Text.Json.Nodes;
using System.Text.Json.Serialization;

namespace ModelContextProtocol.Protocol;
Expand DownExpand Up@@ -35,5 +35,5 @@ public sealed class Root
/// This is reserved by the protocol for future use.
/// </remarks>
[JsonPropertyName("_meta")]
public JsonElement? Meta { get; set; }
public JsonObject? Meta { get; set; }
}
5 changes: 3 additions & 2 deletions tests/ModelContextProtocol.Tests/Protocol/RootTests.cs
View file
Open in desktop
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
using ModelContextProtocol.Protocol;
using System.Text.Json;
using System.Text.Json.Nodes;

namespace ModelContextProtocol.Tests.Protocol;

Expand All@@ -12,7 +13,7 @@ public static void Root_SerializationRoundTrip_PreservesAllProperties()
{
Uri = "file:///home/user/project",
Name = "My Project",
Meta = JsonDocument.Parse("""{"custom":"data"}""").RootElement.Clone()
Meta = new JsonObject { ["custom"] = "data" }
};

string json = JsonSerializer.Serialize(original, McpJsonUtilities.DefaultOptions);
Expand All@@ -22,7 +23,7 @@ public static void Root_SerializationRoundTrip_PreservesAllProperties()
Assert.Equal("file:///home/user/project", deserialized.Uri);
Assert.Equal("My Project", deserialized.Name);
Assert.NotNull(deserialized.Meta);
Assert.Equal("data", deserialized.Meta.Value.GetProperty("custom").GetString());
Assert.Equal("data", (string?)deserialized.Meta["custom"]);
}

[Fact]
Expand Down