Uh oh!
There was an error while loading. Please reload this page.
Upgrade to xunit.v3 - #8
Merged
Merged
Conversation
stephentoub
requested review from
eiriktsarpalis
and removed request for
halter73March 20, 2025 03:56
| <PackageVersion Include="System.Linq.AsyncEnumerable" Version="$(System10Version)" /> | ||
| <PackageVersion Include="xunit" Version="2.9.2" /> | ||
| <PackageVersion Include="xunit.runner.visualstudio" Version="3.0.0" /> | ||
| <PackageVersion Include="xunit.v3" Version="2.0.0" /> |
There was a problem hiding this comment.
There is an unresolved issue with xunit.v3 >= 2.0.0 and Rider. I would recommend using 1.0.x for now until it gets resolved.
There was a problem hiding this comment.
Suggested change
| <PackageVersionInclude="xunit.v3"Version="2.0.0" /> | |
| <PackageVersionInclude="xunit.v3"Version="1.1.0" /> |
PranavSenthilnathan added a commit
to PranavSenthilnathan/csharp-sdk
that referenced
this pull request
Jun 11, 2026
- Docs: clarify IMcpTaskStore strong-consistency contract (SEP-2663 modelcontextprotocol#306) on CreateTaskAsync and document the singleton requirement under stateless HTTP; extend tasks.md custom-store requirements list to match (modelcontextprotocol#5, modelcontextprotocol#7). - Tests: add RootsTool fixture + E2E test covering server-initiated roots/list redirection through the task store (modelcontextprotocol#6); add two E2E tests for SendTaskStatusNotificationAsync covering the Working/Completed and Failed branches (modelcontextprotocol#9); add McpServerTasksNoStoreTests pinning the silent sync fallback when a client opts into tasks but no TaskStore is configured (modelcontextprotocol#8). - Rename CompletedTaskResult.TaskResult and CompletedTaskNotificationParams.TaskResult to Result for consistency with the JSON wire name. Wire format unchanged. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.