Skip to content

fix(pdf-server): import highlight/underline/strike from existing PDFs#592

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ochafik merged 3 commits into from
Apr 2, 2026
Merged

fix(pdf-server): import highlight/underline/strike from existing PDFs #592

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
436850c
fix(pdf-server): import highlight/underline/strike from existing PDFs
ochafik Apr 2, 2026
2f989a7
fix(pdf-server): own markup annotations in our layer, not the canvas
ochafik Apr 2, 2026
ba71bd1
Revert "fix(pdf-server): own markup annotations in our layer, not the…
ochafik Apr 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
53 changes: 50 additions & 3 deletions examples/pdf-server/src/pdf-annotations.test.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -460,7 +460,8 @@ describe("importPdfjsAnnotation", () => {
annotationType: 9,
ref: { num: 5, gen: 0 },
rect: [72, 700, 272, 712],
quadPoints: [[72, 712, 272, 712, 72, 700, 272, 700]],
// pdf.js emits a FLAT Float32Array, not nested arrays.
quadPoints: new Float32Array([72, 712, 272, 712, 72, 700, 272, 700]),
color: new Uint8ClampedArray([255, 255, 0]),
contentsObj: { str: "Important" },
};
Expand All@@ -474,12 +475,57 @@ describe("importPdfjsAnnotation", () => {
expect((result as any).color).toBe("#ffff00");
});

it("imports a multi-line highlight (multiple quads → multiple rects)", () => {
// Regression: the parser iterated quadPoints as if nested; pdf.js's
// flat array yielded numbers, so rects stayed empty and import bailed.
const ann = {
annotationType: 9,
ref: { num: 8, gen: 0 },
quadPoints: new Float32Array([
// line 1
72, 712, 272, 712, 72, 700, 272, 700,
// line 2
72, 698, 200, 698, 72, 686, 200, 686,
]),
color: new Uint8ClampedArray([255, 255, 0]),
};
const result = importPdfjsAnnotation(ann, 1, 0);
expect(result).not.toBeNull();
expect(result!.type).toBe("highlight");
expect((result as any).rects).toHaveLength(2);
expect((result as any).rects[0]).toEqual({
x: 72,
y: 700,
width: 200,
height: 12,
});
expect((result as any).rects[1]).toEqual({
x: 72,
y: 686,
width: 128,
height: 12,
});
});

it("falls back to ann.rect when quadPoints is absent", () => {
const ann = {
annotationType: 9,
ref: { num: 9, gen: 0 },
rect: [72, 700, 272, 712],
color: new Uint8ClampedArray([255, 255, 0]),
};
const result = importPdfjsAnnotation(ann, 1, 0);
expect(result).not.toBeNull();
expect((result as any).rects).toHaveLength(1);
});

it("imports an underline annotation", () => {
const ann = {
annotationType: 10,
ref: { num: 6, gen: 0 },
rect: [72, 700, 272, 712],
quadPoints: [[72, 712, 272, 712, 72, 700, 272, 700]],
// pdf.js emits a FLAT Float32Array, not nested arrays.
quadPoints: new Float32Array([72, 712, 272, 712, 72, 700, 272, 700]),
color: new Uint8ClampedArray([255, 0, 0]),
};
const result = importPdfjsAnnotation(ann, 1, 0);
Expand All@@ -493,7 +539,8 @@ describe("importPdfjsAnnotation", () => {
annotationType: 12,
ref: { num: 7, gen: 0 },
rect: [72, 700, 272, 712],
quadPoints: [[72, 712, 272, 712, 72, 700, 272, 700]],
// pdf.js emits a FLAT Float32Array, not nested arrays.
quadPoints: new Float32Array([72, 712, 272, 712, 72, 700, 272, 700]),
color: new Uint8ClampedArray([255, 0, 0]),
};
const result = importPdfjsAnnotation(ann, 2, 0);
Expand Down
47 changes: 21 additions & 26 deletions examples/pdf-server/src/pdf-annotations.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -948,33 +948,28 @@ export function importPdfjsAnnotation(
case "highlight":
case "underline":
case "strikethrough": {
// PDF.js provides quadPoints as array of arrays [[x1,y1,x2,y2,...], ...]
// or rect as [x1,y1,x2,y2]
let rects: Rect[];
if (ann.quadPoints && ann.quadPoints.length > 0) {
rects = [];
for (const qp of ann.quadPoints) {
// Each quadPoint is [x1,y1,x2,y2,x3,y3,x4,y4]
// We need the bounding box
if (qp.length >= 8) {
const xs = [qp[0], qp[2], qp[4], qp[6]];
const ys = [qp[1], qp[3], qp[5], qp[7]];
const minX = Math.min(...xs);
const minY = Math.min(...ys);
const maxX = Math.max(...xs);
const maxY = Math.max(...ys);
rects.push({
x: minX,
y: minY,
width: maxX - minX,
height: maxY - minY,
});
}
// pdf.js emits quadPoints as a FLAT Float32Array [x1,y1,...,x4,y4, …]
// (8 numbers per quad), NOT as nested arrays. Iterating it yields
// numbers, so the old `for (const qp of …) if (qp.length>=8)` never
// matched and every quad-based annotation was dropped (#506).
const rects: Rect[] = [];
const qp = ann.quadPoints as ArrayLike<number> | undefined;
if (qp && qp.length >= 8) {
for (let i = 0; i + 8 <= qp.length; i += 8) {
const xs = [qp[i], qp[i + 2], qp[i + 4], qp[i + 6]];
const ys = [qp[i + 1], qp[i + 3], qp[i + 5], qp[i + 7]];
const minX = Math.min(...xs);
const minY = Math.min(...ys);
rects.push({
x: minX,
y: minY,
width: Math.max(...xs) - minX,
height: Math.max(...ys) - minY,
});
}
} else if (ann.rect) {
rects = [pdfjsRectToRect(ann.rect)];
} else {
return null;
}
if (rects.length === 0 && ann.rect) {
rects.push(pdfjsRectToRect(ann.rect));
}
if (rects.length === 0) return null;

Expand Down
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all 
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
fix(pdf-server): import highlight/underline/strike from existing PDFs by ochafik · Pull Request #592 · modelcontextprotocol/ext-apps · GitHub
Skip to content
fix(pdf-server): import highlight/underline/strike from existing PDFs#592

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

ochafik
merged 3 commits into

from

Apr 2, 2026
 Merged


fix(pdf-server): import highlight/underline/strike from existing PDFs
#592
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


3 commits


Select commit
Hold shift + click to select a range
436850c

fix(pdf-server): import highlight/underline/strike from existing PDFs


ochafik Apr 2, 2026
2f989a7

fix(pdf-server): own markup annotations in our layer, not the canvas


ochafik Apr 2, 2026
ba71bd1

Revert "fix(pdf-server): own markup annotations in our layer, not the…


ochafik Apr 2, 2026

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


53 changes: 50 additions & 3 deletions
examples/pdf-server/src/pdf-annotations.test.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -460,7 +460,8 @@ describe("importPdfjsAnnotation", () => {
 annotationType: 9,
 ref: { num: 5, gen: 0 },
 rect: [72, 700, 272, 712],
 quadPoints: [[72, 712, 272, 712, 72, 700, 272, 700]],
 // pdf.js emits a FLAT Float32Array, not nested arrays.
 quadPoints: new Float32Array([72, 712, 272, 712, 72, 700, 272, 700]),
 color: new Uint8ClampedArray([255, 255, 0]),
 contentsObj: { str: "Important" },
 };
Expand All@@ -474,12 +475,57 @@ describe("importPdfjsAnnotation", () => {
 expect((result as any).color).toBe("#ffff00");
 });

 it("imports a multi-line highlight (multiple quads → multiple rects)", () => {
 // Regression: the parser iterated quadPoints as if nested; pdf.js's
 // flat array yielded numbers, so rects stayed empty and import bailed.
 const ann = {
 annotationType: 9,
 ref: { num: 8, gen: 0 },
 quadPoints: new Float32Array([
 // line 1
 72, 712, 272, 712, 72, 700, 272, 700,
 // line 2
 72, 698, 200, 698, 72, 686, 200, 686,
 ]),
 color: new Uint8ClampedArray([255, 255, 0]),
 };
 const result = importPdfjsAnnotation(ann, 1, 0);
 expect(result).not.toBeNull();
 expect(result!.type).toBe("highlight");
 expect((result as any).rects).toHaveLength(2);
 expect((result as any).rects[0]).toEqual({
 x: 72,
 y: 700,
 width: 200,
 height: 12,
 });
 expect((result as any).rects[1]).toEqual({
 x: 72,
 y: 686,
 width: 128,
 height: 12,
 });
 });

 it("falls back to ann.rect when quadPoints is absent", () => {
 const ann = {
 annotationType: 9,
 ref: { num: 9, gen: 0 },
 rect: [72, 700, 272, 712],
 color: new Uint8ClampedArray([255, 255, 0]),
 };
 const result = importPdfjsAnnotation(ann, 1, 0);
 expect(result).not.toBeNull();
 expect((result as any).rects).toHaveLength(1);
 });

 it("imports an underline annotation", () => {
 const ann = {
 annotationType: 10,
 ref: { num: 6, gen: 0 },
 rect: [72, 700, 272, 712],
 quadPoints: [[72, 712, 272, 712, 72, 700, 272, 700]],
 // pdf.js emits a FLAT Float32Array, not nested arrays.
 quadPoints: new Float32Array([72, 712, 272, 712, 72, 700, 272, 700]),
 color: new Uint8ClampedArray([255, 0, 0]),
 };
 const result = importPdfjsAnnotation(ann, 1, 0);
Expand All@@ -493,7 +539,8 @@ describe("importPdfjsAnnotation", () => {
 annotationType: 12,
 ref: { num: 7, gen: 0 },
 rect: [72, 700, 272, 712],
 quadPoints: [[72, 712, 272, 712, 72, 700, 272, 700]],
 // pdf.js emits a FLAT Float32Array, not nested arrays.
 quadPoints: new Float32Array([72, 712, 272, 712, 72, 700, 272, 700]),
 color: new Uint8ClampedArray([255, 0, 0]),
 };
 const result = importPdfjsAnnotation(ann, 2, 0);
Expand Down

47 changes: 21 additions & 26 deletions
examples/pdf-server/src/pdf-annotations.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -948,33 +948,28 @@ export function importPdfjsAnnotation(
 case "highlight":
 case "underline":
 case "strikethrough": {
 // PDF.js provides quadPoints as array of arrays [[x1,y1,x2,y2,...], ...]
 // or rect as [x1,y1,x2,y2]
 let rects: Rect[];
 if (ann.quadPoints && ann.quadPoints.length > 0) {
 rects = [];
 for (const qp of ann.quadPoints) {
 // Each quadPoint is [x1,y1,x2,y2,x3,y3,x4,y4]
 // We need the bounding box
 if (qp.length >= 8) {
 const xs = [qp[0], qp[2], qp[4], qp[6]];
 const ys = [qp[1], qp[3], qp[5], qp[7]];
 const minX = Math.min(...xs);
 const minY = Math.min(...ys);
 const maxX = Math.max(...xs);
 const maxY = Math.max(...ys);
 rects.push({
 x: minX,
 y: minY,
 width: maxX - minX,
 height: maxY - minY,
 });
 }
 // pdf.js emits quadPoints as a FLAT Float32Array [x1,y1,...,x4,y4, …]
 // (8 numbers per quad), NOT as nested arrays. Iterating it yields
 // numbers, so the old `for (const qp of …) if (qp.length>=8)` never
 // matched and every quad-based annotation was dropped (#506).
 const rects: Rect[] = [];
 const qp = ann.quadPoints as ArrayLike<number> | undefined;
 if (qp && qp.length >= 8) {
 for (let i = 0; i + 8 <= qp.length; i += 8) {
 const xs = [qp[i], qp[i + 2], qp[i + 4], qp[i + 6]];
 const ys = [qp[i + 1], qp[i + 3], qp[i + 5], qp[i + 7]];
 const minX = Math.min(...xs);
 const minY = Math.min(...ys);
 rects.push({
 x: minX,
 y: minY,
 width: Math.max(...xs) - minX,
 height: Math.max(...ys) - minY,
 });
 }
 } else if (ann.rect) {
 rects = [pdfjsRectToRect(ann.rect)];
 } else {
 return null;
 }
 if (rects.length === 0 && ann.rect) {
 rects.push(pdfjsRectToRect(ann.rect));
 }
 if (rects.length === 0) return null;

Expand Down
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Force GitHub README to respect dark mode
(function() {
var style = document.createElement('style');
style.textContent = '
.markdown-body {
color-scheme: dark light;
}
.markdown-body pre { background: #161b22 !important; }
.markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }
.markdown-body table th, .markdown-body table td { border-color: #30363d !important; }
.markdown-body img { background: #0d1117; }
.markdown-body blockquote { border-left-color: #8b949e; }
.markdown-body hr { border-color: #30363d; }
';
document.head.appendChild(style);
})();
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
fix(pdf-server): import highlight/underline/strike from existing PDFs by ochafik · Pull Request #592 · modelcontextprotocol/ext-apps · GitHub
Skip to content
fix(pdf-server): import highlight/underline/strike from existing PDFs#592

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

ochafik
merged 3 commits into

from

Apr 2, 2026
 Merged


fix(pdf-server): import highlight/underline/strike from existing PDFs
#592
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


3 commits


Select commit
Hold shift + click to select a range
436850c

fix(pdf-server): import highlight/underline/strike from existing PDFs


ochafik Apr 2, 2026
2f989a7

fix(pdf-server): own markup annotations in our layer, not the canvas


ochafik Apr 2, 2026
ba71bd1

Revert "fix(pdf-server): own markup annotations in our layer, not the…


ochafik Apr 2, 2026

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


53 changes: 50 additions & 3 deletions
examples/pdf-server/src/pdf-annotations.test.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -460,7 +460,8 @@ describe("importPdfjsAnnotation", () => {
 annotationType: 9,
 ref: { num: 5, gen: 0 },
 rect: [72, 700, 272, 712],
 quadPoints: [[72, 712, 272, 712, 72, 700, 272, 700]],
 // pdf.js emits a FLAT Float32Array, not nested arrays.
 quadPoints: new Float32Array([72, 712, 272, 712, 72, 700, 272, 700]),
 color: new Uint8ClampedArray([255, 255, 0]),
 contentsObj: { str: "Important" },
 };
Expand All@@ -474,12 +475,57 @@ describe("importPdfjsAnnotation", () => {
 expect((result as any).color).toBe("#ffff00");
 });

 it("imports a multi-line highlight (multiple quads → multiple rects)", () => {
 // Regression: the parser iterated quadPoints as if nested; pdf.js's
 // flat array yielded numbers, so rects stayed empty and import bailed.
 const ann = {
 annotationType: 9,
 ref: { num: 8, gen: 0 },
 quadPoints: new Float32Array([
 // line 1
 72, 712, 272, 712, 72, 700, 272, 700,
 // line 2
 72, 698, 200, 698, 72, 686, 200, 686,
 ]),
 color: new Uint8ClampedArray([255, 255, 0]),
 };
 const result = importPdfjsAnnotation(ann, 1, 0);
 expect(result).not.toBeNull();
 expect(result!.type).toBe("highlight");
 expect((result as any).rects).toHaveLength(2);
 expect((result as any).rects[0]).toEqual({
 x: 72,
 y: 700,
 width: 200,
 height: 12,
 });
 expect((result as any).rects[1]).toEqual({
 x: 72,
 y: 686,
 width: 128,
 height: 12,
 });
 });

 it("falls back to ann.rect when quadPoints is absent", () => {
 const ann = {
 annotationType: 9,
 ref: { num: 9, gen: 0 },
 rect: [72, 700, 272, 712],
 color: new Uint8ClampedArray([255, 255, 0]),
 };
 const result = importPdfjsAnnotation(ann, 1, 0);
 expect(result).not.toBeNull();
 expect((result as any).rects).toHaveLength(1);
 });

 it("imports an underline annotation", () => {
 const ann = {
 annotationType: 10,
 ref: { num: 6, gen: 0 },
 rect: [72, 700, 272, 712],
 quadPoints: [[72, 712, 272, 712, 72, 700, 272, 700]],
 // pdf.js emits a FLAT Float32Array, not nested arrays.
 quadPoints: new Float32Array([72, 712, 272, 712, 72, 700, 272, 700]),
 color: new Uint8ClampedArray([255, 0, 0]),
 };
 const result = importPdfjsAnnotation(ann, 1, 0);
Expand All@@ -493,7 +539,8 @@ describe("importPdfjsAnnotation", () => {
 annotationType: 12,
 ref: { num: 7, gen: 0 },
 rect: [72, 700, 272, 712],
 quadPoints: [[72, 712, 272, 712, 72, 700, 272, 700]],
 // pdf.js emits a FLAT Float32Array, not nested arrays.
 quadPoints: new Float32Array([72, 712, 272, 712, 72, 700, 272, 700]),
 color: new Uint8ClampedArray([255, 0, 0]),
 };
 const result = importPdfjsAnnotation(ann, 2, 0);
Expand Down

47 changes: 21 additions & 26 deletions
examples/pdf-server/src/pdf-annotations.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -948,33 +948,28 @@ export function importPdfjsAnnotation(
 case "highlight":
 case "underline":
 case "strikethrough": {
 // PDF.js provides quadPoints as array of arrays [[x1,y1,x2,y2,...], ...]
 // or rect as [x1,y1,x2,y2]
 let rects: Rect[];
 if (ann.quadPoints && ann.quadPoints.length > 0) {
 rects = [];
 for (const qp of ann.quadPoints) {
 // Each quadPoint is [x1,y1,x2,y2,x3,y3,x4,y4]
 // We need the bounding box
 if (qp.length >= 8) {
 const xs = [qp[0], qp[2], qp[4], qp[6]];
 const ys = [qp[1], qp[3], qp[5], qp[7]];
 const minX = Math.min(...xs);
 const minY = Math.min(...ys);
 const maxX = Math.max(...xs);
 const maxY = Math.max(...ys);
 rects.push({
 x: minX,
 y: minY,
 width: maxX - minX,
 height: maxY - minY,
 });
 }
 // pdf.js emits quadPoints as a FLAT Float32Array [x1,y1,...,x4,y4, …]
 // (8 numbers per quad), NOT as nested arrays. Iterating it yields
 // numbers, so the old `for (const qp of …) if (qp.length>=8)` never
 // matched and every quad-based annotation was dropped (#506).
 const rects: Rect[] = [];
 const qp = ann.quadPoints as ArrayLike<number> | undefined;
 if (qp && qp.length >= 8) {
 for (let i = 0; i + 8 <= qp.length; i += 8) {
 const xs = [qp[i], qp[i + 2], qp[i + 4], qp[i + 6]];
 const ys = [qp[i + 1], qp[i + 3], qp[i + 5], qp[i + 7]];
 const minX = Math.min(...xs);
 const minY = Math.min(...ys);
 rects.push({
 x: minX,
 y: minY,
 width: Math.max(...xs) - minX,
 height: Math.max(...ys) - minY,
 });
 }
 } else if (ann.rect) {
 rects = [pdfjsRectToRect(ann.rect)];
 } else {
 return null;
 }
 if (rects.length === 0 && ann.rect) {
 rects.push(pdfjsRectToRect(ann.rect));
 }
 if (rects.length === 0) return null;

Expand Down
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Highlight search terms from Google/DuckDuckGo/Bing referrer
(function() {
var ref = document.referrer;
var terms = [];
if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {
var url = new URL(ref);
var q = url.searchParams.get('q') || url.searchParams.get('p');
if (q) {
terms = q.split(/\s+/).filter(function(t) { return t.length > 2; });
}
}
if (terms.length === 0) return;
var style = document.createElement('style');
style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';
document.head.appendChild(style);
function highlight(node) {
if (node.nodeType === 3) { // text node
var text = node.textContent;
var found = false;
terms.forEach(function(term) {
var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi');
if (regex.test(text)) {
found = true;
var frag = document.createDocumentFragment();
var parts = text.split(regex);
parts.forEach(function(part, i) {
if (i % 2 === 0) {
frag.appendChild(document.createTextNode(part));
} else {
var span = document.createElement('span');
span.className = 'userscript-highlight';
span.textContent = part;
frag.appendChild(span);
}
});
node.parentNode.replaceChild(frag, node);
}
});
} else if (node.nodeType === 1 && node.childNodes) { // element
var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];
if (!skipTags.includes(node.tagName)) {
Array.from(node.childNodes).forEach(highlight);
}
}
}
highlight(document.body);
// Re-highlight on dynamic content
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1 || node.nodeType === 3) highlight(node);
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
fix(pdf-server): import highlight/underline/strike from existing PDFs by ochafik · Pull Request #592 · modelcontextprotocol/ext-apps · GitHub
Skip to content
fix(pdf-server): import highlight/underline/strike from existing PDFs#592

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

ochafik
merged 3 commits into

from

Apr 2, 2026
 Merged


fix(pdf-server): import highlight/underline/strike from existing PDFs
#592
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


3 commits


Select commit
Hold shift + click to select a range
436850c

fix(pdf-server): import highlight/underline/strike from existing PDFs


ochafik Apr 2, 2026
2f989a7

fix(pdf-server): own markup annotations in our layer, not the canvas


ochafik Apr 2, 2026
ba71bd1

Revert "fix(pdf-server): own markup annotations in our layer, not the…


ochafik Apr 2, 2026

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


53 changes: 50 additions & 3 deletions
examples/pdf-server/src/pdf-annotations.test.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -460,7 +460,8 @@ describe("importPdfjsAnnotation", () => {
 annotationType: 9,
 ref: { num: 5, gen: 0 },
 rect: [72, 700, 272, 712],
 quadPoints: [[72, 712, 272, 712, 72, 700, 272, 700]],
 // pdf.js emits a FLAT Float32Array, not nested arrays.
 quadPoints: new Float32Array([72, 712, 272, 712, 72, 700, 272, 700]),
 color: new Uint8ClampedArray([255, 255, 0]),
 contentsObj: { str: "Important" },
 };
Expand All@@ -474,12 +475,57 @@ describe("importPdfjsAnnotation", () => {
 expect((result as any).color).toBe("#ffff00");
 });

 it("imports a multi-line highlight (multiple quads → multiple rects)", () => {
 // Regression: the parser iterated quadPoints as if nested; pdf.js's
 // flat array yielded numbers, so rects stayed empty and import bailed.
 const ann = {
 annotationType: 9,
 ref: { num: 8, gen: 0 },
 quadPoints: new Float32Array([
 // line 1
 72, 712, 272, 712, 72, 700, 272, 700,
 // line 2
 72, 698, 200, 698, 72, 686, 200, 686,
 ]),
 color: new Uint8ClampedArray([255, 255, 0]),
 };
 const result = importPdfjsAnnotation(ann, 1, 0);
 expect(result).not.toBeNull();
 expect(result!.type).toBe("highlight");
 expect((result as any).rects).toHaveLength(2);
 expect((result as any).rects[0]).toEqual({
 x: 72,
 y: 700,
 width: 200,
 height: 12,
 });
 expect((result as any).rects[1]).toEqual({
 x: 72,
 y: 686,
 width: 128,
 height: 12,
 });
 });

 it("falls back to ann.rect when quadPoints is absent", () => {
 const ann = {
 annotationType: 9,
 ref: { num: 9, gen: 0 },
 rect: [72, 700, 272, 712],
 color: new Uint8ClampedArray([255, 255, 0]),
 };
 const result = importPdfjsAnnotation(ann, 1, 0);
 expect(result).not.toBeNull();
 expect((result as any).rects).toHaveLength(1);
 });

 it("imports an underline annotation", () => {
 const ann = {
 annotationType: 10,
 ref: { num: 6, gen: 0 },
 rect: [72, 700, 272, 712],
 quadPoints: [[72, 712, 272, 712, 72, 700, 272, 700]],
 // pdf.js emits a FLAT Float32Array, not nested arrays.
 quadPoints: new Float32Array([72, 712, 272, 712, 72, 700, 272, 700]),
 color: new Uint8ClampedArray([255, 0, 0]),
 };
 const result = importPdfjsAnnotation(ann, 1, 0);
Expand All@@ -493,7 +539,8 @@ describe("importPdfjsAnnotation", () => {
 annotationType: 12,
 ref: { num: 7, gen: 0 },
 rect: [72, 700, 272, 712],
 quadPoints: [[72, 712, 272, 712, 72, 700, 272, 700]],
 // pdf.js emits a FLAT Float32Array, not nested arrays.
 quadPoints: new Float32Array([72, 712, 272, 712, 72, 700, 272, 700]),
 color: new Uint8ClampedArray([255, 0, 0]),
 };
 const result = importPdfjsAnnotation(ann, 2, 0);
Expand Down

47 changes: 21 additions & 26 deletions
examples/pdf-server/src/pdf-annotations.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -948,33 +948,28 @@ export function importPdfjsAnnotation(
 case "highlight":
 case "underline":
 case "strikethrough": {
 // PDF.js provides quadPoints as array of arrays [[x1,y1,x2,y2,...], ...]
 // or rect as [x1,y1,x2,y2]
 let rects: Rect[];
 if (ann.quadPoints && ann.quadPoints.length > 0) {
 rects = [];
 for (const qp of ann.quadPoints) {
 // Each quadPoint is [x1,y1,x2,y2,x3,y3,x4,y4]
 // We need the bounding box
 if (qp.length >= 8) {
 const xs = [qp[0], qp[2], qp[4], qp[6]];
 const ys = [qp[1], qp[3], qp[5], qp[7]];
 const minX = Math.min(...xs);
 const minY = Math.min(...ys);
 const maxX = Math.max(...xs);
 const maxY = Math.max(...ys);
 rects.push({
 x: minX,
 y: minY,
 width: maxX - minX,
 height: maxY - minY,
 });
 }
 // pdf.js emits quadPoints as a FLAT Float32Array [x1,y1,...,x4,y4, …]
 // (8 numbers per quad), NOT as nested arrays. Iterating it yields
 // numbers, so the old `for (const qp of …) if (qp.length>=8)` never
 // matched and every quad-based annotation was dropped (#506).
 const rects: Rect[] = [];
 const qp = ann.quadPoints as ArrayLike<number> | undefined;
 if (qp && qp.length >= 8) {
 for (let i = 0; i + 8 <= qp.length; i += 8) {
 const xs = [qp[i], qp[i + 2], qp[i + 4], qp[i + 6]];
 const ys = [qp[i + 1], qp[i + 3], qp[i + 5], qp[i + 7]];
 const minX = Math.min(...xs);
 const minY = Math.min(...ys);
 rects.push({
 x: minX,
 y: minY,
 width: Math.max(...xs) - minX,
 height: Math.max(...ys) - minY,
 });
 }
 } else if (ann.rect) {
 rects = [pdfjsRectToRect(ann.rect)];
 } else {
 return null;
 }
 if (rects.length === 0 && ann.rect) {
 rects.push(pdfjsRectToRect(ann.rect));
 }
 if (rects.length === 0) return null;

Expand Down
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Strip utm_, fbclid, gclid, etc. from all links on page
(function() {
var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',
'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',
'ref', 'ref_src', 'source', 'medium', 'campaign'];
function cleanUrl(url) {
try {
var u = new URL(url, window.location.origin);
var changed = false;
trackingParams.forEach(function(p) {
if (u.searchParams.has(p)) {
u.searchParams.delete(p);
changed = true;
}
});
return changed ? u.toString() : url;
} catch (e) {
return url;
}
}
function cleanLinks() {
document.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
cleanLinks();
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1) {
if (node.tagName === 'A') cleanLinks();
node.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '
fix(pdf-server): import highlight/underline/strike from existing PDFs by ochafik · Pull Request #592 · modelcontextprotocol/ext-apps · GitHub
Skip to content
fix(pdf-server): import highlight/underline/strike from existing PDFs#592

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

ochafik
merged 3 commits into

from

Apr 2, 2026
 Merged


fix(pdf-server): import highlight/underline/strike from existing PDFs
#592
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


3 commits


Select commit
Hold shift + click to select a range
436850c

fix(pdf-server): import highlight/underline/strike from existing PDFs


ochafik Apr 2, 2026
2f989a7

fix(pdf-server): own markup annotations in our layer, not the canvas


ochafik Apr 2, 2026
ba71bd1

Revert "fix(pdf-server): own markup annotations in our layer, not the…


ochafik Apr 2, 2026

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


53 changes: 50 additions & 3 deletions
examples/pdf-server/src/pdf-annotations.test.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -460,7 +460,8 @@ describe("importPdfjsAnnotation", () => {
 annotationType: 9,
 ref: { num: 5, gen: 0 },
 rect: [72, 700, 272, 712],
 quadPoints: [[72, 712, 272, 712, 72, 700, 272, 700]],
 // pdf.js emits a FLAT Float32Array, not nested arrays.
 quadPoints: new Float32Array([72, 712, 272, 712, 72, 700, 272, 700]),
 color: new Uint8ClampedArray([255, 255, 0]),
 contentsObj: { str: "Important" },
 };
Expand All@@ -474,12 +475,57 @@ describe("importPdfjsAnnotation", () => {
 expect((result as any).color).toBe("#ffff00");
 });

 it("imports a multi-line highlight (multiple quads → multiple rects)", () => {
 // Regression: the parser iterated quadPoints as if nested; pdf.js's
 // flat array yielded numbers, so rects stayed empty and import bailed.
 const ann = {
 annotationType: 9,
 ref: { num: 8, gen: 0 },
 quadPoints: new Float32Array([
 // line 1
 72, 712, 272, 712, 72, 700, 272, 700,
 // line 2
 72, 698, 200, 698, 72, 686, 200, 686,
 ]),
 color: new Uint8ClampedArray([255, 255, 0]),
 };
 const result = importPdfjsAnnotation(ann, 1, 0);
 expect(result).not.toBeNull();
 expect(result!.type).toBe("highlight");
 expect((result as any).rects).toHaveLength(2);
 expect((result as any).rects[0]).toEqual({
 x: 72,
 y: 700,
 width: 200,
 height: 12,
 });
 expect((result as any).rects[1]).toEqual({
 x: 72,
 y: 686,
 width: 128,
 height: 12,
 });
 });

 it("falls back to ann.rect when quadPoints is absent", () => {
 const ann = {
 annotationType: 9,
 ref: { num: 9, gen: 0 },
 rect: [72, 700, 272, 712],
 color: new Uint8ClampedArray([255, 255, 0]),
 };
 const result = importPdfjsAnnotation(ann, 1, 0);
 expect(result).not.toBeNull();
 expect((result as any).rects).toHaveLength(1);
 });

 it("imports an underline annotation", () => {
 const ann = {
 annotationType: 10,
 ref: { num: 6, gen: 0 },
 rect: [72, 700, 272, 712],
 quadPoints: [[72, 712, 272, 712, 72, 700, 272, 700]],
 // pdf.js emits a FLAT Float32Array, not nested arrays.
 quadPoints: new Float32Array([72, 712, 272, 712, 72, 700, 272, 700]),
 color: new Uint8ClampedArray([255, 0, 0]),
 };
 const result = importPdfjsAnnotation(ann, 1, 0);
Expand All@@ -493,7 +539,8 @@ describe("importPdfjsAnnotation", () => {
 annotationType: 12,
 ref: { num: 7, gen: 0 },
 rect: [72, 700, 272, 712],
 quadPoints: [[72, 712, 272, 712, 72, 700, 272, 700]],
 // pdf.js emits a FLAT Float32Array, not nested arrays.
 quadPoints: new Float32Array([72, 712, 272, 712, 72, 700, 272, 700]),
 color: new Uint8ClampedArray([255, 0, 0]),
 };
 const result = importPdfjsAnnotation(ann, 2, 0);
Expand Down

47 changes: 21 additions & 26 deletions
examples/pdf-server/src/pdf-annotations.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -948,33 +948,28 @@ export function importPdfjsAnnotation(
 case "highlight":
 case "underline":
 case "strikethrough": {
 // PDF.js provides quadPoints as array of arrays [[x1,y1,x2,y2,...], ...]
 // or rect as [x1,y1,x2,y2]
 let rects: Rect[];
 if (ann.quadPoints && ann.quadPoints.length > 0) {
 rects = [];
 for (const qp of ann.quadPoints) {
 // Each quadPoint is [x1,y1,x2,y2,x3,y3,x4,y4]
 // We need the bounding box
 if (qp.length >= 8) {
 const xs = [qp[0], qp[2], qp[4], qp[6]];
 const ys = [qp[1], qp[3], qp[5], qp[7]];
 const minX = Math.min(...xs);
 const minY = Math.min(...ys);
 const maxX = Math.max(...xs);
 const maxY = Math.max(...ys);
 rects.push({
 x: minX,
 y: minY,
 width: maxX - minX,
 height: maxY - minY,
 });
 }
 // pdf.js emits quadPoints as a FLAT Float32Array [x1,y1,...,x4,y4, …]
 // (8 numbers per quad), NOT as nested arrays. Iterating it yields
 // numbers, so the old `for (const qp of …) if (qp.length>=8)` never
 // matched and every quad-based annotation was dropped (#506).
 const rects: Rect[] = [];
 const qp = ann.quadPoints as ArrayLike<number> | undefined;
 if (qp && qp.length >= 8) {
 for (let i = 0; i + 8 <= qp.length; i += 8) {
 const xs = [qp[i], qp[i + 2], qp[i + 4], qp[i + 6]];
 const ys = [qp[i + 1], qp[i + 3], qp[i + 5], qp[i + 7]];
 const minX = Math.min(...xs);
 const minY = Math.min(...ys);
 rects.push({
 x: minX,
 y: minY,
 width: Math.max(...xs) - minX,
 height: Math.max(...ys) - minY,
 });
 }
 } else if (ann.rect) {
 rects = [pdfjsRectToRect(ann.rect)];
 } else {
 return null;
 }
 if (rects.length === 0 && ann.rect) {
 rects.push(pdfjsRectToRect(ann.rect));
 }
 if (rects.length === 0) return null;

Expand Down
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Auto-enable theater mode on YouTube
(function() {
function tryTheater() {
var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]');
if (btn && !btn.classList.contains('activated')) {
btn.click();
}
}
// Try immediately
tryTheater();
// Try after navigation (SPA)
var lastUrl = location.href;
setInterval(function() {
if (location.href !== lastUrl) {
lastUrl = location.href;
setTimeout(tryTheater, 500);
}
}, 1000);
// Also try on player load
var observer = new MutationObserver(tryTheater);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
fix(pdf-server): import highlight/underline/strike from existing PDFs by ochafik · Pull Request #592 · modelcontextprotocol/ext-apps · GitHub
Skip to content
fix(pdf-server): import highlight/underline/strike from existing PDFs#592

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

ochafik
merged 3 commits into

from

Apr 2, 2026
 Merged


fix(pdf-server): import highlight/underline/strike from existing PDFs
#592
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


3 commits


Select commit
Hold shift + click to select a range
436850c

fix(pdf-server): import highlight/underline/strike from existing PDFs


ochafik Apr 2, 2026
2f989a7

fix(pdf-server): own markup annotations in our layer, not the canvas


ochafik Apr 2, 2026
ba71bd1

Revert "fix(pdf-server): own markup annotations in our layer, not the…


ochafik Apr 2, 2026

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


53 changes: 50 additions & 3 deletions
examples/pdf-server/src/pdf-annotations.test.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -460,7 +460,8 @@ describe("importPdfjsAnnotation", () => {
 annotationType: 9,
 ref: { num: 5, gen: 0 },
 rect: [72, 700, 272, 712],
 quadPoints: [[72, 712, 272, 712, 72, 700, 272, 700]],
 // pdf.js emits a FLAT Float32Array, not nested arrays.
 quadPoints: new Float32Array([72, 712, 272, 712, 72, 700, 272, 700]),
 color: new Uint8ClampedArray([255, 255, 0]),
 contentsObj: { str: "Important" },
 };
Expand All@@ -474,12 +475,57 @@ describe("importPdfjsAnnotation", () => {
 expect((result as any).color).toBe("#ffff00");
 });

 it("imports a multi-line highlight (multiple quads → multiple rects)", () => {
 // Regression: the parser iterated quadPoints as if nested; pdf.js's
 // flat array yielded numbers, so rects stayed empty and import bailed.
 const ann = {
 annotationType: 9,
 ref: { num: 8, gen: 0 },
 quadPoints: new Float32Array([
 // line 1
 72, 712, 272, 712, 72, 700, 272, 700,
 // line 2
 72, 698, 200, 698, 72, 686, 200, 686,
 ]),
 color: new Uint8ClampedArray([255, 255, 0]),
 };
 const result = importPdfjsAnnotation(ann, 1, 0);
 expect(result).not.toBeNull();
 expect(result!.type).toBe("highlight");
 expect((result as any).rects).toHaveLength(2);
 expect((result as any).rects[0]).toEqual({
 x: 72,
 y: 700,
 width: 200,
 height: 12,
 });
 expect((result as any).rects[1]).toEqual({
 x: 72,
 y: 686,
 width: 128,
 height: 12,
 });
 });

 it("falls back to ann.rect when quadPoints is absent", () => {
 const ann = {
 annotationType: 9,
 ref: { num: 9, gen: 0 },
 rect: [72, 700, 272, 712],
 color: new Uint8ClampedArray([255, 255, 0]),
 };
 const result = importPdfjsAnnotation(ann, 1, 0);
 expect(result).not.toBeNull();
 expect((result as any).rects).toHaveLength(1);
 });

 it("imports an underline annotation", () => {
 const ann = {
 annotationType: 10,
 ref: { num: 6, gen: 0 },
 rect: [72, 700, 272, 712],
 quadPoints: [[72, 712, 272, 712, 72, 700, 272, 700]],
 // pdf.js emits a FLAT Float32Array, not nested arrays.
 quadPoints: new Float32Array([72, 712, 272, 712, 72, 700, 272, 700]),
 color: new Uint8ClampedArray([255, 0, 0]),
 };
 const result = importPdfjsAnnotation(ann, 1, 0);
Expand All@@ -493,7 +539,8 @@ describe("importPdfjsAnnotation", () => {
 annotationType: 12,
 ref: { num: 7, gen: 0 },
 rect: [72, 700, 272, 712],
 quadPoints: [[72, 712, 272, 712, 72, 700, 272, 700]],
 // pdf.js emits a FLAT Float32Array, not nested arrays.
 quadPoints: new Float32Array([72, 712, 272, 712, 72, 700, 272, 700]),
 color: new Uint8ClampedArray([255, 0, 0]),
 };
 const result = importPdfjsAnnotation(ann, 2, 0);
Expand Down

47 changes: 21 additions & 26 deletions
examples/pdf-server/src/pdf-annotations.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -948,33 +948,28 @@ export function importPdfjsAnnotation(
 case "highlight":
 case "underline":
 case "strikethrough": {
 // PDF.js provides quadPoints as array of arrays [[x1,y1,x2,y2,...], ...]
 // or rect as [x1,y1,x2,y2]
 let rects: Rect[];
 if (ann.quadPoints && ann.quadPoints.length > 0) {
 rects = [];
 for (const qp of ann.quadPoints) {
 // Each quadPoint is [x1,y1,x2,y2,x3,y3,x4,y4]
 // We need the bounding box
 if (qp.length >= 8) {
 const xs = [qp[0], qp[2], qp[4], qp[6]];
 const ys = [qp[1], qp[3], qp[5], qp[7]];
 const minX = Math.min(...xs);
 const minY = Math.min(...ys);
 const maxX = Math.max(...xs);
 const maxY = Math.max(...ys);
 rects.push({
 x: minX,
 y: minY,
 width: maxX - minX,
 height: maxY - minY,
 });
 }
 // pdf.js emits quadPoints as a FLAT Float32Array [x1,y1,...,x4,y4, …]
 // (8 numbers per quad), NOT as nested arrays. Iterating it yields
 // numbers, so the old `for (const qp of …) if (qp.length>=8)` never
 // matched and every quad-based annotation was dropped (#506).
 const rects: Rect[] = [];
 const qp = ann.quadPoints as ArrayLike<number> | undefined;
 if (qp && qp.length >= 8) {
 for (let i = 0; i + 8 <= qp.length; i += 8) {
 const xs = [qp[i], qp[i + 2], qp[i + 4], qp[i + 6]];
 const ys = [qp[i + 1], qp[i + 3], qp[i + 5], qp[i + 7]];
 const minX = Math.min(...xs);
 const minY = Math.min(...ys);
 rects.push({
 x: minX,
 y: minY,
 width: Math.max(...xs) - minX,
 height: Math.max(...ys) - minY,
 });
 }
 } else if (ann.rect) {
 rects = [pdfjsRectToRect(ann.rect)];
 } else {
 return null;
 }
 if (rects.length === 0 && ann.rect) {
 rects.push(pdfjsRectToRect(ann.rect));
 }
 if (rects.length === 0) return null;

Expand Down
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Remove or un-stick sticky/fixed headers that block content
(function() {
function unstick() {
document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) {
if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {
el.style.position = 'static';
el.style.top = 'auto';
el.style.zIndex = 'auto';
}
});
}
unstick();
var observer = new MutationObserver(unstick);
observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });
})();
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
fix(pdf-server): import highlight/underline/strike from existing PDFs by ochafik · Pull Request #592 · modelcontextprotocol/ext-apps · GitHub
Skip to content
fix(pdf-server): import highlight/underline/strike from existing PDFs#592

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

ochafik
merged 3 commits into

from

Apr 2, 2026
 Merged


fix(pdf-server): import highlight/underline/strike from existing PDFs
#592
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


3 commits


Select commit
Hold shift + click to select a range
436850c

fix(pdf-server): import highlight/underline/strike from existing PDFs


ochafik Apr 2, 2026
2f989a7

fix(pdf-server): own markup annotations in our layer, not the canvas


ochafik Apr 2, 2026
ba71bd1

Revert "fix(pdf-server): own markup annotations in our layer, not the…


ochafik Apr 2, 2026

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


53 changes: 50 additions & 3 deletions
examples/pdf-server/src/pdf-annotations.test.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -460,7 +460,8 @@ describe("importPdfjsAnnotation", () => {
 annotationType: 9,
 ref: { num: 5, gen: 0 },
 rect: [72, 700, 272, 712],
 quadPoints: [[72, 712, 272, 712, 72, 700, 272, 700]],
 // pdf.js emits a FLAT Float32Array, not nested arrays.
 quadPoints: new Float32Array([72, 712, 272, 712, 72, 700, 272, 700]),
 color: new Uint8ClampedArray([255, 255, 0]),
 contentsObj: { str: "Important" },
 };
Expand All@@ -474,12 +475,57 @@ describe("importPdfjsAnnotation", () => {
 expect((result as any).color).toBe("#ffff00");
 });

 it("imports a multi-line highlight (multiple quads → multiple rects)", () => {
 // Regression: the parser iterated quadPoints as if nested; pdf.js's
 // flat array yielded numbers, so rects stayed empty and import bailed.
 const ann = {
 annotationType: 9,
 ref: { num: 8, gen: 0 },
 quadPoints: new Float32Array([
 // line 1
 72, 712, 272, 712, 72, 700, 272, 700,
 // line 2
 72, 698, 200, 698, 72, 686, 200, 686,
 ]),
 color: new Uint8ClampedArray([255, 255, 0]),
 };
 const result = importPdfjsAnnotation(ann, 1, 0);
 expect(result).not.toBeNull();
 expect(result!.type).toBe("highlight");
 expect((result as any).rects).toHaveLength(2);
 expect((result as any).rects[0]).toEqual({
 x: 72,
 y: 700,
 width: 200,
 height: 12,
 });
 expect((result as any).rects[1]).toEqual({
 x: 72,
 y: 686,
 width: 128,
 height: 12,
 });
 });

 it("falls back to ann.rect when quadPoints is absent", () => {
 const ann = {
 annotationType: 9,
 ref: { num: 9, gen: 0 },
 rect: [72, 700, 272, 712],
 color: new Uint8ClampedArray([255, 255, 0]),
 };
 const result = importPdfjsAnnotation(ann, 1, 0);
 expect(result).not.toBeNull();
 expect((result as any).rects).toHaveLength(1);
 });

 it("imports an underline annotation", () => {
 const ann = {
 annotationType: 10,
 ref: { num: 6, gen: 0 },
 rect: [72, 700, 272, 712],
 quadPoints: [[72, 712, 272, 712, 72, 700, 272, 700]],
 // pdf.js emits a FLAT Float32Array, not nested arrays.
 quadPoints: new Float32Array([72, 712, 272, 712, 72, 700, 272, 700]),
 color: new Uint8ClampedArray([255, 0, 0]),
 };
 const result = importPdfjsAnnotation(ann, 1, 0);
Expand All@@ -493,7 +539,8 @@ describe("importPdfjsAnnotation", () => {
 annotationType: 12,
 ref: { num: 7, gen: 0 },
 rect: [72, 700, 272, 712],
 quadPoints: [[72, 712, 272, 712, 72, 700, 272, 700]],
 // pdf.js emits a FLAT Float32Array, not nested arrays.
 quadPoints: new Float32Array([72, 712, 272, 712, 72, 700, 272, 700]),
 color: new Uint8ClampedArray([255, 0, 0]),
 };
 const result = importPdfjsAnnotation(ann, 2, 0);
Expand Down

47 changes: 21 additions & 26 deletions
examples/pdf-server/src/pdf-annotations.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -948,33 +948,28 @@ export function importPdfjsAnnotation(
 case "highlight":
 case "underline":
 case "strikethrough": {
 // PDF.js provides quadPoints as array of arrays [[x1,y1,x2,y2,...], ...]
 // or rect as [x1,y1,x2,y2]
 let rects: Rect[];
 if (ann.quadPoints && ann.quadPoints.length > 0) {
 rects = [];
 for (const qp of ann.quadPoints) {
 // Each quadPoint is [x1,y1,x2,y2,x3,y3,x4,y4]
 // We need the bounding box
 if (qp.length >= 8) {
 const xs = [qp[0], qp[2], qp[4], qp[6]];
 const ys = [qp[1], qp[3], qp[5], qp[7]];
 const minX = Math.min(...xs);
 const minY = Math.min(...ys);
 const maxX = Math.max(...xs);
 const maxY = Math.max(...ys);
 rects.push({
 x: minX,
 y: minY,
 width: maxX - minX,
 height: maxY - minY,
 });
 }
 // pdf.js emits quadPoints as a FLAT Float32Array [x1,y1,...,x4,y4, …]
 // (8 numbers per quad), NOT as nested arrays. Iterating it yields
 // numbers, so the old `for (const qp of …) if (qp.length>=8)` never
 // matched and every quad-based annotation was dropped (#506).
 const rects: Rect[] = [];
 const qp = ann.quadPoints as ArrayLike<number> | undefined;
 if (qp && qp.length >= 8) {
 for (let i = 0; i + 8 <= qp.length; i += 8) {
 const xs = [qp[i], qp[i + 2], qp[i + 4], qp[i + 6]];
 const ys = [qp[i + 1], qp[i + 3], qp[i + 5], qp[i + 7]];
 const minX = Math.min(...xs);
 const minY = Math.min(...ys);
 rects.push({
 x: minX,
 y: minY,
 width: Math.max(...xs) - minX,
 height: Math.max(...ys) - minY,
 });
 }
 } else if (ann.rect) {
 rects = [pdfjsRectToRect(ann.rect)];
 } else {
 return null;
 }
 if (rects.length === 0 && ann.rect) {
 rects.push(pdfjsRectToRect(ann.rect));
 }
 if (rects.length === 0) return null;

Expand Down
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Universal Dark Mode - works on any site
(function() {
var enabled = true;
function applyDarkMode() {
if (!enabled) return;
// Create style element if it doesn't exist
var style = document.getElementById('universal-dark-mode-style');
if (!style) {
style = document.createElement('style');
style.id = 'universal-dark-mode-style';
document.head.appendChild(style);
}
// Dark mode CSS - inverts colors but preserves images/video
style.textContent = '
/* Invert everything except media */
html {
filter: invert(1) hue-rotate(180deg) !important;
background: #1a1a2e !important;
}
/* Restore images, videos, iframes, canvas */
img, video, iframe, canvas, svg, picture, [style*="background-image"] {
filter: invert(1) hue-rotate(180deg) !important;
}
/* Preserve specific elements that should not be inverted */
.no-dark-mode, .no-dark-mode *,
[data-theme="light"], [data-theme="light"],
.ace_editor, .ace_editor *,
.CodeMirror, .CodeMirror *,
.monaco-editor, .monaco-editor *,
.markdown-body pre, .markdown-body pre *,
.highlight, .highlight *,
pre code, pre code * {
filter: none !important;
}
/* Fix common UI elements */
.modal, .popup, .dropdown-menu, .tooltip, .popover {
filter: invert(1) hue-rotate(180deg) !important;
background: #2d2d44 !important;
border-color: #444 !important;
}
/* Scrollbars */
::-webkit-scrollbar { background: #1a1a2e !important; }
::-webkit-scrollbar-thumb { background: #444 !important; }
::-webkit-scrollbar-thumb:hover { background: #555 !important; }
/* Selection */
::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
';
}
function removeDarkMode() {
var style = document.getElementById('universal-dark-mode-style');
if (style) style.remove();
}
// Toggle with Alt+Shift+D
document.addEventListener('keydown', function(e) {
if (e.altKey && e.shiftKey && e.key === 'D') {
e.preventDefault();
enabled = !enabled;
if (enabled) {
applyDarkMode();
console.log('[Universal Dark Mode] Enabled');
} else {
removeDarkMode();
console.log('[Universal Dark Mode] Disabled');
}
}
});
// Apply on load
applyDarkMode();
// Re-apply on dynamic content
var observer = new MutationObserver(function(mutations) {
if (enabled && !document.getElementById('universal-dark-mode-style')) {
applyDarkMode();
}
});
observer.observe(document.head, { childList: true });
console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');
})();
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();
fix(pdf-server): import highlight/underline/strike from existing PDFs by ochafik · Pull Request #592 · modelcontextprotocol/ext-apps · GitHub
Skip to content
fix(pdf-server): import highlight/underline/strike from existing PDFs#592

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

ochafik
merged 3 commits into

from

Apr 2, 2026
 Merged


fix(pdf-server): import highlight/underline/strike from existing PDFs
#592
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


3 commits


Select commit
Hold shift + click to select a range
436850c

fix(pdf-server): import highlight/underline/strike from existing PDFs


ochafik Apr 2, 2026
2f989a7

fix(pdf-server): own markup annotations in our layer, not the canvas


ochafik Apr 2, 2026
ba71bd1

Revert "fix(pdf-server): own markup annotations in our layer, not the…


ochafik Apr 2, 2026

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


53 changes: 50 additions & 3 deletions
examples/pdf-server/src/pdf-annotations.test.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -460,7 +460,8 @@ describe("importPdfjsAnnotation", () => {
 annotationType: 9,
 ref: { num: 5, gen: 0 },
 rect: [72, 700, 272, 712],
 quadPoints: [[72, 712, 272, 712, 72, 700, 272, 700]],
 // pdf.js emits a FLAT Float32Array, not nested arrays.
 quadPoints: new Float32Array([72, 712, 272, 712, 72, 700, 272, 700]),
 color: new Uint8ClampedArray([255, 255, 0]),
 contentsObj: { str: "Important" },
 };
Expand All@@ -474,12 +475,57 @@ describe("importPdfjsAnnotation", () => {
 expect((result as any).color).toBe("#ffff00");
 });

 it("imports a multi-line highlight (multiple quads → multiple rects)", () => {
 // Regression: the parser iterated quadPoints as if nested; pdf.js's
 // flat array yielded numbers, so rects stayed empty and import bailed.
 const ann = {
 annotationType: 9,
 ref: { num: 8, gen: 0 },
 quadPoints: new Float32Array([
 // line 1
 72, 712, 272, 712, 72, 700, 272, 700,
 // line 2
 72, 698, 200, 698, 72, 686, 200, 686,
 ]),
 color: new Uint8ClampedArray([255, 255, 0]),
 };
 const result = importPdfjsAnnotation(ann, 1, 0);
 expect(result).not.toBeNull();
 expect(result!.type).toBe("highlight");
 expect((result as any).rects).toHaveLength(2);
 expect((result as any).rects[0]).toEqual({
 x: 72,
 y: 700,
 width: 200,
 height: 12,
 });
 expect((result as any).rects[1]).toEqual({
 x: 72,
 y: 686,
 width: 128,
 height: 12,
 });
 });

 it("falls back to ann.rect when quadPoints is absent", () => {
 const ann = {
 annotationType: 9,
 ref: { num: 9, gen: 0 },
 rect: [72, 700, 272, 712],
 color: new Uint8ClampedArray([255, 255, 0]),
 };
 const result = importPdfjsAnnotation(ann, 1, 0);
 expect(result).not.toBeNull();
 expect((result as any).rects).toHaveLength(1);
 });

 it("imports an underline annotation", () => {
 const ann = {
 annotationType: 10,
 ref: { num: 6, gen: 0 },
 rect: [72, 700, 272, 712],
 quadPoints: [[72, 712, 272, 712, 72, 700, 272, 700]],
 // pdf.js emits a FLAT Float32Array, not nested arrays.
 quadPoints: new Float32Array([72, 712, 272, 712, 72, 700, 272, 700]),
 color: new Uint8ClampedArray([255, 0, 0]),
 };
 const result = importPdfjsAnnotation(ann, 1, 0);
Expand All@@ -493,7 +539,8 @@ describe("importPdfjsAnnotation", () => {
 annotationType: 12,
 ref: { num: 7, gen: 0 },
 rect: [72, 700, 272, 712],
 quadPoints: [[72, 712, 272, 712, 72, 700, 272, 700]],
 // pdf.js emits a FLAT Float32Array, not nested arrays.
 quadPoints: new Float32Array([72, 712, 272, 712, 72, 700, 272, 700]),
 color: new Uint8ClampedArray([255, 0, 0]),
 };
 const result = importPdfjsAnnotation(ann, 2, 0);
Expand Down

47 changes: 21 additions & 26 deletions
examples/pdf-server/src/pdf-annotations.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -948,33 +948,28 @@ export function importPdfjsAnnotation(
 case "highlight":
 case "underline":
 case "strikethrough": {
 // PDF.js provides quadPoints as array of arrays [[x1,y1,x2,y2,...], ...]
 // or rect as [x1,y1,x2,y2]
 let rects: Rect[];
 if (ann.quadPoints && ann.quadPoints.length > 0) {
 rects = [];
 for (const qp of ann.quadPoints) {
 // Each quadPoint is [x1,y1,x2,y2,x3,y3,x4,y4]
 // We need the bounding box
 if (qp.length >= 8) {
 const xs = [qp[0], qp[2], qp[4], qp[6]];
 const ys = [qp[1], qp[3], qp[5], qp[7]];
 const minX = Math.min(...xs);
 const minY = Math.min(...ys);
 const maxX = Math.max(...xs);
 const maxY = Math.max(...ys);
 rects.push({
 x: minX,
 y: minY,
 width: maxX - minX,
 height: maxY - minY,
 });
 }
 // pdf.js emits quadPoints as a FLAT Float32Array [x1,y1,...,x4,y4, …]
 // (8 numbers per quad), NOT as nested arrays. Iterating it yields
 // numbers, so the old `for (const qp of …) if (qp.length>=8)` never
 // matched and every quad-based annotation was dropped (#506).
 const rects: Rect[] = [];
 const qp = ann.quadPoints as ArrayLike<number> | undefined;
 if (qp && qp.length >= 8) {
 for (let i = 0; i + 8 <= qp.length; i += 8) {
 const xs = [qp[i], qp[i + 2], qp[i + 4], qp[i + 6]];
 const ys = [qp[i + 1], qp[i + 3], qp[i + 5], qp[i + 7]];
 const minX = Math.min(...xs);
 const minY = Math.min(...ys);
 rects.push({
 x: minX,
 y: minY,
 width: Math.max(...xs) - minX,
 height: Math.max(...ys) - minY,
 });
 }
 } else if (ann.rect) {
 rects = [pdfjsRectToRect(ann.rect)];
 } else {
 return null;
 }
 if (rects.length === 0 && ann.rect) {
 rects.push(pdfjsRectToRect(ann.rect));
 }
 if (rects.length === 0) return null;

Expand Down
Loading