Uh oh!
There was an error while loading. Please reload this page.
Validate message endpoint in SSE client transport - #943
Merged
Kehrlann merged 1 commit intoApr 30, 2026
Conversation
Kehrlannforce-pushed
the
dgarnier/sse-transport-add-message-endpoint-validator
branch
from
April 30, 2026 14:05
c7f8710 to
efb377fComparechemicL
reviewed
Apr 30, 2026
chemicL
left a comment
Member
There was a problem hiding this comment.
Thanks, overall looks good, just one test related suggestion to avoid waiting. Perhaps this can have more useful consequences actually impacting other areas where we timeout instead of failing upon misconfiguration.
Uh oh!
There was an error while loading. Please reload this page.
Kehrlannforce-pushed
the
dgarnier/sse-transport-add-message-endpoint-validator
branch
from
April 30, 2026 15:21
efb377f to
2256c26CompareSigned-off-by: Daniel Garnier-Moiroux <git@garnier.wf>
Kehrlannforce-pushed
the
dgarnier/sse-transport-add-message-endpoint-validator
branch
from
April 30, 2026 15:22
2256c26 to
fab580dCompareUh oh!
There was an error while loading. Please reload this page.
Kehrlann
deleted the
dgarnier/sse-transport-add-message-endpoint-validator
branch
April 30, 2026 15:30
Kehrlann
commented
Apr 30, 2026
ContributorAuthor
Implemented change, merged without re-requesting approval. |
Kehrlann added a commit
that referenced
this pull request
Apr 30, 2026
- Backport #943 Signed-off-by: Daniel Garnier-Moiroux <git@garnier.wf>
Kehrlann added a commit
that referenced
this pull request
Apr 30, 2026
- Backport #943 Signed-off-by: Daniel Garnier-Moiroux <git@garnier.wf>
Kehrlann added a commit
that referenced
this pull request
May 4, 2026
- Backport #943 Signed-off-by: Daniel Garnier-Moiroux <git@garnier.wf>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add an API for validating the message endpoint that comes back as an SSE event in the SSE client transport.