Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 23 additions & 1 deletion docs/client.md
Original file line numberDiff line numberDiff line change
Expand Up@@ -57,10 +57,32 @@ $client = Client::builder()
->setClientInfo('My Application', '1.0.0', 'Description of my client')
->setInitTimeout(30) // Seconds to wait for initialization
->setRequestTimeout(120) // Seconds to wait for request responses
->setMaxRetries(3) // Retry attempts for failed connections
->setMaxRetries(3) // Retries for failed connections
->build();
```

### Connection Retries

`setMaxRetries()` controls how often `connect()` retries a failed connection. It
counts retries rather than attempts, so the default of `3` means one initial
attempt plus up to three retries — four in total — before the `ConnectionException`
of the last attempt is rethrown:

```php
$client = Client::builder()
->setMaxRetries(0) // Fail on the first failed attempt
->build();
```

Between two attempts the transport is closed, so a retry never reuses a
half-established connection: a `StdioTransport` spawns a fresh server process and
an `HttpTransport` discards the session ID of the failed attempt. Each retry is
preceded by a short, linearly growing delay (100ms, 200ms, 300ms, …).

Only the connection handshake is retried. Individual requests such as
`callTool()` are always sent once — retrying them is unsafe as tool calls are not
necessarily idempotent.

### Client Information

Set the client's identity reported to servers during initialization:
Expand Down
36 changes: 33 additions & 3 deletions src/Client.php
Original file line numberDiff line numberDiff line change
Expand Up@@ -58,6 +58,8 @@
*/
class Client
{
private const RETRY_BASE_DELAY_MS = 100;

private ?TransportInterface $transport = null;

public function __construct(
Expand All@@ -78,16 +80,44 @@ public static function builder(): Builder
/**
* Connect to an MCP server using the provided transport.
*
* @throws ConnectionException If connection or initialization fails
* A failed attempt is closed and retried, see {@see Builder::setMaxRetries()}.
*
* @throws ConnectionException If connection or initialization fails on every attempt
*/
public function connect(TransportInterface $transport): void
{
$this->transport = $transport;
$this->protocol->connect($transport, $this->config);

$transport->connect();
$maxAttempts = $this->config->maxRetries + 1;

for ($attempt = 1; $attempt <= $maxAttempts; ++$attempt) {
try {
$transport->connect();

$this->logger->info('Client connected and initialized', ['attempt' => $attempt]);

return;
} catch (ConnectionException $e) {
// initialize() flags the session before sending the initialized
// notification, so a failure in between leaves the flag set.
$this->protocol->getState()->setInitialized(false);

$this->logger->info('Client connected and initialized');
$transport->close();

if ($attempt === $maxAttempts) {
throw $e;
}

$this->logger->warning('Connection attempt failed, retrying', [
'attempt' => $attempt,
'max_attempts' => $maxAttempts,
'exception' => $e,
]);

usleep($attempt * self::RETRY_BASE_DELAY_MS * 1000);
}
}
}

/**
Expand Down
6 changes: 5 additions & 1 deletion src/Client/Builder.php
Original file line numberDiff line numberDiff line change
Expand Up@@ -96,7 +96,11 @@ public function setRequestTimeout(int $seconds): self
}

/**
* Set maximum retry attempts for failed connections.
* Set the number of times a failed connection attempt is retried.
*
* Counts retries, not attempts: 3 means one initial attempt plus up to three
* retries. Pass 0 to fail on the first failure. Only applies to
* {@see Client::connect()}; individual requests are never retried.
*/
public function setMaxRetries(int $retries): self
{
Expand Down
4 changes: 4 additions & 0 deletions src/Client/Configuration.php
Original file line numberDiff line numberDiff line change
Expand Up@@ -38,5 +38,9 @@ public function __construct(
if ($requestTimeout < 1) {
throw new InvalidArgumentException(\sprintf('The request timeout must be a positive number of seconds, got %d.', $requestTimeout));
}

if ($maxRetries < 0) {
throw new InvalidArgumentException(\sprintf('The maximum number of retries must be zero or greater, got %d.', $maxRetries));
}
}
}
31 changes: 19 additions & 12 deletions src/Client/Protocol.php
Original file line numberDiff line numberDiff line change
Expand Up@@ -179,22 +179,29 @@ public function request(Request $request, int $timeout, bool $withProgress = fal
}

$this->state->addPendingRequest($requestId, $timeout);
$this->sendRequest($request);

$immediate = $this->state->consumeResponse($requestId);
if (null !== $immediate) {
$this->logger->debug('Received immediate response', ['id' => $requestId]);
try {
$this->sendRequest($request);

return $immediate;
}
$immediate = $this->state->consumeResponse($requestId);
if (null !== $immediate) {
$this->logger->debug('Received immediate response', ['id' => $requestId]);

$this->logger->debug('Suspending fiber for response', ['id' => $requestId]);
return $immediate;
}

return \Fiber::suspend([
'type' => 'await_response',
'request_id' => $requestId,
'timeout' => $timeout,
]);
$this->logger->debug('Suspending fiber for response', ['id' => $requestId]);

return \Fiber::suspend([
'type' => 'await_response',
'request_id' => $requestId,
'timeout' => $timeout,
]);
} finally {
// Only the response path clears it, so a request that timed out or
// whose send() threw would stay pending and fail every later one.
$this->state->removePendingRequest($requestId);
}
}

/**
Expand Down
42 changes: 42 additions & 0 deletions tests/Integration/Fixture/request_timeout.php
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,42 @@
<?php

/*
* This file is part of the official PHP MCP SDK.
*
* A collaboration between Symfony and the PHP Foundation.
*
* For the full copyright and license information, please view the LICENSE
* file that was distributed with this source code.
*/

/*
* Server for {@see \Mcp\Tests\Integration\RequestTimeoutTest}.
*
* `slow` outlives the client's request timeout and then goes idle again, which
* is what lets the test call `fast` on a connection the client has already
* given up on once.
*/

use Mcp\Server;
use Mcp\Server\Transport\StdioTransport;

require_once dirname(__DIR__, 3).'/vendor/autoload.php';

Server::builder()
->setServerInfo('integration-server', '1.0.0')
->addTool(
static function (): string {
sleep(2);

return 'late';
},
name: 'slow',
description: 'Answers well after the client stopped waiting.',
)
->addTool(
static fn (): string => 'quick',
name: 'fast',
description: 'Returns at once.',
)
->build()
->run(new StdioTransport());
46 changes: 46 additions & 0 deletions tests/Integration/Fixture/retry.php
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,46 @@
<?php

/*
* This file is part of the official PHP MCP SDK.
*
* A collaboration between Symfony and the PHP Foundation.
*
* For the full copyright and license information, please view the LICENSE
* file that was distributed with this source code.
*/

/*
* Server for {@see \Mcp\Tests\Integration\RetryTest}.
*
* Dies before speaking a frame while the spawn counter is below the configured
* number of failures, so the counter file records how many processes the client
* actually started.
*/

use Mcp\Server;
use Mcp\Server\Transport\StdioTransport;

require_once dirname(__DIR__, 3).'/vendor/autoload.php';

$counter = getenv('MCP_SPAWN_COUNTER');

if (!is_string($counter) || '' === $counter) {
exit(1);
}

$spawns = 1 + (int) file_get_contents($counter);
file_put_contents($counter, (string) $spawns);

if ($spawns <= (int) getenv('MCP_FAIL_SPAWNS')) {
exit(1);
}

Server::builder()
->setServerInfo('integration-server', '1.0.0')
->addTool(
static fn (): string => 'quick',
name: 'fast',
description: 'Returns at once.',
)
->build()
->run(new StdioTransport());
34 changes: 25 additions & 9 deletions tests/Integration/IntegrationTestCase.php
Original file line numberDiff line numberDiff line change
Expand Up@@ -55,26 +55,42 @@ protected function clientBuilder(): ClientBuilder
*/
protected function connect(string $fixture, ?ClientBuilder $client = null, array $env = []): Client
{
$script = __DIR__.'/Fixture/'.$fixture.'.php';

$this->client = ($client ?? $this->clientBuilder())->build();

try {
$this->client->connect(new StdioTransport(
command: \PHP_BINARY,
args: [$script],
// proc_open() replaces the environment rather than adding to it.
env: [] === $env ? null : array_merge(getenv(), $env),
));
$this->client->connect($this->transport($fixture, $env));
} catch (ConnectionException $e) {
// The transport discards the child's stderr, so a fixture dying on
// startup arrives here as a bare timeout.
$this->fail(\sprintf('Could not connect to fixture server "%s": %s. Run `%s %s` to see why.', $fixture, $e->getMessage(), \PHP_BINARY, $script));
$this->fail(\sprintf('Could not connect to fixture server "%s": %s. Run `%s %s` to see why.', $fixture, $e->getMessage(), \PHP_BINARY, self::script($fixture)));
}

return $this->client;
}

/**
* A transport that will spawn a fixture server, without connecting it.
*
* Tests that assert on a failing connection need the transport by itself,
* since {@see self::connect()} turns that failure into a test failure.
*
* @param array<string, string> $env added to the server process environment
*/
protected function transport(string $fixture, array $env = []): StdioTransport
{
return new StdioTransport(
command: \PHP_BINARY,
args: [self::script($fixture)],
// proc_open() replaces the environment rather than adding to it.
env: [] === $env ? null : array_merge(getenv(), $env),
);
}

private static function script(string $fixture): string
{
return __DIR__.'/Fixture/'.$fixture.'.php';
}

protected function tearDown(): void
{
$this->client?->disconnect();
Expand Down
43 changes: 43 additions & 0 deletions tests/Integration/RequestTimeoutTest.php
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,43 @@
<?php

/*
* This file is part of the official PHP MCP SDK.
*
* A collaboration between Symfony and the PHP Foundation.
*
* For the full copyright and license information, please view the LICENSE
* file that was distributed with this source code.
*/

namespace Mcp\Tests\Integration;

use Mcp\Exception\RequestException;
use PHPUnit\Framework\Attributes\TestDox;

/**
* What a timed-out request leaves behind on the connection.
*
* @see Fixture/request_timeout.php for the server under test
*/
final class RequestTimeoutTest extends IntegrationTestCase
{
#[TestDox('an abandoned response is not handed to the next request')]
public function testTimedOutRequestDoesNotLeakIntoTheNext(): void
{
$client = $this->connect('request_timeout', $this->clientBuilder()->setRequestTimeout(1));

try {
$client->callTool('slow');
$this->fail('The slow tool should have outlived the request timeout.');
} catch (RequestException) {
}

// The server is still executing the abandoned call and cannot answer
// anything until it returns, so the next request has to wait it out.
sleep(2);

// Without the pending request being cleared this answers 'late': the
// response the client gave up on, handed to the request after it.
$this->assertSame('quick', $client->callTool('fast')->content[0]->text ?? null);
}
}
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 23 additions & 1 deletion docs/client.md
Original file line numberDiff line numberDiff line change
Expand Up@@ -57,10 +57,32 @@ $client = Client::builder()
->setClientInfo('My Application', '1.0.0', 'Description of my client')
->setInitTimeout(30) // Seconds to wait for initialization
->setRequestTimeout(120) // Seconds to wait for request responses
->setMaxRetries(3) // Retry attempts for failed connections
->setMaxRetries(3) // Retries for failed connections
->build();
```

### Connection Retries

`setMaxRetries()` controls how often `connect()` retries a failed connection. It
counts retries rather than attempts, so the default of `3` means one initial
attempt plus up to three retries — four in total — before the `ConnectionException`
of the last attempt is rethrown:

```php
$client = Client::builder()
->setMaxRetries(0) // Fail on the first failed attempt
->build();
```

Between two attempts the transport is closed, so a retry never reuses a
half-established connection: a `StdioTransport` spawns a fresh server process and
an `HttpTransport` discards the session ID of the failed attempt. Each retry is
preceded by a short, linearly growing delay (100ms, 200ms, 300ms, …).

Only the connection handshake is retried. Individual requests such as
`callTool()` are always sent once — retrying them is unsafe as tool calls are not
necessarily idempotent.

### Client Information

Set the client's identity reported to servers during initialization:
Expand Down
36 changes: 33 additions & 3 deletions src/Client.php
Original file line numberDiff line numberDiff line change
Expand Up@@ -58,6 +58,8 @@
*/
class Client
{
private const RETRY_BASE_DELAY_MS = 100;

private ?TransportInterface $transport = null;

public function __construct(
Expand All@@ -78,16 +80,44 @@ public static function builder(): Builder
/**
* Connect to an MCP server using the provided transport.
*
* @throws ConnectionException If connection or initialization fails
* A failed attempt is closed and retried, see {@see Builder::setMaxRetries()}.
*
* @throws ConnectionException If connection or initialization fails on every attempt
*/
public function connect(TransportInterface $transport): void
{
$this->transport = $transport;
$this->protocol->connect($transport, $this->config);

$transport->connect();
$maxAttempts = $this->config->maxRetries + 1;

for ($attempt = 1; $attempt <= $maxAttempts; ++$attempt) {
try {
$transport->connect();

$this->logger->info('Client connected and initialized', ['attempt' => $attempt]);

return;
} catch (ConnectionException $e) {
// initialize() flags the session before sending the initialized
// notification, so a failure in between leaves the flag set.
$this->protocol->getState()->setInitialized(false);

$this->logger->info('Client connected and initialized');
$transport->close();

if ($attempt === $maxAttempts) {
throw $e;
}

$this->logger->warning('Connection attempt failed, retrying', [
'attempt' => $attempt,
'max_attempts' => $maxAttempts,
'exception' => $e,
]);

usleep($attempt * self::RETRY_BASE_DELAY_MS * 1000);
}
}
}

/**
Expand Down
6 changes: 5 additions & 1 deletion src/Client/Builder.php
Original file line numberDiff line numberDiff line change
Expand Up@@ -96,7 +96,11 @@ public function setRequestTimeout(int $seconds): self
}

/**
* Set maximum retry attempts for failed connections.
* Set the number of times a failed connection attempt is retried.
*
* Counts retries, not attempts: 3 means one initial attempt plus up to three
* retries. Pass 0 to fail on the first failure. Only applies to
* {@see Client::connect()}; individual requests are never retried.
*/
public function setMaxRetries(int $retries): self
{
Expand Down
4 changes: 4 additions & 0 deletions src/Client/Configuration.php
Original file line numberDiff line numberDiff line change
Expand Up@@ -38,5 +38,9 @@ public function __construct(
if ($requestTimeout < 1) {
throw new InvalidArgumentException(\sprintf('The request timeout must be a positive number of seconds, got %d.', $requestTimeout));
}

if ($maxRetries < 0) {
throw new InvalidArgumentException(\sprintf('The maximum number of retries must be zero or greater, got %d.', $maxRetries));
}
}
}
31 changes: 19 additions & 12 deletions src/Client/Protocol.php
Original file line numberDiff line numberDiff line change
Expand Up@@ -179,22 +179,29 @@ public function request(Request $request, int $timeout, bool $withProgress = fal
}

$this->state->addPendingRequest($requestId, $timeout);
$this->sendRequest($request);

$immediate = $this->state->consumeResponse($requestId);
if (null !== $immediate) {
$this->logger->debug('Received immediate response', ['id' => $requestId]);
try {
$this->sendRequest($request);

return $immediate;
}
$immediate = $this->state->consumeResponse($requestId);
if (null !== $immediate) {
$this->logger->debug('Received immediate response', ['id' => $requestId]);

$this->logger->debug('Suspending fiber for response', ['id' => $requestId]);
return $immediate;
}

return \Fiber::suspend([
'type' => 'await_response',
'request_id' => $requestId,
'timeout' => $timeout,
]);
$this->logger->debug('Suspending fiber for response', ['id' => $requestId]);

return \Fiber::suspend([
'type' => 'await_response',
'request_id' => $requestId,
'timeout' => $timeout,
]);
} finally {
// Only the response path clears it, so a request that timed out or
// whose send() threw would stay pending and fail every later one.
$this->state->removePendingRequest($requestId);
}
}

/**
Expand Down
42 changes: 42 additions & 0 deletions tests/Integration/Fixture/request_timeout.php
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,42 @@
<?php

/*
* This file is part of the official PHP MCP SDK.
*
* A collaboration between Symfony and the PHP Foundation.
*
* For the full copyright and license information, please view the LICENSE
* file that was distributed with this source code.
*/

/*
* Server for {@see \Mcp\Tests\Integration\RequestTimeoutTest}.
*
* `slow` outlives the client's request timeout and then goes idle again, which
* is what lets the test call `fast` on a connection the client has already
* given up on once.
*/

use Mcp\Server;
use Mcp\Server\Transport\StdioTransport;

require_once dirname(__DIR__, 3).'/vendor/autoload.php';

Server::builder()
->setServerInfo('integration-server', '1.0.0')
->addTool(
static function (): string {
sleep(2);

return 'late';
},
name: 'slow',
description: 'Answers well after the client stopped waiting.',
)
->addTool(
static fn (): string => 'quick',
name: 'fast',
description: 'Returns at once.',
)
->build()
->run(new StdioTransport());
46 changes: 46 additions & 0 deletions tests/Integration/Fixture/retry.php
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,46 @@
<?php

/*
* This file is part of the official PHP MCP SDK.
*
* A collaboration between Symfony and the PHP Foundation.
*
* For the full copyright and license information, please view the LICENSE
* file that was distributed with this source code.
*/

/*
* Server for {@see \Mcp\Tests\Integration\RetryTest}.
*
* Dies before speaking a frame while the spawn counter is below the configured
* number of failures, so the counter file records how many processes the client
* actually started.
*/

use Mcp\Server;
use Mcp\Server\Transport\StdioTransport;

require_once dirname(__DIR__, 3).'/vendor/autoload.php';

$counter = getenv('MCP_SPAWN_COUNTER');

if (!is_string($counter) || '' === $counter) {
exit(1);
}

$spawns = 1 + (int) file_get_contents($counter);
file_put_contents($counter, (string) $spawns);

if ($spawns <= (int) getenv('MCP_FAIL_SPAWNS')) {
exit(1);
}

Server::builder()
->setServerInfo('integration-server', '1.0.0')
->addTool(
static fn (): string => 'quick',
name: 'fast',
description: 'Returns at once.',
)
->build()
->run(new StdioTransport());
34 changes: 25 additions & 9 deletions tests/Integration/IntegrationTestCase.php
Original file line numberDiff line numberDiff line change
Expand Up@@ -55,26 +55,42 @@ protected function clientBuilder(): ClientBuilder
*/
protected function connect(string $fixture, ?ClientBuilder $client = null, array $env = []): Client
{
$script = __DIR__.'/Fixture/'.$fixture.'.php';

$this->client = ($client ?? $this->clientBuilder())->build();

try {
$this->client->connect(new StdioTransport(
command: \PHP_BINARY,
args: [$script],
// proc_open() replaces the environment rather than adding to it.
env: [] === $env ? null : array_merge(getenv(), $env),
));
$this->client->connect($this->transport($fixture, $env));
} catch (ConnectionException $e) {
// The transport discards the child's stderr, so a fixture dying on
// startup arrives here as a bare timeout.
$this->fail(\sprintf('Could not connect to fixture server "%s": %s. Run `%s %s` to see why.', $fixture, $e->getMessage(), \PHP_BINARY, $script));
$this->fail(\sprintf('Could not connect to fixture server "%s": %s. Run `%s %s` to see why.', $fixture, $e->getMessage(), \PHP_BINARY, self::script($fixture)));
}

return $this->client;
}

/**
* A transport that will spawn a fixture server, without connecting it.
*
* Tests that assert on a failing connection need the transport by itself,
* since {@see self::connect()} turns that failure into a test failure.
*
* @param array<string, string> $env added to the server process environment
*/
protected function transport(string $fixture, array $env = []): StdioTransport
{
return new StdioTransport(
command: \PHP_BINARY,
args: [self::script($fixture)],
// proc_open() replaces the environment rather than adding to it.
env: [] === $env ? null : array_merge(getenv(), $env),
);
}

private static function script(string $fixture): string
{
return __DIR__.'/Fixture/'.$fixture.'.php';
}

protected function tearDown(): void
{
$this->client?->disconnect();
Expand Down
43 changes: 43 additions & 0 deletions tests/Integration/RequestTimeoutTest.php
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,43 @@
<?php

/*
* This file is part of the official PHP MCP SDK.
*
* A collaboration between Symfony and the PHP Foundation.
*
* For the full copyright and license information, please view the LICENSE
* file that was distributed with this source code.
*/

namespace Mcp\Tests\Integration;

use Mcp\Exception\RequestException;
use PHPUnit\Framework\Attributes\TestDox;

/**
* What a timed-out request leaves behind on the connection.
*
* @see Fixture/request_timeout.php for the server under test
*/
final class RequestTimeoutTest extends IntegrationTestCase
{
#[TestDox('an abandoned response is not handed to the next request')]
public function testTimedOutRequestDoesNotLeakIntoTheNext(): void
{
$client = $this->connect('request_timeout', $this->clientBuilder()->setRequestTimeout(1));

try {
$client->callTool('slow');
$this->fail('The slow tool should have outlived the request timeout.');
} catch (RequestException) {
}

// The server is still executing the abandoned call and cannot answer
// anything until it returns, so the next request has to wait it out.
sleep(2);

// Without the pending request being cleared this answers 'late': the
// response the client gave up on, handed to the request after it.
$this->assertSame('quick', $client->callTool('fast')->content[0]->text ?? null);
}
}
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix"); } } catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 23 additions & 1 deletion docs/client.md
Original file line numberDiff line numberDiff line change
Expand Up@@ -57,10 +57,32 @@ $client = Client::builder()
->setClientInfo('My Application', '1.0.0', 'Description of my client')
->setInitTimeout(30) // Seconds to wait for initialization
->setRequestTimeout(120) // Seconds to wait for request responses
->setMaxRetries(3) // Retry attempts for failed connections
->setMaxRetries(3) // Retries for failed connections
->build();
```

### Connection Retries

`setMaxRetries()` controls how often `connect()` retries a failed connection. It
counts retries rather than attempts, so the default of `3` means one initial
attempt plus up to three retries — four in total — before the `ConnectionException`
of the last attempt is rethrown:

```php
$client = Client::builder()
->setMaxRetries(0) // Fail on the first failed attempt
->build();
```

Between two attempts the transport is closed, so a retry never reuses a
half-established connection: a `StdioTransport` spawns a fresh server process and
an `HttpTransport` discards the session ID of the failed attempt. Each retry is
preceded by a short, linearly growing delay (100ms, 200ms, 300ms, …).

Only the connection handshake is retried. Individual requests such as
`callTool()` are always sent once — retrying them is unsafe as tool calls are not
necessarily idempotent.

### Client Information

Set the client's identity reported to servers during initialization:
Expand Down
36 changes: 33 additions & 3 deletions src/Client.php
Original file line numberDiff line numberDiff line change
Expand Up@@ -58,6 +58,8 @@
*/
class Client
{
private const RETRY_BASE_DELAY_MS = 100;

private ?TransportInterface $transport = null;

public function __construct(
Expand All@@ -78,16 +80,44 @@ public static function builder(): Builder
/**
* Connect to an MCP server using the provided transport.
*
* @throws ConnectionException If connection or initialization fails
* A failed attempt is closed and retried, see {@see Builder::setMaxRetries()}.
*
* @throws ConnectionException If connection or initialization fails on every attempt
*/
public function connect(TransportInterface $transport): void
{
$this->transport = $transport;
$this->protocol->connect($transport, $this->config);

$transport->connect();
$maxAttempts = $this->config->maxRetries + 1;

for ($attempt = 1; $attempt <= $maxAttempts; ++$attempt) {
try {
$transport->connect();

$this->logger->info('Client connected and initialized', ['attempt' => $attempt]);

return;
} catch (ConnectionException $e) {
// initialize() flags the session before sending the initialized
// notification, so a failure in between leaves the flag set.
$this->protocol->getState()->setInitialized(false);

$this->logger->info('Client connected and initialized');
$transport->close();

if ($attempt === $maxAttempts) {
throw $e;
}

$this->logger->warning('Connection attempt failed, retrying', [
'attempt' => $attempt,
'max_attempts' => $maxAttempts,
'exception' => $e,
]);

usleep($attempt * self::RETRY_BASE_DELAY_MS * 1000);
}
}
}

/**
Expand Down
6 changes: 5 additions & 1 deletion src/Client/Builder.php
Original file line numberDiff line numberDiff line change
Expand Up@@ -96,7 +96,11 @@ public function setRequestTimeout(int $seconds): self
}

/**
* Set maximum retry attempts for failed connections.
* Set the number of times a failed connection attempt is retried.
*
* Counts retries, not attempts: 3 means one initial attempt plus up to three
* retries. Pass 0 to fail on the first failure. Only applies to
* {@see Client::connect()}; individual requests are never retried.
*/
public function setMaxRetries(int $retries): self
{
Expand Down
4 changes: 4 additions & 0 deletions src/Client/Configuration.php
Original file line numberDiff line numberDiff line change
Expand Up@@ -38,5 +38,9 @@ public function __construct(
if ($requestTimeout < 1) {
throw new InvalidArgumentException(\sprintf('The request timeout must be a positive number of seconds, got %d.', $requestTimeout));
}

if ($maxRetries < 0) {
throw new InvalidArgumentException(\sprintf('The maximum number of retries must be zero or greater, got %d.', $maxRetries));
}
}
}
31 changes: 19 additions & 12 deletions src/Client/Protocol.php
Original file line numberDiff line numberDiff line change
Expand Up@@ -179,22 +179,29 @@ public function request(Request $request, int $timeout, bool $withProgress = fal
}

$this->state->addPendingRequest($requestId, $timeout);
$this->sendRequest($request);

$immediate = $this->state->consumeResponse($requestId);
if (null !== $immediate) {
$this->logger->debug('Received immediate response', ['id' => $requestId]);
try {
$this->sendRequest($request);

return $immediate;
}
$immediate = $this->state->consumeResponse($requestId);
if (null !== $immediate) {
$this->logger->debug('Received immediate response', ['id' => $requestId]);

$this->logger->debug('Suspending fiber for response', ['id' => $requestId]);
return $immediate;
}

return \Fiber::suspend([
'type' => 'await_response',
'request_id' => $requestId,
'timeout' => $timeout,
]);
$this->logger->debug('Suspending fiber for response', ['id' => $requestId]);

return \Fiber::suspend([
'type' => 'await_response',
'request_id' => $requestId,
'timeout' => $timeout,
]);
} finally {
// Only the response path clears it, so a request that timed out or
// whose send() threw would stay pending and fail every later one.
$this->state->removePendingRequest($requestId);
}
}

/**
Expand Down
42 changes: 42 additions & 0 deletions tests/Integration/Fixture/request_timeout.php
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,42 @@
<?php

/*
* This file is part of the official PHP MCP SDK.
*
* A collaboration between Symfony and the PHP Foundation.
*
* For the full copyright and license information, please view the LICENSE
* file that was distributed with this source code.
*/

/*
* Server for {@see \Mcp\Tests\Integration\RequestTimeoutTest}.
*
* `slow` outlives the client's request timeout and then goes idle again, which
* is what lets the test call `fast` on a connection the client has already
* given up on once.
*/

use Mcp\Server;
use Mcp\Server\Transport\StdioTransport;

require_once dirname(__DIR__, 3).'/vendor/autoload.php';

Server::builder()
->setServerInfo('integration-server', '1.0.0')
->addTool(
static function (): string {
sleep(2);

return 'late';
},
name: 'slow',
description: 'Answers well after the client stopped waiting.',
)
->addTool(
static fn (): string => 'quick',
name: 'fast',
description: 'Returns at once.',
)
->build()
->run(new StdioTransport());
46 changes: 46 additions & 0 deletions tests/Integration/Fixture/retry.php
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,46 @@
<?php

/*
* This file is part of the official PHP MCP SDK.
*
* A collaboration between Symfony and the PHP Foundation.
*
* For the full copyright and license information, please view the LICENSE
* file that was distributed with this source code.
*/

/*
* Server for {@see \Mcp\Tests\Integration\RetryTest}.
*
* Dies before speaking a frame while the spawn counter is below the configured
* number of failures, so the counter file records how many processes the client
* actually started.
*/

use Mcp\Server;
use Mcp\Server\Transport\StdioTransport;

require_once dirname(__DIR__, 3).'/vendor/autoload.php';

$counter = getenv('MCP_SPAWN_COUNTER');

if (!is_string($counter) || '' === $counter) {
exit(1);
}

$spawns = 1 + (int) file_get_contents($counter);
file_put_contents($counter, (string) $spawns);

if ($spawns <= (int) getenv('MCP_FAIL_SPAWNS')) {
exit(1);
}

Server::builder()
->setServerInfo('integration-server', '1.0.0')
->addTool(
static fn (): string => 'quick',
name: 'fast',
description: 'Returns at once.',
)
->build()
->run(new StdioTransport());
34 changes: 25 additions & 9 deletions tests/Integration/IntegrationTestCase.php
Original file line numberDiff line numberDiff line change
Expand Up@@ -55,26 +55,42 @@ protected function clientBuilder(): ClientBuilder
*/
protected function connect(string $fixture, ?ClientBuilder $client = null, array $env = []): Client
{
$script = __DIR__.'/Fixture/'.$fixture.'.php';

$this->client = ($client ?? $this->clientBuilder())->build();

try {
$this->client->connect(new StdioTransport(
command: \PHP_BINARY,
args: [$script],
// proc_open() replaces the environment rather than adding to it.
env: [] === $env ? null : array_merge(getenv(), $env),
));
$this->client->connect($this->transport($fixture, $env));
} catch (ConnectionException $e) {
// The transport discards the child's stderr, so a fixture dying on
// startup arrives here as a bare timeout.
$this->fail(\sprintf('Could not connect to fixture server "%s": %s. Run `%s %s` to see why.', $fixture, $e->getMessage(), \PHP_BINARY, $script));
$this->fail(\sprintf('Could not connect to fixture server "%s": %s. Run `%s %s` to see why.', $fixture, $e->getMessage(), \PHP_BINARY, self::script($fixture)));
}

return $this->client;
}

/**
* A transport that will spawn a fixture server, without connecting it.
*
* Tests that assert on a failing connection need the transport by itself,
* since {@see self::connect()} turns that failure into a test failure.
*
* @param array<string, string> $env added to the server process environment
*/
protected function transport(string $fixture, array $env = []): StdioTransport
{
return new StdioTransport(
command: \PHP_BINARY,
args: [self::script($fixture)],
// proc_open() replaces the environment rather than adding to it.
env: [] === $env ? null : array_merge(getenv(), $env),
);
}

private static function script(string $fixture): string
{
return __DIR__.'/Fixture/'.$fixture.'.php';
}

protected function tearDown(): void
{
$this->client?->disconnect();
Expand Down
43 changes: 43 additions & 0 deletions tests/Integration/RequestTimeoutTest.php
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,43 @@
<?php

/*
* This file is part of the official PHP MCP SDK.
*
* A collaboration between Symfony and the PHP Foundation.
*
* For the full copyright and license information, please view the LICENSE
* file that was distributed with this source code.
*/

namespace Mcp\Tests\Integration;

use Mcp\Exception\RequestException;
use PHPUnit\Framework\Attributes\TestDox;

/**
* What a timed-out request leaves behind on the connection.
*
* @see Fixture/request_timeout.php for the server under test
*/
final class RequestTimeoutTest extends IntegrationTestCase
{
#[TestDox('an abandoned response is not handed to the next request')]
public function testTimedOutRequestDoesNotLeakIntoTheNext(): void
{
$client = $this->connect('request_timeout', $this->clientBuilder()->setRequestTimeout(1));

try {
$client->callTool('slow');
$this->fail('The slow tool should have outlived the request timeout.');
} catch (RequestException) {
}

// The server is still executing the abandoned call and cannot answer
// anything until it returns, so the next request has to wait it out.
sleep(2);

// Without the pending request being cleared this answers 'late': the
// response the client gave up on, handed to the request after it.
$this->assertSame('quick', $client->callTool('fast')->content[0]->text ?? null);
}
}
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms"); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 23 additions & 1 deletion docs/client.md
Original file line numberDiff line numberDiff line change
Expand Up@@ -57,10 +57,32 @@ $client = Client::builder()
->setClientInfo('My Application', '1.0.0', 'Description of my client')
->setInitTimeout(30) // Seconds to wait for initialization
->setRequestTimeout(120) // Seconds to wait for request responses
->setMaxRetries(3) // Retry attempts for failed connections
->setMaxRetries(3) // Retries for failed connections
->build();
```

### Connection Retries

`setMaxRetries()` controls how often `connect()` retries a failed connection. It
counts retries rather than attempts, so the default of `3` means one initial
attempt plus up to three retries — four in total — before the `ConnectionException`
of the last attempt is rethrown:

```php
$client = Client::builder()
->setMaxRetries(0) // Fail on the first failed attempt
->build();
```

Between two attempts the transport is closed, so a retry never reuses a
half-established connection: a `StdioTransport` spawns a fresh server process and
an `HttpTransport` discards the session ID of the failed attempt. Each retry is
preceded by a short, linearly growing delay (100ms, 200ms, 300ms, …).

Only the connection handshake is retried. Individual requests such as
`callTool()` are always sent once — retrying them is unsafe as tool calls are not
necessarily idempotent.

### Client Information

Set the client's identity reported to servers during initialization:
Expand Down
36 changes: 33 additions & 3 deletions src/Client.php
Original file line numberDiff line numberDiff line change
Expand Up@@ -58,6 +58,8 @@
*/
class Client
{
private const RETRY_BASE_DELAY_MS = 100;

private ?TransportInterface $transport = null;

public function __construct(
Expand All@@ -78,16 +80,44 @@ public static function builder(): Builder
/**
* Connect to an MCP server using the provided transport.
*
* @throws ConnectionException If connection or initialization fails
* A failed attempt is closed and retried, see {@see Builder::setMaxRetries()}.
*
* @throws ConnectionException If connection or initialization fails on every attempt
*/
public function connect(TransportInterface $transport): void
{
$this->transport = $transport;
$this->protocol->connect($transport, $this->config);

$transport->connect();
$maxAttempts = $this->config->maxRetries + 1;

for ($attempt = 1; $attempt <= $maxAttempts; ++$attempt) {
try {
$transport->connect();

$this->logger->info('Client connected and initialized', ['attempt' => $attempt]);

return;
} catch (ConnectionException $e) {
// initialize() flags the session before sending the initialized
// notification, so a failure in between leaves the flag set.
$this->protocol->getState()->setInitialized(false);

$this->logger->info('Client connected and initialized');
$transport->close();

if ($attempt === $maxAttempts) {
throw $e;
}

$this->logger->warning('Connection attempt failed, retrying', [
'attempt' => $attempt,
'max_attempts' => $maxAttempts,
'exception' => $e,
]);

usleep($attempt * self::RETRY_BASE_DELAY_MS * 1000);
}
}
}

/**
Expand Down
6 changes: 5 additions & 1 deletion src/Client/Builder.php
Original file line numberDiff line numberDiff line change
Expand Up@@ -96,7 +96,11 @@ public function setRequestTimeout(int $seconds): self
}

/**
* Set maximum retry attempts for failed connections.
* Set the number of times a failed connection attempt is retried.
*
* Counts retries, not attempts: 3 means one initial attempt plus up to three
* retries. Pass 0 to fail on the first failure. Only applies to
* {@see Client::connect()}; individual requests are never retried.
*/
public function setMaxRetries(int $retries): self
{
Expand Down
4 changes: 4 additions & 0 deletions src/Client/Configuration.php
Original file line numberDiff line numberDiff line change
Expand Up@@ -38,5 +38,9 @@ public function __construct(
if ($requestTimeout < 1) {
throw new InvalidArgumentException(\sprintf('The request timeout must be a positive number of seconds, got %d.', $requestTimeout));
}

if ($maxRetries < 0) {
throw new InvalidArgumentException(\sprintf('The maximum number of retries must be zero or greater, got %d.', $maxRetries));
}
}
}
31 changes: 19 additions & 12 deletions src/Client/Protocol.php
Original file line numberDiff line numberDiff line change
Expand Up@@ -179,22 +179,29 @@ public function request(Request $request, int $timeout, bool $withProgress = fal
}

$this->state->addPendingRequest($requestId, $timeout);
$this->sendRequest($request);

$immediate = $this->state->consumeResponse($requestId);
if (null !== $immediate) {
$this->logger->debug('Received immediate response', ['id' => $requestId]);
try {
$this->sendRequest($request);

return $immediate;
}
$immediate = $this->state->consumeResponse($requestId);
if (null !== $immediate) {
$this->logger->debug('Received immediate response', ['id' => $requestId]);

$this->logger->debug('Suspending fiber for response', ['id' => $requestId]);
return $immediate;
}

return \Fiber::suspend([
'type' => 'await_response',
'request_id' => $requestId,
'timeout' => $timeout,
]);
$this->logger->debug('Suspending fiber for response', ['id' => $requestId]);

return \Fiber::suspend([
'type' => 'await_response',
'request_id' => $requestId,
'timeout' => $timeout,
]);
} finally {
// Only the response path clears it, so a request that timed out or
// whose send() threw would stay pending and fail every later one.
$this->state->removePendingRequest($requestId);
}
}

/**
Expand Down
42 changes: 42 additions & 0 deletions tests/Integration/Fixture/request_timeout.php
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,42 @@
<?php

/*
* This file is part of the official PHP MCP SDK.
*
* A collaboration between Symfony and the PHP Foundation.
*
* For the full copyright and license information, please view the LICENSE
* file that was distributed with this source code.
*/

/*
* Server for {@see \Mcp\Tests\Integration\RequestTimeoutTest}.
*
* `slow` outlives the client's request timeout and then goes idle again, which
* is what lets the test call `fast` on a connection the client has already
* given up on once.
*/

use Mcp\Server;
use Mcp\Server\Transport\StdioTransport;

require_once dirname(__DIR__, 3).'/vendor/autoload.php';

Server::builder()
->setServerInfo('integration-server', '1.0.0')
->addTool(
static function (): string {
sleep(2);

return 'late';
},
name: 'slow',
description: 'Answers well after the client stopped waiting.',
)
->addTool(
static fn (): string => 'quick',
name: 'fast',
description: 'Returns at once.',
)
->build()
->run(new StdioTransport());
46 changes: 46 additions & 0 deletions tests/Integration/Fixture/retry.php
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,46 @@
<?php

/*
* This file is part of the official PHP MCP SDK.
*
* A collaboration between Symfony and the PHP Foundation.
*
* For the full copyright and license information, please view the LICENSE
* file that was distributed with this source code.
*/

/*
* Server for {@see \Mcp\Tests\Integration\RetryTest}.
*
* Dies before speaking a frame while the spawn counter is below the configured
* number of failures, so the counter file records how many processes the client
* actually started.
*/

use Mcp\Server;
use Mcp\Server\Transport\StdioTransport;

require_once dirname(__DIR__, 3).'/vendor/autoload.php';

$counter = getenv('MCP_SPAWN_COUNTER');

if (!is_string($counter) || '' === $counter) {
exit(1);
}

$spawns = 1 + (int) file_get_contents($counter);
file_put_contents($counter, (string) $spawns);

if ($spawns <= (int) getenv('MCP_FAIL_SPAWNS')) {
exit(1);
}

Server::builder()
->setServerInfo('integration-server', '1.0.0')
->addTool(
static fn (): string => 'quick',
name: 'fast',
description: 'Returns at once.',
)
->build()
->run(new StdioTransport());
34 changes: 25 additions & 9 deletions tests/Integration/IntegrationTestCase.php
Original file line numberDiff line numberDiff line change
Expand Up@@ -55,26 +55,42 @@ protected function clientBuilder(): ClientBuilder
*/
protected function connect(string $fixture, ?ClientBuilder $client = null, array $env = []): Client
{
$script = __DIR__.'/Fixture/'.$fixture.'.php';

$this->client = ($client ?? $this->clientBuilder())->build();

try {
$this->client->connect(new StdioTransport(
command: \PHP_BINARY,
args: [$script],
// proc_open() replaces the environment rather than adding to it.
env: [] === $env ? null : array_merge(getenv(), $env),
));
$this->client->connect($this->transport($fixture, $env));
} catch (ConnectionException $e) {
// The transport discards the child's stderr, so a fixture dying on
// startup arrives here as a bare timeout.
$this->fail(\sprintf('Could not connect to fixture server "%s": %s. Run `%s %s` to see why.', $fixture, $e->getMessage(), \PHP_BINARY, $script));
$this->fail(\sprintf('Could not connect to fixture server "%s": %s. Run `%s %s` to see why.', $fixture, $e->getMessage(), \PHP_BINARY, self::script($fixture)));
}

return $this->client;
}

/**
* A transport that will spawn a fixture server, without connecting it.
*
* Tests that assert on a failing connection need the transport by itself,
* since {@see self::connect()} turns that failure into a test failure.
*
* @param array<string, string> $env added to the server process environment
*/
protected function transport(string $fixture, array $env = []): StdioTransport
{
return new StdioTransport(
command: \PHP_BINARY,
args: [self::script($fixture)],
// proc_open() replaces the environment rather than adding to it.
env: [] === $env ? null : array_merge(getenv(), $env),
);
}

private static function script(string $fixture): string
{
return __DIR__.'/Fixture/'.$fixture.'.php';
}

protected function tearDown(): void
{
$this->client?->disconnect();
Expand Down
43 changes: 43 additions & 0 deletions tests/Integration/RequestTimeoutTest.php
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,43 @@
<?php

/*
* This file is part of the official PHP MCP SDK.
*
* A collaboration between Symfony and the PHP Foundation.
*
* For the full copyright and license information, please view the LICENSE
* file that was distributed with this source code.
*/

namespace Mcp\Tests\Integration;

use Mcp\Exception\RequestException;
use PHPUnit\Framework\Attributes\TestDox;

/**
* What a timed-out request leaves behind on the connection.
*
* @see Fixture/request_timeout.php for the server under test
*/
final class RequestTimeoutTest extends IntegrationTestCase
{
#[TestDox('an abandoned response is not handed to the next request')]
public function testTimedOutRequestDoesNotLeakIntoTheNext(): void
{
$client = $this->connect('request_timeout', $this->clientBuilder()->setRequestTimeout(1));

try {
$client->callTool('slow');
$this->fail('The slow tool should have outlived the request timeout.');
} catch (RequestException) {
}

// The server is still executing the abandoned call and cannot answer
// anything until it returns, so the next request has to wait it out.
sleep(2);

// Without the pending request being cleared this answers 'late': the
// response the client gave up on, handed to the request after it.
$this->assertSame('quick', $client->callTool('fast')->content[0]->text ?? null);
}
}
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links"); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + '
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 23 additions & 1 deletion docs/client.md
Original file line numberDiff line numberDiff line change
Expand Up@@ -57,10 +57,32 @@ $client = Client::builder()
->setClientInfo('My Application', '1.0.0', 'Description of my client')
->setInitTimeout(30) // Seconds to wait for initialization
->setRequestTimeout(120) // Seconds to wait for request responses
->setMaxRetries(3) // Retry attempts for failed connections
->setMaxRetries(3) // Retries for failed connections
->build();
```

### Connection Retries

`setMaxRetries()` controls how often `connect()` retries a failed connection. It
counts retries rather than attempts, so the default of `3` means one initial
attempt plus up to three retries — four in total — before the `ConnectionException`
of the last attempt is rethrown:

```php
$client = Client::builder()
->setMaxRetries(0) // Fail on the first failed attempt
->build();
```

Between two attempts the transport is closed, so a retry never reuses a
half-established connection: a `StdioTransport` spawns a fresh server process and
an `HttpTransport` discards the session ID of the failed attempt. Each retry is
preceded by a short, linearly growing delay (100ms, 200ms, 300ms, …).

Only the connection handshake is retried. Individual requests such as
`callTool()` are always sent once — retrying them is unsafe as tool calls are not
necessarily idempotent.

### Client Information

Set the client's identity reported to servers during initialization:
Expand Down
36 changes: 33 additions & 3 deletions src/Client.php
Original file line numberDiff line numberDiff line change
Expand Up@@ -58,6 +58,8 @@
*/
class Client
{
private const RETRY_BASE_DELAY_MS = 100;

private ?TransportInterface $transport = null;

public function __construct(
Expand All@@ -78,16 +80,44 @@ public static function builder(): Builder
/**
* Connect to an MCP server using the provided transport.
*
* @throws ConnectionException If connection or initialization fails
* A failed attempt is closed and retried, see {@see Builder::setMaxRetries()}.
*
* @throws ConnectionException If connection or initialization fails on every attempt
*/
public function connect(TransportInterface $transport): void
{
$this->transport = $transport;
$this->protocol->connect($transport, $this->config);

$transport->connect();
$maxAttempts = $this->config->maxRetries + 1;

for ($attempt = 1; $attempt <= $maxAttempts; ++$attempt) {
try {
$transport->connect();

$this->logger->info('Client connected and initialized', ['attempt' => $attempt]);

return;
} catch (ConnectionException $e) {
// initialize() flags the session before sending the initialized
// notification, so a failure in between leaves the flag set.
$this->protocol->getState()->setInitialized(false);

$this->logger->info('Client connected and initialized');
$transport->close();

if ($attempt === $maxAttempts) {
throw $e;
}

$this->logger->warning('Connection attempt failed, retrying', [
'attempt' => $attempt,
'max_attempts' => $maxAttempts,
'exception' => $e,
]);

usleep($attempt * self::RETRY_BASE_DELAY_MS * 1000);
}
}
}

/**
Expand Down
6 changes: 5 additions & 1 deletion src/Client/Builder.php
Original file line numberDiff line numberDiff line change
Expand Up@@ -96,7 +96,11 @@ public function setRequestTimeout(int $seconds): self
}

/**
* Set maximum retry attempts for failed connections.
* Set the number of times a failed connection attempt is retried.
*
* Counts retries, not attempts: 3 means one initial attempt plus up to three
* retries. Pass 0 to fail on the first failure. Only applies to
* {@see Client::connect()}; individual requests are never retried.
*/
public function setMaxRetries(int $retries): self
{
Expand Down
4 changes: 4 additions & 0 deletions src/Client/Configuration.php
Original file line numberDiff line numberDiff line change
Expand Up@@ -38,5 +38,9 @@ public function __construct(
if ($requestTimeout < 1) {
throw new InvalidArgumentException(\sprintf('The request timeout must be a positive number of seconds, got %d.', $requestTimeout));
}

if ($maxRetries < 0) {
throw new InvalidArgumentException(\sprintf('The maximum number of retries must be zero or greater, got %d.', $maxRetries));
}
}
}
31 changes: 19 additions & 12 deletions src/Client/Protocol.php
Original file line numberDiff line numberDiff line change
Expand Up@@ -179,22 +179,29 @@ public function request(Request $request, int $timeout, bool $withProgress = fal
}

$this->state->addPendingRequest($requestId, $timeout);
$this->sendRequest($request);

$immediate = $this->state->consumeResponse($requestId);
if (null !== $immediate) {
$this->logger->debug('Received immediate response', ['id' => $requestId]);
try {
$this->sendRequest($request);

return $immediate;
}
$immediate = $this->state->consumeResponse($requestId);
if (null !== $immediate) {
$this->logger->debug('Received immediate response', ['id' => $requestId]);

$this->logger->debug('Suspending fiber for response', ['id' => $requestId]);
return $immediate;
}

return \Fiber::suspend([
'type' => 'await_response',
'request_id' => $requestId,
'timeout' => $timeout,
]);
$this->logger->debug('Suspending fiber for response', ['id' => $requestId]);

return \Fiber::suspend([
'type' => 'await_response',
'request_id' => $requestId,
'timeout' => $timeout,
]);
} finally {
// Only the response path clears it, so a request that timed out or
// whose send() threw would stay pending and fail every later one.
$this->state->removePendingRequest($requestId);
}
}

/**
Expand Down
42 changes: 42 additions & 0 deletions tests/Integration/Fixture/request_timeout.php
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,42 @@
<?php

/*
* This file is part of the official PHP MCP SDK.
*
* A collaboration between Symfony and the PHP Foundation.
*
* For the full copyright and license information, please view the LICENSE
* file that was distributed with this source code.
*/

/*
* Server for {@see \Mcp\Tests\Integration\RequestTimeoutTest}.
*
* `slow` outlives the client's request timeout and then goes idle again, which
* is what lets the test call `fast` on a connection the client has already
* given up on once.
*/

use Mcp\Server;
use Mcp\Server\Transport\StdioTransport;

require_once dirname(__DIR__, 3).'/vendor/autoload.php';

Server::builder()
->setServerInfo('integration-server', '1.0.0')
->addTool(
static function (): string {
sleep(2);

return 'late';
},
name: 'slow',
description: 'Answers well after the client stopped waiting.',
)
->addTool(
static fn (): string => 'quick',
name: 'fast',
description: 'Returns at once.',
)
->build()
->run(new StdioTransport());
46 changes: 46 additions & 0 deletions tests/Integration/Fixture/retry.php
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,46 @@
<?php

/*
* This file is part of the official PHP MCP SDK.
*
* A collaboration between Symfony and the PHP Foundation.
*
* For the full copyright and license information, please view the LICENSE
* file that was distributed with this source code.
*/

/*
* Server for {@see \Mcp\Tests\Integration\RetryTest}.
*
* Dies before speaking a frame while the spawn counter is below the configured
* number of failures, so the counter file records how many processes the client
* actually started.
*/

use Mcp\Server;
use Mcp\Server\Transport\StdioTransport;

require_once dirname(__DIR__, 3).'/vendor/autoload.php';

$counter = getenv('MCP_SPAWN_COUNTER');

if (!is_string($counter) || '' === $counter) {
exit(1);
}

$spawns = 1 + (int) file_get_contents($counter);
file_put_contents($counter, (string) $spawns);

if ($spawns <= (int) getenv('MCP_FAIL_SPAWNS')) {
exit(1);
}

Server::builder()
->setServerInfo('integration-server', '1.0.0')
->addTool(
static fn (): string => 'quick',
name: 'fast',
description: 'Returns at once.',
)
->build()
->run(new StdioTransport());
34 changes: 25 additions & 9 deletions tests/Integration/IntegrationTestCase.php
Original file line numberDiff line numberDiff line change
Expand Up@@ -55,26 +55,42 @@ protected function clientBuilder(): ClientBuilder
*/
protected function connect(string $fixture, ?ClientBuilder $client = null, array $env = []): Client
{
$script = __DIR__.'/Fixture/'.$fixture.'.php';

$this->client = ($client ?? $this->clientBuilder())->build();

try {
$this->client->connect(new StdioTransport(
command: \PHP_BINARY,
args: [$script],
// proc_open() replaces the environment rather than adding to it.
env: [] === $env ? null : array_merge(getenv(), $env),
));
$this->client->connect($this->transport($fixture, $env));
} catch (ConnectionException $e) {
// The transport discards the child's stderr, so a fixture dying on
// startup arrives here as a bare timeout.
$this->fail(\sprintf('Could not connect to fixture server "%s": %s. Run `%s %s` to see why.', $fixture, $e->getMessage(), \PHP_BINARY, $script));
$this->fail(\sprintf('Could not connect to fixture server "%s": %s. Run `%s %s` to see why.', $fixture, $e->getMessage(), \PHP_BINARY, self::script($fixture)));
}

return $this->client;
}

/**
* A transport that will spawn a fixture server, without connecting it.
*
* Tests that assert on a failing connection need the transport by itself,
* since {@see self::connect()} turns that failure into a test failure.
*
* @param array<string, string> $env added to the server process environment
*/
protected function transport(string $fixture, array $env = []): StdioTransport
{
return new StdioTransport(
command: \PHP_BINARY,
args: [self::script($fixture)],
// proc_open() replaces the environment rather than adding to it.
env: [] === $env ? null : array_merge(getenv(), $env),
);
}

private static function script(string $fixture): string
{
return __DIR__.'/Fixture/'.$fixture.'.php';
}

protected function tearDown(): void
{
$this->client?->disconnect();
Expand Down
43 changes: 43 additions & 0 deletions tests/Integration/RequestTimeoutTest.php
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,43 @@
<?php

/*
* This file is part of the official PHP MCP SDK.
*
* A collaboration between Symfony and the PHP Foundation.
*
* For the full copyright and license information, please view the LICENSE
* file that was distributed with this source code.
*/

namespace Mcp\Tests\Integration;

use Mcp\Exception\RequestException;
use PHPUnit\Framework\Attributes\TestDox;

/**
* What a timed-out request leaves behind on the connection.
*
* @see Fixture/request_timeout.php for the server under test
*/
final class RequestTimeoutTest extends IntegrationTestCase
{
#[TestDox('an abandoned response is not handed to the next request')]
public function testTimedOutRequestDoesNotLeakIntoTheNext(): void
{
$client = $this->connect('request_timeout', $this->clientBuilder()->setRequestTimeout(1));

try {
$client->callTool('slow');
$this->fail('The slow tool should have outlived the request timeout.');
} catch (RequestException) {
}

// The server is still executing the abandoned call and cannot answer
// anything until it returns, so the next request has to wait it out.
sleep(2);

// Without the pending request being cleared this answers 'late': the
// response the client gave up on, handed to the request after it.
$this->assertSame('quick', $client->callTool('fast')->content[0]->text ?? null);
}
}
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default"); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 23 additions & 1 deletion docs/client.md
Original file line numberDiff line numberDiff line change
Expand Up@@ -57,10 +57,32 @@ $client = Client::builder()
->setClientInfo('My Application', '1.0.0', 'Description of my client')
->setInitTimeout(30) // Seconds to wait for initialization
->setRequestTimeout(120) // Seconds to wait for request responses
->setMaxRetries(3) // Retry attempts for failed connections
->setMaxRetries(3) // Retries for failed connections
->build();
```

### Connection Retries

`setMaxRetries()` controls how often `connect()` retries a failed connection. It
counts retries rather than attempts, so the default of `3` means one initial
attempt plus up to three retries — four in total — before the `ConnectionException`
of the last attempt is rethrown:

```php
$client = Client::builder()
->setMaxRetries(0) // Fail on the first failed attempt
->build();
```

Between two attempts the transport is closed, so a retry never reuses a
half-established connection: a `StdioTransport` spawns a fresh server process and
an `HttpTransport` discards the session ID of the failed attempt. Each retry is
preceded by a short, linearly growing delay (100ms, 200ms, 300ms, …).

Only the connection handshake is retried. Individual requests such as
`callTool()` are always sent once — retrying them is unsafe as tool calls are not
necessarily idempotent.

### Client Information

Set the client's identity reported to servers during initialization:
Expand Down
36 changes: 33 additions & 3 deletions src/Client.php
Original file line numberDiff line numberDiff line change
Expand Up@@ -58,6 +58,8 @@
*/
class Client
{
private const RETRY_BASE_DELAY_MS = 100;

private ?TransportInterface $transport = null;

public function __construct(
Expand All@@ -78,16 +80,44 @@ public static function builder(): Builder
/**
* Connect to an MCP server using the provided transport.
*
* @throws ConnectionException If connection or initialization fails
* A failed attempt is closed and retried, see {@see Builder::setMaxRetries()}.
*
* @throws ConnectionException If connection or initialization fails on every attempt
*/
public function connect(TransportInterface $transport): void
{
$this->transport = $transport;
$this->protocol->connect($transport, $this->config);

$transport->connect();
$maxAttempts = $this->config->maxRetries + 1;

for ($attempt = 1; $attempt <= $maxAttempts; ++$attempt) {
try {
$transport->connect();

$this->logger->info('Client connected and initialized', ['attempt' => $attempt]);

return;
} catch (ConnectionException $e) {
// initialize() flags the session before sending the initialized
// notification, so a failure in between leaves the flag set.
$this->protocol->getState()->setInitialized(false);

$this->logger->info('Client connected and initialized');
$transport->close();

if ($attempt === $maxAttempts) {
throw $e;
}

$this->logger->warning('Connection attempt failed, retrying', [
'attempt' => $attempt,
'max_attempts' => $maxAttempts,
'exception' => $e,
]);

usleep($attempt * self::RETRY_BASE_DELAY_MS * 1000);
}
}
}

/**
Expand Down
6 changes: 5 additions & 1 deletion src/Client/Builder.php
Original file line numberDiff line numberDiff line change
Expand Up@@ -96,7 +96,11 @@ public function setRequestTimeout(int $seconds): self
}

/**
* Set maximum retry attempts for failed connections.
* Set the number of times a failed connection attempt is retried.
*
* Counts retries, not attempts: 3 means one initial attempt plus up to three
* retries. Pass 0 to fail on the first failure. Only applies to
* {@see Client::connect()}; individual requests are never retried.
*/
public function setMaxRetries(int $retries): self
{
Expand Down
4 changes: 4 additions & 0 deletions src/Client/Configuration.php
Original file line numberDiff line numberDiff line change
Expand Up@@ -38,5 +38,9 @@ public function __construct(
if ($requestTimeout < 1) {
throw new InvalidArgumentException(\sprintf('The request timeout must be a positive number of seconds, got %d.', $requestTimeout));
}

if ($maxRetries < 0) {
throw new InvalidArgumentException(\sprintf('The maximum number of retries must be zero or greater, got %d.', $maxRetries));
}
}
}
31 changes: 19 additions & 12 deletions src/Client/Protocol.php
Original file line numberDiff line numberDiff line change
Expand Up@@ -179,22 +179,29 @@ public function request(Request $request, int $timeout, bool $withProgress = fal
}

$this->state->addPendingRequest($requestId, $timeout);
$this->sendRequest($request);

$immediate = $this->state->consumeResponse($requestId);
if (null !== $immediate) {
$this->logger->debug('Received immediate response', ['id' => $requestId]);
try {
$this->sendRequest($request);

return $immediate;
}
$immediate = $this->state->consumeResponse($requestId);
if (null !== $immediate) {
$this->logger->debug('Received immediate response', ['id' => $requestId]);

$this->logger->debug('Suspending fiber for response', ['id' => $requestId]);
return $immediate;
}

return \Fiber::suspend([
'type' => 'await_response',
'request_id' => $requestId,
'timeout' => $timeout,
]);
$this->logger->debug('Suspending fiber for response', ['id' => $requestId]);

return \Fiber::suspend([
'type' => 'await_response',
'request_id' => $requestId,
'timeout' => $timeout,
]);
} finally {
// Only the response path clears it, so a request that timed out or
// whose send() threw would stay pending and fail every later one.
$this->state->removePendingRequest($requestId);
}
}

/**
Expand Down
42 changes: 42 additions & 0 deletions tests/Integration/Fixture/request_timeout.php
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,42 @@
<?php

/*
* This file is part of the official PHP MCP SDK.
*
* A collaboration between Symfony and the PHP Foundation.
*
* For the full copyright and license information, please view the LICENSE
* file that was distributed with this source code.
*/

/*
* Server for {@see \Mcp\Tests\Integration\RequestTimeoutTest}.
*
* `slow` outlives the client's request timeout and then goes idle again, which
* is what lets the test call `fast` on a connection the client has already
* given up on once.
*/

use Mcp\Server;
use Mcp\Server\Transport\StdioTransport;

require_once dirname(__DIR__, 3).'/vendor/autoload.php';

Server::builder()
->setServerInfo('integration-server', '1.0.0')
->addTool(
static function (): string {
sleep(2);

return 'late';
},
name: 'slow',
description: 'Answers well after the client stopped waiting.',
)
->addTool(
static fn (): string => 'quick',
name: 'fast',
description: 'Returns at once.',
)
->build()
->run(new StdioTransport());
46 changes: 46 additions & 0 deletions tests/Integration/Fixture/retry.php
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,46 @@
<?php

/*
* This file is part of the official PHP MCP SDK.
*
* A collaboration between Symfony and the PHP Foundation.
*
* For the full copyright and license information, please view the LICENSE
* file that was distributed with this source code.
*/

/*
* Server for {@see \Mcp\Tests\Integration\RetryTest}.
*
* Dies before speaking a frame while the spawn counter is below the configured
* number of failures, so the counter file records how many processes the client
* actually started.
*/

use Mcp\Server;
use Mcp\Server\Transport\StdioTransport;

require_once dirname(__DIR__, 3).'/vendor/autoload.php';

$counter = getenv('MCP_SPAWN_COUNTER');

if (!is_string($counter) || '' === $counter) {
exit(1);
}

$spawns = 1 + (int) file_get_contents($counter);
file_put_contents($counter, (string) $spawns);

if ($spawns <= (int) getenv('MCP_FAIL_SPAWNS')) {
exit(1);
}

Server::builder()
->setServerInfo('integration-server', '1.0.0')
->addTool(
static fn (): string => 'quick',
name: 'fast',
description: 'Returns at once.',
)
->build()
->run(new StdioTransport());
34 changes: 25 additions & 9 deletions tests/Integration/IntegrationTestCase.php
Original file line numberDiff line numberDiff line change
Expand Up@@ -55,26 +55,42 @@ protected function clientBuilder(): ClientBuilder
*/
protected function connect(string $fixture, ?ClientBuilder $client = null, array $env = []): Client
{
$script = __DIR__.'/Fixture/'.$fixture.'.php';

$this->client = ($client ?? $this->clientBuilder())->build();

try {
$this->client->connect(new StdioTransport(
command: \PHP_BINARY,
args: [$script],
// proc_open() replaces the environment rather than adding to it.
env: [] === $env ? null : array_merge(getenv(), $env),
));
$this->client->connect($this->transport($fixture, $env));
} catch (ConnectionException $e) {
// The transport discards the child's stderr, so a fixture dying on
// startup arrives here as a bare timeout.
$this->fail(\sprintf('Could not connect to fixture server "%s": %s. Run `%s %s` to see why.', $fixture, $e->getMessage(), \PHP_BINARY, $script));
$this->fail(\sprintf('Could not connect to fixture server "%s": %s. Run `%s %s` to see why.', $fixture, $e->getMessage(), \PHP_BINARY, self::script($fixture)));
}

return $this->client;
}

/**
* A transport that will spawn a fixture server, without connecting it.
*
* Tests that assert on a failing connection need the transport by itself,
* since {@see self::connect()} turns that failure into a test failure.
*
* @param array<string, string> $env added to the server process environment
*/
protected function transport(string $fixture, array $env = []): StdioTransport
{
return new StdioTransport(
command: \PHP_BINARY,
args: [self::script($fixture)],
// proc_open() replaces the environment rather than adding to it.
env: [] === $env ? null : array_merge(getenv(), $env),
);
}

private static function script(string $fixture): string
{
return __DIR__.'/Fixture/'.$fixture.'.php';
}

protected function tearDown(): void
{
$this->client?->disconnect();
Expand Down
43 changes: 43 additions & 0 deletions tests/Integration/RequestTimeoutTest.php
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,43 @@
<?php

/*
* This file is part of the official PHP MCP SDK.
*
* A collaboration between Symfony and the PHP Foundation.
*
* For the full copyright and license information, please view the LICENSE
* file that was distributed with this source code.
*/

namespace Mcp\Tests\Integration;

use Mcp\Exception\RequestException;
use PHPUnit\Framework\Attributes\TestDox;

/**
* What a timed-out request leaves behind on the connection.
*
* @see Fixture/request_timeout.php for the server under test
*/
final class RequestTimeoutTest extends IntegrationTestCase
{
#[TestDox('an abandoned response is not handed to the next request')]
public function testTimedOutRequestDoesNotLeakIntoTheNext(): void
{
$client = $this->connect('request_timeout', $this->clientBuilder()->setRequestTimeout(1));

try {
$client->callTool('slow');
$this->fail('The slow tool should have outlived the request timeout.');
} catch (RequestException) {
}

// The server is still executing the abandoned call and cannot answer
// anything until it returns, so the next request has to wait it out.
sleep(2);

// Without the pending request being cleared this answers 'late': the
// response the client gave up on, handed to the request after it.
$this->assertSame('quick', $client->callTool('fast')->content[0]->text ?? null);
}
}
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers"); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 23 additions & 1 deletion docs/client.md
Original file line numberDiff line numberDiff line change
Expand Up@@ -57,10 +57,32 @@ $client = Client::builder()
->setClientInfo('My Application', '1.0.0', 'Description of my client')
->setInitTimeout(30) // Seconds to wait for initialization
->setRequestTimeout(120) // Seconds to wait for request responses
->setMaxRetries(3) // Retry attempts for failed connections
->setMaxRetries(3) // Retries for failed connections
->build();
```

### Connection Retries

`setMaxRetries()` controls how often `connect()` retries a failed connection. It
counts retries rather than attempts, so the default of `3` means one initial
attempt plus up to three retries — four in total — before the `ConnectionException`
of the last attempt is rethrown:

```php
$client = Client::builder()
->setMaxRetries(0) // Fail on the first failed attempt
->build();
```

Between two attempts the transport is closed, so a retry never reuses a
half-established connection: a `StdioTransport` spawns a fresh server process and
an `HttpTransport` discards the session ID of the failed attempt. Each retry is
preceded by a short, linearly growing delay (100ms, 200ms, 300ms, …).

Only the connection handshake is retried. Individual requests such as
`callTool()` are always sent once — retrying them is unsafe as tool calls are not
necessarily idempotent.

### Client Information

Set the client's identity reported to servers during initialization:
Expand Down
36 changes: 33 additions & 3 deletions src/Client.php
Original file line numberDiff line numberDiff line change
Expand Up@@ -58,6 +58,8 @@
*/
class Client
{
private const RETRY_BASE_DELAY_MS = 100;

private ?TransportInterface $transport = null;

public function __construct(
Expand All@@ -78,16 +80,44 @@ public static function builder(): Builder
/**
* Connect to an MCP server using the provided transport.
*
* @throws ConnectionException If connection or initialization fails
* A failed attempt is closed and retried, see {@see Builder::setMaxRetries()}.
*
* @throws ConnectionException If connection or initialization fails on every attempt
*/
public function connect(TransportInterface $transport): void
{
$this->transport = $transport;
$this->protocol->connect($transport, $this->config);

$transport->connect();
$maxAttempts = $this->config->maxRetries + 1;

for ($attempt = 1; $attempt <= $maxAttempts; ++$attempt) {
try {
$transport->connect();

$this->logger->info('Client connected and initialized', ['attempt' => $attempt]);

return;
} catch (ConnectionException $e) {
// initialize() flags the session before sending the initialized
// notification, so a failure in between leaves the flag set.
$this->protocol->getState()->setInitialized(false);

$this->logger->info('Client connected and initialized');
$transport->close();

if ($attempt === $maxAttempts) {
throw $e;
}

$this->logger->warning('Connection attempt failed, retrying', [
'attempt' => $attempt,
'max_attempts' => $maxAttempts,
'exception' => $e,
]);

usleep($attempt * self::RETRY_BASE_DELAY_MS * 1000);
}
}
}

/**
Expand Down
6 changes: 5 additions & 1 deletion src/Client/Builder.php
Original file line numberDiff line numberDiff line change
Expand Up@@ -96,7 +96,11 @@ public function setRequestTimeout(int $seconds): self
}

/**
* Set maximum retry attempts for failed connections.
* Set the number of times a failed connection attempt is retried.
*
* Counts retries, not attempts: 3 means one initial attempt plus up to three
* retries. Pass 0 to fail on the first failure. Only applies to
* {@see Client::connect()}; individual requests are never retried.
*/
public function setMaxRetries(int $retries): self
{
Expand Down
4 changes: 4 additions & 0 deletions src/Client/Configuration.php
Original file line numberDiff line numberDiff line change
Expand Up@@ -38,5 +38,9 @@ public function __construct(
if ($requestTimeout < 1) {
throw new InvalidArgumentException(\sprintf('The request timeout must be a positive number of seconds, got %d.', $requestTimeout));
}

if ($maxRetries < 0) {
throw new InvalidArgumentException(\sprintf('The maximum number of retries must be zero or greater, got %d.', $maxRetries));
}
}
}
31 changes: 19 additions & 12 deletions src/Client/Protocol.php
Original file line numberDiff line numberDiff line change
Expand Up@@ -179,22 +179,29 @@ public function request(Request $request, int $timeout, bool $withProgress = fal
}

$this->state->addPendingRequest($requestId, $timeout);
$this->sendRequest($request);

$immediate = $this->state->consumeResponse($requestId);
if (null !== $immediate) {
$this->logger->debug('Received immediate response', ['id' => $requestId]);
try {
$this->sendRequest($request);

return $immediate;
}
$immediate = $this->state->consumeResponse($requestId);
if (null !== $immediate) {
$this->logger->debug('Received immediate response', ['id' => $requestId]);

$this->logger->debug('Suspending fiber for response', ['id' => $requestId]);
return $immediate;
}

return \Fiber::suspend([
'type' => 'await_response',
'request_id' => $requestId,
'timeout' => $timeout,
]);
$this->logger->debug('Suspending fiber for response', ['id' => $requestId]);

return \Fiber::suspend([
'type' => 'await_response',
'request_id' => $requestId,
'timeout' => $timeout,
]);
} finally {
// Only the response path clears it, so a request that timed out or
// whose send() threw would stay pending and fail every later one.
$this->state->removePendingRequest($requestId);
}
}

/**
Expand Down
42 changes: 42 additions & 0 deletions tests/Integration/Fixture/request_timeout.php
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,42 @@
<?php

/*
* This file is part of the official PHP MCP SDK.
*
* A collaboration between Symfony and the PHP Foundation.
*
* For the full copyright and license information, please view the LICENSE
* file that was distributed with this source code.
*/

/*
* Server for {@see \Mcp\Tests\Integration\RequestTimeoutTest}.
*
* `slow` outlives the client's request timeout and then goes idle again, which
* is what lets the test call `fast` on a connection the client has already
* given up on once.
*/

use Mcp\Server;
use Mcp\Server\Transport\StdioTransport;

require_once dirname(__DIR__, 3).'/vendor/autoload.php';

Server::builder()
->setServerInfo('integration-server', '1.0.0')
->addTool(
static function (): string {
sleep(2);

return 'late';
},
name: 'slow',
description: 'Answers well after the client stopped waiting.',
)
->addTool(
static fn (): string => 'quick',
name: 'fast',
description: 'Returns at once.',
)
->build()
->run(new StdioTransport());
46 changes: 46 additions & 0 deletions tests/Integration/Fixture/retry.php
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,46 @@
<?php

/*
* This file is part of the official PHP MCP SDK.
*
* A collaboration between Symfony and the PHP Foundation.
*
* For the full copyright and license information, please view the LICENSE
* file that was distributed with this source code.
*/

/*
* Server for {@see \Mcp\Tests\Integration\RetryTest}.
*
* Dies before speaking a frame while the spawn counter is below the configured
* number of failures, so the counter file records how many processes the client
* actually started.
*/

use Mcp\Server;
use Mcp\Server\Transport\StdioTransport;

require_once dirname(__DIR__, 3).'/vendor/autoload.php';

$counter = getenv('MCP_SPAWN_COUNTER');

if (!is_string($counter) || '' === $counter) {
exit(1);
}

$spawns = 1 + (int) file_get_contents($counter);
file_put_contents($counter, (string) $spawns);

if ($spawns <= (int) getenv('MCP_FAIL_SPAWNS')) {
exit(1);
}

Server::builder()
->setServerInfo('integration-server', '1.0.0')
->addTool(
static fn (): string => 'quick',
name: 'fast',
description: 'Returns at once.',
)
->build()
->run(new StdioTransport());
34 changes: 25 additions & 9 deletions tests/Integration/IntegrationTestCase.php
Original file line numberDiff line numberDiff line change
Expand Up@@ -55,26 +55,42 @@ protected function clientBuilder(): ClientBuilder
*/
protected function connect(string $fixture, ?ClientBuilder $client = null, array $env = []): Client
{
$script = __DIR__.'/Fixture/'.$fixture.'.php';

$this->client = ($client ?? $this->clientBuilder())->build();

try {
$this->client->connect(new StdioTransport(
command: \PHP_BINARY,
args: [$script],
// proc_open() replaces the environment rather than adding to it.
env: [] === $env ? null : array_merge(getenv(), $env),
));
$this->client->connect($this->transport($fixture, $env));
} catch (ConnectionException $e) {
// The transport discards the child's stderr, so a fixture dying on
// startup arrives here as a bare timeout.
$this->fail(\sprintf('Could not connect to fixture server "%s": %s. Run `%s %s` to see why.', $fixture, $e->getMessage(), \PHP_BINARY, $script));
$this->fail(\sprintf('Could not connect to fixture server "%s": %s. Run `%s %s` to see why.', $fixture, $e->getMessage(), \PHP_BINARY, self::script($fixture)));
}

return $this->client;
}

/**
* A transport that will spawn a fixture server, without connecting it.
*
* Tests that assert on a failing connection need the transport by itself,
* since {@see self::connect()} turns that failure into a test failure.
*
* @param array<string, string> $env added to the server process environment
*/
protected function transport(string $fixture, array $env = []): StdioTransport
{
return new StdioTransport(
command: \PHP_BINARY,
args: [self::script($fixture)],
// proc_open() replaces the environment rather than adding to it.
env: [] === $env ? null : array_merge(getenv(), $env),
);
}

private static function script(string $fixture): string
{
return __DIR__.'/Fixture/'.$fixture.'.php';
}

protected function tearDown(): void
{
$this->client?->disconnect();
Expand Down
43 changes: 43 additions & 0 deletions tests/Integration/RequestTimeoutTest.php
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,43 @@
<?php

/*
* This file is part of the official PHP MCP SDK.
*
* A collaboration between Symfony and the PHP Foundation.
*
* For the full copyright and license information, please view the LICENSE
* file that was distributed with this source code.
*/

namespace Mcp\Tests\Integration;

use Mcp\Exception\RequestException;
use PHPUnit\Framework\Attributes\TestDox;

/**
* What a timed-out request leaves behind on the connection.
*
* @see Fixture/request_timeout.php for the server under test
*/
final class RequestTimeoutTest extends IntegrationTestCase
{
#[TestDox('an abandoned response is not handed to the next request')]
public function testTimedOutRequestDoesNotLeakIntoTheNext(): void
{
$client = $this->connect('request_timeout', $this->clientBuilder()->setRequestTimeout(1));

try {
$client->callTool('slow');
$this->fail('The slow tool should have outlived the request timeout.');
} catch (RequestException) {
}

// The server is still executing the abandoned call and cannot answer
// anything until it returns, so the next request has to wait it out.
sleep(2);

// Without the pending request being cleared this answers 'late': the
// response the client gave up on, handed to the request after it.
$this->assertSame('quick', $client->callTool('fast')->content[0]->text ?? null);
}
}
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode"); } } catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); } })(); })();
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 23 additions & 1 deletion docs/client.md
Original file line numberDiff line numberDiff line change
Expand Up@@ -57,10 +57,32 @@ $client = Client::builder()
->setClientInfo('My Application', '1.0.0', 'Description of my client')
->setInitTimeout(30) // Seconds to wait for initialization
->setRequestTimeout(120) // Seconds to wait for request responses
->setMaxRetries(3) // Retry attempts for failed connections
->setMaxRetries(3) // Retries for failed connections
->build();
```

### Connection Retries

`setMaxRetries()` controls how often `connect()` retries a failed connection. It
counts retries rather than attempts, so the default of `3` means one initial
attempt plus up to three retries — four in total — before the `ConnectionException`
of the last attempt is rethrown:

```php
$client = Client::builder()
->setMaxRetries(0) // Fail on the first failed attempt
->build();
```

Between two attempts the transport is closed, so a retry never reuses a
half-established connection: a `StdioTransport` spawns a fresh server process and
an `HttpTransport` discards the session ID of the failed attempt. Each retry is
preceded by a short, linearly growing delay (100ms, 200ms, 300ms, …).

Only the connection handshake is retried. Individual requests such as
`callTool()` are always sent once — retrying them is unsafe as tool calls are not
necessarily idempotent.

### Client Information

Set the client's identity reported to servers during initialization:
Expand Down
36 changes: 33 additions & 3 deletions src/Client.php
Original file line numberDiff line numberDiff line change
Expand Up@@ -58,6 +58,8 @@
*/
class Client
{
private const RETRY_BASE_DELAY_MS = 100;

private ?TransportInterface $transport = null;

public function __construct(
Expand All@@ -78,16 +80,44 @@ public static function builder(): Builder
/**
* Connect to an MCP server using the provided transport.
*
* @throws ConnectionException If connection or initialization fails
* A failed attempt is closed and retried, see {@see Builder::setMaxRetries()}.
*
* @throws ConnectionException If connection or initialization fails on every attempt
*/
public function connect(TransportInterface $transport): void
{
$this->transport = $transport;
$this->protocol->connect($transport, $this->config);

$transport->connect();
$maxAttempts = $this->config->maxRetries + 1;

for ($attempt = 1; $attempt <= $maxAttempts; ++$attempt) {
try {
$transport->connect();

$this->logger->info('Client connected and initialized', ['attempt' => $attempt]);

return;
} catch (ConnectionException $e) {
// initialize() flags the session before sending the initialized
// notification, so a failure in between leaves the flag set.
$this->protocol->getState()->setInitialized(false);

$this->logger->info('Client connected and initialized');
$transport->close();

if ($attempt === $maxAttempts) {
throw $e;
}

$this->logger->warning('Connection attempt failed, retrying', [
'attempt' => $attempt,
'max_attempts' => $maxAttempts,
'exception' => $e,
]);

usleep($attempt * self::RETRY_BASE_DELAY_MS * 1000);
}
}
}

/**
Expand Down
6 changes: 5 additions & 1 deletion src/Client/Builder.php
Original file line numberDiff line numberDiff line change
Expand Up@@ -96,7 +96,11 @@ public function setRequestTimeout(int $seconds): self
}

/**
* Set maximum retry attempts for failed connections.
* Set the number of times a failed connection attempt is retried.
*
* Counts retries, not attempts: 3 means one initial attempt plus up to three
* retries. Pass 0 to fail on the first failure. Only applies to
* {@see Client::connect()}; individual requests are never retried.
*/
public function setMaxRetries(int $retries): self
{
Expand Down
4 changes: 4 additions & 0 deletions src/Client/Configuration.php
Original file line numberDiff line numberDiff line change
Expand Up@@ -38,5 +38,9 @@ public function __construct(
if ($requestTimeout < 1) {
throw new InvalidArgumentException(\sprintf('The request timeout must be a positive number of seconds, got %d.', $requestTimeout));
}

if ($maxRetries < 0) {
throw new InvalidArgumentException(\sprintf('The maximum number of retries must be zero or greater, got %d.', $maxRetries));
}
}
}
31 changes: 19 additions & 12 deletions src/Client/Protocol.php
Original file line numberDiff line numberDiff line change
Expand Up@@ -179,22 +179,29 @@ public function request(Request $request, int $timeout, bool $withProgress = fal
}

$this->state->addPendingRequest($requestId, $timeout);
$this->sendRequest($request);

$immediate = $this->state->consumeResponse($requestId);
if (null !== $immediate) {
$this->logger->debug('Received immediate response', ['id' => $requestId]);
try {
$this->sendRequest($request);

return $immediate;
}
$immediate = $this->state->consumeResponse($requestId);
if (null !== $immediate) {
$this->logger->debug('Received immediate response', ['id' => $requestId]);

$this->logger->debug('Suspending fiber for response', ['id' => $requestId]);
return $immediate;
}

return \Fiber::suspend([
'type' => 'await_response',
'request_id' => $requestId,
'timeout' => $timeout,
]);
$this->logger->debug('Suspending fiber for response', ['id' => $requestId]);

return \Fiber::suspend([
'type' => 'await_response',
'request_id' => $requestId,
'timeout' => $timeout,
]);
} finally {
// Only the response path clears it, so a request that timed out or
// whose send() threw would stay pending and fail every later one.
$this->state->removePendingRequest($requestId);
}
}

/**
Expand Down
42 changes: 42 additions & 0 deletions tests/Integration/Fixture/request_timeout.php
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,42 @@
<?php

/*
* This file is part of the official PHP MCP SDK.
*
* A collaboration between Symfony and the PHP Foundation.
*
* For the full copyright and license information, please view the LICENSE
* file that was distributed with this source code.
*/

/*
* Server for {@see \Mcp\Tests\Integration\RequestTimeoutTest}.
*
* `slow` outlives the client's request timeout and then goes idle again, which
* is what lets the test call `fast` on a connection the client has already
* given up on once.
*/

use Mcp\Server;
use Mcp\Server\Transport\StdioTransport;

require_once dirname(__DIR__, 3).'/vendor/autoload.php';

Server::builder()
->setServerInfo('integration-server', '1.0.0')
->addTool(
static function (): string {
sleep(2);

return 'late';
},
name: 'slow',
description: 'Answers well after the client stopped waiting.',
)
->addTool(
static fn (): string => 'quick',
name: 'fast',
description: 'Returns at once.',
)
->build()
->run(new StdioTransport());
46 changes: 46 additions & 0 deletions tests/Integration/Fixture/retry.php
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,46 @@
<?php

/*
* This file is part of the official PHP MCP SDK.
*
* A collaboration between Symfony and the PHP Foundation.
*
* For the full copyright and license information, please view the LICENSE
* file that was distributed with this source code.
*/

/*
* Server for {@see \Mcp\Tests\Integration\RetryTest}.
*
* Dies before speaking a frame while the spawn counter is below the configured
* number of failures, so the counter file records how many processes the client
* actually started.
*/

use Mcp\Server;
use Mcp\Server\Transport\StdioTransport;

require_once dirname(__DIR__, 3).'/vendor/autoload.php';

$counter = getenv('MCP_SPAWN_COUNTER');

if (!is_string($counter) || '' === $counter) {
exit(1);
}

$spawns = 1 + (int) file_get_contents($counter);
file_put_contents($counter, (string) $spawns);

if ($spawns <= (int) getenv('MCP_FAIL_SPAWNS')) {
exit(1);
}

Server::builder()
->setServerInfo('integration-server', '1.0.0')
->addTool(
static fn (): string => 'quick',
name: 'fast',
description: 'Returns at once.',
)
->build()
->run(new StdioTransport());
34 changes: 25 additions & 9 deletions tests/Integration/IntegrationTestCase.php
Original file line numberDiff line numberDiff line change
Expand Up@@ -55,26 +55,42 @@ protected function clientBuilder(): ClientBuilder
*/
protected function connect(string $fixture, ?ClientBuilder $client = null, array $env = []): Client
{
$script = __DIR__.'/Fixture/'.$fixture.'.php';

$this->client = ($client ?? $this->clientBuilder())->build();

try {
$this->client->connect(new StdioTransport(
command: \PHP_BINARY,
args: [$script],
// proc_open() replaces the environment rather than adding to it.
env: [] === $env ? null : array_merge(getenv(), $env),
));
$this->client->connect($this->transport($fixture, $env));
} catch (ConnectionException $e) {
// The transport discards the child's stderr, so a fixture dying on
// startup arrives here as a bare timeout.
$this->fail(\sprintf('Could not connect to fixture server "%s": %s. Run `%s %s` to see why.', $fixture, $e->getMessage(), \PHP_BINARY, $script));
$this->fail(\sprintf('Could not connect to fixture server "%s": %s. Run `%s %s` to see why.', $fixture, $e->getMessage(), \PHP_BINARY, self::script($fixture)));
}

return $this->client;
}

/**
* A transport that will spawn a fixture server, without connecting it.
*
* Tests that assert on a failing connection need the transport by itself,
* since {@see self::connect()} turns that failure into a test failure.
*
* @param array<string, string> $env added to the server process environment
*/
protected function transport(string $fixture, array $env = []): StdioTransport
{
return new StdioTransport(
command: \PHP_BINARY,
args: [self::script($fixture)],
// proc_open() replaces the environment rather than adding to it.
env: [] === $env ? null : array_merge(getenv(), $env),
);
}

private static function script(string $fixture): string
{
return __DIR__.'/Fixture/'.$fixture.'.php';
}

protected function tearDown(): void
{
$this->client?->disconnect();
Expand Down
43 changes: 43 additions & 0 deletions tests/Integration/RequestTimeoutTest.php
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,43 @@
<?php

/*
* This file is part of the official PHP MCP SDK.
*
* A collaboration between Symfony and the PHP Foundation.
*
* For the full copyright and license information, please view the LICENSE
* file that was distributed with this source code.
*/

namespace Mcp\Tests\Integration;

use Mcp\Exception\RequestException;
use PHPUnit\Framework\Attributes\TestDox;

/**
* What a timed-out request leaves behind on the connection.
*
* @see Fixture/request_timeout.php for the server under test
*/
final class RequestTimeoutTest extends IntegrationTestCase
{
#[TestDox('an abandoned response is not handed to the next request')]
public function testTimedOutRequestDoesNotLeakIntoTheNext(): void
{
$client = $this->connect('request_timeout', $this->clientBuilder()->setRequestTimeout(1));

try {
$client->callTool('slow');
$this->fail('The slow tool should have outlived the request timeout.');
} catch (RequestException) {
}

// The server is still executing the abandoned call and cannot answer
// anything until it returns, so the next request has to wait it out.
sleep(2);

// Without the pending request being cleared this answers 'late': the
// response the client gave up on, handed to the request after it.
$this->assertSame('quick', $client->callTool('fast')->content[0]->text ?? null);
}
}
Loading