Skip to content

Use proper sync resolution in CI - #1325

Closed
Kludex wants to merge 2 commits into
mainfrom
fix-pipeline
Closed

Use proper sync resolution in CI#1325
Kludex wants to merge 2 commits into
mainfrom
fix-pipeline

Conversation

@Kludex

Copy link
Copy Markdown
Member

No description provided.

@Kludex
Kludex requested review from a team and dsp-antAugust 30, 2025 21:01
@KludexKludex mentioned this pull request Aug 30, 2025
4 tasks
@Kludex

Copy link
Copy Markdown
MemberAuthor

@maxisbey Do you have time to debug this?

@maxisbey

Copy link
Copy Markdown
Contributor

@maxisbey Do you have time to debug this?

Pretty sure it's because of this function here:

deftest_command_execution(mock_config_path: Path):

It runs a uv command built here:

uv_path=get_uv_path()

This is then run without uv --frozen and without whatever dependency resolution is being set by the changes you made in this PR. So the unit test times out since it's re-installing a bunch of dependencies due to the different dependency version resolution uv is using when launched inside the unit test.

@felixweinbergerfelixweinberger added the needs more work Not ready to be merged yet, needs additional follow-up from the author(s). label Sep 23, 2025
@felixweinberger

Copy link
Copy Markdown
Contributor

Will pick this up from @ihrpr

@felixweinbergerfelixweinberger added the needs maintainer Potentially serious issue - needs proactive fix and maintainer attention label Sep 23, 2025
@felixweinbergerfelixweinberger self-assigned this Sep 23, 2025
@felixweinbergerfelixweinberger added this to the CI & Testing milestone Sep 30, 2025
@felixweinbergerfelixweinberger removed their assignment Oct 10, 2025
@felixweinberger

Copy link
Copy Markdown
Contributor

Closing in favor of #1507

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs maintainerPotentially serious issue - needs proactive fix and maintainer attentionneeds more workNot ready to be merged yet, needs additional follow-up from the author(s).

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@Kludex@maxisbey@felixweinberger@dsp-ant