Skip to content

GitHub Actions: Test on Python 3.14 - #1346

Closed
cclauss wants to merge 1 commit into
modelcontextprotocol:mainfrom
cclauss:patch-2
Closed

GitHub Actions: Test on Python 3.14#1346
cclauss wants to merge 1 commit into
modelcontextprotocol:mainfrom
cclauss:patch-2

Conversation

@cclauss

@cclausscclauss commented Sep 5, 2025•
edited
Loading

Copy link
Copy Markdown
Contributor
- python-version: ["3.10", "3.11", "3.12", "3.13"]+ python-version: ["3.10", "3.11", "3.12", "3.13", "3.14", "3.14t"]

Python 3.14 (the π version)

Call to action
We strongly encourage maintainers of third-party Python projects to prepare their projects for 3.14 during this phase, and publish Python 3.14 wheels on PyPI to be ready for the final release of 3.14.0, and to help other projects do their own testing. Any binary wheels built against Python 3.14.0 release candidates will work with future versions of Python 3.14.

Motivation and Context

Let's ensure things work as expected on the next version of CPython as recommended by the Python Core Team.

How Has This Been Tested?

Breaking Changes

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update

Checklist

  • I have read the MCP Documentation
  • My code follows the repository's style guidelines
  • New and existing tests pass locally
  • I have added appropriate error handling
  • I have added or updated documentation as needed

Additional context

@cclauss
cclauss requested review from a team and felixweinbergerSeptember 5, 2025 14:12
@felixweinberger

felixweinberger commented Sep 5, 2025

Copy link
Copy Markdown
Contributor

Curious what other maintainers think about adding 3.14 already to our CI @Kludex@dsp-ant@ihrpr

Looks like 3.14 is currently pre-release with release slated for 7 Oct 2025 so relatively soon (https://devguide.python.org/versions/)

@Kludex

Kludex commented Sep 6, 2025

Copy link
Copy Markdown
Member

I mean, if you are able to make the pipeline pass, then sure...

@cclauss
cclaussforce-pushed the patch-2 branch 2 times, most recently from ad5ebde to e8229abCompareSeptember 6, 2025 13:49
@cclauss

cclauss commented Sep 6, 2025•
edited
Loading

Copy link
Copy Markdown
ContributorAuthor

Blocked by

@cclauss
cclaussforce-pushed the patch-2 branch 4 times, most recently from ff8d859 to 7e204c0CompareSeptember 6, 2025 14:18
@Kludex

Kludex commented Sep 6, 2025

Copy link
Copy Markdown
Member

We don't really need to build the docs in 3.14.

You can add a marker to not install on that version. python_version < '3.14' should work.

@cclauss

cclauss commented Sep 6, 2025

Copy link
Copy Markdown
ContributorAuthor

Sorry. I am out of my depth. uv --all-extras will ignore python_version markers and install everything.

@cclausscclauss closed this Sep 6, 2025
@cclauss
cclauss deleted the patch-2 branch September 6, 2025 14:56
@cclausscclauss mentioned this pull request Sep 6, 2025
Closed
@cclauss
cclauss restored the patch-2 branch September 8, 2025 07:04
@cclausscclauss reopened this Sep 8, 2025
@cclauss
cclaussforce-pushed the patch-2 branch 4 times, most recently from 058dd07 to 109909bCompareSeptember 8, 2025 07:35
@cclauss

cclauss commented Sep 8, 2025•
edited
Loading

Copy link
Copy Markdown
ContributorAuthor

mkdocs-material v9.6.19 was released, so we can force mkdocs-material[imaging] to use pillow v11.3 instead of v10.

Now the problem is pydantic --> pydantic-core --> pyo3.

Using the alpha release https://pypi.org/project/pydantic/2.12.0a1, we finally get the build to succeed.
However, the Pydantic differences now mean that 7 modelcontextprotocol/python-sdk pytests fail.

@cclauss
cclaussforce-pushed the patch-2 branch 2 times, most recently from 8179c10 to 9a66350CompareSeptember 8, 2025 07:47
Kludex
Kludex reviewed Sep 9, 2025
View reviewed changes
Comment thread.github/workflows/shared.yml
with:
enable-cache: true
version: 0.7.2

@KludexKludexSep 9, 2025

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please put this back.

@cclausscclaussSep 9, 2025•
edited
Loading

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/astral-sh/uv/releases/tag/0.8.11 Added Python 3.14rc2 and 0.8.12 speeds up zstandard performance.

@KludexKludexSep 18, 2025

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can change the version, but there's no need to remove it.

We actually need to set this version in the pyproject.toml.

Kludex
Kludex reviewed Sep 9, 2025
View reviewed changes
Comment threadpyproject.toml Outdated
@@ -25,7 +25,8 @@ dependencies = [
"anyio>=4.5",
"httpx>=0.27.1",
"httpx-sse>=0.4",
"pydantic>=2.11.0,<3.0.0",
"pydantic>=2.11.0,<3.0.0; python_version < '3.14'",

@KludexKludexSep 9, 2025

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing the classifier above.

@cclausscclaussSep 9, 2025

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

?

@KludexKludexSep 18, 2025•
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is missing on line 22.

 "Programming Language :: Python :: 3.14",

@cclausscclaussSep 18, 2025

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was not going to commit to supporting 3.14 until after we got the tests to pass, but here we go...

@cclauss
cclaussforce-pushed the patch-2 branch 4 times, most recently from 2ac61e5 to 9018463CompareSeptember 18, 2025 16:12
@felixweinbergerfelixweinberger added needs more work Not ready to be merged yet, needs additional follow-up from the author(s). needs sync labels Sep 23, 2025
@felixweinbergerfelixweinberger added this to the CI & Testing milestone Sep 30, 2025
@cclauss
cclaussforce-pushed the patch-2 branch 2 times, most recently from 3c4e0c1 to 3ebe806CompareOctober 4, 2025 20:36
@cclausscclauss changed the title GitHub Actions: Test on Python 3.14 release candidate 2GitHub Actions: Test on Python 3.14 release candidate 3Oct 4, 2025
@cclausscclauss changed the title GitHub Actions: Test on Python 3.14 release candidate 3GitHub Actions: Test on Python 3.14Oct 7, 2025
@felixweinberger

felixweinberger commented Oct 13, 2025

Copy link
Copy Markdown
Contributor

Marking this as a draft for now to remove from our review queue while the 3.14 tests are still failing - let us know if you need help on addressing the remaining failures?

@felixweinberger
felixweinberger marked this pull request as draft October 13, 2025 15:36
@cclauss
GitHub Actions: Test on Python 3.14 release candidate 2
74ab61a
```diff
- python-version: ["3.10", "3.11", "3.12", "3.13"]
+ python-version: ["3.10", "3.11", "3.12", "3.13", "3.14"]
```
https://www.python.org/download/pre-releaseshttps://www.python.org/downloads/release/python-3140rc2
@cclauss

cclauss commented Oct 13, 2025

Copy link
Copy Markdown
ContributorAuthor

Yes. Sorry, this will require someone who understands the Pydantic annotation changes in Python 3.14.

@cclausscclauss closed this Oct 13, 2025
@cclauss
cclauss deleted the patch-2 branch October 13, 2025 16:29
@cclausscclauss mentioned this pull request Oct 13, 2025
Merged
9 tasks
@Viicos

Viicos commented Oct 13, 2025

Copy link
Copy Markdown
Contributor

I'll handle the Pydantic 2.12 compatibility.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@KludexKludexKludex left review comments

Assignees

No one assigned

Labels

needs more workNot ready to be merged yet, needs additional follow-up from the author(s).

Projects

None yet

Milestone

CI & Testing

Development

Successfully merging this pull request may close these issues.

4 participants

@cclauss@felixweinberger@Kludex@Viicos