Skip to content

fix: add HTTP readiness check to wait_for_server and remove dead code in SSE tests#2073

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Kludex merged 2 commits into from
Feb 17, 2026
Merged

fix: add HTTP readiness check to wait_for_server and remove dead code in SSE tests #2073

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ad87cfa
fix: add HTTP readiness check to wait_for_server and remove dead code…
BabyChrist666 Feb 17, 2026
2342188
Revert wait_for_server HTTP check; also remove dead code in test_ws.py
BabyChrist666 Feb 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 0 additions & 11 deletions tests/shared/test_sse.py
View file
Open in desktop
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
import json
import multiprocessing
import socket
import time
from collections.abc import AsyncGenerator, Generator
from typing import Any
from unittest.mock import AsyncMock, MagicMock, Mock, patch
Expand DownExpand Up@@ -134,11 +133,6 @@ def run_server(server_port: int) -> None: # pragma: no cover
print(f"starting server on {server_port}")
server.run()

# Give server time to start
while not server.started:
print("waiting for server to start")
time.sleep(0.5)


@pytest.fixture()
def server(server_port: int) -> Generator[None, None, None]:
Expand DownExpand Up@@ -313,11 +307,6 @@ def run_mounted_server(server_port: int) -> None: # pragma: no cover
print(f"starting server on {server_port}")
server.run()

# Give server time to start
while not server.started:
print("waiting for server to start")
time.sleep(0.5)


@pytest.fixture()
def mounted_server(server_port: int) -> Generator[None, None, None]:
Expand Down
6 changes: 0 additions & 6 deletions tests/shared/test_ws.py
View file
Open in desktop
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
import multiprocessing
import socket
import time
from collections.abc import AsyncGenerator, Generator
from urllib.parse import urlparse

Expand DownExpand Up@@ -114,11 +113,6 @@ def run_server(server_port: int) -> None: # pragma: no cover
print(f"starting server on {server_port}")
server.run()

# Give server time to start
while not server.started:
print("waiting for server to start")
time.sleep(0.5)


@pytest.fixture()
def server(server_port: int) -> Generator[None, None, None]:
Expand Down