Uh oh!
There was an error while loading. Please reload this page.
fix: chain exceptions with 'from' in 4 missed raise sites - #2576
Closed
siddhirajkatkar wants to merge 1 commit into
Closed
fix: chain exceptions with 'from' in 4 missed raise sites#2576siddhirajkatkar wants to merge 1 commit into
siddhirajkatkar wants to merge 1 commit into
Conversation
Follow-up to modelcontextprotocol#2564 which fixed 12 sites. These 4 were missed: - resources/templates.py: add 'from e' to preserve exception chain - in_memory_task_store.py: add 'from None' (same type, better message) - prompts/base.py: add 'from None' and 'from e' to two raise sites
siddhirajkatkarforce-pushed
the
fix/exception-chain-missed-sites
branch
from
May 12, 2026 16:09
924efcf to
c8e7562Comparemaxisbey
commented
May 18, 2026
Contributor
siddhirajkatkar
commented
May 18, 2026
ContributorAuthor
"Happy to help with testing or review if needed." |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes#2575
Follow-up to #2564 which fixed 12 sites. These 4 were missed:
from efrom Nonefrom Nonefrom eWithout
from, Python shows "During handling of the above exception,another exception occurred" instead of "The above exception was the
direct cause". Callers cannot inspect
__cause__programmatically.