Uh oh!
There was an error while loading. Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork 3.8k
fix: preserve typed Context in resource and prompt handlers#3236
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
morluto
wants to merge
5
commits into
modelcontextprotocol:mainChoose a base branch
from
morluto:fix/template-resource-context
base:main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+127
−40
Open
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
823a081
Fix typed Context in resources and prompts
morluto 5029af5
Cover context injection fallback paths
morluto 543c733
Clarify context support for resource templates
morluto 34816ec
Strengthen typed context regression coverage
morluto 595c442
Simplify injected context validation
morluto File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Uh oh!
There was an error while loading. Please reload this page.
Jump to
Jump to file
Failed to load files.
Loading
Uh oh!
There was an error while loading. Please reload this page.
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
33 changes: 33 additions & 0 deletions
33 tests/server/mcpserver/resources/test_resource_template.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1197,9 +1197,9 @@ async def test_resource_with_context(self): | ||
| mcp = MCPServer() | ||
| @mcp.resource("resource://context/{name}") | ||
| def resource_with_context(name: str, ctx: Context) -> str: | ||
| async def resource_with_context(name: str, ctx: Context[None]) -> str: | ||
morluto marked this conversation as resolved.
Uh oh!There was an error while loading. Please reload this page. morluto marked this conversation as resolved.
Uh oh!There was an error while loading. Please reload this page. | ||
| """Resource that receives context.""" | ||
| assert ctx is not None | ||
| assert ctx.request_context is not None | ||
| return f"Resource {name} - context injected" | ||
| # Verify template has context_kwarg set | ||
| @@ -1280,9 +1280,9 @@ async def test_prompt_with_context(self): | ||
| mcp = MCPServer() | ||
| @mcp.prompt("prompt_with_ctx") | ||
| def prompt_with_context(text: str, ctx: Context) -> str: | ||
| def prompt_with_context(text: str, ctx: Context[None]) -> str: | ||
| """Prompt that expects context.""" | ||
| assert ctx is not None | ||
| assert ctx.request_context is not None | ||
| return f"Prompt '{text}' - context injected" | ||
| # Test via client | ||
| @@ -2324,6 +2324,11 @@ def test_context_mcp_server_outside_request_raises() -> None: | ||
| _ = Context().mcp_server | ||
| def test_context_request_context_outside_request_raises() -> None: | ||
| with pytest.raises(ValueError, match="outside of a request"): | ||
| _ = Context().request_context | ||
| async def test_context_notify_outside_a_request_raises() -> None: | ||
| with pytest.raises(ValueError, match="outside of a request"): | ||
| await Context().notify_tools_changed() | ||
Oops, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.