Uh oh!
There was an error while loading. Please reload this page.
perf: clean up SSE session writer - #518
Conversation
nadeemcite
commented
Apr 15, 2025
Can you check if this can solve #514 |
Kludex
left a comment
There was a problem hiding this comment.
I don't think this is the way to go. BackgroundTasks only works on 2xx responses, but also, this kind of logic is more suited as a middleware. Where do we create the session_id? We should probably drop it in the same place.
LeeEirc
commented
Apr 15, 2025
The SseServerTransport class contains a memory leak due to improper cleanup of the |
Uh oh!
There was an error while loading. Please reload this page.
lcamhoa
commented
Apr 25, 2025
@Kludex I make a PR for this one also #582 to clean up the memory writer when sse disconnect . SSE Disconnect event handler is new feature I request on sysid/sse-starlette#127 |
Prevents memory leaks from stream writer