Skip to content

Fix SSE client failing when server not running on root - #564

Closed
michaelpoluektov wants to merge 1 commit into
modelcontextprotocol:mainfrom
michaelpoluektov:fix-sse-client
Closed

Fix SSE client failing when server not running on root#564
michaelpoluektov wants to merge 1 commit into
modelcontextprotocol:mainfrom
michaelpoluektov:fix-sse-client

Conversation

@michaelpoluektov

@michaelpoluektovmichaelpoluektov commented Apr 22, 2025

Copy link
Copy Markdown

Fix#563

mcp-shadow[bot]
mcp-shadowBot reviewed May 13, 2025
View reviewed changes

@mcp-shadowmcp-shadowBot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The issue identified in PR #564 has already been resolved with a more comprehensive fix in PR #659 (merged on May 12, 2025). The solution is to handle path resolution on the server side using ASGI's built-in root_path mechanism, rather than implementing a client-side workaround.

@mcp-shadowmcp-shadowBot closed this May 13, 2025
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@mcp-shadowmcp-shadow[bot]mcp-shadow[bot] left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

sse_client fails if URL is not on the root path

1 participant

@michaelpoluektov