Skip to content

StreamableHttp -- resumability support for servers - #587

Merged
ihrpr merged 57 commits into
mainfrom
ihrpr/resumability-server
May 2, 2025
Merged

StreamableHttp -- resumability support for servers#587
ihrpr merged 57 commits into
mainfrom
ihrpr/resumability-server

Conversation

@ihrpr

@ihrprihrpr commented Apr 25, 2025•
edited
Loading

Copy link
Copy Markdown
Contributor

Adding support for resumability to servers.

As we already have Typescript client that support resumability, testing it with it and the follow up is to add support for resumability on typescript client.
###How to test:

Start Python example server:

uv run mcp-simple-streamablehttp --log-level DEBUG

In the new terminal start Typescript client

npx tsx src/examples/client/simpleStreamableHttp.ts

Follow steps:

  • type start-notifications 10 10
  • wait 20 seconds -
  • press esc and Enter
  • type connect
  • type start-notifications 10 10 - you'll see missing events were replayed and the tool continues to send notifications

stacked on top of #573

ihrpr added 30 commits April 21, 2025 09:36
@ihrpr
initial streamable http server
2b95598
@ihrpr
add request validation and tests
3d790f8
@ihrpr
session management
27bc01e
@ihrpr
terminations of a session
3c4cf10
@ihrpr
fix cleaning up
bce74b3
@ihrpr
add happy path test
2011579
@ihrpr
tests
2cebf08
@ihrpr
json mode
6c9c320
@ihrpr
clean up
ede8cde
@ihrpr
fix example server
2a3bed8
@ihrpr
return 405 for get stream
0456b1b
@ihrpr
speed up tests
97ca48d
@ihrpr
stateless implemetation
f738cbf
@ihrpr
format
92d4287
@ihrpr
uv lock
aa9f6e5
@ihrpr
Merge branch 'ihrpr/streamablehttp-server' into ihrpr/streamablehttp-…
2fba7f3
…stateless
@ihrpr
simplify readme
45723ea
@ihrpr
clean up
6b7a616
@ihrpr
get sse
b1be691
@ihrpr
uv lock
201ec99
@ihrpr
clean up
46ec72d
@ihrpr
Merge branch 'ihrpr/streamablehttp-server' into ihrpr/streamablehttp-…
1902abb
…stateless
@ihrpr
Merge branch 'ihrpr/streamablehttp-stateless' into ihrpr/get-sse
da1df74
@ihrpr
streamable http client
c2be5af
@ihrpr
add comments to server example where we use related_request_id
9b096dc
@ihrpr
Merge branch 'main' into ihrpr/streamablehttp-server
bbe79c2
@ihrpr
small fixes
a0a9c5b
@ihrpr
use mta field for related_request_id
a5ac2e0
@ihrpr
unrelated test and format
2e615f3
@ihrpr
clean up
110526d
dsp-ant
dsp-ant requested changes Apr 25, 2025
View reviewed changes
Comment threadexamples/servers/simple-streamablehttp/mcp_simple_streamablehttp/event_store.py Outdated
Comment threadexamples/servers/simple-streamablehttp/mcp_simple_streamablehttp/event_store.py Outdated
Comment threadexamples/servers/simple-streamablehttp/mcp_simple_streamablehttp/event_store.py Outdated
Comment threadsrc/mcp/server/streamableHttp.py Outdated
Comment threadsrc/mcp/server/streamableHttp.py Outdated
Comment threadsrc/mcp/server/streamableHttp.py Outdated
Comment threadsrc/mcp/server/streamableHttp.py Outdated
dsp-ant
dsp-ant reviewed Apr 25, 2025
View reviewed changes
Comment threadexamples/servers/simple-streamablehttp/mcp_simple_streamablehttp/event_store.py Outdated
Comment threadexamples/servers/simple-streamablehttp/mcp_simple_streamablehttp/event_store.py Outdated
Comment threadsrc/mcp/server/streamableHttp.py Outdated
Comment threadsrc/mcp/server/streamableHttp.py
Comment on lines +764 to +767
msg_writer, msg_reader = anyio.create_memory_object_stream[
tuple[JSONRPCMessage, str | None]
](0)
self._request_streams[stream_id] = msg_writer

@dsp-antdsp-antApr 25, 2025

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will this cause leaking streams and unclosed resources?

@ihrprihrprApr 25, 2025•
edited
Loading

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

have a separate PR to review all resources and close them: #604

@ihrpr
ihrpr requested a review from dsp-antApril 25, 2025 16:04
@ihrprihrpr mentioned this pull request Apr 27, 2025
Merged
@ihrprihrpr added this to the 2025-03-26 spec release milestone Apr 29, 2025
@ihrprihrpr mentioned this pull request Apr 30, 2025
Closed
dsp-ant
dsp-ant previously approved these changes May 2, 2025
View reviewed changes
Comment threadsrc/mcp/server/streamable_http.py Outdated
Comment on lines +551 to +554
last_event_id = request.headers.get(LAST_EVENT_ID_HEADER)
if last_event_id:
await self._replay_events(last_event_id, request, send)
return

@dsp-antdsp-antMay 2, 2025

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
last_event_id=request.headers.get(LAST_EVENT_ID_HEADER)
iflast_event_id:
awaitself._replay_events(last_event_id, request, send)
return
iflast_event_id:=request.headers.get(LAST_EVENT_ID_HEADER):
awaitself._replay_events(last_event_id, request, send)
return

Base automatically changed from ihrpr/client to mainMay 2, 2025 12:59
@ihrpr
ihrpr dismissed dsp-ant’s stale reviewMay 2, 2025 12:59

The base branch was changed.

@ihrpr
ihrpr merged commit 3978c6e into mainMay 2, 2025
@ihrpr
ihrpr deleted the ihrpr/resumability-server branch May 2, 2025 13:10
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dsp-antdsp-antdsp-ant left review comments
@jerome3o-anthropicjerome3o-anthropicAwaiting requested review from jerome3o-anthropic

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

2025-03-26 spec release

Development

Successfully merging this pull request may close these issues.

2 participants

@ihrpr@dsp-ant