Fix 307 Temporary Redirect when use streamable_http by chi2liu · Pull Request #781 · modelcontextprotocol/python-sdk

chi2liu · 2025-05-22T09:03:31Z

The default mount path of Streamable HTTP is /mcp, but in some environments, a 307 Temporary Redirect to /mcp/mcp/ will appear, causing the request to hang or fail. When the streamable_http path is set to /mcp/, everything works fine.

Code Analysis
Mount Path

In the server.py and simple-streamablehttp-stateless examples, the ASGI routes are Mount("/mcp", app=handle_streamable_http), that is, there is no trailing slash.
In the Settings class of server.py, the default value of streamable_http_path is "/mcp" (also without a slash).
Redirection Issue

Mount("/mcp", ...) route of Starlette/FastAPI, if /mcp is requested, will automatically 307 redirect to /mcp/ (with a slash).
But if the client requests /mcp/ and the server only mounts /mcp, a redirect chain of /mcp/mcp/ will appear in some environments, resulting in "unreachable".
This is related to the "strict slash matching" of ASGI routing.
Solution

Recommended practice: Always use /mcp/ as the mounting path (with a slash) and let the client request /mcp/, so there will be no redirection problem.
Or, when mounting /mcp, make sure the client only requests /mcp without a slash.

Motivation and Context

How Has This Been Tested?

Breaking Changes

Types of changes

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to change)
Documentation update

Checklist

I have read the MCP Documentation
My code follows the repository's style guidelines
New and existing tests pass locally
I have added appropriate error handling
I have added or updated documentation as needed

Additional context

chi2liu · 2025-05-22T09:04:47Z

#732

chi2liu · 2025-05-22T09:09:01Z

when we set the default /mcp, the log will be, in some env will

INFO: Started server process [55547]
INFO: Waiting for application startup.
INFO: Application startup complete.
INFO: Uvicorn running on http://0.0.0.0:8080 (Press CTRL+C to quit)
INFO: 10.183.170.230:53048 - "POST /mcp HTTP/1.1" 307 Temporary Redirect
INFO: 10.183.170.230:53054 - "POST /mcp/ HTTP/1.1" 200 OK
INFO: 10.183.170.230:53048 - "POST /mcp HTTP/1.1" 307 Temporary Redirect
INFO: 10.183.170.230:53054 - "POST /mcp/ HTTP/1.1" 202 Accepted
INFO: 10.183.170.230:53048 - "GET /mcp HTTP/1.1" 307 Temporary Redirect
INFO: 10.183.170.230:53054 - "GET /mcp/ HTTP/1.1" 200 OK
INFO: 10.183.170.230:34296 - "POST /mcp HTTP/1.1" 307 Temporary Redirect
INFO: 10.183.170.230:34312 - "POST /mcp/ HTTP/1.1" 200 OK

in some env will be hanging, because 307 Temporary Redirect to /byoa/mcp/mcp/, this is unreachable

INFO: Started server process [35]
INFO: Waiting for application startup.
INFO: Application startup complete.
INFO: Uvicorn running on http://0.0.0.0:8080 (Press CTRL+C to quit)
INFO: 100.67.31.17:58472 - "POST /mcp HTTP/1.1" 307 Temporary Redirect
INFO: 100.67.30.95:57600 - "GET /mcp HTTP/1.1" 307 Temporary Redirect

when we set the streamable_http to '/mcp/', it will be good, as the log:

[05/22/25 01:52:28] INFO Starting server "StatelessServer"... server.py:214
INFO: Started server process [80154]
INFO: Waiting for application startup.
INFO: Application startup complete.
INFO: Uvicorn running on http://0.0.0.0:8080 (Press CTRL+C to quit)
INFO: 10.183.170.230:36166 - "POST /mcp/ HTTP/1.1" 200 OK
INFO: 10.183.170.230:36166 - "POST /mcp/ HTTP/1.1" 202 Accepted
INFO: 10.183.170.230:36182 - "GET /mcp/ HTTP/1.1" 200 OK
INFO: 10.183.170.230:33648 - "POST /mcp/ HTTP/1.1" 200 OK

chi2liu · 2025-05-22T09:09:57Z

@simonw @sheffler @comfuture @shimizukawa

chi2liu · 2025-05-22T09:24:05Z

@ihrpr

ihrpr

Thanks for identifying and reporting this redirect issue! However, I don't think changing the default
streamable_http_path is the right approach here.

The core issue: This change creates inconsistency across the codebase rather than solving the root problem.

All client code constructs URLs with /mcp (no trailing slash) - see examples/clients/simple-auth-client/main.py:344
All example servers mount at /mcp (no trailing slash) - see both simple-streamablehttp examples
All tests use /mcp (no trailing slash) consistently - see tests/shared/test_streamable_http.py:238
Only FastMCP would have a different default with this change

Problems with this approach:

Breaking consistency: Makes FastMCP behave differently from all examples and existing usage patterns
Incomplete fix: The examples and tests still use /mcp without trailing slash, so the inconsistency remains
Wrong direction: The entire ecosystem already standardized on /mcp - we shouldn't change that

Alterative:

Keep the default as /mcp and fix the ASGI mounting logic to handle redirects properly
Add logic to FastMCP to handle both /mcp and /mcp/ transparently at the mount level
Document the trailing slash behavior so users can choose the approach that works for their environment

The redirect issue you've identified is real and needs fixing, but changing the default path creates more problems than
it solves. Let's find a solution that maintains consistency while addressing the underlying ASGI routing behavior.

chi2liu · 2025-05-26T03:13:16Z

Thanks for identifying and reporting this redirect issue! However, I don't think changing the default streamable_http_path is the right approach here.
The core issue: This change creates inconsistency across the codebase rather than solving the root problem.
All client code constructs URLs with /mcp (no trailing slash) - see examples/clients/simple-auth-client/main.py:344
All example servers mount at /mcp (no trailing slash) - see both simple-streamablehttp examples
All tests use /mcp (no trailing slash) consistently - see tests/shared/test_streamable_http.py:238
Only FastMCP would have a different default with this change
Problems with this approach:
Breaking consistency: Makes FastMCP behave differently from all examples and existing usage patterns
Incomplete fix: The examples and tests still use /mcp without trailing slash, so the inconsistency remains
Wrong direction: The entire ecosystem already standardized on /mcp - we shouldn't change that
Alterative:
Keep the default as /mcp and fix the ASGI mounting logic to handle redirects properly
Add logic to FastMCP to handle both /mcp and /mcp/ transparently at the mount level
Document the trailing slash behavior so users can choose the approach that works for their environment
The redirect issue you've identified is real and needs fixing, but changing the default path creates more problems than it solves. Let's find a solution that maintains consistency while addressing the underlying ASGI routing behavior.

Thank you for your review and helpful suggestions.
@ihrpr The following changes have been made to completely solve the trailing slash compatibility issue:

Keep the default path as /mcp to avoid disrupting the existing ecosystem.
In the ASGI route registration logic of FastMCP, automatically mount handlers for both /mcp and /mcp/, and clients can access them in any form without redirection.

In this way, whether the client, example, or test uses /mcp or /mcp/, it can be seamlessly compatible without modifying the existing code. The problem has been completely solved.

vectorstain

GG

vectorstain

GG

vectorstain

GG

vectorstain · 2025-05-27T18:20:20Z

@chi2liu please update the branch with master and check again tests results

ihrpr

Thank you!

Please can you add tests to verify all works as expected?

…iu/python-sdk into fix-307-Temporary-Redirect

chi2liu · 2025-05-29T02:54:36Z

Why are we even mounting applications? We can have a Router and set redirect_slashes to False.

I have modified it according to your suggestion. Could you please review it? @Kludex

Kludex · 2025-05-29T07:27:39Z


 starlette_app = self.streamable_http_app()
-
+ starlette_app.router.redirect_slashes = False


Hmmm... I think we can add redirect_slashes in the Starlette constructor on starlette's side.
But this part is fine.

@Kludex So do we need to add this parameter to starlette now?

Kludex · 2025-05-29T07:29:19Z

+ async def handle_streamable_http(request: Request) -> Response:
+ await self.session_manager.handle_request(
+ request.scope, request.receive, request._send
+ )
+ return Response()


This is not fine. Does handle_request needs to be an ASGI application?

@Kludex This could be a more suitable solution ? PR

Kludex · 2025-05-29T07:31:40Z

+ # Always register both /mcp and /mcp/ for full compatibility
+ _main_path = self.settings.streamable_http_path.removesuffix("/")
+ _alt_path = _main_path + "/"


I think the problem was the redirect, but if you have a 404 then it's not an issue anymore, and we shouldn't be needing this.

* Refactor FastMCP routing to use Router and streamline request handling * Add async support to token validation test and enhance metadata snapshot assertions * Fix tests * Fix tests --------- Co-authored-by: Vincenzo Maria Calandra <vincenzomariacalandra@MacBook-Pro-di-Vincenzo.local> Co-authored-by: 633WHU <cliu_whu@yeah.net>

chi2liu · 2025-05-30T08:39:07Z

Updated the latest code, please help review @Kludex @vectorstain @mroch @ihrpr

Kludex · 2025-05-30T08:45:47Z

You marked my comments as resolved, but you actually ignore them.

chi2liu · 2025-05-30T09:09:32Z

You marked my comments as resolved, but you actually ignore them.

Restored, please check one by one

vectorstain

GG, @Kludex, can you help review?

tampiss · 2025-06-09T14:55:28Z

🙏🏼

alenprodan · 2025-06-24T17:16:19Z

@chi2liu

Hi everyone!
Could you provide an update on when this fix might be merged and released?

I'm experiencing the 307 redirect issue described in this PR.

Thanks for your work on fixing this!

vectorstain · 2025-06-25T07:21:02Z

Hi @alenprodan, we are waiting for a feedback @ihrpr

ihrpr · 2025-07-11T10:51:35Z

Thank you for working on the fix! We merged #1115 and this PR (test from this PR) and merged #1115. Closing this PR.

Update streamable_http_path to /mcp/ to avoid 307 Temporary Redirect
0bf3521

chi2liu mentioned this pull request May 22, 2025
307 Temporary Redirect #732
Closed

Merge branch 'main' into fix-307-Temporary-Redirect
dd00227

ihrpr requested changes May 23, 2025
View reviewed changes

chi2liu added 7 commits May 26, 2025 10:58

Streamable HTTP Trailing Slash Compatibility
d89e737

Streamable HTTP Trailing Slash Compatibility
7d6e14f

Streamable HTTP Trailing Slash Compatibility
a84399b

Merge branch 'main' into fix-307-Temporary-Redirect
900c2dd

Streamable HTTP Trailing Slash Compatibility
1a638ad

Streamable HTTP Trailing Slash Compatibility
b3bf4c9

Streamable HTTP Trailing Slash Compatibility
645e1ab

vectorstain reviewed May 26, 2025
View reviewed changes

Merge branch 'main' into fix-307-Temporary-Redirect
3e9e33f

chi2liu requested review from ihrpr and vectorstain May 27, 2025 01:37

vectorstain reviewed May 27, 2025
View reviewed changes

Comment threadsrc/mcp/server/fastmcp/server.py Outdated

Clean logic (#3)
7ef5f8d

chi2liu requested a review from vectorstain May 27, 2025 09:09

vectorstain reviewed May 27, 2025
View reviewed changes

Merge branch 'main' into fix-307-Temporary-Redirect
303cac8

chi2liu requested a review from vectorstain May 27, 2025 19:34

ihrpr reviewed May 27, 2025
View reviewed changes

chi2liuand others added 2 commits May 28, 2025 09:17

Merge branch 'main' into fix-307-Temporary-Redirect
0d05075

add unit test for Streamable HTTP Trailing Slash Compatibility
898fc88

chiliu added 2 commits May 28, 2025 19:35

Merge branch 'fix-307-Temporary-Redirect' ofhttps://github.com/chi2l…
355c882
…iu/python-sdk into fix-307-Temporary-Redirect

fix typo
86da08d

chi2liu requested a review from ihrpr May 29, 2025 02:52

Kludex reviewed May 29, 2025
View reviewed changes

chiliuand others added 3 commits May 29, 2025 02:11

fix
3d86e61

Update server.py
cc9f3d9

Update test_server.py
cce6d2f

chi2liu requested a review from Kludex May 29, 2025 09:13

vectorstain reviewed May 29, 2025
View reviewed changes

Comment threadsrc/mcp/server/fastmcp/server.py Outdated

chi2liuand others added 2 commits May 29, 2025 22:18

Merge branch 'main' into fix-307-Temporary-Redirect
04c4bcf

chi2liu requested a review from vectorstain May 29, 2025 14:21

chi2liuand others added 3 commits May 29, 2025 22:21

Merge branch 'main' into fix-307-Temporary-Redirect
2761e8f

Update server.py
2aa0428

fix format
5841a55

vectorstain reviewed May 31, 2025
View reviewed changes

danbarr mentioned this pull request Jul 1, 2025
Add note about VS Code and FastMCP streamable HTTP stacklok/docs-website#33
Merged

ihrpr mentioned this pull request Jul 11, 2025
Update routing for streamable HTTP to avoid 307 redirect #1115
Merged
9 tasks

ihrpr closed this Jul 11, 2025


		starlette_app = self.streamable_http_app()

		starlette_app.router.redirect_slashes = False

Uh oh!

Conversation

chi2liu commented May 22, 2025• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Motivation and Context

How Has This Been Tested?

Breaking Changes

Types of changes

Checklist

Additional context

Uh oh!

chi2liu commented May 22, 2025

Uh oh!

chi2liu commented May 22, 2025

Uh oh!

chi2liu commented May 22, 2025

Uh oh!

chi2liu commented May 22, 2025

Uh oh!

ihrpr left a comment

Choose a reason for hiding this comment

Uh oh!

chi2liu commented May 26, 2025• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

vectorstain left a comment

Choose a reason for hiding this comment

Uh oh!

vectorstain left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

vectorstain left a comment

Choose a reason for hiding this comment

Uh oh!

vectorstain commented May 27, 2025

Uh oh!

ihrpr left a comment

Choose a reason for hiding this comment

Uh oh!

chi2liu commented May 29, 2025

Uh oh!

KludexMay 29, 2025• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

chi2liuMay 30, 2025

Choose a reason for hiding this comment

Uh oh!

KludexMay 29, 2025

Choose a reason for hiding this comment

Uh oh!

vectorstainMay 29, 2025• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

KludexMay 29, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

chi2liu commented May 30, 2025

Uh oh!

Kludex commented May 30, 2025

Uh oh!

chi2liu commented May 30, 2025

Uh oh!

vectorstain left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

tampiss commented Jun 9, 2025

Uh oh!

alenprodan commented Jun 24, 2025

Uh oh!

vectorstain commented Jun 25, 2025

Uh oh!

ihrpr commented Jul 11, 2025

Uh oh!

Reviewers

Assignees

chi2liu commented May 22, 2025•
edited
Loading

chi2liu commented May 26, 2025•
edited
Loading

KludexMay 29, 2025•
edited
Loading

vectorstainMay 29, 2025•
edited
Loading

vectorstain left a comment •
edited
Loading