Uh oh!
There was an error while loading. Please reload this page.
feat: add subscription listen streams (SEP-2575) - #1000
Merged
Conversation
DaleSeoforce-pushed
the
feat/sep-2575-subscriptions-listen
branch
from
July 17, 2026 00:48
57f0dad to
5a1ead3CompareDaleSeoforce-pushed
the
feat/sep-2575-subscriptions-listen
branch
from
July 17, 2026 13:56
5a1ead3 to
a10f1c2CompareDaleSeo
marked this pull request as ready for review
July 17, 2026 13:58
7 tasks
alexhancock
previously approved these changes
Jul 20, 2026
| .map(ServerResult::DiscoverResult), | ||
| ClientRequest::PingRequest(_request) => { | ||
| self.ping(context).await.map(ServerResult::empty) | ||
| if mrtr_supported { |
Contributor
There was a problem hiding this comment.
Should we consolidate helpers for this? It stands out to me that I did something slightly different for detecting (and now validating) legacy requests in #999
MemberAuthor
There was a problem hiding this comment.
@alexhancock Extracted uses_legacy_lifecycle and reused it in both tower.rs and server.rs.
DaleSeoforce-pushed
the
feat/sep-2575-subscriptions-listen
branch
3 times, most recently
from
July 20, 2026 19:18
9741293 to
ddd07a9CompareDaleSeoforce-pushed
the
feat/sep-2575-subscriptions-listen
branch
2 times, most recently
from
July 21, 2026 01:17
3a7c650 to
513c348CompareDaleSeoforce-pushed
the
feat/sep-2575-subscriptions-listen
branch
from
July 21, 2026 01:23
513c348 to
90d72a6Comparealexhancock
approved these changes
Jul 21, 2026
Uh oh!
There was an error while loading. Please reload this page.
This was referenced Jul 21, 2026
Closed
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation and Context
SEP-2575 replaces the old way of delivering notifications through
resources/subscribe,resources/unsubscribe, and standalone Streamable HTTP GET streams. It introduces a new transport-neutral request calledsubscriptions/listen. This update brings in typed models and high-level server/client APIs that ensure acknowledgment ordering, subscription ID tagging, opt-in filtering, concurrent stream isolation, cancellation, and smooth or abrupt termination for both stdio and Streamable HTTP.We still support legacy resource subscriptions, HTTP sessions, GET/DELETE, and resumable streams for older protocol versions.
How Has This Been Tested?
Add tests. The conformance suite passes
Breaking Changes
No existing stable-protocol behavior is removed. The legacy
subscribe()andunsubscribe()APIs are deprecated for the 2026 protocol revision but retain their existing wire behavior for older negotiated versions.Types of changes
Checklist