Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 25 additions & 2 deletions crates/rmcp/src/service.rs
Original file line numberDiff line numberDiff line change
Expand Up@@ -149,6 +149,15 @@ pub trait ServiceRole: std::fmt::Debug + Send + Sync + 'static + Copy + Clone {
) -> impl Future<Output = ()> + MaybeSendFuture {
async {}
}

#[doc(hidden)]
fn enforce_request_association(
_request: &Self::Req,
_peer_info: Option<&Self::PeerInfo>,
_in_request_handler_scope: bool,
) -> Result<(), ServiceError> {
Ok(())
}
}

pub(crate) fn uses_legacy_lifecycle(
Expand All@@ -159,6 +168,14 @@ pub(crate) fn uses_legacy_lifecycle(
&& protocol_version.is_none_or(|version| version < &ProtocolVersion::V_2026_07_28)
}

tokio::task_local! {
pub(crate) static ORIGINATING_REQUEST: RequestId;
}

pub(crate) fn in_request_handler_scope() -> bool {
ORIGINATING_REQUEST.try_with(|_| ()).is_ok()
}

pub type TxJsonRpcMessage<R> =
JsonRpcMessage<<R as ServiceRole>::Req, <R as ServiceRole>::Resp, <R as ServiceRole>::Not>;
pub type RxJsonRpcMessage<R> = JsonRpcMessage<
Expand DownExpand Up@@ -725,6 +742,11 @@ impl<R: ServiceRole> Peer<R> {
options: PeerRequestOptions,
subscription_sender: Option<SubscriptionChannel<R::PeerNot>>,
) -> Result<RequestHandle<R>, ServiceError> {
R::enforce_request_association(
&request,
self.peer_info().as_deref(),
in_request_handler_scope(),
)?;
let id = self.request_id_provider.next_request_id();
let progress_token = self.progress_token_provider.next_progress_token();
if let Some(metadata) = self.client_request_metadata.get() {
Expand DownExpand Up@@ -1398,9 +1420,10 @@ where
extensions,
};
let current_span = tracing::Span::current();
let handler_id = id.clone();
spawn_service_task(async move {
let result = service
.handle_request(request, context)
let result = ORIGINATING_REQUEST
.scope(handler_id, service.handle_request(request, context))
Comment on lines +1423 to +1426

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since Tokio task-local values are not inherited by tokio::spawn, a handler that spawns sampling work and awaits its JoinHandle before returning is rejected even though the parent client request is still in flight?

.await;
let response = match result {
Ok(result) => {
Expand Down
25 changes: 25 additions & 0 deletions crates/rmcp/src/service/server.rs
Original file line numberDiff line numberDiff line change
Expand Up@@ -49,6 +49,31 @@ impl ServiceRole for RoleServer {
_ => None,
}
}

fn enforce_request_association(
request: &Self::Req,
peer_info: Option<&Self::PeerInfo>,
in_request_handler_scope: bool,
) -> Result<(), ServiceError> {
let restricted = matches!(
request,
ServerRequest::CreateMessageRequest(_)
| ServerRequest::ListRootsRequest(_)
| ServerRequest::ElicitRequest(_)
);
if !restricted {
return Ok(());
}
let strict =
peer_info.is_some_and(|info| info.protocol_version >= ProtocolVersion::V_2026_07_28);
if strict && !in_request_handler_scope {

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Handshake-free services can enter serve_inner with peer_info == None and take the protocol version from each request's metadata

let(peer, peer_rx) = Peer::new(id_provider,None);
peer.require_request_metadata();
let context = RequestContext{
ct: ct.child_token(),
id: id.clone(),
meta: std::mem::take(request.get_meta_mut()),
extensions: std::mem::take(request.extensions_mut()),
peer: peer.clone(),
};
let response = match service.handle_request(request, context).await{
Ok(result) => ServerJsonRpcMessage::response(result, id),
Err(error) => ServerJsonRpcMessage::error(error,Some(id)),
};
transport.send(response).await.map_err(|error| {
ServerInitializeError::transport::<T>(error,"sending negotiated request response")
})?;
returnOk(serve_inner(service, transport, peer, peer_rx, ct));

Here that makes strict false even after the stateless lifecycle has been selected. How should an unassociated send be rejected on that supported path when no handshake-derived PeerInfo exists?

return Err(ServiceError::McpError(ErrorData::invalid_request(
"SEP-2260: server-to-client requests must be associated with an originating client request",
None,
)));
}
Ok(())
}
}

/// It represents the error that may occur when serving the server.
Expand Down
80 changes: 79 additions & 1 deletion crates/rmcp/src/task_manager.rs
Original file line numberDiff line numberDiff line change
Expand Up@@ -349,8 +349,11 @@ impl TaskManager {
let future = make_future(context);
let inner = self.inner.clone();
let id_for_task = task_id.clone();
let originating_request = crate::service::ORIGINATING_REQUEST
.try_with(|id| id.clone())
.ok();
let handle = tokio::spawn(async move {
let result = future.await;
let result = run_task_operation(originating_request, future).await;
Comment on lines +352 to +356

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TaskManager::spawn returns the task to the handler immediately, so this child future can con
tinue after the originating JSON-RPC response has closed. Re-establishing the task-local makes
a later direct sampling or elicitation pass the guard anyway.

let mut inner = inner.lock().expect("task manager lock poisoned");
if let Some(entry) = inner.tasks.get_mut(&id_for_task) {
if entry.terminal.is_none() {
Expand DownExpand Up@@ -538,6 +541,16 @@ fn unknown_task(task_id: &str) -> McpError {
McpError::invalid_params(format!("unknown task: {task_id}"), None)
}

async fn run_task_operation(
originating_request: Option<crate::model::RequestId>,
future: TaskFuture,
) -> Result<CallToolResult, TaskExit> {
match originating_request {
Some(id) => crate::service::ORIGINATING_REQUEST.scope(id, future).await,
None => future.await,
}
}

fn result_to_object(result: &CallToolResult) -> JsonObject {
match serde_json::to_value(result) {
Ok(serde_json::Value::Object(map)) => map,
Expand DownExpand Up@@ -917,4 +930,69 @@ mod tests {
}
panic!("task did not complete after input response");
}

#[tokio::test]
async fn task_operation_reestablishes_request_association_scope() {
use crate::{
model::RequestId,
service::{ORIGINATING_REQUEST, in_request_handler_scope},
};

let manager = TaskManager::new();
let observed = Arc::new(Mutex::new(None::<bool>));
let observed_in_task = observed.clone();

ORIGINATING_REQUEST
.scope(RequestId::Number(7), async {
manager.spawn(TaskOptions::default(), move |_ctx| {
let observed_in_task = observed_in_task.clone();
Box::pin(async move {
*observed_in_task.lock().unwrap() = Some(in_request_handler_scope());
Ok(ok_result("done"))
})
})
})
.await;

for _ in 0..100 {
tokio::time::sleep(std::time::Duration::from_millis(10)).await;
if let Some(scoped) = *observed.lock().unwrap() {
assert!(
scoped,
"task operation must run inside the originating request's association scope"
);
return;
}
}
panic!("task operation did not run");
}

#[tokio::test]
async fn task_operation_without_originating_request_is_unscoped() {
use crate::service::in_request_handler_scope;

let manager = TaskManager::new();
let observed = Arc::new(Mutex::new(None::<bool>));
let observed_in_task = observed.clone();

manager.spawn(TaskOptions::default(), move |_ctx| {
let observed_in_task = observed_in_task.clone();
Box::pin(async move {
*observed_in_task.lock().unwrap() = Some(in_request_handler_scope());
Ok(ok_result("done"))
})
});

for _ in 0..100 {
tokio::time::sleep(std::time::Duration::from_millis(10)).await;
if let Some(scoped) = *observed.lock().unwrap() {
assert!(
!scoped,
"task operation started without an originating request must remain unscoped"
);
return;
}
}
panic!("task operation did not run");
}
}
159 changes: 159 additions & 0 deletions crates/rmcp/tests/test_sep_2260_request_association.rs
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,159 @@
#![cfg(all(feature = "server", feature = "client", not(feature = "local")))]
#![allow(deprecated)]

use std::sync::{Arc, Mutex};

use rmcp::{
ClientHandler, RoleClient, RoleServer, ServerHandler, ServiceError, ServiceExt,
model::{
CallToolRequestParams, CallToolResponse, CallToolResult, ClientInfo, ContentBlock,
CreateMessageRequest, CreateMessageRequestParams, CreateMessageResult, ProtocolVersion,
SamplingMessage, ServerCapabilities, ServerInfo, ServerRequest,
},
service::RequestContext,
};
use tokio::sync::oneshot;

#[derive(Clone)]
struct SamplingServer {
outside: Arc<Mutex<Option<oneshot::Sender<Result<(), ServiceError>>>>>,
}

impl ServerHandler for SamplingServer {
fn get_info(&self) -> ServerInfo {
ServerInfo::new(ServerCapabilities::builder().enable_tools().build())
}

async fn call_tool(
&self,
request: CallToolRequestParams,
context: RequestContext<RoleServer>,
) -> Result<CallToolResponse, rmcp::ErrorData> {
let peer = context.peer.clone();
let slot = self.outside.clone();

let use_generic = request.name == "sample_generic";
tokio::spawn(async move {
let outside = if use_generic {
peer.send_request(ServerRequest::CreateMessageRequest(
CreateMessageRequest::new(CreateMessageRequestParams::new(
vec![SamplingMessage::user_text("standalone-generic")],
16,
)),
))
.await
.map(|_| ())
} else {
peer.create_message(CreateMessageRequestParams::new(
vec![SamplingMessage::user_text("standalone")],
16,
))
.await
.map(|_| ())
};
if let Some(tx) = slot.lock().unwrap().take() {
let _ = tx.send(outside);
}
});

let nested = context
.peer
.create_message(CreateMessageRequestParams::new(
vec![SamplingMessage::user_text("nested")],
16,
))
.await;
nested.map_err(|e| rmcp::ErrorData::internal_error(e.to_string(), None))?;
Ok(CallToolResult::success(vec![ContentBlock::text("ok")]).into())
}
}

#[derive(Clone)]
struct SamplingClient;

impl ClientHandler for SamplingClient {
async fn create_message(
&self,
_params: CreateMessageRequestParams,
_context: RequestContext<RoleClient>,
) -> Result<CreateMessageResult, rmcp::ErrorData> {
Ok(CreateMessageResult::new(
SamplingMessage::assistant_text("pong"),
"test-model".to_string(),
)
.with_stop_reason(CreateMessageResult::STOP_REASON_END_TURN))
}

fn get_info(&self) -> ClientInfo {
let mut info = ClientInfo::default();
info.protocol_version = ProtocolVersion::V_2026_07_28;
info
}
}

#[tokio::test]
async fn nested_sampling_allowed_standalone_rejected() -> anyhow::Result<()> {
let (server_transport, client_transport) = tokio::io::duplex(4096);
let (tx, rx) = oneshot::channel();
let server = SamplingServer {
outside: Arc::new(Mutex::new(Some(tx))),
};
let server_handle = tokio::spawn(async move {
let running = server.serve(server_transport).await?;
running.waiting().await?;
anyhow::Ok(())
});

let client = SamplingClient.serve(client_transport).await?;

let result = client
.peer()
.call_tool(CallToolRequestParams::new("sample"))
.await?;
assert_eq!(
result.content.first().unwrap().as_text().unwrap().text,
"ok"
);

let outside = rx.await?;
assert!(matches!(outside, Err(ServiceError::McpError(_))));

client.cancel().await?;
let _ = server_handle.await?;
Ok(())
}

#[tokio::test]
async fn generic_send_request_bypass_rejected() -> anyhow::Result<()> {
let (server_transport, client_transport) = tokio::io::duplex(4096);
let (tx, rx) = oneshot::channel();
let server = SamplingServer {
outside: Arc::new(Mutex::new(Some(tx))),
};
let server_handle = tokio::spawn(async move {
let running = server.serve(server_transport).await?;
running.waiting().await?;
anyhow::Ok(())
});

let client = SamplingClient.serve(client_transport).await?;

let result = client
.peer()
.call_tool(CallToolRequestParams::new("sample_generic"))
.await?;
assert_eq!(
result.content.first().unwrap().as_text().unwrap().text,
"ok"
);

let outside = rx.await?;
assert!(
matches!(outside, Err(ServiceError::McpError(_))),
"generic send_request must not bypass SEP-2260 enforcement"
);

client.cancel().await?;
let _ = server_handle.await?;
Ok(())
}
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 25 additions & 2 deletions crates/rmcp/src/service.rs
Original file line numberDiff line numberDiff line change
Expand Up@@ -149,6 +149,15 @@ pub trait ServiceRole: std::fmt::Debug + Send + Sync + 'static + Copy + Clone {
) -> impl Future<Output = ()> + MaybeSendFuture {
async {}
}

#[doc(hidden)]
fn enforce_request_association(
_request: &Self::Req,
_peer_info: Option<&Self::PeerInfo>,
_in_request_handler_scope: bool,
) -> Result<(), ServiceError> {
Ok(())
}
}

pub(crate) fn uses_legacy_lifecycle(
Expand All@@ -159,6 +168,14 @@ pub(crate) fn uses_legacy_lifecycle(
&& protocol_version.is_none_or(|version| version < &ProtocolVersion::V_2026_07_28)
}

tokio::task_local! {
pub(crate) static ORIGINATING_REQUEST: RequestId;
}

pub(crate) fn in_request_handler_scope() -> bool {
ORIGINATING_REQUEST.try_with(|_| ()).is_ok()
}

pub type TxJsonRpcMessage<R> =
JsonRpcMessage<<R as ServiceRole>::Req, <R as ServiceRole>::Resp, <R as ServiceRole>::Not>;
pub type RxJsonRpcMessage<R> = JsonRpcMessage<
Expand DownExpand Up@@ -725,6 +742,11 @@ impl<R: ServiceRole> Peer<R> {
options: PeerRequestOptions,
subscription_sender: Option<SubscriptionChannel<R::PeerNot>>,
) -> Result<RequestHandle<R>, ServiceError> {
R::enforce_request_association(
&request,
self.peer_info().as_deref(),
in_request_handler_scope(),
)?;
let id = self.request_id_provider.next_request_id();
let progress_token = self.progress_token_provider.next_progress_token();
if let Some(metadata) = self.client_request_metadata.get() {
Expand DownExpand Up@@ -1398,9 +1420,10 @@ where
extensions,
};
let current_span = tracing::Span::current();
let handler_id = id.clone();
spawn_service_task(async move {
let result = service
.handle_request(request, context)
let result = ORIGINATING_REQUEST
.scope(handler_id, service.handle_request(request, context))
Comment on lines +1423 to +1426

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since Tokio task-local values are not inherited by tokio::spawn, a handler that spawns sampling work and awaits its JoinHandle before returning is rejected even though the parent client request is still in flight?

.await;
let response = match result {
Ok(result) => {
Expand Down
25 changes: 25 additions & 0 deletions crates/rmcp/src/service/server.rs
Original file line numberDiff line numberDiff line change
Expand Up@@ -49,6 +49,31 @@ impl ServiceRole for RoleServer {
_ => None,
}
}

fn enforce_request_association(
request: &Self::Req,
peer_info: Option<&Self::PeerInfo>,
in_request_handler_scope: bool,
) -> Result<(), ServiceError> {
let restricted = matches!(
request,
ServerRequest::CreateMessageRequest(_)
| ServerRequest::ListRootsRequest(_)
| ServerRequest::ElicitRequest(_)
);
if !restricted {
return Ok(());
}
let strict =
peer_info.is_some_and(|info| info.protocol_version >= ProtocolVersion::V_2026_07_28);
if strict && !in_request_handler_scope {

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Handshake-free services can enter serve_inner with peer_info == None and take the protocol version from each request's metadata

let(peer, peer_rx) = Peer::new(id_provider,None);
peer.require_request_metadata();
let context = RequestContext{
ct: ct.child_token(),
id: id.clone(),
meta: std::mem::take(request.get_meta_mut()),
extensions: std::mem::take(request.extensions_mut()),
peer: peer.clone(),
};
let response = match service.handle_request(request, context).await{
Ok(result) => ServerJsonRpcMessage::response(result, id),
Err(error) => ServerJsonRpcMessage::error(error,Some(id)),
};
transport.send(response).await.map_err(|error| {
ServerInitializeError::transport::<T>(error,"sending negotiated request response")
})?;
returnOk(serve_inner(service, transport, peer, peer_rx, ct));

Here that makes strict false even after the stateless lifecycle has been selected. How should an unassociated send be rejected on that supported path when no handshake-derived PeerInfo exists?

return Err(ServiceError::McpError(ErrorData::invalid_request(
"SEP-2260: server-to-client requests must be associated with an originating client request",
None,
)));
}
Ok(())
}
}

/// It represents the error that may occur when serving the server.
Expand Down
80 changes: 79 additions & 1 deletion crates/rmcp/src/task_manager.rs
Original file line numberDiff line numberDiff line change
Expand Up@@ -349,8 +349,11 @@ impl TaskManager {
let future = make_future(context);
let inner = self.inner.clone();
let id_for_task = task_id.clone();
let originating_request = crate::service::ORIGINATING_REQUEST
.try_with(|id| id.clone())
.ok();
let handle = tokio::spawn(async move {
let result = future.await;
let result = run_task_operation(originating_request, future).await;
Comment on lines +352 to +356

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TaskManager::spawn returns the task to the handler immediately, so this child future can con
tinue after the originating JSON-RPC response has closed. Re-establishing the task-local makes
a later direct sampling or elicitation pass the guard anyway.

let mut inner = inner.lock().expect("task manager lock poisoned");
if let Some(entry) = inner.tasks.get_mut(&id_for_task) {
if entry.terminal.is_none() {
Expand DownExpand Up@@ -538,6 +541,16 @@ fn unknown_task(task_id: &str) -> McpError {
McpError::invalid_params(format!("unknown task: {task_id}"), None)
}

async fn run_task_operation(
originating_request: Option<crate::model::RequestId>,
future: TaskFuture,
) -> Result<CallToolResult, TaskExit> {
match originating_request {
Some(id) => crate::service::ORIGINATING_REQUEST.scope(id, future).await,
None => future.await,
}
}

fn result_to_object(result: &CallToolResult) -> JsonObject {
match serde_json::to_value(result) {
Ok(serde_json::Value::Object(map)) => map,
Expand DownExpand Up@@ -917,4 +930,69 @@ mod tests {
}
panic!("task did not complete after input response");
}

#[tokio::test]
async fn task_operation_reestablishes_request_association_scope() {
use crate::{
model::RequestId,
service::{ORIGINATING_REQUEST, in_request_handler_scope},
};

let manager = TaskManager::new();
let observed = Arc::new(Mutex::new(None::<bool>));
let observed_in_task = observed.clone();

ORIGINATING_REQUEST
.scope(RequestId::Number(7), async {
manager.spawn(TaskOptions::default(), move |_ctx| {
let observed_in_task = observed_in_task.clone();
Box::pin(async move {
*observed_in_task.lock().unwrap() = Some(in_request_handler_scope());
Ok(ok_result("done"))
})
})
})
.await;

for _ in 0..100 {
tokio::time::sleep(std::time::Duration::from_millis(10)).await;
if let Some(scoped) = *observed.lock().unwrap() {
assert!(
scoped,
"task operation must run inside the originating request's association scope"
);
return;
}
}
panic!("task operation did not run");
}

#[tokio::test]
async fn task_operation_without_originating_request_is_unscoped() {
use crate::service::in_request_handler_scope;

let manager = TaskManager::new();
let observed = Arc::new(Mutex::new(None::<bool>));
let observed_in_task = observed.clone();

manager.spawn(TaskOptions::default(), move |_ctx| {
let observed_in_task = observed_in_task.clone();
Box::pin(async move {
*observed_in_task.lock().unwrap() = Some(in_request_handler_scope());
Ok(ok_result("done"))
})
});

for _ in 0..100 {
tokio::time::sleep(std::time::Duration::from_millis(10)).await;
if let Some(scoped) = *observed.lock().unwrap() {
assert!(
!scoped,
"task operation started without an originating request must remain unscoped"
);
return;
}
}
panic!("task operation did not run");
}
}
159 changes: 159 additions & 0 deletions crates/rmcp/tests/test_sep_2260_request_association.rs
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,159 @@
#![cfg(all(feature = "server", feature = "client", not(feature = "local")))]
#![allow(deprecated)]

use std::sync::{Arc, Mutex};

use rmcp::{
ClientHandler, RoleClient, RoleServer, ServerHandler, ServiceError, ServiceExt,
model::{
CallToolRequestParams, CallToolResponse, CallToolResult, ClientInfo, ContentBlock,
CreateMessageRequest, CreateMessageRequestParams, CreateMessageResult, ProtocolVersion,
SamplingMessage, ServerCapabilities, ServerInfo, ServerRequest,
},
service::RequestContext,
};
use tokio::sync::oneshot;

#[derive(Clone)]
struct SamplingServer {
outside: Arc<Mutex<Option<oneshot::Sender<Result<(), ServiceError>>>>>,
}

impl ServerHandler for SamplingServer {
fn get_info(&self) -> ServerInfo {
ServerInfo::new(ServerCapabilities::builder().enable_tools().build())
}

async fn call_tool(
&self,
request: CallToolRequestParams,
context: RequestContext<RoleServer>,
) -> Result<CallToolResponse, rmcp::ErrorData> {
let peer = context.peer.clone();
let slot = self.outside.clone();

let use_generic = request.name == "sample_generic";
tokio::spawn(async move {
let outside = if use_generic {
peer.send_request(ServerRequest::CreateMessageRequest(
CreateMessageRequest::new(CreateMessageRequestParams::new(
vec![SamplingMessage::user_text("standalone-generic")],
16,
)),
))
.await
.map(|_| ())
} else {
peer.create_message(CreateMessageRequestParams::new(
vec![SamplingMessage::user_text("standalone")],
16,
))
.await
.map(|_| ())
};
if let Some(tx) = slot.lock().unwrap().take() {
let _ = tx.send(outside);
}
});

let nested = context
.peer
.create_message(CreateMessageRequestParams::new(
vec![SamplingMessage::user_text("nested")],
16,
))
.await;
nested.map_err(|e| rmcp::ErrorData::internal_error(e.to_string(), None))?;
Ok(CallToolResult::success(vec![ContentBlock::text("ok")]).into())
}
}

#[derive(Clone)]
struct SamplingClient;

impl ClientHandler for SamplingClient {
async fn create_message(
&self,
_params: CreateMessageRequestParams,
_context: RequestContext<RoleClient>,
) -> Result<CreateMessageResult, rmcp::ErrorData> {
Ok(CreateMessageResult::new(
SamplingMessage::assistant_text("pong"),
"test-model".to_string(),
)
.with_stop_reason(CreateMessageResult::STOP_REASON_END_TURN))
}

fn get_info(&self) -> ClientInfo {
let mut info = ClientInfo::default();
info.protocol_version = ProtocolVersion::V_2026_07_28;
info
}
}

#[tokio::test]
async fn nested_sampling_allowed_standalone_rejected() -> anyhow::Result<()> {
let (server_transport, client_transport) = tokio::io::duplex(4096);
let (tx, rx) = oneshot::channel();
let server = SamplingServer {
outside: Arc::new(Mutex::new(Some(tx))),
};
let server_handle = tokio::spawn(async move {
let running = server.serve(server_transport).await?;
running.waiting().await?;
anyhow::Ok(())
});

let client = SamplingClient.serve(client_transport).await?;

let result = client
.peer()
.call_tool(CallToolRequestParams::new("sample"))
.await?;
assert_eq!(
result.content.first().unwrap().as_text().unwrap().text,
"ok"
);

let outside = rx.await?;
assert!(matches!(outside, Err(ServiceError::McpError(_))));

client.cancel().await?;
let _ = server_handle.await?;
Ok(())
}

#[tokio::test]
async fn generic_send_request_bypass_rejected() -> anyhow::Result<()> {
let (server_transport, client_transport) = tokio::io::duplex(4096);
let (tx, rx) = oneshot::channel();
let server = SamplingServer {
outside: Arc::new(Mutex::new(Some(tx))),
};
let server_handle = tokio::spawn(async move {
let running = server.serve(server_transport).await?;
running.waiting().await?;
anyhow::Ok(())
});

let client = SamplingClient.serve(client_transport).await?;

let result = client
.peer()
.call_tool(CallToolRequestParams::new("sample_generic"))
.await?;
assert_eq!(
result.content.first().unwrap().as_text().unwrap().text,
"ok"
);

let outside = rx.await?;
assert!(
matches!(outside, Err(ServiceError::McpError(_))),
"generic send_request must not bypass SEP-2260 enforcement"
);

client.cancel().await?;
let _ = server_handle.await?;
Ok(())
}
, 'i'); if (__m === '*' || __re.test(location.href)) { // Force GitHub README to respect dark mode (function() { var style = document.createElement('style'); style.textContent = ' .markdown-body { color-scheme: dark light; } .markdown-body pre { background: #161b22 !important; } .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; } .markdown-body table th, .markdown-body table td { border-color: #30363d !important; } .markdown-body img { background: #0d1117; } .markdown-body blockquote { border-left-color: #8b949e; } .markdown-body hr { border-color: #30363d; } '; document.head.appendChild(style); })(); } } catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 25 additions & 2 deletions crates/rmcp/src/service.rs
Original file line numberDiff line numberDiff line change
Expand Up@@ -149,6 +149,15 @@ pub trait ServiceRole: std::fmt::Debug + Send + Sync + 'static + Copy + Clone {
) -> impl Future<Output = ()> + MaybeSendFuture {
async {}
}

#[doc(hidden)]
fn enforce_request_association(
_request: &Self::Req,
_peer_info: Option<&Self::PeerInfo>,
_in_request_handler_scope: bool,
) -> Result<(), ServiceError> {
Ok(())
}
}

pub(crate) fn uses_legacy_lifecycle(
Expand All@@ -159,6 +168,14 @@ pub(crate) fn uses_legacy_lifecycle(
&& protocol_version.is_none_or(|version| version < &ProtocolVersion::V_2026_07_28)
}

tokio::task_local! {
pub(crate) static ORIGINATING_REQUEST: RequestId;
}

pub(crate) fn in_request_handler_scope() -> bool {
ORIGINATING_REQUEST.try_with(|_| ()).is_ok()
}

pub type TxJsonRpcMessage<R> =
JsonRpcMessage<<R as ServiceRole>::Req, <R as ServiceRole>::Resp, <R as ServiceRole>::Not>;
pub type RxJsonRpcMessage<R> = JsonRpcMessage<
Expand DownExpand Up@@ -725,6 +742,11 @@ impl<R: ServiceRole> Peer<R> {
options: PeerRequestOptions,
subscription_sender: Option<SubscriptionChannel<R::PeerNot>>,
) -> Result<RequestHandle<R>, ServiceError> {
R::enforce_request_association(
&request,
self.peer_info().as_deref(),
in_request_handler_scope(),
)?;
let id = self.request_id_provider.next_request_id();
let progress_token = self.progress_token_provider.next_progress_token();
if let Some(metadata) = self.client_request_metadata.get() {
Expand DownExpand Up@@ -1398,9 +1420,10 @@ where
extensions,
};
let current_span = tracing::Span::current();
let handler_id = id.clone();
spawn_service_task(async move {
let result = service
.handle_request(request, context)
let result = ORIGINATING_REQUEST
.scope(handler_id, service.handle_request(request, context))
Comment on lines +1423 to +1426

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since Tokio task-local values are not inherited by tokio::spawn, a handler that spawns sampling work and awaits its JoinHandle before returning is rejected even though the parent client request is still in flight?

.await;
let response = match result {
Ok(result) => {
Expand Down
25 changes: 25 additions & 0 deletions crates/rmcp/src/service/server.rs
Original file line numberDiff line numberDiff line change
Expand Up@@ -49,6 +49,31 @@ impl ServiceRole for RoleServer {
_ => None,
}
}

fn enforce_request_association(
request: &Self::Req,
peer_info: Option<&Self::PeerInfo>,
in_request_handler_scope: bool,
) -> Result<(), ServiceError> {
let restricted = matches!(
request,
ServerRequest::CreateMessageRequest(_)
| ServerRequest::ListRootsRequest(_)
| ServerRequest::ElicitRequest(_)
);
if !restricted {
return Ok(());
}
let strict =
peer_info.is_some_and(|info| info.protocol_version >= ProtocolVersion::V_2026_07_28);
if strict && !in_request_handler_scope {

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Handshake-free services can enter serve_inner with peer_info == None and take the protocol version from each request's metadata

let(peer, peer_rx) = Peer::new(id_provider,None);
peer.require_request_metadata();
let context = RequestContext{
ct: ct.child_token(),
id: id.clone(),
meta: std::mem::take(request.get_meta_mut()),
extensions: std::mem::take(request.extensions_mut()),
peer: peer.clone(),
};
let response = match service.handle_request(request, context).await{
Ok(result) => ServerJsonRpcMessage::response(result, id),
Err(error) => ServerJsonRpcMessage::error(error,Some(id)),
};
transport.send(response).await.map_err(|error| {
ServerInitializeError::transport::<T>(error,"sending negotiated request response")
})?;
returnOk(serve_inner(service, transport, peer, peer_rx, ct));

Here that makes strict false even after the stateless lifecycle has been selected. How should an unassociated send be rejected on that supported path when no handshake-derived PeerInfo exists?

return Err(ServiceError::McpError(ErrorData::invalid_request(
"SEP-2260: server-to-client requests must be associated with an originating client request",
None,
)));
}
Ok(())
}
}

/// It represents the error that may occur when serving the server.
Expand Down
80 changes: 79 additions & 1 deletion crates/rmcp/src/task_manager.rs
Original file line numberDiff line numberDiff line change
Expand Up@@ -349,8 +349,11 @@ impl TaskManager {
let future = make_future(context);
let inner = self.inner.clone();
let id_for_task = task_id.clone();
let originating_request = crate::service::ORIGINATING_REQUEST
.try_with(|id| id.clone())
.ok();
let handle = tokio::spawn(async move {
let result = future.await;
let result = run_task_operation(originating_request, future).await;
Comment on lines +352 to +356

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TaskManager::spawn returns the task to the handler immediately, so this child future can con
tinue after the originating JSON-RPC response has closed. Re-establishing the task-local makes
a later direct sampling or elicitation pass the guard anyway.

let mut inner = inner.lock().expect("task manager lock poisoned");
if let Some(entry) = inner.tasks.get_mut(&id_for_task) {
if entry.terminal.is_none() {
Expand DownExpand Up@@ -538,6 +541,16 @@ fn unknown_task(task_id: &str) -> McpError {
McpError::invalid_params(format!("unknown task: {task_id}"), None)
}

async fn run_task_operation(
originating_request: Option<crate::model::RequestId>,
future: TaskFuture,
) -> Result<CallToolResult, TaskExit> {
match originating_request {
Some(id) => crate::service::ORIGINATING_REQUEST.scope(id, future).await,
None => future.await,
}
}

fn result_to_object(result: &CallToolResult) -> JsonObject {
match serde_json::to_value(result) {
Ok(serde_json::Value::Object(map)) => map,
Expand DownExpand Up@@ -917,4 +930,69 @@ mod tests {
}
panic!("task did not complete after input response");
}

#[tokio::test]
async fn task_operation_reestablishes_request_association_scope() {
use crate::{
model::RequestId,
service::{ORIGINATING_REQUEST, in_request_handler_scope},
};

let manager = TaskManager::new();
let observed = Arc::new(Mutex::new(None::<bool>));
let observed_in_task = observed.clone();

ORIGINATING_REQUEST
.scope(RequestId::Number(7), async {
manager.spawn(TaskOptions::default(), move |_ctx| {
let observed_in_task = observed_in_task.clone();
Box::pin(async move {
*observed_in_task.lock().unwrap() = Some(in_request_handler_scope());
Ok(ok_result("done"))
})
})
})
.await;

for _ in 0..100 {
tokio::time::sleep(std::time::Duration::from_millis(10)).await;
if let Some(scoped) = *observed.lock().unwrap() {
assert!(
scoped,
"task operation must run inside the originating request's association scope"
);
return;
}
}
panic!("task operation did not run");
}

#[tokio::test]
async fn task_operation_without_originating_request_is_unscoped() {
use crate::service::in_request_handler_scope;

let manager = TaskManager::new();
let observed = Arc::new(Mutex::new(None::<bool>));
let observed_in_task = observed.clone();

manager.spawn(TaskOptions::default(), move |_ctx| {
let observed_in_task = observed_in_task.clone();
Box::pin(async move {
*observed_in_task.lock().unwrap() = Some(in_request_handler_scope());
Ok(ok_result("done"))
})
});

for _ in 0..100 {
tokio::time::sleep(std::time::Duration::from_millis(10)).await;
if let Some(scoped) = *observed.lock().unwrap() {
assert!(
!scoped,
"task operation started without an originating request must remain unscoped"
);
return;
}
}
panic!("task operation did not run");
}
}
159 changes: 159 additions & 0 deletions crates/rmcp/tests/test_sep_2260_request_association.rs
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,159 @@
#![cfg(all(feature = "server", feature = "client", not(feature = "local")))]
#![allow(deprecated)]

use std::sync::{Arc, Mutex};

use rmcp::{
ClientHandler, RoleClient, RoleServer, ServerHandler, ServiceError, ServiceExt,
model::{
CallToolRequestParams, CallToolResponse, CallToolResult, ClientInfo, ContentBlock,
CreateMessageRequest, CreateMessageRequestParams, CreateMessageResult, ProtocolVersion,
SamplingMessage, ServerCapabilities, ServerInfo, ServerRequest,
},
service::RequestContext,
};
use tokio::sync::oneshot;

#[derive(Clone)]
struct SamplingServer {
outside: Arc<Mutex<Option<oneshot::Sender<Result<(), ServiceError>>>>>,
}

impl ServerHandler for SamplingServer {
fn get_info(&self) -> ServerInfo {
ServerInfo::new(ServerCapabilities::builder().enable_tools().build())
}

async fn call_tool(
&self,
request: CallToolRequestParams,
context: RequestContext<RoleServer>,
) -> Result<CallToolResponse, rmcp::ErrorData> {
let peer = context.peer.clone();
let slot = self.outside.clone();

let use_generic = request.name == "sample_generic";
tokio::spawn(async move {
let outside = if use_generic {
peer.send_request(ServerRequest::CreateMessageRequest(
CreateMessageRequest::new(CreateMessageRequestParams::new(
vec![SamplingMessage::user_text("standalone-generic")],
16,
)),
))
.await
.map(|_| ())
} else {
peer.create_message(CreateMessageRequestParams::new(
vec![SamplingMessage::user_text("standalone")],
16,
))
.await
.map(|_| ())
};
if let Some(tx) = slot.lock().unwrap().take() {
let _ = tx.send(outside);
}
});

let nested = context
.peer
.create_message(CreateMessageRequestParams::new(
vec![SamplingMessage::user_text("nested")],
16,
))
.await;
nested.map_err(|e| rmcp::ErrorData::internal_error(e.to_string(), None))?;
Ok(CallToolResult::success(vec![ContentBlock::text("ok")]).into())
}
}

#[derive(Clone)]
struct SamplingClient;

impl ClientHandler for SamplingClient {
async fn create_message(
&self,
_params: CreateMessageRequestParams,
_context: RequestContext<RoleClient>,
) -> Result<CreateMessageResult, rmcp::ErrorData> {
Ok(CreateMessageResult::new(
SamplingMessage::assistant_text("pong"),
"test-model".to_string(),
)
.with_stop_reason(CreateMessageResult::STOP_REASON_END_TURN))
}

fn get_info(&self) -> ClientInfo {
let mut info = ClientInfo::default();
info.protocol_version = ProtocolVersion::V_2026_07_28;
info
}
}

#[tokio::test]
async fn nested_sampling_allowed_standalone_rejected() -> anyhow::Result<()> {
let (server_transport, client_transport) = tokio::io::duplex(4096);
let (tx, rx) = oneshot::channel();
let server = SamplingServer {
outside: Arc::new(Mutex::new(Some(tx))),
};
let server_handle = tokio::spawn(async move {
let running = server.serve(server_transport).await?;
running.waiting().await?;
anyhow::Ok(())
});

let client = SamplingClient.serve(client_transport).await?;

let result = client
.peer()
.call_tool(CallToolRequestParams::new("sample"))
.await?;
assert_eq!(
result.content.first().unwrap().as_text().unwrap().text,
"ok"
);

let outside = rx.await?;
assert!(matches!(outside, Err(ServiceError::McpError(_))));

client.cancel().await?;
let _ = server_handle.await?;
Ok(())
}

#[tokio::test]
async fn generic_send_request_bypass_rejected() -> anyhow::Result<()> {
let (server_transport, client_transport) = tokio::io::duplex(4096);
let (tx, rx) = oneshot::channel();
let server = SamplingServer {
outside: Arc::new(Mutex::new(Some(tx))),
};
let server_handle = tokio::spawn(async move {
let running = server.serve(server_transport).await?;
running.waiting().await?;
anyhow::Ok(())
});

let client = SamplingClient.serve(client_transport).await?;

let result = client
.peer()
.call_tool(CallToolRequestParams::new("sample_generic"))
.await?;
assert_eq!(
result.content.first().unwrap().as_text().unwrap().text,
"ok"
);

let outside = rx.await?;
assert!(
matches!(outside, Err(ServiceError::McpError(_))),
"generic send_request must not bypass SEP-2260 enforcement"
);

client.cancel().await?;
let _ = server_handle.await?;
Ok(())
}
, 'i'); if (__m === '*' || __re.test(location.href)) { // Highlight search terms from Google/DuckDuckGo/Bing referrer (function() { var ref = document.referrer; var terms = []; if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) { var url = new URL(ref); var q = url.searchParams.get('q') || url.searchParams.get('p'); if (q) { terms = q.split(/\s+/).filter(function(t) { return t.length > 2; }); } } if (terms.length === 0) return; var style = document.createElement('style'); style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }'; document.head.appendChild(style); function highlight(node) { if (node.nodeType === 3) { // text node var text = node.textContent; var found = false; terms.forEach(function(term) { var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi'); if (regex.test(text)) { found = true; var frag = document.createDocumentFragment(); var parts = text.split(regex); parts.forEach(function(part, i) { if (i % 2 === 0) { frag.appendChild(document.createTextNode(part)); } else { var span = document.createElement('span'); span.className = 'userscript-highlight'; span.textContent = part; frag.appendChild(span); } }); node.parentNode.replaceChild(frag, node); } }); } else if (node.nodeType === 1 && node.childNodes) { // element var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT']; if (!skipTags.includes(node.tagName)) { Array.from(node.childNodes).forEach(highlight); } } } highlight(document.body); // Re-highlight on dynamic content var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1 || node.nodeType === 3) highlight(node); }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 25 additions & 2 deletions crates/rmcp/src/service.rs
Original file line numberDiff line numberDiff line change
Expand Up@@ -149,6 +149,15 @@ pub trait ServiceRole: std::fmt::Debug + Send + Sync + 'static + Copy + Clone {
) -> impl Future<Output = ()> + MaybeSendFuture {
async {}
}

#[doc(hidden)]
fn enforce_request_association(
_request: &Self::Req,
_peer_info: Option<&Self::PeerInfo>,
_in_request_handler_scope: bool,
) -> Result<(), ServiceError> {
Ok(())
}
}

pub(crate) fn uses_legacy_lifecycle(
Expand All@@ -159,6 +168,14 @@ pub(crate) fn uses_legacy_lifecycle(
&& protocol_version.is_none_or(|version| version < &ProtocolVersion::V_2026_07_28)
}

tokio::task_local! {
pub(crate) static ORIGINATING_REQUEST: RequestId;
}

pub(crate) fn in_request_handler_scope() -> bool {
ORIGINATING_REQUEST.try_with(|_| ()).is_ok()
}

pub type TxJsonRpcMessage<R> =
JsonRpcMessage<<R as ServiceRole>::Req, <R as ServiceRole>::Resp, <R as ServiceRole>::Not>;
pub type RxJsonRpcMessage<R> = JsonRpcMessage<
Expand DownExpand Up@@ -725,6 +742,11 @@ impl<R: ServiceRole> Peer<R> {
options: PeerRequestOptions,
subscription_sender: Option<SubscriptionChannel<R::PeerNot>>,
) -> Result<RequestHandle<R>, ServiceError> {
R::enforce_request_association(
&request,
self.peer_info().as_deref(),
in_request_handler_scope(),
)?;
let id = self.request_id_provider.next_request_id();
let progress_token = self.progress_token_provider.next_progress_token();
if let Some(metadata) = self.client_request_metadata.get() {
Expand DownExpand Up@@ -1398,9 +1420,10 @@ where
extensions,
};
let current_span = tracing::Span::current();
let handler_id = id.clone();
spawn_service_task(async move {
let result = service
.handle_request(request, context)
let result = ORIGINATING_REQUEST
.scope(handler_id, service.handle_request(request, context))
Comment on lines +1423 to +1426

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since Tokio task-local values are not inherited by tokio::spawn, a handler that spawns sampling work and awaits its JoinHandle before returning is rejected even though the parent client request is still in flight?

.await;
let response = match result {
Ok(result) => {
Expand Down
25 changes: 25 additions & 0 deletions crates/rmcp/src/service/server.rs
Original file line numberDiff line numberDiff line change
Expand Up@@ -49,6 +49,31 @@ impl ServiceRole for RoleServer {
_ => None,
}
}

fn enforce_request_association(
request: &Self::Req,
peer_info: Option<&Self::PeerInfo>,
in_request_handler_scope: bool,
) -> Result<(), ServiceError> {
let restricted = matches!(
request,
ServerRequest::CreateMessageRequest(_)
| ServerRequest::ListRootsRequest(_)
| ServerRequest::ElicitRequest(_)
);
if !restricted {
return Ok(());
}
let strict =
peer_info.is_some_and(|info| info.protocol_version >= ProtocolVersion::V_2026_07_28);
if strict && !in_request_handler_scope {

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Handshake-free services can enter serve_inner with peer_info == None and take the protocol version from each request's metadata

let(peer, peer_rx) = Peer::new(id_provider,None);
peer.require_request_metadata();
let context = RequestContext{
ct: ct.child_token(),
id: id.clone(),
meta: std::mem::take(request.get_meta_mut()),
extensions: std::mem::take(request.extensions_mut()),
peer: peer.clone(),
};
let response = match service.handle_request(request, context).await{
Ok(result) => ServerJsonRpcMessage::response(result, id),
Err(error) => ServerJsonRpcMessage::error(error,Some(id)),
};
transport.send(response).await.map_err(|error| {
ServerInitializeError::transport::<T>(error,"sending negotiated request response")
})?;
returnOk(serve_inner(service, transport, peer, peer_rx, ct));

Here that makes strict false even after the stateless lifecycle has been selected. How should an unassociated send be rejected on that supported path when no handshake-derived PeerInfo exists?

return Err(ServiceError::McpError(ErrorData::invalid_request(
"SEP-2260: server-to-client requests must be associated with an originating client request",
None,
)));
}
Ok(())
}
}

/// It represents the error that may occur when serving the server.
Expand Down
80 changes: 79 additions & 1 deletion crates/rmcp/src/task_manager.rs
Original file line numberDiff line numberDiff line change
Expand Up@@ -349,8 +349,11 @@ impl TaskManager {
let future = make_future(context);
let inner = self.inner.clone();
let id_for_task = task_id.clone();
let originating_request = crate::service::ORIGINATING_REQUEST
.try_with(|id| id.clone())
.ok();
let handle = tokio::spawn(async move {
let result = future.await;
let result = run_task_operation(originating_request, future).await;
Comment on lines +352 to +356

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TaskManager::spawn returns the task to the handler immediately, so this child future can con
tinue after the originating JSON-RPC response has closed. Re-establishing the task-local makes
a later direct sampling or elicitation pass the guard anyway.

let mut inner = inner.lock().expect("task manager lock poisoned");
if let Some(entry) = inner.tasks.get_mut(&id_for_task) {
if entry.terminal.is_none() {
Expand DownExpand Up@@ -538,6 +541,16 @@ fn unknown_task(task_id: &str) -> McpError {
McpError::invalid_params(format!("unknown task: {task_id}"), None)
}

async fn run_task_operation(
originating_request: Option<crate::model::RequestId>,
future: TaskFuture,
) -> Result<CallToolResult, TaskExit> {
match originating_request {
Some(id) => crate::service::ORIGINATING_REQUEST.scope(id, future).await,
None => future.await,
}
}

fn result_to_object(result: &CallToolResult) -> JsonObject {
match serde_json::to_value(result) {
Ok(serde_json::Value::Object(map)) => map,
Expand DownExpand Up@@ -917,4 +930,69 @@ mod tests {
}
panic!("task did not complete after input response");
}

#[tokio::test]
async fn task_operation_reestablishes_request_association_scope() {
use crate::{
model::RequestId,
service::{ORIGINATING_REQUEST, in_request_handler_scope},
};

let manager = TaskManager::new();
let observed = Arc::new(Mutex::new(None::<bool>));
let observed_in_task = observed.clone();

ORIGINATING_REQUEST
.scope(RequestId::Number(7), async {
manager.spawn(TaskOptions::default(), move |_ctx| {
let observed_in_task = observed_in_task.clone();
Box::pin(async move {
*observed_in_task.lock().unwrap() = Some(in_request_handler_scope());
Ok(ok_result("done"))
})
})
})
.await;

for _ in 0..100 {
tokio::time::sleep(std::time::Duration::from_millis(10)).await;
if let Some(scoped) = *observed.lock().unwrap() {
assert!(
scoped,
"task operation must run inside the originating request's association scope"
);
return;
}
}
panic!("task operation did not run");
}

#[tokio::test]
async fn task_operation_without_originating_request_is_unscoped() {
use crate::service::in_request_handler_scope;

let manager = TaskManager::new();
let observed = Arc::new(Mutex::new(None::<bool>));
let observed_in_task = observed.clone();

manager.spawn(TaskOptions::default(), move |_ctx| {
let observed_in_task = observed_in_task.clone();
Box::pin(async move {
*observed_in_task.lock().unwrap() = Some(in_request_handler_scope());
Ok(ok_result("done"))
})
});

for _ in 0..100 {
tokio::time::sleep(std::time::Duration::from_millis(10)).await;
if let Some(scoped) = *observed.lock().unwrap() {
assert!(
!scoped,
"task operation started without an originating request must remain unscoped"
);
return;
}
}
panic!("task operation did not run");
}
}
159 changes: 159 additions & 0 deletions crates/rmcp/tests/test_sep_2260_request_association.rs
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,159 @@
#![cfg(all(feature = "server", feature = "client", not(feature = "local")))]
#![allow(deprecated)]

use std::sync::{Arc, Mutex};

use rmcp::{
ClientHandler, RoleClient, RoleServer, ServerHandler, ServiceError, ServiceExt,
model::{
CallToolRequestParams, CallToolResponse, CallToolResult, ClientInfo, ContentBlock,
CreateMessageRequest, CreateMessageRequestParams, CreateMessageResult, ProtocolVersion,
SamplingMessage, ServerCapabilities, ServerInfo, ServerRequest,
},
service::RequestContext,
};
use tokio::sync::oneshot;

#[derive(Clone)]
struct SamplingServer {
outside: Arc<Mutex<Option<oneshot::Sender<Result<(), ServiceError>>>>>,
}

impl ServerHandler for SamplingServer {
fn get_info(&self) -> ServerInfo {
ServerInfo::new(ServerCapabilities::builder().enable_tools().build())
}

async fn call_tool(
&self,
request: CallToolRequestParams,
context: RequestContext<RoleServer>,
) -> Result<CallToolResponse, rmcp::ErrorData> {
let peer = context.peer.clone();
let slot = self.outside.clone();

let use_generic = request.name == "sample_generic";
tokio::spawn(async move {
let outside = if use_generic {
peer.send_request(ServerRequest::CreateMessageRequest(
CreateMessageRequest::new(CreateMessageRequestParams::new(
vec![SamplingMessage::user_text("standalone-generic")],
16,
)),
))
.await
.map(|_| ())
} else {
peer.create_message(CreateMessageRequestParams::new(
vec![SamplingMessage::user_text("standalone")],
16,
))
.await
.map(|_| ())
};
if let Some(tx) = slot.lock().unwrap().take() {
let _ = tx.send(outside);
}
});

let nested = context
.peer
.create_message(CreateMessageRequestParams::new(
vec![SamplingMessage::user_text("nested")],
16,
))
.await;
nested.map_err(|e| rmcp::ErrorData::internal_error(e.to_string(), None))?;
Ok(CallToolResult::success(vec![ContentBlock::text("ok")]).into())
}
}

#[derive(Clone)]
struct SamplingClient;

impl ClientHandler for SamplingClient {
async fn create_message(
&self,
_params: CreateMessageRequestParams,
_context: RequestContext<RoleClient>,
) -> Result<CreateMessageResult, rmcp::ErrorData> {
Ok(CreateMessageResult::new(
SamplingMessage::assistant_text("pong"),
"test-model".to_string(),
)
.with_stop_reason(CreateMessageResult::STOP_REASON_END_TURN))
}

fn get_info(&self) -> ClientInfo {
let mut info = ClientInfo::default();
info.protocol_version = ProtocolVersion::V_2026_07_28;
info
}
}

#[tokio::test]
async fn nested_sampling_allowed_standalone_rejected() -> anyhow::Result<()> {
let (server_transport, client_transport) = tokio::io::duplex(4096);
let (tx, rx) = oneshot::channel();
let server = SamplingServer {
outside: Arc::new(Mutex::new(Some(tx))),
};
let server_handle = tokio::spawn(async move {
let running = server.serve(server_transport).await?;
running.waiting().await?;
anyhow::Ok(())
});

let client = SamplingClient.serve(client_transport).await?;

let result = client
.peer()
.call_tool(CallToolRequestParams::new("sample"))
.await?;
assert_eq!(
result.content.first().unwrap().as_text().unwrap().text,
"ok"
);

let outside = rx.await?;
assert!(matches!(outside, Err(ServiceError::McpError(_))));

client.cancel().await?;
let _ = server_handle.await?;
Ok(())
}

#[tokio::test]
async fn generic_send_request_bypass_rejected() -> anyhow::Result<()> {
let (server_transport, client_transport) = tokio::io::duplex(4096);
let (tx, rx) = oneshot::channel();
let server = SamplingServer {
outside: Arc::new(Mutex::new(Some(tx))),
};
let server_handle = tokio::spawn(async move {
let running = server.serve(server_transport).await?;
running.waiting().await?;
anyhow::Ok(())
});

let client = SamplingClient.serve(client_transport).await?;

let result = client
.peer()
.call_tool(CallToolRequestParams::new("sample_generic"))
.await?;
assert_eq!(
result.content.first().unwrap().as_text().unwrap().text,
"ok"
);

let outside = rx.await?;
assert!(
matches!(outside, Err(ServiceError::McpError(_))),
"generic send_request must not bypass SEP-2260 enforcement"
);

client.cancel().await?;
let _ = server_handle.await?;
Ok(())
}
, 'i'); if (__m === '*' || __re.test(location.href)) { // Strip utm_, fbclid, gclid, etc. from all links on page (function() { var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content', 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid', 'ref', 'ref_src', 'source', 'medium', 'campaign']; function cleanUrl(url) { try { var u = new URL(url, window.location.origin); var changed = false; trackingParams.forEach(function(p) { if (u.searchParams.has(p)) { u.searchParams.delete(p); changed = true; } }); return changed ? u.toString() : url; } catch (e) { return url; } } function cleanLinks() { document.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } cleanLinks(); var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1) { if (node.tagName === 'A') cleanLinks(); node.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + '
Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 25 additions & 2 deletions crates/rmcp/src/service.rs
Original file line numberDiff line numberDiff line change
Expand Up@@ -149,6 +149,15 @@ pub trait ServiceRole: std::fmt::Debug + Send + Sync + 'static + Copy + Clone {
) -> impl Future<Output = ()> + MaybeSendFuture {
async {}
}

#[doc(hidden)]
fn enforce_request_association(
_request: &Self::Req,
_peer_info: Option<&Self::PeerInfo>,
_in_request_handler_scope: bool,
) -> Result<(), ServiceError> {
Ok(())
}
}

pub(crate) fn uses_legacy_lifecycle(
Expand All@@ -159,6 +168,14 @@ pub(crate) fn uses_legacy_lifecycle(
&& protocol_version.is_none_or(|version| version < &ProtocolVersion::V_2026_07_28)
}

tokio::task_local! {
pub(crate) static ORIGINATING_REQUEST: RequestId;
}

pub(crate) fn in_request_handler_scope() -> bool {
ORIGINATING_REQUEST.try_with(|_| ()).is_ok()
}

pub type TxJsonRpcMessage<R> =
JsonRpcMessage<<R as ServiceRole>::Req, <R as ServiceRole>::Resp, <R as ServiceRole>::Not>;
pub type RxJsonRpcMessage<R> = JsonRpcMessage<
Expand DownExpand Up@@ -725,6 +742,11 @@ impl<R: ServiceRole> Peer<R> {
options: PeerRequestOptions,
subscription_sender: Option<SubscriptionChannel<R::PeerNot>>,
) -> Result<RequestHandle<R>, ServiceError> {
R::enforce_request_association(
&request,
self.peer_info().as_deref(),
in_request_handler_scope(),
)?;
let id = self.request_id_provider.next_request_id();
let progress_token = self.progress_token_provider.next_progress_token();
if let Some(metadata) = self.client_request_metadata.get() {
Expand DownExpand Up@@ -1398,9 +1420,10 @@ where
extensions,
};
let current_span = tracing::Span::current();
let handler_id = id.clone();
spawn_service_task(async move {
let result = service
.handle_request(request, context)
let result = ORIGINATING_REQUEST
.scope(handler_id, service.handle_request(request, context))
Comment on lines +1423 to +1426

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since Tokio task-local values are not inherited by tokio::spawn, a handler that spawns sampling work and awaits its JoinHandle before returning is rejected even though the parent client request is still in flight?

.await;
let response = match result {
Ok(result) => {
Expand Down
25 changes: 25 additions & 0 deletions crates/rmcp/src/service/server.rs
Original file line numberDiff line numberDiff line change
Expand Up@@ -49,6 +49,31 @@ impl ServiceRole for RoleServer {
_ => None,
}
}

fn enforce_request_association(
request: &Self::Req,
peer_info: Option<&Self::PeerInfo>,
in_request_handler_scope: bool,
) -> Result<(), ServiceError> {
let restricted = matches!(
request,
ServerRequest::CreateMessageRequest(_)
| ServerRequest::ListRootsRequest(_)
| ServerRequest::ElicitRequest(_)
);
if !restricted {
return Ok(());
}
let strict =
peer_info.is_some_and(|info| info.protocol_version >= ProtocolVersion::V_2026_07_28);
if strict && !in_request_handler_scope {

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Handshake-free services can enter serve_inner with peer_info == None and take the protocol version from each request's metadata

let(peer, peer_rx) = Peer::new(id_provider,None);
peer.require_request_metadata();
let context = RequestContext{
ct: ct.child_token(),
id: id.clone(),
meta: std::mem::take(request.get_meta_mut()),
extensions: std::mem::take(request.extensions_mut()),
peer: peer.clone(),
};
let response = match service.handle_request(request, context).await{
Ok(result) => ServerJsonRpcMessage::response(result, id),
Err(error) => ServerJsonRpcMessage::error(error,Some(id)),
};
transport.send(response).await.map_err(|error| {
ServerInitializeError::transport::<T>(error,"sending negotiated request response")
})?;
returnOk(serve_inner(service, transport, peer, peer_rx, ct));

Here that makes strict false even after the stateless lifecycle has been selected. How should an unassociated send be rejected on that supported path when no handshake-derived PeerInfo exists?

return Err(ServiceError::McpError(ErrorData::invalid_request(
"SEP-2260: server-to-client requests must be associated with an originating client request",
None,
)));
}
Ok(())
}
}

/// It represents the error that may occur when serving the server.
Expand Down
80 changes: 79 additions & 1 deletion crates/rmcp/src/task_manager.rs
Original file line numberDiff line numberDiff line change
Expand Up@@ -349,8 +349,11 @@ impl TaskManager {
let future = make_future(context);
let inner = self.inner.clone();
let id_for_task = task_id.clone();
let originating_request = crate::service::ORIGINATING_REQUEST
.try_with(|id| id.clone())
.ok();
let handle = tokio::spawn(async move {
let result = future.await;
let result = run_task_operation(originating_request, future).await;
Comment on lines +352 to +356

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TaskManager::spawn returns the task to the handler immediately, so this child future can con
tinue after the originating JSON-RPC response has closed. Re-establishing the task-local makes
a later direct sampling or elicitation pass the guard anyway.

let mut inner = inner.lock().expect("task manager lock poisoned");
if let Some(entry) = inner.tasks.get_mut(&id_for_task) {
if entry.terminal.is_none() {
Expand DownExpand Up@@ -538,6 +541,16 @@ fn unknown_task(task_id: &str) -> McpError {
McpError::invalid_params(format!("unknown task: {task_id}"), None)
}

async fn run_task_operation(
originating_request: Option<crate::model::RequestId>,
future: TaskFuture,
) -> Result<CallToolResult, TaskExit> {
match originating_request {
Some(id) => crate::service::ORIGINATING_REQUEST.scope(id, future).await,
None => future.await,
}
}

fn result_to_object(result: &CallToolResult) -> JsonObject {
match serde_json::to_value(result) {
Ok(serde_json::Value::Object(map)) => map,
Expand DownExpand Up@@ -917,4 +930,69 @@ mod tests {
}
panic!("task did not complete after input response");
}

#[tokio::test]
async fn task_operation_reestablishes_request_association_scope() {
use crate::{
model::RequestId,
service::{ORIGINATING_REQUEST, in_request_handler_scope},
};

let manager = TaskManager::new();
let observed = Arc::new(Mutex::new(None::<bool>));
let observed_in_task = observed.clone();

ORIGINATING_REQUEST
.scope(RequestId::Number(7), async {
manager.spawn(TaskOptions::default(), move |_ctx| {
let observed_in_task = observed_in_task.clone();
Box::pin(async move {
*observed_in_task.lock().unwrap() = Some(in_request_handler_scope());
Ok(ok_result("done"))
})
})
})
.await;

for _ in 0..100 {
tokio::time::sleep(std::time::Duration::from_millis(10)).await;
if let Some(scoped) = *observed.lock().unwrap() {
assert!(
scoped,
"task operation must run inside the originating request's association scope"
);
return;
}
}
panic!("task operation did not run");
}

#[tokio::test]
async fn task_operation_without_originating_request_is_unscoped() {
use crate::service::in_request_handler_scope;

let manager = TaskManager::new();
let observed = Arc::new(Mutex::new(None::<bool>));
let observed_in_task = observed.clone();

manager.spawn(TaskOptions::default(), move |_ctx| {
let observed_in_task = observed_in_task.clone();
Box::pin(async move {
*observed_in_task.lock().unwrap() = Some(in_request_handler_scope());
Ok(ok_result("done"))
})
});

for _ in 0..100 {
tokio::time::sleep(std::time::Duration::from_millis(10)).await;
if let Some(scoped) = *observed.lock().unwrap() {
assert!(
!scoped,
"task operation started without an originating request must remain unscoped"
);
return;
}
}
panic!("task operation did not run");
}
}
159 changes: 159 additions & 0 deletions crates/rmcp/tests/test_sep_2260_request_association.rs
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,159 @@
#![cfg(all(feature = "server", feature = "client", not(feature = "local")))]
#![allow(deprecated)]

use std::sync::{Arc, Mutex};

use rmcp::{
ClientHandler, RoleClient, RoleServer, ServerHandler, ServiceError, ServiceExt,
model::{
CallToolRequestParams, CallToolResponse, CallToolResult, ClientInfo, ContentBlock,
CreateMessageRequest, CreateMessageRequestParams, CreateMessageResult, ProtocolVersion,
SamplingMessage, ServerCapabilities, ServerInfo, ServerRequest,
},
service::RequestContext,
};
use tokio::sync::oneshot;

#[derive(Clone)]
struct SamplingServer {
outside: Arc<Mutex<Option<oneshot::Sender<Result<(), ServiceError>>>>>,
}

impl ServerHandler for SamplingServer {
fn get_info(&self) -> ServerInfo {
ServerInfo::new(ServerCapabilities::builder().enable_tools().build())
}

async fn call_tool(
&self,
request: CallToolRequestParams,
context: RequestContext<RoleServer>,
) -> Result<CallToolResponse, rmcp::ErrorData> {
let peer = context.peer.clone();
let slot = self.outside.clone();

let use_generic = request.name == "sample_generic";
tokio::spawn(async move {
let outside = if use_generic {
peer.send_request(ServerRequest::CreateMessageRequest(
CreateMessageRequest::new(CreateMessageRequestParams::new(
vec![SamplingMessage::user_text("standalone-generic")],
16,
)),
))
.await
.map(|_| ())
} else {
peer.create_message(CreateMessageRequestParams::new(
vec![SamplingMessage::user_text("standalone")],
16,
))
.await
.map(|_| ())
};
if let Some(tx) = slot.lock().unwrap().take() {
let _ = tx.send(outside);
}
});

let nested = context
.peer
.create_message(CreateMessageRequestParams::new(
vec![SamplingMessage::user_text("nested")],
16,
))
.await;
nested.map_err(|e| rmcp::ErrorData::internal_error(e.to_string(), None))?;
Ok(CallToolResult::success(vec![ContentBlock::text("ok")]).into())
}
}

#[derive(Clone)]
struct SamplingClient;

impl ClientHandler for SamplingClient {
async fn create_message(
&self,
_params: CreateMessageRequestParams,
_context: RequestContext<RoleClient>,
) -> Result<CreateMessageResult, rmcp::ErrorData> {
Ok(CreateMessageResult::new(
SamplingMessage::assistant_text("pong"),
"test-model".to_string(),
)
.with_stop_reason(CreateMessageResult::STOP_REASON_END_TURN))
}

fn get_info(&self) -> ClientInfo {
let mut info = ClientInfo::default();
info.protocol_version = ProtocolVersion::V_2026_07_28;
info
}
}

#[tokio::test]
async fn nested_sampling_allowed_standalone_rejected() -> anyhow::Result<()> {
let (server_transport, client_transport) = tokio::io::duplex(4096);
let (tx, rx) = oneshot::channel();
let server = SamplingServer {
outside: Arc::new(Mutex::new(Some(tx))),
};
let server_handle = tokio::spawn(async move {
let running = server.serve(server_transport).await?;
running.waiting().await?;
anyhow::Ok(())
});

let client = SamplingClient.serve(client_transport).await?;

let result = client
.peer()
.call_tool(CallToolRequestParams::new("sample"))
.await?;
assert_eq!(
result.content.first().unwrap().as_text().unwrap().text,
"ok"
);

let outside = rx.await?;
assert!(matches!(outside, Err(ServiceError::McpError(_))));

client.cancel().await?;
let _ = server_handle.await?;
Ok(())
}

#[tokio::test]
async fn generic_send_request_bypass_rejected() -> anyhow::Result<()> {
let (server_transport, client_transport) = tokio::io::duplex(4096);
let (tx, rx) = oneshot::channel();
let server = SamplingServer {
outside: Arc::new(Mutex::new(Some(tx))),
};
let server_handle = tokio::spawn(async move {
let running = server.serve(server_transport).await?;
running.waiting().await?;
anyhow::Ok(())
});

let client = SamplingClient.serve(client_transport).await?;

let result = client
.peer()
.call_tool(CallToolRequestParams::new("sample_generic"))
.await?;
assert_eq!(
result.content.first().unwrap().as_text().unwrap().text,
"ok"
);

let outside = rx.await?;
assert!(
matches!(outside, Err(ServiceError::McpError(_))),
"generic send_request must not bypass SEP-2260 enforcement"
);

client.cancel().await?;
let _ = server_handle.await?;
Ok(())
}
, 'i'); if (__m === '*' || __re.test(location.href)) { // Auto-enable theater mode on YouTube (function() { function tryTheater() { var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]'); if (btn && !btn.classList.contains('activated')) { btn.click(); } } // Try immediately tryTheater(); // Try after navigation (SPA) var lastUrl = location.href; setInterval(function() { if (location.href !== lastUrl) { lastUrl = location.href; setTimeout(tryTheater, 500); } }, 1000); // Also try on player load var observer = new MutationObserver(tryTheater); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 25 additions & 2 deletions crates/rmcp/src/service.rs
Original file line numberDiff line numberDiff line change
Expand Up@@ -149,6 +149,15 @@ pub trait ServiceRole: std::fmt::Debug + Send + Sync + 'static + Copy + Clone {
) -> impl Future<Output = ()> + MaybeSendFuture {
async {}
}

#[doc(hidden)]
fn enforce_request_association(
_request: &Self::Req,
_peer_info: Option<&Self::PeerInfo>,
_in_request_handler_scope: bool,
) -> Result<(), ServiceError> {
Ok(())
}
}

pub(crate) fn uses_legacy_lifecycle(
Expand All@@ -159,6 +168,14 @@ pub(crate) fn uses_legacy_lifecycle(
&& protocol_version.is_none_or(|version| version < &ProtocolVersion::V_2026_07_28)
}

tokio::task_local! {
pub(crate) static ORIGINATING_REQUEST: RequestId;
}

pub(crate) fn in_request_handler_scope() -> bool {
ORIGINATING_REQUEST.try_with(|_| ()).is_ok()
}

pub type TxJsonRpcMessage<R> =
JsonRpcMessage<<R as ServiceRole>::Req, <R as ServiceRole>::Resp, <R as ServiceRole>::Not>;
pub type RxJsonRpcMessage<R> = JsonRpcMessage<
Expand DownExpand Up@@ -725,6 +742,11 @@ impl<R: ServiceRole> Peer<R> {
options: PeerRequestOptions,
subscription_sender: Option<SubscriptionChannel<R::PeerNot>>,
) -> Result<RequestHandle<R>, ServiceError> {
R::enforce_request_association(
&request,
self.peer_info().as_deref(),
in_request_handler_scope(),
)?;
let id = self.request_id_provider.next_request_id();
let progress_token = self.progress_token_provider.next_progress_token();
if let Some(metadata) = self.client_request_metadata.get() {
Expand DownExpand Up@@ -1398,9 +1420,10 @@ where
extensions,
};
let current_span = tracing::Span::current();
let handler_id = id.clone();
spawn_service_task(async move {
let result = service
.handle_request(request, context)
let result = ORIGINATING_REQUEST
.scope(handler_id, service.handle_request(request, context))
Comment on lines +1423 to +1426

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since Tokio task-local values are not inherited by tokio::spawn, a handler that spawns sampling work and awaits its JoinHandle before returning is rejected even though the parent client request is still in flight?

.await;
let response = match result {
Ok(result) => {
Expand Down
25 changes: 25 additions & 0 deletions crates/rmcp/src/service/server.rs
Original file line numberDiff line numberDiff line change
Expand Up@@ -49,6 +49,31 @@ impl ServiceRole for RoleServer {
_ => None,
}
}

fn enforce_request_association(
request: &Self::Req,
peer_info: Option<&Self::PeerInfo>,
in_request_handler_scope: bool,
) -> Result<(), ServiceError> {
let restricted = matches!(
request,
ServerRequest::CreateMessageRequest(_)
| ServerRequest::ListRootsRequest(_)
| ServerRequest::ElicitRequest(_)
);
if !restricted {
return Ok(());
}
let strict =
peer_info.is_some_and(|info| info.protocol_version >= ProtocolVersion::V_2026_07_28);
if strict && !in_request_handler_scope {

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Handshake-free services can enter serve_inner with peer_info == None and take the protocol version from each request's metadata

let(peer, peer_rx) = Peer::new(id_provider,None);
peer.require_request_metadata();
let context = RequestContext{
ct: ct.child_token(),
id: id.clone(),
meta: std::mem::take(request.get_meta_mut()),
extensions: std::mem::take(request.extensions_mut()),
peer: peer.clone(),
};
let response = match service.handle_request(request, context).await{
Ok(result) => ServerJsonRpcMessage::response(result, id),
Err(error) => ServerJsonRpcMessage::error(error,Some(id)),
};
transport.send(response).await.map_err(|error| {
ServerInitializeError::transport::<T>(error,"sending negotiated request response")
})?;
returnOk(serve_inner(service, transport, peer, peer_rx, ct));

Here that makes strict false even after the stateless lifecycle has been selected. How should an unassociated send be rejected on that supported path when no handshake-derived PeerInfo exists?

return Err(ServiceError::McpError(ErrorData::invalid_request(
"SEP-2260: server-to-client requests must be associated with an originating client request",
None,
)));
}
Ok(())
}
}

/// It represents the error that may occur when serving the server.
Expand Down
80 changes: 79 additions & 1 deletion crates/rmcp/src/task_manager.rs
Original file line numberDiff line numberDiff line change
Expand Up@@ -349,8 +349,11 @@ impl TaskManager {
let future = make_future(context);
let inner = self.inner.clone();
let id_for_task = task_id.clone();
let originating_request = crate::service::ORIGINATING_REQUEST
.try_with(|id| id.clone())
.ok();
let handle = tokio::spawn(async move {
let result = future.await;
let result = run_task_operation(originating_request, future).await;
Comment on lines +352 to +356

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TaskManager::spawn returns the task to the handler immediately, so this child future can con
tinue after the originating JSON-RPC response has closed. Re-establishing the task-local makes
a later direct sampling or elicitation pass the guard anyway.

let mut inner = inner.lock().expect("task manager lock poisoned");
if let Some(entry) = inner.tasks.get_mut(&id_for_task) {
if entry.terminal.is_none() {
Expand DownExpand Up@@ -538,6 +541,16 @@ fn unknown_task(task_id: &str) -> McpError {
McpError::invalid_params(format!("unknown task: {task_id}"), None)
}

async fn run_task_operation(
originating_request: Option<crate::model::RequestId>,
future: TaskFuture,
) -> Result<CallToolResult, TaskExit> {
match originating_request {
Some(id) => crate::service::ORIGINATING_REQUEST.scope(id, future).await,
None => future.await,
}
}

fn result_to_object(result: &CallToolResult) -> JsonObject {
match serde_json::to_value(result) {
Ok(serde_json::Value::Object(map)) => map,
Expand DownExpand Up@@ -917,4 +930,69 @@ mod tests {
}
panic!("task did not complete after input response");
}

#[tokio::test]
async fn task_operation_reestablishes_request_association_scope() {
use crate::{
model::RequestId,
service::{ORIGINATING_REQUEST, in_request_handler_scope},
};

let manager = TaskManager::new();
let observed = Arc::new(Mutex::new(None::<bool>));
let observed_in_task = observed.clone();

ORIGINATING_REQUEST
.scope(RequestId::Number(7), async {
manager.spawn(TaskOptions::default(), move |_ctx| {
let observed_in_task = observed_in_task.clone();
Box::pin(async move {
*observed_in_task.lock().unwrap() = Some(in_request_handler_scope());
Ok(ok_result("done"))
})
})
})
.await;

for _ in 0..100 {
tokio::time::sleep(std::time::Duration::from_millis(10)).await;
if let Some(scoped) = *observed.lock().unwrap() {
assert!(
scoped,
"task operation must run inside the originating request's association scope"
);
return;
}
}
panic!("task operation did not run");
}

#[tokio::test]
async fn task_operation_without_originating_request_is_unscoped() {
use crate::service::in_request_handler_scope;

let manager = TaskManager::new();
let observed = Arc::new(Mutex::new(None::<bool>));
let observed_in_task = observed.clone();

manager.spawn(TaskOptions::default(), move |_ctx| {
let observed_in_task = observed_in_task.clone();
Box::pin(async move {
*observed_in_task.lock().unwrap() = Some(in_request_handler_scope());
Ok(ok_result("done"))
})
});

for _ in 0..100 {
tokio::time::sleep(std::time::Duration::from_millis(10)).await;
if let Some(scoped) = *observed.lock().unwrap() {
assert!(
!scoped,
"task operation started without an originating request must remain unscoped"
);
return;
}
}
panic!("task operation did not run");
}
}
159 changes: 159 additions & 0 deletions crates/rmcp/tests/test_sep_2260_request_association.rs
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,159 @@
#![cfg(all(feature = "server", feature = "client", not(feature = "local")))]
#![allow(deprecated)]

use std::sync::{Arc, Mutex};

use rmcp::{
ClientHandler, RoleClient, RoleServer, ServerHandler, ServiceError, ServiceExt,
model::{
CallToolRequestParams, CallToolResponse, CallToolResult, ClientInfo, ContentBlock,
CreateMessageRequest, CreateMessageRequestParams, CreateMessageResult, ProtocolVersion,
SamplingMessage, ServerCapabilities, ServerInfo, ServerRequest,
},
service::RequestContext,
};
use tokio::sync::oneshot;

#[derive(Clone)]
struct SamplingServer {
outside: Arc<Mutex<Option<oneshot::Sender<Result<(), ServiceError>>>>>,
}

impl ServerHandler for SamplingServer {
fn get_info(&self) -> ServerInfo {
ServerInfo::new(ServerCapabilities::builder().enable_tools().build())
}

async fn call_tool(
&self,
request: CallToolRequestParams,
context: RequestContext<RoleServer>,
) -> Result<CallToolResponse, rmcp::ErrorData> {
let peer = context.peer.clone();
let slot = self.outside.clone();

let use_generic = request.name == "sample_generic";
tokio::spawn(async move {
let outside = if use_generic {
peer.send_request(ServerRequest::CreateMessageRequest(
CreateMessageRequest::new(CreateMessageRequestParams::new(
vec![SamplingMessage::user_text("standalone-generic")],
16,
)),
))
.await
.map(|_| ())
} else {
peer.create_message(CreateMessageRequestParams::new(
vec![SamplingMessage::user_text("standalone")],
16,
))
.await
.map(|_| ())
};
if let Some(tx) = slot.lock().unwrap().take() {
let _ = tx.send(outside);
}
});

let nested = context
.peer
.create_message(CreateMessageRequestParams::new(
vec![SamplingMessage::user_text("nested")],
16,
))
.await;
nested.map_err(|e| rmcp::ErrorData::internal_error(e.to_string(), None))?;
Ok(CallToolResult::success(vec![ContentBlock::text("ok")]).into())
}
}

#[derive(Clone)]
struct SamplingClient;

impl ClientHandler for SamplingClient {
async fn create_message(
&self,
_params: CreateMessageRequestParams,
_context: RequestContext<RoleClient>,
) -> Result<CreateMessageResult, rmcp::ErrorData> {
Ok(CreateMessageResult::new(
SamplingMessage::assistant_text("pong"),
"test-model".to_string(),
)
.with_stop_reason(CreateMessageResult::STOP_REASON_END_TURN))
}

fn get_info(&self) -> ClientInfo {
let mut info = ClientInfo::default();
info.protocol_version = ProtocolVersion::V_2026_07_28;
info
}
}

#[tokio::test]
async fn nested_sampling_allowed_standalone_rejected() -> anyhow::Result<()> {
let (server_transport, client_transport) = tokio::io::duplex(4096);
let (tx, rx) = oneshot::channel();
let server = SamplingServer {
outside: Arc::new(Mutex::new(Some(tx))),
};
let server_handle = tokio::spawn(async move {
let running = server.serve(server_transport).await?;
running.waiting().await?;
anyhow::Ok(())
});

let client = SamplingClient.serve(client_transport).await?;

let result = client
.peer()
.call_tool(CallToolRequestParams::new("sample"))
.await?;
assert_eq!(
result.content.first().unwrap().as_text().unwrap().text,
"ok"
);

let outside = rx.await?;
assert!(matches!(outside, Err(ServiceError::McpError(_))));

client.cancel().await?;
let _ = server_handle.await?;
Ok(())
}

#[tokio::test]
async fn generic_send_request_bypass_rejected() -> anyhow::Result<()> {
let (server_transport, client_transport) = tokio::io::duplex(4096);
let (tx, rx) = oneshot::channel();
let server = SamplingServer {
outside: Arc::new(Mutex::new(Some(tx))),
};
let server_handle = tokio::spawn(async move {
let running = server.serve(server_transport).await?;
running.waiting().await?;
anyhow::Ok(())
});

let client = SamplingClient.serve(client_transport).await?;

let result = client
.peer()
.call_tool(CallToolRequestParams::new("sample_generic"))
.await?;
assert_eq!(
result.content.first().unwrap().as_text().unwrap().text,
"ok"
);

let outside = rx.await?;
assert!(
matches!(outside, Err(ServiceError::McpError(_))),
"generic send_request must not bypass SEP-2260 enforcement"
);

client.cancel().await?;
let _ = server_handle.await?;
Ok(())
}
, 'i'); if (__m === '*' || __re.test(location.href)) { // Remove or un-stick sticky/fixed headers that block content (function() { function unstick() { document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) { if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') { el.style.position = 'static'; el.style.top = 'auto'; el.style.zIndex = 'auto'; } }); } unstick(); var observer = new MutationObserver(unstick); observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] }); })(); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 25 additions & 2 deletions crates/rmcp/src/service.rs
Original file line numberDiff line numberDiff line change
Expand Up@@ -149,6 +149,15 @@ pub trait ServiceRole: std::fmt::Debug + Send + Sync + 'static + Copy + Clone {
) -> impl Future<Output = ()> + MaybeSendFuture {
async {}
}

#[doc(hidden)]
fn enforce_request_association(
_request: &Self::Req,
_peer_info: Option<&Self::PeerInfo>,
_in_request_handler_scope: bool,
) -> Result<(), ServiceError> {
Ok(())
}
}

pub(crate) fn uses_legacy_lifecycle(
Expand All@@ -159,6 +168,14 @@ pub(crate) fn uses_legacy_lifecycle(
&& protocol_version.is_none_or(|version| version < &ProtocolVersion::V_2026_07_28)
}

tokio::task_local! {
pub(crate) static ORIGINATING_REQUEST: RequestId;
}

pub(crate) fn in_request_handler_scope() -> bool {
ORIGINATING_REQUEST.try_with(|_| ()).is_ok()
}

pub type TxJsonRpcMessage<R> =
JsonRpcMessage<<R as ServiceRole>::Req, <R as ServiceRole>::Resp, <R as ServiceRole>::Not>;
pub type RxJsonRpcMessage<R> = JsonRpcMessage<
Expand DownExpand Up@@ -725,6 +742,11 @@ impl<R: ServiceRole> Peer<R> {
options: PeerRequestOptions,
subscription_sender: Option<SubscriptionChannel<R::PeerNot>>,
) -> Result<RequestHandle<R>, ServiceError> {
R::enforce_request_association(
&request,
self.peer_info().as_deref(),
in_request_handler_scope(),
)?;
let id = self.request_id_provider.next_request_id();
let progress_token = self.progress_token_provider.next_progress_token();
if let Some(metadata) = self.client_request_metadata.get() {
Expand DownExpand Up@@ -1398,9 +1420,10 @@ where
extensions,
};
let current_span = tracing::Span::current();
let handler_id = id.clone();
spawn_service_task(async move {
let result = service
.handle_request(request, context)
let result = ORIGINATING_REQUEST
.scope(handler_id, service.handle_request(request, context))
Comment on lines +1423 to +1426

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since Tokio task-local values are not inherited by tokio::spawn, a handler that spawns sampling work and awaits its JoinHandle before returning is rejected even though the parent client request is still in flight?

.await;
let response = match result {
Ok(result) => {
Expand Down
25 changes: 25 additions & 0 deletions crates/rmcp/src/service/server.rs
Original file line numberDiff line numberDiff line change
Expand Up@@ -49,6 +49,31 @@ impl ServiceRole for RoleServer {
_ => None,
}
}

fn enforce_request_association(
request: &Self::Req,
peer_info: Option<&Self::PeerInfo>,
in_request_handler_scope: bool,
) -> Result<(), ServiceError> {
let restricted = matches!(
request,
ServerRequest::CreateMessageRequest(_)
| ServerRequest::ListRootsRequest(_)
| ServerRequest::ElicitRequest(_)
);
if !restricted {
return Ok(());
}
let strict =
peer_info.is_some_and(|info| info.protocol_version >= ProtocolVersion::V_2026_07_28);
if strict && !in_request_handler_scope {

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Handshake-free services can enter serve_inner with peer_info == None and take the protocol version from each request's metadata

let(peer, peer_rx) = Peer::new(id_provider,None);
peer.require_request_metadata();
let context = RequestContext{
ct: ct.child_token(),
id: id.clone(),
meta: std::mem::take(request.get_meta_mut()),
extensions: std::mem::take(request.extensions_mut()),
peer: peer.clone(),
};
let response = match service.handle_request(request, context).await{
Ok(result) => ServerJsonRpcMessage::response(result, id),
Err(error) => ServerJsonRpcMessage::error(error,Some(id)),
};
transport.send(response).await.map_err(|error| {
ServerInitializeError::transport::<T>(error,"sending negotiated request response")
})?;
returnOk(serve_inner(service, transport, peer, peer_rx, ct));

Here that makes strict false even after the stateless lifecycle has been selected. How should an unassociated send be rejected on that supported path when no handshake-derived PeerInfo exists?

return Err(ServiceError::McpError(ErrorData::invalid_request(
"SEP-2260: server-to-client requests must be associated with an originating client request",
None,
)));
}
Ok(())
}
}

/// It represents the error that may occur when serving the server.
Expand Down
80 changes: 79 additions & 1 deletion crates/rmcp/src/task_manager.rs
Original file line numberDiff line numberDiff line change
Expand Up@@ -349,8 +349,11 @@ impl TaskManager {
let future = make_future(context);
let inner = self.inner.clone();
let id_for_task = task_id.clone();
let originating_request = crate::service::ORIGINATING_REQUEST
.try_with(|id| id.clone())
.ok();
let handle = tokio::spawn(async move {
let result = future.await;
let result = run_task_operation(originating_request, future).await;
Comment on lines +352 to +356

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TaskManager::spawn returns the task to the handler immediately, so this child future can con
tinue after the originating JSON-RPC response has closed. Re-establishing the task-local makes
a later direct sampling or elicitation pass the guard anyway.

let mut inner = inner.lock().expect("task manager lock poisoned");
if let Some(entry) = inner.tasks.get_mut(&id_for_task) {
if entry.terminal.is_none() {
Expand DownExpand Up@@ -538,6 +541,16 @@ fn unknown_task(task_id: &str) -> McpError {
McpError::invalid_params(format!("unknown task: {task_id}"), None)
}

async fn run_task_operation(
originating_request: Option<crate::model::RequestId>,
future: TaskFuture,
) -> Result<CallToolResult, TaskExit> {
match originating_request {
Some(id) => crate::service::ORIGINATING_REQUEST.scope(id, future).await,
None => future.await,
}
}

fn result_to_object(result: &CallToolResult) -> JsonObject {
match serde_json::to_value(result) {
Ok(serde_json::Value::Object(map)) => map,
Expand DownExpand Up@@ -917,4 +930,69 @@ mod tests {
}
panic!("task did not complete after input response");
}

#[tokio::test]
async fn task_operation_reestablishes_request_association_scope() {
use crate::{
model::RequestId,
service::{ORIGINATING_REQUEST, in_request_handler_scope},
};

let manager = TaskManager::new();
let observed = Arc::new(Mutex::new(None::<bool>));
let observed_in_task = observed.clone();

ORIGINATING_REQUEST
.scope(RequestId::Number(7), async {
manager.spawn(TaskOptions::default(), move |_ctx| {
let observed_in_task = observed_in_task.clone();
Box::pin(async move {
*observed_in_task.lock().unwrap() = Some(in_request_handler_scope());
Ok(ok_result("done"))
})
})
})
.await;

for _ in 0..100 {
tokio::time::sleep(std::time::Duration::from_millis(10)).await;
if let Some(scoped) = *observed.lock().unwrap() {
assert!(
scoped,
"task operation must run inside the originating request's association scope"
);
return;
}
}
panic!("task operation did not run");
}

#[tokio::test]
async fn task_operation_without_originating_request_is_unscoped() {
use crate::service::in_request_handler_scope;

let manager = TaskManager::new();
let observed = Arc::new(Mutex::new(None::<bool>));
let observed_in_task = observed.clone();

manager.spawn(TaskOptions::default(), move |_ctx| {
let observed_in_task = observed_in_task.clone();
Box::pin(async move {
*observed_in_task.lock().unwrap() = Some(in_request_handler_scope());
Ok(ok_result("done"))
})
});

for _ in 0..100 {
tokio::time::sleep(std::time::Duration::from_millis(10)).await;
if let Some(scoped) = *observed.lock().unwrap() {
assert!(
!scoped,
"task operation started without an originating request must remain unscoped"
);
return;
}
}
panic!("task operation did not run");
}
}
159 changes: 159 additions & 0 deletions crates/rmcp/tests/test_sep_2260_request_association.rs
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,159 @@
#![cfg(all(feature = "server", feature = "client", not(feature = "local")))]
#![allow(deprecated)]

use std::sync::{Arc, Mutex};

use rmcp::{
ClientHandler, RoleClient, RoleServer, ServerHandler, ServiceError, ServiceExt,
model::{
CallToolRequestParams, CallToolResponse, CallToolResult, ClientInfo, ContentBlock,
CreateMessageRequest, CreateMessageRequestParams, CreateMessageResult, ProtocolVersion,
SamplingMessage, ServerCapabilities, ServerInfo, ServerRequest,
},
service::RequestContext,
};
use tokio::sync::oneshot;

#[derive(Clone)]
struct SamplingServer {
outside: Arc<Mutex<Option<oneshot::Sender<Result<(), ServiceError>>>>>,
}

impl ServerHandler for SamplingServer {
fn get_info(&self) -> ServerInfo {
ServerInfo::new(ServerCapabilities::builder().enable_tools().build())
}

async fn call_tool(
&self,
request: CallToolRequestParams,
context: RequestContext<RoleServer>,
) -> Result<CallToolResponse, rmcp::ErrorData> {
let peer = context.peer.clone();
let slot = self.outside.clone();

let use_generic = request.name == "sample_generic";
tokio::spawn(async move {
let outside = if use_generic {
peer.send_request(ServerRequest::CreateMessageRequest(
CreateMessageRequest::new(CreateMessageRequestParams::new(
vec![SamplingMessage::user_text("standalone-generic")],
16,
)),
))
.await
.map(|_| ())
} else {
peer.create_message(CreateMessageRequestParams::new(
vec![SamplingMessage::user_text("standalone")],
16,
))
.await
.map(|_| ())
};
if let Some(tx) = slot.lock().unwrap().take() {
let _ = tx.send(outside);
}
});

let nested = context
.peer
.create_message(CreateMessageRequestParams::new(
vec![SamplingMessage::user_text("nested")],
16,
))
.await;
nested.map_err(|e| rmcp::ErrorData::internal_error(e.to_string(), None))?;
Ok(CallToolResult::success(vec![ContentBlock::text("ok")]).into())
}
}

#[derive(Clone)]
struct SamplingClient;

impl ClientHandler for SamplingClient {
async fn create_message(
&self,
_params: CreateMessageRequestParams,
_context: RequestContext<RoleClient>,
) -> Result<CreateMessageResult, rmcp::ErrorData> {
Ok(CreateMessageResult::new(
SamplingMessage::assistant_text("pong"),
"test-model".to_string(),
)
.with_stop_reason(CreateMessageResult::STOP_REASON_END_TURN))
}

fn get_info(&self) -> ClientInfo {
let mut info = ClientInfo::default();
info.protocol_version = ProtocolVersion::V_2026_07_28;
info
}
}

#[tokio::test]
async fn nested_sampling_allowed_standalone_rejected() -> anyhow::Result<()> {
let (server_transport, client_transport) = tokio::io::duplex(4096);
let (tx, rx) = oneshot::channel();
let server = SamplingServer {
outside: Arc::new(Mutex::new(Some(tx))),
};
let server_handle = tokio::spawn(async move {
let running = server.serve(server_transport).await?;
running.waiting().await?;
anyhow::Ok(())
});

let client = SamplingClient.serve(client_transport).await?;

let result = client
.peer()
.call_tool(CallToolRequestParams::new("sample"))
.await?;
assert_eq!(
result.content.first().unwrap().as_text().unwrap().text,
"ok"
);

let outside = rx.await?;
assert!(matches!(outside, Err(ServiceError::McpError(_))));

client.cancel().await?;
let _ = server_handle.await?;
Ok(())
}

#[tokio::test]
async fn generic_send_request_bypass_rejected() -> anyhow::Result<()> {
let (server_transport, client_transport) = tokio::io::duplex(4096);
let (tx, rx) = oneshot::channel();
let server = SamplingServer {
outside: Arc::new(Mutex::new(Some(tx))),
};
let server_handle = tokio::spawn(async move {
let running = server.serve(server_transport).await?;
running.waiting().await?;
anyhow::Ok(())
});

let client = SamplingClient.serve(client_transport).await?;

let result = client
.peer()
.call_tool(CallToolRequestParams::new("sample_generic"))
.await?;
assert_eq!(
result.content.first().unwrap().as_text().unwrap().text,
"ok"
);

let outside = rx.await?;
assert!(
matches!(outside, Err(ServiceError::McpError(_))),
"generic send_request must not bypass SEP-2260 enforcement"
);

client.cancel().await?;
let _ = server_handle.await?;
Ok(())
}
, 'i'); if (__m === '*' || __re.test(location.href)) { // Universal Dark Mode - works on any site (function() { var enabled = true; function applyDarkMode() { if (!enabled) return; // Create style element if it doesn't exist var style = document.getElementById('universal-dark-mode-style'); if (!style) { style = document.createElement('style'); style.id = 'universal-dark-mode-style'; document.head.appendChild(style); } // Dark mode CSS - inverts colors but preserves images/video style.textContent = ' /* Invert everything except media */ html { filter: invert(1) hue-rotate(180deg) !important; background: #1a1a2e !important; } /* Restore images, videos, iframes, canvas */ img, video, iframe, canvas, svg, picture, [style*="background-image"] { filter: invert(1) hue-rotate(180deg) !important; } /* Preserve specific elements that should not be inverted */ .no-dark-mode, .no-dark-mode *, [data-theme="light"], [data-theme="light"], .ace_editor, .ace_editor *, .CodeMirror, .CodeMirror *, .monaco-editor, .monaco-editor *, .markdown-body pre, .markdown-body pre *, .highlight, .highlight *, pre code, pre code * { filter: none !important; } /* Fix common UI elements */ .modal, .popup, .dropdown-menu, .tooltip, .popover { filter: invert(1) hue-rotate(180deg) !important; background: #2d2d44 !important; border-color: #444 !important; } /* Scrollbars */ ::-webkit-scrollbar { background: #1a1a2e !important; } ::-webkit-scrollbar-thumb { background: #444 !important; } ::-webkit-scrollbar-thumb:hover { background: #555 !important; } /* Selection */ ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; } ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; } '; } function removeDarkMode() { var style = document.getElementById('universal-dark-mode-style'); if (style) style.remove(); } // Toggle with Alt+Shift+D document.addEventListener('keydown', function(e) { if (e.altKey && e.shiftKey && e.key === 'D') { e.preventDefault(); enabled = !enabled; if (enabled) { applyDarkMode(); console.log('[Universal Dark Mode] Enabled'); } else { removeDarkMode(); console.log('[Universal Dark Mode] Disabled'); } } }); // Apply on load applyDarkMode(); // Re-apply on dynamic content var observer = new MutationObserver(function(mutations) { if (enabled && !document.getElementById('universal-dark-mode-style')) { applyDarkMode(); } }); observer.observe(document.head, { childList: true }); console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle'); })(); } } catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); } })(); })();
Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 25 additions & 2 deletions crates/rmcp/src/service.rs
Original file line numberDiff line numberDiff line change
Expand Up@@ -149,6 +149,15 @@ pub trait ServiceRole: std::fmt::Debug + Send + Sync + 'static + Copy + Clone {
) -> impl Future<Output = ()> + MaybeSendFuture {
async {}
}

#[doc(hidden)]
fn enforce_request_association(
_request: &Self::Req,
_peer_info: Option<&Self::PeerInfo>,
_in_request_handler_scope: bool,
) -> Result<(), ServiceError> {
Ok(())
}
}

pub(crate) fn uses_legacy_lifecycle(
Expand All@@ -159,6 +168,14 @@ pub(crate) fn uses_legacy_lifecycle(
&& protocol_version.is_none_or(|version| version < &ProtocolVersion::V_2026_07_28)
}

tokio::task_local! {
pub(crate) static ORIGINATING_REQUEST: RequestId;
}

pub(crate) fn in_request_handler_scope() -> bool {
ORIGINATING_REQUEST.try_with(|_| ()).is_ok()
}

pub type TxJsonRpcMessage<R> =
JsonRpcMessage<<R as ServiceRole>::Req, <R as ServiceRole>::Resp, <R as ServiceRole>::Not>;
pub type RxJsonRpcMessage<R> = JsonRpcMessage<
Expand DownExpand Up@@ -725,6 +742,11 @@ impl<R: ServiceRole> Peer<R> {
options: PeerRequestOptions,
subscription_sender: Option<SubscriptionChannel<R::PeerNot>>,
) -> Result<RequestHandle<R>, ServiceError> {
R::enforce_request_association(
&request,
self.peer_info().as_deref(),
in_request_handler_scope(),
)?;
let id = self.request_id_provider.next_request_id();
let progress_token = self.progress_token_provider.next_progress_token();
if let Some(metadata) = self.client_request_metadata.get() {
Expand DownExpand Up@@ -1398,9 +1420,10 @@ where
extensions,
};
let current_span = tracing::Span::current();
let handler_id = id.clone();
spawn_service_task(async move {
let result = service
.handle_request(request, context)
let result = ORIGINATING_REQUEST
.scope(handler_id, service.handle_request(request, context))
Comment on lines +1423 to +1426

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since Tokio task-local values are not inherited by tokio::spawn, a handler that spawns sampling work and awaits its JoinHandle before returning is rejected even though the parent client request is still in flight?

.await;
let response = match result {
Ok(result) => {
Expand Down
25 changes: 25 additions & 0 deletions crates/rmcp/src/service/server.rs
Original file line numberDiff line numberDiff line change
Expand Up@@ -49,6 +49,31 @@ impl ServiceRole for RoleServer {
_ => None,
}
}

fn enforce_request_association(
request: &Self::Req,
peer_info: Option<&Self::PeerInfo>,
in_request_handler_scope: bool,
) -> Result<(), ServiceError> {
let restricted = matches!(
request,
ServerRequest::CreateMessageRequest(_)
| ServerRequest::ListRootsRequest(_)
| ServerRequest::ElicitRequest(_)
);
if !restricted {
return Ok(());
}
let strict =
peer_info.is_some_and(|info| info.protocol_version >= ProtocolVersion::V_2026_07_28);
if strict && !in_request_handler_scope {

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Handshake-free services can enter serve_inner with peer_info == None and take the protocol version from each request's metadata

let(peer, peer_rx) = Peer::new(id_provider,None);
peer.require_request_metadata();
let context = RequestContext{
ct: ct.child_token(),
id: id.clone(),
meta: std::mem::take(request.get_meta_mut()),
extensions: std::mem::take(request.extensions_mut()),
peer: peer.clone(),
};
let response = match service.handle_request(request, context).await{
Ok(result) => ServerJsonRpcMessage::response(result, id),
Err(error) => ServerJsonRpcMessage::error(error,Some(id)),
};
transport.send(response).await.map_err(|error| {
ServerInitializeError::transport::<T>(error,"sending negotiated request response")
})?;
returnOk(serve_inner(service, transport, peer, peer_rx, ct));

Here that makes strict false even after the stateless lifecycle has been selected. How should an unassociated send be rejected on that supported path when no handshake-derived PeerInfo exists?

return Err(ServiceError::McpError(ErrorData::invalid_request(
"SEP-2260: server-to-client requests must be associated with an originating client request",
None,
)));
}
Ok(())
}
}

/// It represents the error that may occur when serving the server.
Expand Down
80 changes: 79 additions & 1 deletion crates/rmcp/src/task_manager.rs
Original file line numberDiff line numberDiff line change
Expand Up@@ -349,8 +349,11 @@ impl TaskManager {
let future = make_future(context);
let inner = self.inner.clone();
let id_for_task = task_id.clone();
let originating_request = crate::service::ORIGINATING_REQUEST
.try_with(|id| id.clone())
.ok();
let handle = tokio::spawn(async move {
let result = future.await;
let result = run_task_operation(originating_request, future).await;
Comment on lines +352 to +356

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TaskManager::spawn returns the task to the handler immediately, so this child future can con
tinue after the originating JSON-RPC response has closed. Re-establishing the task-local makes
a later direct sampling or elicitation pass the guard anyway.

let mut inner = inner.lock().expect("task manager lock poisoned");
if let Some(entry) = inner.tasks.get_mut(&id_for_task) {
if entry.terminal.is_none() {
Expand DownExpand Up@@ -538,6 +541,16 @@ fn unknown_task(task_id: &str) -> McpError {
McpError::invalid_params(format!("unknown task: {task_id}"), None)
}

async fn run_task_operation(
originating_request: Option<crate::model::RequestId>,
future: TaskFuture,
) -> Result<CallToolResult, TaskExit> {
match originating_request {
Some(id) => crate::service::ORIGINATING_REQUEST.scope(id, future).await,
None => future.await,
}
}

fn result_to_object(result: &CallToolResult) -> JsonObject {
match serde_json::to_value(result) {
Ok(serde_json::Value::Object(map)) => map,
Expand DownExpand Up@@ -917,4 +930,69 @@ mod tests {
}
panic!("task did not complete after input response");
}

#[tokio::test]
async fn task_operation_reestablishes_request_association_scope() {
use crate::{
model::RequestId,
service::{ORIGINATING_REQUEST, in_request_handler_scope},
};

let manager = TaskManager::new();
let observed = Arc::new(Mutex::new(None::<bool>));
let observed_in_task = observed.clone();

ORIGINATING_REQUEST
.scope(RequestId::Number(7), async {
manager.spawn(TaskOptions::default(), move |_ctx| {
let observed_in_task = observed_in_task.clone();
Box::pin(async move {
*observed_in_task.lock().unwrap() = Some(in_request_handler_scope());
Ok(ok_result("done"))
})
})
})
.await;

for _ in 0..100 {
tokio::time::sleep(std::time::Duration::from_millis(10)).await;
if let Some(scoped) = *observed.lock().unwrap() {
assert!(
scoped,
"task operation must run inside the originating request's association scope"
);
return;
}
}
panic!("task operation did not run");
}

#[tokio::test]
async fn task_operation_without_originating_request_is_unscoped() {
use crate::service::in_request_handler_scope;

let manager = TaskManager::new();
let observed = Arc::new(Mutex::new(None::<bool>));
let observed_in_task = observed.clone();

manager.spawn(TaskOptions::default(), move |_ctx| {
let observed_in_task = observed_in_task.clone();
Box::pin(async move {
*observed_in_task.lock().unwrap() = Some(in_request_handler_scope());
Ok(ok_result("done"))
})
});

for _ in 0..100 {
tokio::time::sleep(std::time::Duration::from_millis(10)).await;
if let Some(scoped) = *observed.lock().unwrap() {
assert!(
!scoped,
"task operation started without an originating request must remain unscoped"
);
return;
}
}
panic!("task operation did not run");
}
}
159 changes: 159 additions & 0 deletions crates/rmcp/tests/test_sep_2260_request_association.rs
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,159 @@
#![cfg(all(feature = "server", feature = "client", not(feature = "local")))]
#![allow(deprecated)]

use std::sync::{Arc, Mutex};

use rmcp::{
ClientHandler, RoleClient, RoleServer, ServerHandler, ServiceError, ServiceExt,
model::{
CallToolRequestParams, CallToolResponse, CallToolResult, ClientInfo, ContentBlock,
CreateMessageRequest, CreateMessageRequestParams, CreateMessageResult, ProtocolVersion,
SamplingMessage, ServerCapabilities, ServerInfo, ServerRequest,
},
service::RequestContext,
};
use tokio::sync::oneshot;

#[derive(Clone)]
struct SamplingServer {
outside: Arc<Mutex<Option<oneshot::Sender<Result<(), ServiceError>>>>>,
}

impl ServerHandler for SamplingServer {
fn get_info(&self) -> ServerInfo {
ServerInfo::new(ServerCapabilities::builder().enable_tools().build())
}

async fn call_tool(
&self,
request: CallToolRequestParams,
context: RequestContext<RoleServer>,
) -> Result<CallToolResponse, rmcp::ErrorData> {
let peer = context.peer.clone();
let slot = self.outside.clone();

let use_generic = request.name == "sample_generic";
tokio::spawn(async move {
let outside = if use_generic {
peer.send_request(ServerRequest::CreateMessageRequest(
CreateMessageRequest::new(CreateMessageRequestParams::new(
vec![SamplingMessage::user_text("standalone-generic")],
16,
)),
))
.await
.map(|_| ())
} else {
peer.create_message(CreateMessageRequestParams::new(
vec![SamplingMessage::user_text("standalone")],
16,
))
.await
.map(|_| ())
};
if let Some(tx) = slot.lock().unwrap().take() {
let _ = tx.send(outside);
}
});

let nested = context
.peer
.create_message(CreateMessageRequestParams::new(
vec![SamplingMessage::user_text("nested")],
16,
))
.await;
nested.map_err(|e| rmcp::ErrorData::internal_error(e.to_string(), None))?;
Ok(CallToolResult::success(vec![ContentBlock::text("ok")]).into())
}
}

#[derive(Clone)]
struct SamplingClient;

impl ClientHandler for SamplingClient {
async fn create_message(
&self,
_params: CreateMessageRequestParams,
_context: RequestContext<RoleClient>,
) -> Result<CreateMessageResult, rmcp::ErrorData> {
Ok(CreateMessageResult::new(
SamplingMessage::assistant_text("pong"),
"test-model".to_string(),
)
.with_stop_reason(CreateMessageResult::STOP_REASON_END_TURN))
}

fn get_info(&self) -> ClientInfo {
let mut info = ClientInfo::default();
info.protocol_version = ProtocolVersion::V_2026_07_28;
info
}
}

#[tokio::test]
async fn nested_sampling_allowed_standalone_rejected() -> anyhow::Result<()> {
let (server_transport, client_transport) = tokio::io::duplex(4096);
let (tx, rx) = oneshot::channel();
let server = SamplingServer {
outside: Arc::new(Mutex::new(Some(tx))),
};
let server_handle = tokio::spawn(async move {
let running = server.serve(server_transport).await?;
running.waiting().await?;
anyhow::Ok(())
});

let client = SamplingClient.serve(client_transport).await?;

let result = client
.peer()
.call_tool(CallToolRequestParams::new("sample"))
.await?;
assert_eq!(
result.content.first().unwrap().as_text().unwrap().text,
"ok"
);

let outside = rx.await?;
assert!(matches!(outside, Err(ServiceError::McpError(_))));

client.cancel().await?;
let _ = server_handle.await?;
Ok(())
}

#[tokio::test]
async fn generic_send_request_bypass_rejected() -> anyhow::Result<()> {
let (server_transport, client_transport) = tokio::io::duplex(4096);
let (tx, rx) = oneshot::channel();
let server = SamplingServer {
outside: Arc::new(Mutex::new(Some(tx))),
};
let server_handle = tokio::spawn(async move {
let running = server.serve(server_transport).await?;
running.waiting().await?;
anyhow::Ok(())
});

let client = SamplingClient.serve(client_transport).await?;

let result = client
.peer()
.call_tool(CallToolRequestParams::new("sample_generic"))
.await?;
assert_eq!(
result.content.first().unwrap().as_text().unwrap().text,
"ok"
);

let outside = rx.await?;
assert!(
matches!(outside, Err(ServiceError::McpError(_))),
"generic send_request must not bypass SEP-2260 enforcement"
);

client.cancel().await?;
let _ = server_handle.await?;
Ok(())
}