Uh oh!
There was an error while loading. Please reload this page.
fix(oauth): three oauth discovery and registration issues - #489
Merged
alexhancock merged 1 commit intoOct 21, 2025
Merged
Conversation
gpeal
commented
Oct 18, 2025
| pub client_id: String, | ||
| pub client_secret: Option<String>, | ||
| pub client_name: String, | ||
| pub client_name: Option<String>, |
ContributorAuthor
There was a problem hiding this comment.
gpeal
commented
Oct 18, 2025
| Ok(None) | ||
| } | ||
| async fn fetch_resource_metadata_url(&self) -> Result<Option<Url>, AuthError> { |
ContributorAuthor
There was a problem hiding this comment.
gpealforce-pushed
the
gpeal/www-authenticate-header
branch
from
October 18, 2025 00:49
ce3df3a to
73d4574Comparegpeal
commented
Oct 18, 2025
| Ok(token) => token, | ||
| Err(RequestTokenError::Parse(_, body)) => { | ||
| match serde_json::from_slice::<OAuthTokenResponse>(&body) { | ||
| Ok(parsed) => { |
ContributorAuthor
There was a problem hiding this comment.
Parse errors can happen during successful token exchanges
https://github.com/ramosbugs/oauth2-rs/blob/main/src/error.rs#L125
gpealforce-pushed
the
gpeal/www-authenticate-header
branch
from
October 18, 2025 00:53
73d4574 to
8704262Comparegpealforce-pushed
the
gpeal/www-authenticate-header
branch
from
October 18, 2025 00:55
8704262 to
a415b2eCompare| /// fragment. Quoted values support escaped characters (e.g. `\"`). The parser skips leading | ||
| /// whitespace before reading either a quoted or token value. If no well-formed value is found, | ||
| /// `None` is returned. | ||
| fn parse_next_header_value(header_fragment: &str) -> Option<(String, usize)> { |
Contributor
There was a problem hiding this comment.
I would do some revs on whether there are any valid header formats not handled by this parsing logic. It looks good to me for the formats I know about, but I asked our dear friend ChatGPT and it mentioned a few that might cause issues:
not sure the validity of these possibilities, and how widely used any of them would be in servers that matter, but worth doing a sanity check before merge.
alexhancock
previously approved these changes
Oct 20, 2025
alexhancock
left a comment
Contributor
There was a problem hiding this comment.
Looked over it and it LGTM
gpeal
commented
Oct 20, 2025
ContributorAuthor
I'll skip the first since it's deprecated and we'll see if any reports of popular MCPs report issues with it. I'll add support for semicolons because it's easy enough even though it's not a part of the spec. Let's punt on escaped/embedded commas in urls. Hopefully that isn't an issue in practice. |
gpealforce-pushed
the
gpeal/www-authenticate-header
branch
from
October 20, 2025 22:02
a415b2e to
6a9c393Comparealexhancock
self-requested a review
October 21, 2025 00:49
alexhancock
approved these changes
Oct 21, 2025
Uh oh!
There was an error while loading. Please reload this page.
Merged
gpeal added a commit
to openai/codex
that referenced
this pull request
Oct 21, 2025
[Release notes](https://github.com/modelcontextprotocol/rust-sdk/releases) Notably, this picks up two of my PRs that have four separate fixes for oauth dynamic client registration and auth modelcontextprotocol/rust-sdk#489modelcontextprotocol/rust-sdk#476
JeffCarpenter pushed a commit
to JeffCarpenter/codex
that referenced
this pull request
Oct 24, 2025
[Release notes](https://github.com/modelcontextprotocol/rust-sdk/releases) Notably, this picks up two of my PRs that have four separate fixes for oauth dynamic client registration and auth modelcontextprotocol/rust-sdk#489modelcontextprotocol/rust-sdk#476
DioNanos pushed a commit
to DioNanos/codex-termux
that referenced
this pull request
Nov 10, 2025
[Release notes](https://github.com/modelcontextprotocol/rust-sdk/releases) Notably, this picks up two of my PRs that have four separate fixes for oauth dynamic client registration and auth modelcontextprotocol/rust-sdk#489modelcontextprotocol/rust-sdk#476
willy3087 pushed a commit
to nextlw/elai_codex
that referenced
this pull request
Nov 14, 2025
[Release notes](https://github.com/modelcontextprotocol/rust-sdk/releases) Notably, this picks up two of my PRs that have four separate fixes for oauth dynamic client registration and auth modelcontextprotocol/rust-sdk#489modelcontextprotocol/rust-sdk#476
takumi-earth pushed a commit
to earthlings-dev/codex
that referenced
this pull request
Dec 2, 2025
[Release notes](https://github.com/modelcontextprotocol/rust-sdk/releases) Notably, this picks up two of my PRs that have four separate fixes for oauth dynamic client registration and auth modelcontextprotocol/rust-sdk#489modelcontextprotocol/rust-sdk#476
takumi-earth pushed a commit
to earthlings-dev/rmcp
that referenced
this pull request
Jan 27, 2026
monkeycode-aiBot
pushed a commit
to agogo233/Ecode
that referenced
this pull request
Jun 8, 2026
[Release notes](https://github.com/modelcontextprotocol/rust-sdk/releases) Notably, this picks up two of my PRs that have four separate fixes for oauth dynamic client registration and auth modelcontextprotocol/rust-sdk#489modelcontextprotocol/rust-sdk#476
AIALRA-0 pushed a commit
to AIALRA-0/codex-turn-engine
that referenced
this pull request
Jun 10, 2026
[Release notes](https://github.com/modelcontextprotocol/rust-sdk/releases) Notably, this picks up two of my PRs that have four separate fixes for oauth dynamic client registration and auth modelcontextprotocol/rust-sdk#489modelcontextprotocol/rust-sdk#476
shafqatevo pushed a commit
to alo-labs/kay
that referenced
this pull request
Aug 7, 2026
[Release notes](https://github.com/modelcontextprotocol/rust-sdk/releases) Notably, this picks up two of my PRs that have four separate fixes for oauth dynamic client registration and auth modelcontextprotocol/rust-sdk#489modelcontextprotocol/rust-sdk#476
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation and Context
While trying to get Supabase to login as part of openai/codex#5254, I encountered three separate oauth issues. Comments are inline
How Has This Been Tested?
Logged in to the Supabase MCP with Codex for the first time.
Sanity checked Linear, Notion, and Todoist and verified that they all still work.
Breaking Changes
None
Types of changes
Checklist