feat(elicitation) implement SEP-1330 Elicitation Enum Schema Improvements

[pbezglasny]

Implemented #524 Elicitation Enum Schema Improvements and Standards Compliance.

Motivation and Context

SEP-1330: Elicitation Enum Schema Improvements introduce new schema for enum type for elicitation. This PR implements its specifications: single/multi select options with/without titles.

Details:

• Introduced new model struct to match required schema
• Old response move to Legacy struct
• Added builder to configure enum schema
• New elicitation enum structs support default values required by Implement SEP-1034: Default Values for Elicitation Schemas #521
• Now it's possible to use next structs for elicitation request with some hacks:

#[derive(Debug,Serialize,Deserialize,JsonSchema,Default)]// inline attribute required to work for schema inference in elicitation forms#[schemars(inline)]// schemars does not provide required type field for enums, so we extend it here#[schemars(extend("type" = "string"))]enumTitledEnum{#[schemars(title = "Title for the first value")]#[default]FirstValue,#[schemars(title = "Title for the second value")]SecondValue,}#[derive(Debug,Serialize,Deserialize,JsonSchema)]// inline attribute required to work for schema inference in elicitation forms#[schemars(inline)]enumUntitledEnum{First,Second,Third,}fndefault_untitled_multi_select() -> Vec<UntitledEnum>{vec![UntitledEnum::Second,UntitledEnum::Third]}#[derive(Debug,Serialize,Deserialize,JsonSchema)]#[schemars(description = "User information")]structSelectEnumForm{pubsingle_select_untitled:UntitledEnum,#[schemars( title = "Single Select Titled", description = "Description for single select enum",default)]pubsingle_select_titled:TitledEnum,#[serde(default = "default_untitled_multi_select")]pubmulti_select_untitled:Vec<UntitledEnum>,#[schemars( title = "Multi Select Titled", description = "Multi Select Description")]pubmulti_select_titled:Vec<TitledEnum>,}

This code will serialized to specification format.

• Added new example of using enums with elicitations in elicitation_enum_inference.rs

There was another PR #537 that closed. In this PR is used standard way to parse json schema without modification using attributes of schemars

How Has This Been Tested?

Tested with mcpinspector. It correctly understands single select option for enum. But does not work with multi-select options.

Breaking Changes

• Fields in PrimitiveSchema were reordered: Enum put on the top. This due to overcome deserialization issue of serde. In details: untitled enums and string use both "type":"string" field(with additional fields for enums). Due to library uses untagged representation, for serde first match type will win. In our case if json will contain additional "enum" or "oneOf" fields it will be enum and string otherwise.

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)
• Documentation update

Checklist

• I have read the MCP Documentation
• My code follows the repository's style guidelines
• New and existing tests pass locally
• I have added appropriate error handling
• I have added or updated documentation as needed

Additional context

Closes#524

[Copilot]

Pull Request Overview

This PR implements SEP-1330 Elicitation Enum Schema Improvements to support enhanced enum selection capabilities for the MCP (Model Context Protocol) Rust SDK. The implementation adds support for single/multi-select enums with optional human-readable titles.

Key changes:

• Introduced new enum schema structures (SingleSelectEnumSchema, MultiSelectEnumSchema) with titled and untitled variants to comply with the updated specification
• Added EnumSchemaBuilder with a fluent API for configuring enum schemas including multi-select options, min/max items, and default values
• Maintained backward compatibility by preserving the legacy enum schema structure
• Enhanced JSON schema inference to automatically detect and convert enum types in structs to the appropriate elicitation schema format

Reviewed Changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 10 comments.

Show a summary per file

File	Description
examples/servers/src/elicitation_enum_inference.rs	New example demonstrating enum selection in elicitation forms with both titled and untitled single/multi-select options
examples/servers/Cargo.toml	Added example configuration for the new enum elicitation example
crates/rmcp/tests/test_message_schema/server_json_rpc_message_schema_current.json	Updated JSON schema definitions to include new enum schema structures
crates/rmcp/tests/test_message_schema/server_json_rpc_message_schema.json	Updated JSON schema definitions to include new enum schema structures
crates/rmcp/tests/test_elicitation.rs	Updated test to use new EnumSchema::builder() API instead of direct vector construction
crates/rmcp/src/model/elicitation_schema.rs	Core implementation of new enum schema types, builder pattern, and schema inference logic

Comments suppressed due to low confidence (1)

crates/rmcp/src/model/elicitation_schema.rs:953

• Debug print statement left in production code. This println! should be removed or replaced with proper logging (e.g., tracing::debug!).

 serde_json::from_value(serde_json::Value::Object(schema))

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[bug-ops]

Hi, @pbezglasny ! As I see, you've combined the implementation of #521 in this PR. I think it's worth mentioning this explicitly here.

[pbezglasny]

@bug-ops good point, thanks. I'll update PR description

[alexhancock]

@pbezglasny Sorry for the hang time on this. Would love to get it in if you can rebase/update

[pbezglasny]

@alexhancock sure, I can update the PR. I'll do it tomorrow.

[pbezglasny]

Implemented #524 Elicitation Enum Schema Improvements and Standards Compliance.

Motivation and Context

SEP-1330: Elicitation Enum Schema Improvements introduce new schema for enum type for elicitation. This PR implements its specifications: single/multi select options with/without titles.

Details:

• Introduced new model struct to match required schema
• Old response move to Legacy struct
• Added builder to configure enum schema
• New elicitation enum structs support default values required by Implement SEP-1034: Default Values for Elicitation Schemas #521
• Now it's possible to use next structs for elicitation request with some hacks:

#[derive(Debug,Serialize,Deserialize,JsonSchema,Default)]// inline attribute required to work for schema inference in elicitation forms#[schemars(inline)]// schemars does not provide required type field for enums, so we extend it here#[schemars(extend("type" = "string"))]enumTitledEnum{#[schemars(title = "Title for the first value")]#[default]FirstValue,#[schemars(title = "Title for the second value")]SecondValue,}#[derive(Debug,Serialize,Deserialize,JsonSchema)]// inline attribute required to work for schema inference in elicitation forms#[schemars(inline)]enumUntitledEnum{First,Second,Third,}fndefault_untitled_multi_select() -> Vec<UntitledEnum>{vec![UntitledEnum::Second,UntitledEnum::Third]}#[derive(Debug,Serialize,Deserialize,JsonSchema)]#[schemars(description = "User information")]structSelectEnumForm{pubsingle_select_untitled:UntitledEnum,#[schemars( title = "Single Select Titled", description = "Description for single select enum",default)]pubsingle_select_titled:TitledEnum,#[serde(default = "default_untitled_multi_select")]pubmulti_select_untitled:Vec<UntitledEnum>,#[schemars( title = "Multi Select Titled", description = "Multi Select Description")]pubmulti_select_titled:Vec<TitledEnum>,}

This code will serialized to specification format.

• Added new example of using enums with elicitations in elicitation_enum_inference.rs

There was another PR #537 that closed. In this PR is used standard way to parse json schema without modification using attributes of schemars

How Has This Been Tested?

Tested with mcpinspector. It correctly understands single select option for enum. But does not work with multi-select options.

Breaking Changes

• Fields in PrimitiveSchema were reordered: Enum put on the top. This due to overcome deserialization issue of serde. In details: untitled enums and string use both "type":"string" field(with additional fields for enums). Due to library uses untagged representation, for serde first match type will win. In our case if json will contain additional "enum" or "oneOf" fields it will be enum and string otherwise.

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)
• Documentation update

Checklist

• I have read the MCP Documentation
• My code follows the repository's style guidelines
• New and existing tests pass locally
• I have added appropriate error handling
• I have added or updated documentation as needed

Additional context

Closes#524

[Copilot]

Pull Request Overview

This PR implements SEP-1330 Elicitation Enum Schema Improvements to support enhanced enum selection capabilities for the MCP (Model Context Protocol) Rust SDK. The implementation adds support for single/multi-select enums with optional human-readable titles.

Key changes:

• Introduced new enum schema structures (SingleSelectEnumSchema, MultiSelectEnumSchema) with titled and untitled variants to comply with the updated specification
• Added EnumSchemaBuilder with a fluent API for configuring enum schemas including multi-select options, min/max items, and default values
• Maintained backward compatibility by preserving the legacy enum schema structure
• Enhanced JSON schema inference to automatically detect and convert enum types in structs to the appropriate elicitation schema format

Reviewed Changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 10 comments.

Show a summary per file

File	Description
examples/servers/src/elicitation_enum_inference.rs	New example demonstrating enum selection in elicitation forms with both titled and untitled single/multi-select options
examples/servers/Cargo.toml	Added example configuration for the new enum elicitation example
crates/rmcp/tests/test_message_schema/server_json_rpc_message_schema_current.json	Updated JSON schema definitions to include new enum schema structures
crates/rmcp/tests/test_message_schema/server_json_rpc_message_schema.json	Updated JSON schema definitions to include new enum schema structures
crates/rmcp/tests/test_elicitation.rs	Updated test to use new EnumSchema::builder() API instead of direct vector construction
crates/rmcp/src/model/elicitation_schema.rs	Core implementation of new enum schema types, builder pattern, and schema inference logic

Comments suppressed due to low confidence (1)

crates/rmcp/src/model/elicitation_schema.rs:953

• Debug print statement left in production code. This println! should be removed or replaced with proper logging (e.g., tracing::debug!).

 serde_json::from_value(serde_json::Value::Object(schema))

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[bug-ops]

Hi, @pbezglasny ! As I see, you've combined the implementation of #521 in this PR. I think it's worth mentioning this explicitly here.

[pbezglasny]

@bug-ops good point, thanks. I'll update PR description

[alexhancock]

@pbezglasny Sorry for the hang time on this. Would love to get it in if you can rebase/update

[pbezglasny]

@alexhancock sure, I can update the PR. I'll do it tomorrow.

[pbezglasny]

Implemented #524 Elicitation Enum Schema Improvements and Standards Compliance.

Motivation and Context

SEP-1330: Elicitation Enum Schema Improvements introduce new schema for enum type for elicitation. This PR implements its specifications: single/multi select options with/without titles.

Details:

• Introduced new model struct to match required schema
• Old response move to Legacy struct
• Added builder to configure enum schema
• New elicitation enum structs support default values required by Implement SEP-1034: Default Values for Elicitation Schemas #521
• Now it's possible to use next structs for elicitation request with some hacks:

#[derive(Debug,Serialize,Deserialize,JsonSchema,Default)]// inline attribute required to work for schema inference in elicitation forms#[schemars(inline)]// schemars does not provide required type field for enums, so we extend it here#[schemars(extend("type" = "string"))]enumTitledEnum{#[schemars(title = "Title for the first value")]#[default]FirstValue,#[schemars(title = "Title for the second value")]SecondValue,}#[derive(Debug,Serialize,Deserialize,JsonSchema)]// inline attribute required to work for schema inference in elicitation forms#[schemars(inline)]enumUntitledEnum{First,Second,Third,}fndefault_untitled_multi_select() -> Vec<UntitledEnum>{vec![UntitledEnum::Second,UntitledEnum::Third]}#[derive(Debug,Serialize,Deserialize,JsonSchema)]#[schemars(description = "User information")]structSelectEnumForm{pubsingle_select_untitled:UntitledEnum,#[schemars( title = "Single Select Titled", description = "Description for single select enum",default)]pubsingle_select_titled:TitledEnum,#[serde(default = "default_untitled_multi_select")]pubmulti_select_untitled:Vec<UntitledEnum>,#[schemars( title = "Multi Select Titled", description = "Multi Select Description")]pubmulti_select_titled:Vec<TitledEnum>,}

This code will serialized to specification format.

• Added new example of using enums with elicitations in elicitation_enum_inference.rs

There was another PR #537 that closed. In this PR is used standard way to parse json schema without modification using attributes of schemars

How Has This Been Tested?

Tested with mcpinspector. It correctly understands single select option for enum. But does not work with multi-select options.

Breaking Changes

• Fields in PrimitiveSchema were reordered: Enum put on the top. This due to overcome deserialization issue of serde. In details: untitled enums and string use both "type":"string" field(with additional fields for enums). Due to library uses untagged representation, for serde first match type will win. In our case if json will contain additional "enum" or "oneOf" fields it will be enum and string otherwise.

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)
• Documentation update

Checklist

• I have read the MCP Documentation
• My code follows the repository's style guidelines
• New and existing tests pass locally
• I have added appropriate error handling
• I have added or updated documentation as needed

Additional context

Closes#524

[Copilot]

Pull Request Overview

This PR implements SEP-1330 Elicitation Enum Schema Improvements to support enhanced enum selection capabilities for the MCP (Model Context Protocol) Rust SDK. The implementation adds support for single/multi-select enums with optional human-readable titles.

Key changes:

• Introduced new enum schema structures (SingleSelectEnumSchema, MultiSelectEnumSchema) with titled and untitled variants to comply with the updated specification
• Added EnumSchemaBuilder with a fluent API for configuring enum schemas including multi-select options, min/max items, and default values
• Maintained backward compatibility by preserving the legacy enum schema structure
• Enhanced JSON schema inference to automatically detect and convert enum types in structs to the appropriate elicitation schema format

Reviewed Changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 10 comments.

Show a summary per file

File	Description
examples/servers/src/elicitation_enum_inference.rs	New example demonstrating enum selection in elicitation forms with both titled and untitled single/multi-select options
examples/servers/Cargo.toml	Added example configuration for the new enum elicitation example
crates/rmcp/tests/test_message_schema/server_json_rpc_message_schema_current.json	Updated JSON schema definitions to include new enum schema structures
crates/rmcp/tests/test_message_schema/server_json_rpc_message_schema.json	Updated JSON schema definitions to include new enum schema structures
crates/rmcp/tests/test_elicitation.rs	Updated test to use new EnumSchema::builder() API instead of direct vector construction
crates/rmcp/src/model/elicitation_schema.rs	Core implementation of new enum schema types, builder pattern, and schema inference logic

Comments suppressed due to low confidence (1)

crates/rmcp/src/model/elicitation_schema.rs:953

• Debug print statement left in production code. This println! should be removed or replaced with proper logging (e.g., tracing::debug!).

 serde_json::from_value(serde_json::Value::Object(schema))

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[bug-ops]

Hi, @pbezglasny ! As I see, you've combined the implementation of #521 in this PR. I think it's worth mentioning this explicitly here.

[pbezglasny]

@bug-ops good point, thanks. I'll update PR description

[alexhancock]

@pbezglasny Sorry for the hang time on this. Would love to get it in if you can rebase/update

[pbezglasny]

@alexhancock sure, I can update the PR. I'll do it tomorrow.

[pbezglasny]

Implemented #524 Elicitation Enum Schema Improvements and Standards Compliance.

Motivation and Context

SEP-1330: Elicitation Enum Schema Improvements introduce new schema for enum type for elicitation. This PR implements its specifications: single/multi select options with/without titles.

Details:

• Introduced new model struct to match required schema
• Old response move to Legacy struct
• Added builder to configure enum schema
• New elicitation enum structs support default values required by Implement SEP-1034: Default Values for Elicitation Schemas #521
• Now it's possible to use next structs for elicitation request with some hacks:

#[derive(Debug,Serialize,Deserialize,JsonSchema,Default)]// inline attribute required to work for schema inference in elicitation forms#[schemars(inline)]// schemars does not provide required type field for enums, so we extend it here#[schemars(extend("type" = "string"))]enumTitledEnum{#[schemars(title = "Title for the first value")]#[default]FirstValue,#[schemars(title = "Title for the second value")]SecondValue,}#[derive(Debug,Serialize,Deserialize,JsonSchema)]// inline attribute required to work for schema inference in elicitation forms#[schemars(inline)]enumUntitledEnum{First,Second,Third,}fndefault_untitled_multi_select() -> Vec<UntitledEnum>{vec![UntitledEnum::Second,UntitledEnum::Third]}#[derive(Debug,Serialize,Deserialize,JsonSchema)]#[schemars(description = "User information")]structSelectEnumForm{pubsingle_select_untitled:UntitledEnum,#[schemars( title = "Single Select Titled", description = "Description for single select enum",default)]pubsingle_select_titled:TitledEnum,#[serde(default = "default_untitled_multi_select")]pubmulti_select_untitled:Vec<UntitledEnum>,#[schemars( title = "Multi Select Titled", description = "Multi Select Description")]pubmulti_select_titled:Vec<TitledEnum>,}

This code will serialized to specification format.

• Added new example of using enums with elicitations in elicitation_enum_inference.rs

There was another PR #537 that closed. In this PR is used standard way to parse json schema without modification using attributes of schemars

How Has This Been Tested?

Tested with mcpinspector. It correctly understands single select option for enum. But does not work with multi-select options.

Breaking Changes

• Fields in PrimitiveSchema were reordered: Enum put on the top. This due to overcome deserialization issue of serde. In details: untitled enums and string use both "type":"string" field(with additional fields for enums). Due to library uses untagged representation, for serde first match type will win. In our case if json will contain additional "enum" or "oneOf" fields it will be enum and string otherwise.

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)
• Documentation update

Checklist

• I have read the MCP Documentation
• My code follows the repository's style guidelines
• New and existing tests pass locally
• I have added appropriate error handling
• I have added or updated documentation as needed

Additional context

Closes#524

[Copilot]

Pull Request Overview

This PR implements SEP-1330 Elicitation Enum Schema Improvements to support enhanced enum selection capabilities for the MCP (Model Context Protocol) Rust SDK. The implementation adds support for single/multi-select enums with optional human-readable titles.

Key changes:

• Introduced new enum schema structures (SingleSelectEnumSchema, MultiSelectEnumSchema) with titled and untitled variants to comply with the updated specification
• Added EnumSchemaBuilder with a fluent API for configuring enum schemas including multi-select options, min/max items, and default values
• Maintained backward compatibility by preserving the legacy enum schema structure
• Enhanced JSON schema inference to automatically detect and convert enum types in structs to the appropriate elicitation schema format

Reviewed Changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 10 comments.

Show a summary per file

File	Description
examples/servers/src/elicitation_enum_inference.rs	New example demonstrating enum selection in elicitation forms with both titled and untitled single/multi-select options
examples/servers/Cargo.toml	Added example configuration for the new enum elicitation example
crates/rmcp/tests/test_message_schema/server_json_rpc_message_schema_current.json	Updated JSON schema definitions to include new enum schema structures
crates/rmcp/tests/test_message_schema/server_json_rpc_message_schema.json	Updated JSON schema definitions to include new enum schema structures
crates/rmcp/tests/test_elicitation.rs	Updated test to use new EnumSchema::builder() API instead of direct vector construction
crates/rmcp/src/model/elicitation_schema.rs	Core implementation of new enum schema types, builder pattern, and schema inference logic

Comments suppressed due to low confidence (1)

crates/rmcp/src/model/elicitation_schema.rs:953

• Debug print statement left in production code. This println! should be removed or replaced with proper logging (e.g., tracing::debug!).

 serde_json::from_value(serde_json::Value::Object(schema))

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[bug-ops]

Hi, @pbezglasny ! As I see, you've combined the implementation of #521 in this PR. I think it's worth mentioning this explicitly here.

[pbezglasny]

@bug-ops good point, thanks. I'll update PR description

[alexhancock]

@pbezglasny Sorry for the hang time on this. Would love to get it in if you can rebase/update

[pbezglasny]

@alexhancock sure, I can update the PR. I'll do it tomorrow.

[pbezglasny]

Implemented #524 Elicitation Enum Schema Improvements and Standards Compliance.

Motivation and Context

SEP-1330: Elicitation Enum Schema Improvements introduce new schema for enum type for elicitation. This PR implements its specifications: single/multi select options with/without titles.

Details:

• Introduced new model struct to match required schema
• Old response move to Legacy struct
• Added builder to configure enum schema
• New elicitation enum structs support default values required by Implement SEP-1034: Default Values for Elicitation Schemas #521
• Now it's possible to use next structs for elicitation request with some hacks:

#[derive(Debug,Serialize,Deserialize,JsonSchema,Default)]// inline attribute required to work for schema inference in elicitation forms#[schemars(inline)]// schemars does not provide required type field for enums, so we extend it here#[schemars(extend("type" = "string"))]enumTitledEnum{#[schemars(title = "Title for the first value")]#[default]FirstValue,#[schemars(title = "Title for the second value")]SecondValue,}#[derive(Debug,Serialize,Deserialize,JsonSchema)]// inline attribute required to work for schema inference in elicitation forms#[schemars(inline)]enumUntitledEnum{First,Second,Third,}fndefault_untitled_multi_select() -> Vec<UntitledEnum>{vec![UntitledEnum::Second,UntitledEnum::Third]}#[derive(Debug,Serialize,Deserialize,JsonSchema)]#[schemars(description = "User information")]structSelectEnumForm{pubsingle_select_untitled:UntitledEnum,#[schemars( title = "Single Select Titled", description = "Description for single select enum",default)]pubsingle_select_titled:TitledEnum,#[serde(default = "default_untitled_multi_select")]pubmulti_select_untitled:Vec<UntitledEnum>,#[schemars( title = "Multi Select Titled", description = "Multi Select Description")]pubmulti_select_titled:Vec<TitledEnum>,}

This code will serialized to specification format.

• Added new example of using enums with elicitations in elicitation_enum_inference.rs

There was another PR #537 that closed. In this PR is used standard way to parse json schema without modification using attributes of schemars

How Has This Been Tested?

Tested with mcpinspector. It correctly understands single select option for enum. But does not work with multi-select options.

Breaking Changes

• Fields in PrimitiveSchema were reordered: Enum put on the top. This due to overcome deserialization issue of serde. In details: untitled enums and string use both "type":"string" field(with additional fields for enums). Due to library uses untagged representation, for serde first match type will win. In our case if json will contain additional "enum" or "oneOf" fields it will be enum and string otherwise.

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)
• Documentation update

Checklist

• I have read the MCP Documentation
• My code follows the repository's style guidelines
• New and existing tests pass locally
• I have added appropriate error handling
• I have added or updated documentation as needed

Additional context

Closes#524

[Copilot]

Pull Request Overview

This PR implements SEP-1330 Elicitation Enum Schema Improvements to support enhanced enum selection capabilities for the MCP (Model Context Protocol) Rust SDK. The implementation adds support for single/multi-select enums with optional human-readable titles.

Key changes:

• Introduced new enum schema structures (SingleSelectEnumSchema, MultiSelectEnumSchema) with titled and untitled variants to comply with the updated specification
• Added EnumSchemaBuilder with a fluent API for configuring enum schemas including multi-select options, min/max items, and default values
• Maintained backward compatibility by preserving the legacy enum schema structure
• Enhanced JSON schema inference to automatically detect and convert enum types in structs to the appropriate elicitation schema format

Reviewed Changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 10 comments.

Show a summary per file

File	Description
examples/servers/src/elicitation_enum_inference.rs	New example demonstrating enum selection in elicitation forms with both titled and untitled single/multi-select options
examples/servers/Cargo.toml	Added example configuration for the new enum elicitation example
crates/rmcp/tests/test_message_schema/server_json_rpc_message_schema_current.json	Updated JSON schema definitions to include new enum schema structures
crates/rmcp/tests/test_message_schema/server_json_rpc_message_schema.json	Updated JSON schema definitions to include new enum schema structures
crates/rmcp/tests/test_elicitation.rs	Updated test to use new EnumSchema::builder() API instead of direct vector construction
crates/rmcp/src/model/elicitation_schema.rs	Core implementation of new enum schema types, builder pattern, and schema inference logic

Comments suppressed due to low confidence (1)

crates/rmcp/src/model/elicitation_schema.rs:953

• Debug print statement left in production code. This println! should be removed or replaced with proper logging (e.g., tracing::debug!).

 serde_json::from_value(serde_json::Value::Object(schema))

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[bug-ops]

Hi, @pbezglasny ! As I see, you've combined the implementation of #521 in this PR. I think it's worth mentioning this explicitly here.

[pbezglasny]

@bug-ops good point, thanks. I'll update PR description

[alexhancock]

@pbezglasny Sorry for the hang time on this. Would love to get it in if you can rebase/update

[pbezglasny]

@alexhancock sure, I can update the PR. I'll do it tomorrow.

[pbezglasny]

Implemented #524 Elicitation Enum Schema Improvements and Standards Compliance.

Motivation and Context

SEP-1330: Elicitation Enum Schema Improvements introduce new schema for enum type for elicitation. This PR implements its specifications: single/multi select options with/without titles.

Details:

• Introduced new model struct to match required schema
• Old response move to Legacy struct
• Added builder to configure enum schema
• New elicitation enum structs support default values required by Implement SEP-1034: Default Values for Elicitation Schemas #521
• Now it's possible to use next structs for elicitation request with some hacks:

#[derive(Debug,Serialize,Deserialize,JsonSchema,Default)]// inline attribute required to work for schema inference in elicitation forms#[schemars(inline)]// schemars does not provide required type field for enums, so we extend it here#[schemars(extend("type" = "string"))]enumTitledEnum{#[schemars(title = "Title for the first value")]#[default]FirstValue,#[schemars(title = "Title for the second value")]SecondValue,}#[derive(Debug,Serialize,Deserialize,JsonSchema)]// inline attribute required to work for schema inference in elicitation forms#[schemars(inline)]enumUntitledEnum{First,Second,Third,}fndefault_untitled_multi_select() -> Vec<UntitledEnum>{vec![UntitledEnum::Second,UntitledEnum::Third]}#[derive(Debug,Serialize,Deserialize,JsonSchema)]#[schemars(description = "User information")]structSelectEnumForm{pubsingle_select_untitled:UntitledEnum,#[schemars( title = "Single Select Titled", description = "Description for single select enum",default)]pubsingle_select_titled:TitledEnum,#[serde(default = "default_untitled_multi_select")]pubmulti_select_untitled:Vec<UntitledEnum>,#[schemars( title = "Multi Select Titled", description = "Multi Select Description")]pubmulti_select_titled:Vec<TitledEnum>,}

This code will serialized to specification format.

• Added new example of using enums with elicitations in elicitation_enum_inference.rs

There was another PR #537 that closed. In this PR is used standard way to parse json schema without modification using attributes of schemars

How Has This Been Tested?

Tested with mcpinspector. It correctly understands single select option for enum. But does not work with multi-select options.

Breaking Changes

• Fields in PrimitiveSchema were reordered: Enum put on the top. This due to overcome deserialization issue of serde. In details: untitled enums and string use both "type":"string" field(with additional fields for enums). Due to library uses untagged representation, for serde first match type will win. In our case if json will contain additional "enum" or "oneOf" fields it will be enum and string otherwise.

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)
• Documentation update

Checklist

• I have read the MCP Documentation
• My code follows the repository's style guidelines
• New and existing tests pass locally
• I have added appropriate error handling
• I have added or updated documentation as needed

Additional context

Closes#524

[Copilot]

Pull Request Overview

This PR implements SEP-1330 Elicitation Enum Schema Improvements to support enhanced enum selection capabilities for the MCP (Model Context Protocol) Rust SDK. The implementation adds support for single/multi-select enums with optional human-readable titles.

Key changes:

• Introduced new enum schema structures (SingleSelectEnumSchema, MultiSelectEnumSchema) with titled and untitled variants to comply with the updated specification
• Added EnumSchemaBuilder with a fluent API for configuring enum schemas including multi-select options, min/max items, and default values
• Maintained backward compatibility by preserving the legacy enum schema structure
• Enhanced JSON schema inference to automatically detect and convert enum types in structs to the appropriate elicitation schema format

Reviewed Changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 10 comments.

Show a summary per file

File	Description
examples/servers/src/elicitation_enum_inference.rs	New example demonstrating enum selection in elicitation forms with both titled and untitled single/multi-select options
examples/servers/Cargo.toml	Added example configuration for the new enum elicitation example
crates/rmcp/tests/test_message_schema/server_json_rpc_message_schema_current.json	Updated JSON schema definitions to include new enum schema structures
crates/rmcp/tests/test_message_schema/server_json_rpc_message_schema.json	Updated JSON schema definitions to include new enum schema structures
crates/rmcp/tests/test_elicitation.rs	Updated test to use new EnumSchema::builder() API instead of direct vector construction
crates/rmcp/src/model/elicitation_schema.rs	Core implementation of new enum schema types, builder pattern, and schema inference logic

Comments suppressed due to low confidence (1)

crates/rmcp/src/model/elicitation_schema.rs:953

• Debug print statement left in production code. This println! should be removed or replaced with proper logging (e.g., tracing::debug!).

 serde_json::from_value(serde_json::Value::Object(schema))

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[bug-ops]

Hi, @pbezglasny ! As I see, you've combined the implementation of #521 in this PR. I think it's worth mentioning this explicitly here.

[pbezglasny]

@bug-ops good point, thanks. I'll update PR description

[alexhancock]

@pbezglasny Sorry for the hang time on this. Would love to get it in if you can rebase/update

[pbezglasny]

@alexhancock sure, I can update the PR. I'll do it tomorrow.

[pbezglasny]

Implemented #524 Elicitation Enum Schema Improvements and Standards Compliance.

Motivation and Context

SEP-1330: Elicitation Enum Schema Improvements introduce new schema for enum type for elicitation. This PR implements its specifications: single/multi select options with/without titles.

Details:

• Introduced new model struct to match required schema
• Old response move to Legacy struct
• Added builder to configure enum schema
• New elicitation enum structs support default values required by Implement SEP-1034: Default Values for Elicitation Schemas #521
• Now it's possible to use next structs for elicitation request with some hacks:

#[derive(Debug,Serialize,Deserialize,JsonSchema,Default)]// inline attribute required to work for schema inference in elicitation forms#[schemars(inline)]// schemars does not provide required type field for enums, so we extend it here#[schemars(extend("type" = "string"))]enumTitledEnum{#[schemars(title = "Title for the first value")]#[default]FirstValue,#[schemars(title = "Title for the second value")]SecondValue,}#[derive(Debug,Serialize,Deserialize,JsonSchema)]// inline attribute required to work for schema inference in elicitation forms#[schemars(inline)]enumUntitledEnum{First,Second,Third,}fndefault_untitled_multi_select() -> Vec<UntitledEnum>{vec![UntitledEnum::Second,UntitledEnum::Third]}#[derive(Debug,Serialize,Deserialize,JsonSchema)]#[schemars(description = "User information")]structSelectEnumForm{pubsingle_select_untitled:UntitledEnum,#[schemars( title = "Single Select Titled", description = "Description for single select enum",default)]pubsingle_select_titled:TitledEnum,#[serde(default = "default_untitled_multi_select")]pubmulti_select_untitled:Vec<UntitledEnum>,#[schemars( title = "Multi Select Titled", description = "Multi Select Description")]pubmulti_select_titled:Vec<TitledEnum>,}

This code will serialized to specification format.

• Added new example of using enums with elicitations in elicitation_enum_inference.rs

There was another PR #537 that closed. In this PR is used standard way to parse json schema without modification using attributes of schemars

How Has This Been Tested?

Tested with mcpinspector. It correctly understands single select option for enum. But does not work with multi-select options.

Breaking Changes

• Fields in PrimitiveSchema were reordered: Enum put on the top. This due to overcome deserialization issue of serde. In details: untitled enums and string use both "type":"string" field(with additional fields for enums). Due to library uses untagged representation, for serde first match type will win. In our case if json will contain additional "enum" or "oneOf" fields it will be enum and string otherwise.

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)
• Documentation update

Checklist

• I have read the MCP Documentation
• My code follows the repository's style guidelines
• New and existing tests pass locally
• I have added appropriate error handling
• I have added or updated documentation as needed

Additional context

Closes#524

[Copilot]

Pull Request Overview

This PR implements SEP-1330 Elicitation Enum Schema Improvements to support enhanced enum selection capabilities for the MCP (Model Context Protocol) Rust SDK. The implementation adds support for single/multi-select enums with optional human-readable titles.

Key changes:

• Introduced new enum schema structures (SingleSelectEnumSchema, MultiSelectEnumSchema) with titled and untitled variants to comply with the updated specification
• Added EnumSchemaBuilder with a fluent API for configuring enum schemas including multi-select options, min/max items, and default values
• Maintained backward compatibility by preserving the legacy enum schema structure
• Enhanced JSON schema inference to automatically detect and convert enum types in structs to the appropriate elicitation schema format

Reviewed Changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 10 comments.

Show a summary per file

File	Description
examples/servers/src/elicitation_enum_inference.rs	New example demonstrating enum selection in elicitation forms with both titled and untitled single/multi-select options
examples/servers/Cargo.toml	Added example configuration for the new enum elicitation example
crates/rmcp/tests/test_message_schema/server_json_rpc_message_schema_current.json	Updated JSON schema definitions to include new enum schema structures
crates/rmcp/tests/test_message_schema/server_json_rpc_message_schema.json	Updated JSON schema definitions to include new enum schema structures
crates/rmcp/tests/test_elicitation.rs	Updated test to use new EnumSchema::builder() API instead of direct vector construction
crates/rmcp/src/model/elicitation_schema.rs	Core implementation of new enum schema types, builder pattern, and schema inference logic

Comments suppressed due to low confidence (1)

crates/rmcp/src/model/elicitation_schema.rs:953

• Debug print statement left in production code. This println! should be removed or replaced with proper logging (e.g., tracing::debug!).

 serde_json::from_value(serde_json::Value::Object(schema))

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[bug-ops]

Hi, @pbezglasny ! As I see, you've combined the implementation of #521 in this PR. I think it's worth mentioning this explicitly here.

[pbezglasny]

@bug-ops good point, thanks. I'll update PR description

[alexhancock]

@pbezglasny Sorry for the hang time on this. Would love to get it in if you can rebase/update

[pbezglasny]

@alexhancock sure, I can update the PR. I'll do it tomorrow.

[pbezglasny]

Implemented #524 Elicitation Enum Schema Improvements and Standards Compliance.

Motivation and Context

SEP-1330: Elicitation Enum Schema Improvements introduce new schema for enum type for elicitation. This PR implements its specifications: single/multi select options with/without titles.

Details:

• Introduced new model struct to match required schema
• Old response move to Legacy struct
• Added builder to configure enum schema
• New elicitation enum structs support default values required by Implement SEP-1034: Default Values for Elicitation Schemas #521
• Now it's possible to use next structs for elicitation request with some hacks:

#[derive(Debug,Serialize,Deserialize,JsonSchema,Default)]// inline attribute required to work for schema inference in elicitation forms#[schemars(inline)]// schemars does not provide required type field for enums, so we extend it here#[schemars(extend("type" = "string"))]enumTitledEnum{#[schemars(title = "Title for the first value")]#[default]FirstValue,#[schemars(title = "Title for the second value")]SecondValue,}#[derive(Debug,Serialize,Deserialize,JsonSchema)]// inline attribute required to work for schema inference in elicitation forms#[schemars(inline)]enumUntitledEnum{First,Second,Third,}fndefault_untitled_multi_select() -> Vec<UntitledEnum>{vec![UntitledEnum::Second,UntitledEnum::Third]}#[derive(Debug,Serialize,Deserialize,JsonSchema)]#[schemars(description = "User information")]structSelectEnumForm{pubsingle_select_untitled:UntitledEnum,#[schemars( title = "Single Select Titled", description = "Description for single select enum",default)]pubsingle_select_titled:TitledEnum,#[serde(default = "default_untitled_multi_select")]pubmulti_select_untitled:Vec<UntitledEnum>,#[schemars( title = "Multi Select Titled", description = "Multi Select Description")]pubmulti_select_titled:Vec<TitledEnum>,}

This code will serialized to specification format.

• Added new example of using enums with elicitations in elicitation_enum_inference.rs

There was another PR #537 that closed. In this PR is used standard way to parse json schema without modification using attributes of schemars

How Has This Been Tested?

Tested with mcpinspector. It correctly understands single select option for enum. But does not work with multi-select options.

Breaking Changes

• Fields in PrimitiveSchema were reordered: Enum put on the top. This due to overcome deserialization issue of serde. In details: untitled enums and string use both "type":"string" field(with additional fields for enums). Due to library uses untagged representation, for serde first match type will win. In our case if json will contain additional "enum" or "oneOf" fields it will be enum and string otherwise.

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)
• Documentation update

Checklist

• I have read the MCP Documentation
• My code follows the repository's style guidelines
• New and existing tests pass locally
• I have added appropriate error handling
• I have added or updated documentation as needed

Additional context

Closes#524

[Copilot]

Pull Request Overview

This PR implements SEP-1330 Elicitation Enum Schema Improvements to support enhanced enum selection capabilities for the MCP (Model Context Protocol) Rust SDK. The implementation adds support for single/multi-select enums with optional human-readable titles.

Key changes:

• Introduced new enum schema structures (SingleSelectEnumSchema, MultiSelectEnumSchema) with titled and untitled variants to comply with the updated specification
• Added EnumSchemaBuilder with a fluent API for configuring enum schemas including multi-select options, min/max items, and default values
• Maintained backward compatibility by preserving the legacy enum schema structure
• Enhanced JSON schema inference to automatically detect and convert enum types in structs to the appropriate elicitation schema format

Reviewed Changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 10 comments.

Show a summary per file

File	Description
examples/servers/src/elicitation_enum_inference.rs	New example demonstrating enum selection in elicitation forms with both titled and untitled single/multi-select options
examples/servers/Cargo.toml	Added example configuration for the new enum elicitation example
crates/rmcp/tests/test_message_schema/server_json_rpc_message_schema_current.json	Updated JSON schema definitions to include new enum schema structures
crates/rmcp/tests/test_message_schema/server_json_rpc_message_schema.json	Updated JSON schema definitions to include new enum schema structures
crates/rmcp/tests/test_elicitation.rs	Updated test to use new EnumSchema::builder() API instead of direct vector construction
crates/rmcp/src/model/elicitation_schema.rs	Core implementation of new enum schema types, builder pattern, and schema inference logic

Comments suppressed due to low confidence (1)

crates/rmcp/src/model/elicitation_schema.rs:953

• Debug print statement left in production code. This println! should be removed or replaced with proper logging (e.g., tracing::debug!).

 serde_json::from_value(serde_json::Value::Object(schema))

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[bug-ops]

Hi, @pbezglasny ! As I see, you've combined the implementation of #521 in this PR. I think it's worth mentioning this explicitly here.

[pbezglasny]

@bug-ops good point, thanks. I'll update PR description

[alexhancock]

@pbezglasny Sorry for the hang time on this. Would love to get it in if you can rebase/update

[pbezglasny]

@alexhancock sure, I can update the PR. I'll do it tomorrow.