Uh oh!
There was an error while loading. Please reload this page.
ci: add semver check job and disable release-plz semver - #765
Closed
DaleSeo wants to merge 1 commit into
Closed
Conversation
DaleSeoforce-pushed
the
ci/semver-check-config
branch
from
March 21, 2026 23:03
f2b7dd8 to
144b55fCompareDaleSeo
marked this pull request as ready for review
March 22, 2026 10:37
DaleSeo
commented
Mar 25, 2026
MemberAuthor
Closing in favor of #776 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Follow-up to #757. release-plz runs its semver analysis with all features enabled, which includes the
localfeature. Sincelocalintentionally changes the API surface (relaxing Send + Sync bounds), this causes false-positive breaking-change detections and forces a major version bump (see #747).This PR disables release-plz's built-in semver check via
release-plz.tomland adds a dedicated CI job that runscargo semver-checks --default-featuresinstead. This way, real breaking changes in the default API are still caught in CI, while the intentionallocalfeature changes don't trigger false alarms.There's an open issue to support feature selection in release-plz (release-plz/release-plz#2291), which would make this workaround unnecessary.
How Has This Been Tested?
Breaking Changes
Types of changes
Checklist
Additional context