Skip to content

fix: pass client conformance suite - #960

Merged
DaleSeo merged 5 commits into
mainfrom
fix/oauth-client-discovery-conformance
Jul 8, 2026
Merged

fix: pass client conformance suite#960
DaleSeo merged 5 commits into
mainfrom
fix/oauth-client-discovery-conformance

Conversation

@DaleSeo

@DaleSeoDaleSeo commented Jul 7, 2026

Copy link
Copy Markdown
Member

Motivation and Context

This fixes OAuth client authorization-server discovery for path-based issuers, custom protected-resource metadata locations, and legacy servers that do not publish RFC 8414 metadata. It also fixes the remaining client conformance suite gaps around SSE retry handling and auth scope harness behavior. The change keeps metadata URL protections in place, allows loopback authorization servers only for loopback resources, and expands CI to run the full 2025-11-25 client conformance suite.

How Has This Been Tested?

Run cargo build -p mcp-conformance, then run npx -y @modelcontextprotocol/conformance@0.1.16 client --command "$(pwd)/target/debug/conformance-client" --suite all --spec-version 2025-11-25 and expect 222/222 checks to pass.

Breaking Changes

No breaking changes. This is a non-breaking client-side discovery fix.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update

Checklist

  • I have read the MCP Documentation
  • My code follows the repository's style guidelines
  • New and existing tests pass locally
  • I have added appropriate error handling
  • I have added or updated documentation as needed

@github-actionsgithub-actionsBot added T-CI Changes to CI/CD workflows and configuration T-config Configuration file changes T-core Core library changes T-transport Transport layer changes labels Jul 7, 2026
@DaleSeoDaleSeo linked an issue Jul 7, 2026 that may be closed by this pull request
@DaleSeo
DaleSeo marked this pull request as ready for review July 7, 2026 00:21
@DaleSeo
DaleSeo requested a review from a team as a code ownerJuly 7, 2026 00:21
@DaleSeoDaleSeo changed the title Fix/oauth client discovery conformancefix: support oauth metadata fallbacksJul 7, 2026
@DaleSeo
DaleSeoforce-pushed the fix/oauth-client-discovery-conformance branch from 1f148d9 to 62266aeCompareJuly 7, 2026 00:23
@DaleSeoDaleSeo self-assigned this Jul 7, 2026
@DaleSeoDaleSeo changed the title fix: support oauth metadata fallbacksfix: pass client conformance suiteJul 7, 2026
alexhancock
alexhancock previously approved these changes Jul 7, 2026
@DaleSeo
DaleSeoforce-pushed the fix/oauth-client-discovery-conformance branch from f270d31 to eedbb0dCompareJuly 8, 2026 00:14
alexhancock
alexhancock previously approved these changes Jul 8, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

T-CIChanges to CI/CD workflows and configurationT-configConfiguration file changesT-coreCore library changesT-transportTransport layer changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Conformance Testing

2 participants

@DaleSeo@alexhancock