Uh oh!
There was an error while loading. Please reload this page.
Fix JSON parse error on SSE events with empty data - #1184
Merged
Conversation
commit: |
Priming events for resumability (SEP-1699) have an event ID but empty
data. The client was attempting JSON.parse("") which throws "Unexpected
end of JSON input".
Skip processing for all events with empty data, not just message events.
This handles priming events, keep-alives, and any other events that may
have empty data fields.felixweinbergerforce-pushed
the
fweinberger/fix-empty-sse-data
branch
from
November 27, 2025 19:58
2ec83ef to
f0c6062Comparemaxisbey
approved these changes
Nov 27, 2025
mattzcarey
approved these changes
Nov 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Priming events for resumability (SEP-1699) have an event ID but empty data. The client was attempting
JSON.parse("")which throws "Unexpected end of JSON input".Motivation and Context
When connecting to a server that supports SSE resumability, the server sends priming events like:
The client's SSE handler was only checking for empty data inside the
messageevent type check, but priming events may not have an explicit event type. This caused a JSON parse error on every connection to servers with resumability enabled.How Has This Been Tested?
Breaking Changes
None.
Types of changes
Checklist