') + ')', 'gi'); if (regex.test(text)) { found = true; var frag = document.createDocumentFragment(); var parts = text.split(regex); parts.forEach(function(part, i) { if (i % 2 === 0) { frag.appendChild(document.createTextNode(part)); } else { var span = document.createElement('span'); span.className = 'userscript-highlight'; span.textContent = part; frag.appendChild(span); } }); node.parentNode.replaceChild(frag, node); } }); } else if (node.nodeType === 1 && node.childNodes) { // element var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT']; if (!skipTags.includes(node.tagName)) { Array.from(node.childNodes).forEach(highlight); } } } highlight(document.body); // Re-highlight on dynamic content var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1 || node.nodeType === 3) highlight(node); }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Strip utm_, fbclid, gclid, etc. from all links on page (function() { var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content', 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid', 'ref', 'ref_src', 'source', 'medium', 'campaign']; function cleanUrl(url) { try { var u = new URL(url, window.location.origin); var changed = false; trackingParams.forEach(function(p) { if (u.searchParams.has(p)) { u.searchParams.delete(p); changed = true; } }); return changed ? u.toString() : url; } catch (e) { return url; } } function cleanLinks() { document.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } cleanLinks(); var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1) { if (node.tagName === 'A') cleanLinks(); node.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Auto-enable theater mode on YouTube (function() { function tryTheater() { var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]'); if (btn && !btn.classList.contains('activated')) { btn.click(); } } // Try immediately tryTheater(); // Try after navigation (SPA) var lastUrl = location.href; setInterval(function() { if (location.href !== lastUrl) { lastUrl = location.href; setTimeout(tryTheater, 500); } }, 1000); // Also try on player load var observer = new MutationObserver(tryTheater); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Remove or un-stick sticky/fixed headers that block content (function() { function unstick() { document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) { if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') { el.style.position = 'static'; el.style.top = 'auto'; el.style.zIndex = 'auto'; } }); } unstick(); var observer = new MutationObserver(unstick); observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] }); })(); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); })(); Support ZodObject schemas in tool method by DaleSeo · Pull Request #1310 · modelcontextprotocol/typescript-sdk · GitHub
Skip to content

Support ZodObject schemas in tool method - #1310

Closed
DaleSeo wants to merge 1 commit into
modelcontextprotocol:mainfrom
DaleSeo:tool-method-zobject-arguments
Closed

Support ZodObject schemas in tool method#1310
DaleSeo wants to merge 1 commit into
modelcontextprotocol:mainfrom
DaleSeo:tool-method-zobject-arguments

Conversation

@DaleSeo

@DaleSeoDaleSeo commented Dec 17, 2025•
edited
Loading

Copy link
Copy Markdown
Member

Fixes#1291

Motivation and Context

When using the tool() method with a ZodObject schema like z.object({ message: z.string() }), the SDK was silently treating the schema as annotations instead of a parameter schema.

How Has This Been Tested?

Added some tests to verify that the tool() method handles ZodObject schemas as expected.

Breaking Changes

No breaking changes. This is a backward-compatible bug fix.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update

Checklist

  • I have read the MCP Documentation
  • My code follows the repository's style guidelines
  • New and existing tests pass locally
  • I have added appropriate error handling
  • I have added or updated documentation as needed

Additional context

@pkg-pr-new

pkg-pr-newBot commented Dec 17, 2025•
edited
Loading

Copy link
Copy Markdown

Open in StackBlitz

npm i https://pkg.pr.new/modelcontextprotocol/typescript-sdk/@modelcontextprotocol/client@1310

npm i https://pkg.pr.new/modelcontextprotocol/typescript-sdk/@modelcontextprotocol/server@1310

commit: fae2e6b

@DaleSeo
DaleSeo marked this pull request as ready for review December 17, 2025 14:16
@DaleSeo
DaleSeo requested a review from a team as a code ownerDecember 17, 2025 14:16
@changeset-bot

changeset-botBot commented Dec 20, 2025•
edited
Loading

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: fae2e6b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@DaleSeo

DaleSeo commented Dec 22, 2025

Copy link
Copy Markdown
MemberAuthor

Hi @felixweinberger, could you take a look at this PR when you have a chance? Thanks!

@KKonstantinov

KKonstantinov commented Dec 23, 2025

Copy link
Copy Markdown
Contributor

Hello, .tool signatures will be removed in v2 effectively - please use registerTool instead (these are deprecated methods). For v1.x, these are also marked as @deprecated. Does the same issue apply to registerTool?

@DaleSeo

DaleSeo commented Dec 26, 2025•
edited
Loading

Copy link
Copy Markdown
MemberAuthor

Hi @KKonstantinov, I don't think registerTool has the same issue. The bug only affects tool because of its complex positional argument parsing logic. This fix will prevent silent failures for developers using the idiomatic z.object() syntax with the deprecated tool method until it is removed in v2.

@felixweinberger

felixweinberger commented Mar 25, 2026•
edited
Loading

Copy link
Copy Markdown
Contributor

Thanks for the thorough fix and tests, @DaleSeo! Unfortunately this has been superseded by events on main:

Since you confirmed registerTool doesn't have this bug, the underlying issue is resolved. Closing #1291 alongside this pointing users to registerTool. Appreciate your work in tracking this down.

@felixweinbergerfelixweinberger mentioned this pull request Mar 25, 2026
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Bug: server.tool() silently ignores ZodObject schemas and strips all arguments

3 participants

@DaleSeo@KKonstantinov@felixweinberger