Uh oh!
There was an error while loading. Please reload this page.
fix(server): handle undefined arguments for tools with all optional params - #1404
Conversation
|
@modelcontextprotocol/client@modelcontextprotocol/server@modelcontextprotocol/express@modelcontextprotocol/hono@modelcontextprotocol/nodecommit: |
felixweinberger
left a comment
There was a problem hiding this comment.
Thanks for the fix! This aligns with how the Python SDK handles the same case (arguments or {}).
I made a couple small changes:
- Updated the test to use
registerToolinstead of the deprecatedtoolmethod - Moved the test to
test/issues/test400.optional-tool-params.test.tsto match our pattern for regression tests
Uh oh!
There was an error while loading. Please reload this page.
… are optional Mirror the tools fix from modelcontextprotocol#1404 to the prompts handler: default undefined arguments to {} before schema validation so that a prompt with all-optional argsSchema fields accepts a request that omits arguments entirely. Closesmodelcontextprotocol#1869
Fixes#400
Motivation and Context
When a tool has all optional parameters, some LLM models call the tool without providing an
argumentsfield. This causes Zod validation to fail with:MCP error -32602: Invalid arguments for tool [name]: Invalid input: expected object, received
undefined
Even though the schema allows all fields to be optional, Zod's
z.object()expects the inputitself to be an object, not
undefinedornull.How Has This Been Tested?
should accept undefined arguments when all tool params are optionalundefined→ fails with "expected object, received undefined"null→ fails with "expected object, received null"{}→ passes validationBreaking Changes
None. This is a backward-compatible fix that only affects edge cases where
argumentsisomitted.
Types of changes
Checklist
Additional context
The fix is a single line change in
packages/server/src/server/mcp.ts: