Uh oh!
There was an error while loading. Please reload this page.
Add typings exports - #1623
Merged
KKonstantinov merged 2 commits intoMar 26, 2026
Merged
Conversation
🦋 Changeset detectedLatest commit: b80704d The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
commit: |
tdraier
commented
Mar 12, 2026
Author
@felixweinberger can you please have a look ? this is really blocking us as we need to add ugly typescript mappings to get type defs 🙏 |
KKonstantinov
approved these changes
Mar 26, 2026
Uh oh!
There was an error while loading. Please reload this page.
KKonstantinov
commented
Mar 26, 2026
Contributor
LGTM! |
9 tasks
felixweinberger pushed a commit
that referenced
this pull request
Mar 27, 2026
9 tasks
8 tasks
sbosio added a commit
to heroku/heroku-mcp-server
that referenced
this pull request
Aug 11, 2026
## Summary Dependency updates to fix multiple high security vulnerabilities reported by Dependabot on `js-yaml`. As part of the update, `@modelcontextprotocol/sdk` was updated to v1.30.0 and that required update for the imports in all files because type exports were added in v1.29.0 (see: modelcontextprotocol/typescript-sdk#1623) that didn't break building the package, but did affect linting (no-unresolved-module started to fail without changes applied). ## Type of Change ### Breaking Changes (major semver update) - [ ] Add a `!` after your change type to denote a change that breaks current behavior ### Feature Additions (minor semver update) - [ ] **feat**: Introduces a new feature to the codebase ### Patch Updates (patch semver update) - [ ] **fix**: Bug fix - [X] **deps**: Dependency upgrade - [ ] **revert**: Revert a previous commit - [ ] **chore**: Change that does not affect production code - [ ] **refactor**: Refactoring existing code without changing behavior - [ ] **test**: Add/update/remove tests ## Testing 1. Passing CI suffices. ## Related Issues Dependabot alerts: - https://github.com/heroku/heroku-mcp-server/security/dependabot/125 - https://github.com/heroku/heroku-mcp-server/security/dependabot/149 - https://github.com/heroku/heroku-mcp-server/security/dependabot/145
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation and Context
TypeScript projects using moduleResolution: "bundler" (or "node16") cannot resolve type declarations for subpath imports like @modelcontextprotocol/sdk/types or @modelcontextprotocol/sdk/shared/transport. This is because the exports map lacks "types" conditions, so TypeScript doesn't know where to find .d.ts files for these subpaths.
How Has This Been Tested?
Verified that a TypeScript project with moduleResolution: "bundler" can resolve @modelcontextprotocol/sdk/types, @modelcontextprotocol/sdk/shared/transport, and other subpath imports without needing tsconfig.json paths workarounds.
Breaking Changes
None. Adding "types" conditions is purely additive — it enables TypeScript to resolve types that previously required manual paths configuration. Existing setups using typesVersions or explicit paths will continue to work.
Types of changes
Checklist
Additional context
The "types" condition is the modern replacement for "typesVersions" and is recommended by TypeScript for packages using exports. Only the named subpaths (., ./client, ./server) and the catch-all (./) needed updating — the ./validation/ and ./experimental/* entries are covered by the ./* catch-all.