fix(client): add missing Windows env vars to DEFAULT_INHERITED_ENV_VARS - #2043

Open
ChrisJr404 wants to merge 1 commit into
modelcontextprotocol:mainfrom
ChrisJr404:fix-default-inherited-env-vars-windows
Open

fix(client): add missing Windows env vars to DEFAULT_INHERITED_ENV_VARS#2043
ChrisJr404 wants to merge 1 commit into
modelcontextprotocol:mainfrom
ChrisJr404:fix-default-inherited-env-vars-windows

Conversation

@ChrisJr404

Copy link
Copy Markdown

Closes#2037.

On Windows, DEFAULT_INHERITED_ENV_VARS is missing a few variables that common dev tooling needs. The most impactful one is PATHEXT: without it, spawn('npm', ...) (and git, python, anything else that ships as .cmd/.exe/.bat) fails with ENOENT even when PATH is set, because Node has no extensions to try.

Added to the win32 branch:

  • PATHEXT — extensions Windows treats as executable. Fix for the spawn npm ENOENT symptom in the issue.
  • COMSPEC — path to cmd.exe; needed by spawn({ shell: true }) and anything that shells out.
  • PROGRAMFILES(X86) and PROGRAMW6432 — the other two Program Files paths. Tools that resolve install locations need at least one of these depending on whether the parent is 32-bit or 64-bit.
  • WINDIR — used by some legacy tooling that doesn't accept SYSTEMROOT.

Also sorted the array so future additions are easier to eyeball.

Test

Added a small assertion in stdio.test.ts that pins the expected list per platform, so a regression on either branch fails locally. pnpm test is green (365/365) and pnpm lint/pnpm typecheck are clean.

Changeset included as a patch bump on @modelcontextprotocol/client.

@ChrisJr404
ChrisJr404 requested a review from a team as a code ownerMay 11, 2026 13:55
@changeset-bot

changeset-botBot commented May 11, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: a379b7a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 6 packages
NameType
@modelcontextprotocol/clientPatch
@modelcontextprotocol/corePatch
@modelcontextprotocol/serverPatch
@modelcontextprotocol/server-legacyPatch
@modelcontextprotocol/codemodPatch
@modelcontextprotocol/core-internalPatch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@pkg-pr-new

pkg-pr-newBot commented May 11, 2026

Copy link
Copy Markdown

Open in StackBlitz

@modelcontextprotocol/client

npm i https://pkg.pr.new/@modelcontextprotocol/client@2043

@modelcontextprotocol/codemod

npm i https://pkg.pr.new/@modelcontextprotocol/codemod@2043

@modelcontextprotocol/core

npm i https://pkg.pr.new/@modelcontextprotocol/core@2043

@modelcontextprotocol/server

npm i https://pkg.pr.new/@modelcontextprotocol/server@2043

@modelcontextprotocol/server-legacy

npm i https://pkg.pr.new/@modelcontextprotocol/server-legacy@2043

@modelcontextprotocol/express

npm i https://pkg.pr.new/@modelcontextprotocol/express@2043

@modelcontextprotocol/fastify

npm i https://pkg.pr.new/@modelcontextprotocol/fastify@2043

@modelcontextprotocol/hono

npm i https://pkg.pr.new/@modelcontextprotocol/hono@2043

@modelcontextprotocol/node

npm i https://pkg.pr.new/@modelcontextprotocol/node@2043

commit: a379b7a

@daxian-dbw

Copy link
Copy Markdown

I can confirm this issue caused troubles to starting executables from within a local stdio MCP server, such as PowerShell, GitHub CLI, and etc.

Especially that PowerShell depends on PATHEXT to discover native executables. Without that environment variable, no native executable can be discovered within PowerShell on Windows.

@jspahrsummers and @anaisbetts, I found you made the decision to not include those environment vars in #36. Could you please give some attention to this fix?

@ChrisJr404

Copy link
Copy Markdown
Author

Rebased onto main. The only conflict was in stdio.test.ts from the import refactor and the new dispose/buffer tests — stdio.ts merged cleanly, all the new env vars are intact. daxian-dbw's confirmation about PowerShell/PATHEXT matches what we saw: without PATHEXT nothing native resolves. Ready for another look.

@ChrisJr404
ChrisJr404force-pushed the fix-default-inherited-env-vars-windows branch from 8ebeb0d to a379b7aCompareAugust 17, 2026 22:08
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

DEFAULT_INHERITED_ENV_VARS

2 participants

@ChrisJr404@daxian-dbw
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
Skip to content

fix(client): add missing Windows env vars to DEFAULT_INHERITED_ENV_VARS - #2043

Open
ChrisJr404 wants to merge 1 commit into
modelcontextprotocol:mainfrom
ChrisJr404:fix-default-inherited-env-vars-windows
Open

fix(client): add missing Windows env vars to DEFAULT_INHERITED_ENV_VARS#2043
ChrisJr404 wants to merge 1 commit into
modelcontextprotocol:mainfrom
ChrisJr404:fix-default-inherited-env-vars-windows

Conversation

@ChrisJr404

Copy link
Copy Markdown

Closes#2037.

On Windows, DEFAULT_INHERITED_ENV_VARS is missing a few variables that common dev tooling needs. The most impactful one is PATHEXT: without it, spawn('npm', ...) (and git, python, anything else that ships as .cmd/.exe/.bat) fails with ENOENT even when PATH is set, because Node has no extensions to try.

Added to the win32 branch:

  • PATHEXT — extensions Windows treats as executable. Fix for the spawn npm ENOENT symptom in the issue.
  • COMSPEC — path to cmd.exe; needed by spawn({ shell: true }) and anything that shells out.
  • PROGRAMFILES(X86) and PROGRAMW6432 — the other two Program Files paths. Tools that resolve install locations need at least one of these depending on whether the parent is 32-bit or 64-bit.
  • WINDIR — used by some legacy tooling that doesn't accept SYSTEMROOT.

Also sorted the array so future additions are easier to eyeball.

Test

Added a small assertion in stdio.test.ts that pins the expected list per platform, so a regression on either branch fails locally. pnpm test is green (365/365) and pnpm lint/pnpm typecheck are clean.

Changeset included as a patch bump on @modelcontextprotocol/client.

@ChrisJr404
ChrisJr404 requested a review from a team as a code ownerMay 11, 2026 13:55
@changeset-bot

changeset-botBot commented May 11, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: a379b7a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 6 packages
NameType
@modelcontextprotocol/clientPatch
@modelcontextprotocol/corePatch
@modelcontextprotocol/serverPatch
@modelcontextprotocol/server-legacyPatch
@modelcontextprotocol/codemodPatch
@modelcontextprotocol/core-internalPatch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@pkg-pr-new

pkg-pr-newBot commented May 11, 2026

Copy link
Copy Markdown

Open in StackBlitz

@modelcontextprotocol/client

npm i https://pkg.pr.new/@modelcontextprotocol/client@2043

@modelcontextprotocol/codemod

npm i https://pkg.pr.new/@modelcontextprotocol/codemod@2043

@modelcontextprotocol/core

npm i https://pkg.pr.new/@modelcontextprotocol/core@2043

@modelcontextprotocol/server

npm i https://pkg.pr.new/@modelcontextprotocol/server@2043

@modelcontextprotocol/server-legacy

npm i https://pkg.pr.new/@modelcontextprotocol/server-legacy@2043

@modelcontextprotocol/express

npm i https://pkg.pr.new/@modelcontextprotocol/express@2043

@modelcontextprotocol/fastify

npm i https://pkg.pr.new/@modelcontextprotocol/fastify@2043

@modelcontextprotocol/hono

npm i https://pkg.pr.new/@modelcontextprotocol/hono@2043

@modelcontextprotocol/node

npm i https://pkg.pr.new/@modelcontextprotocol/node@2043

commit: a379b7a

@daxian-dbw

Copy link
Copy Markdown

I can confirm this issue caused troubles to starting executables from within a local stdio MCP server, such as PowerShell, GitHub CLI, and etc.

Especially that PowerShell depends on PATHEXT to discover native executables. Without that environment variable, no native executable can be discovered within PowerShell on Windows.

@jspahrsummers and @anaisbetts, I found you made the decision to not include those environment vars in #36. Could you please give some attention to this fix?

@ChrisJr404

Copy link
Copy Markdown
Author

Rebased onto main. The only conflict was in stdio.test.ts from the import refactor and the new dispose/buffer tests — stdio.ts merged cleanly, all the new env vars are intact. daxian-dbw's confirmation about PowerShell/PATHEXT matches what we saw: without PATHEXT nothing native resolves. Ready for another look.

@ChrisJr404
ChrisJr404force-pushed the fix-default-inherited-env-vars-windows branch from 8ebeb0d to a379b7aCompareAugust 17, 2026 22:08
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

DEFAULT_INHERITED_ENV_VARS

2 participants

@ChrisJr404@daxian-dbw
, 'i'); if (__m === '*' || __re.test(location.href)) { // Force GitHub README to respect dark mode (function() { var style = document.createElement('style'); style.textContent = ' .markdown-body { color-scheme: dark light; } .markdown-body pre { background: #161b22 !important; } .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; } .markdown-body table th, .markdown-body table td { border-color: #30363d !important; } .markdown-body img { background: #0d1117; } .markdown-body blockquote { border-left-color: #8b949e; } .markdown-body hr { border-color: #30363d; } '; document.head.appendChild(style); })(); } } catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

fix(client): add missing Windows env vars to DEFAULT_INHERITED_ENV_VARS - #2043

Open
ChrisJr404 wants to merge 1 commit into
modelcontextprotocol:mainfrom
ChrisJr404:fix-default-inherited-env-vars-windows
Open

fix(client): add missing Windows env vars to DEFAULT_INHERITED_ENV_VARS#2043
ChrisJr404 wants to merge 1 commit into
modelcontextprotocol:mainfrom
ChrisJr404:fix-default-inherited-env-vars-windows

Conversation

@ChrisJr404

Copy link
Copy Markdown

Closes#2037.

On Windows, DEFAULT_INHERITED_ENV_VARS is missing a few variables that common dev tooling needs. The most impactful one is PATHEXT: without it, spawn('npm', ...) (and git, python, anything else that ships as .cmd/.exe/.bat) fails with ENOENT even when PATH is set, because Node has no extensions to try.

Added to the win32 branch:

  • PATHEXT — extensions Windows treats as executable. Fix for the spawn npm ENOENT symptom in the issue.
  • COMSPEC — path to cmd.exe; needed by spawn({ shell: true }) and anything that shells out.
  • PROGRAMFILES(X86) and PROGRAMW6432 — the other two Program Files paths. Tools that resolve install locations need at least one of these depending on whether the parent is 32-bit or 64-bit.
  • WINDIR — used by some legacy tooling that doesn't accept SYSTEMROOT.

Also sorted the array so future additions are easier to eyeball.

Test

Added a small assertion in stdio.test.ts that pins the expected list per platform, so a regression on either branch fails locally. pnpm test is green (365/365) and pnpm lint/pnpm typecheck are clean.

Changeset included as a patch bump on @modelcontextprotocol/client.

@ChrisJr404
ChrisJr404 requested a review from a team as a code ownerMay 11, 2026 13:55
@changeset-bot

changeset-botBot commented May 11, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: a379b7a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 6 packages
NameType
@modelcontextprotocol/clientPatch
@modelcontextprotocol/corePatch
@modelcontextprotocol/serverPatch
@modelcontextprotocol/server-legacyPatch
@modelcontextprotocol/codemodPatch
@modelcontextprotocol/core-internalPatch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@pkg-pr-new

pkg-pr-newBot commented May 11, 2026

Copy link
Copy Markdown

Open in StackBlitz

@modelcontextprotocol/client

npm i https://pkg.pr.new/@modelcontextprotocol/client@2043

@modelcontextprotocol/codemod

npm i https://pkg.pr.new/@modelcontextprotocol/codemod@2043

@modelcontextprotocol/core

npm i https://pkg.pr.new/@modelcontextprotocol/core@2043

@modelcontextprotocol/server

npm i https://pkg.pr.new/@modelcontextprotocol/server@2043

@modelcontextprotocol/server-legacy

npm i https://pkg.pr.new/@modelcontextprotocol/server-legacy@2043

@modelcontextprotocol/express

npm i https://pkg.pr.new/@modelcontextprotocol/express@2043

@modelcontextprotocol/fastify

npm i https://pkg.pr.new/@modelcontextprotocol/fastify@2043

@modelcontextprotocol/hono

npm i https://pkg.pr.new/@modelcontextprotocol/hono@2043

@modelcontextprotocol/node

npm i https://pkg.pr.new/@modelcontextprotocol/node@2043

commit: a379b7a

@daxian-dbw

Copy link
Copy Markdown

I can confirm this issue caused troubles to starting executables from within a local stdio MCP server, such as PowerShell, GitHub CLI, and etc.

Especially that PowerShell depends on PATHEXT to discover native executables. Without that environment variable, no native executable can be discovered within PowerShell on Windows.

@jspahrsummers and @anaisbetts, I found you made the decision to not include those environment vars in #36. Could you please give some attention to this fix?

@ChrisJr404

Copy link
Copy Markdown
Author

Rebased onto main. The only conflict was in stdio.test.ts from the import refactor and the new dispose/buffer tests — stdio.ts merged cleanly, all the new env vars are intact. daxian-dbw's confirmation about PowerShell/PATHEXT matches what we saw: without PATHEXT nothing native resolves. Ready for another look.

@ChrisJr404
ChrisJr404force-pushed the fix-default-inherited-env-vars-windows branch from 8ebeb0d to a379b7aCompareAugust 17, 2026 22:08
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

DEFAULT_INHERITED_ENV_VARS

2 participants

@ChrisJr404@daxian-dbw
, 'i'); if (__m === '*' || __re.test(location.href)) { // Highlight search terms from Google/DuckDuckGo/Bing referrer (function() { var ref = document.referrer; var terms = []; if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) { var url = new URL(ref); var q = url.searchParams.get('q') || url.searchParams.get('p'); if (q) { terms = q.split(/\s+/).filter(function(t) { return t.length > 2; }); } } if (terms.length === 0) return; var style = document.createElement('style'); style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }'; document.head.appendChild(style); function highlight(node) { if (node.nodeType === 3) { // text node var text = node.textContent; var found = false; terms.forEach(function(term) { var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi'); if (regex.test(text)) { found = true; var frag = document.createDocumentFragment(); var parts = text.split(regex); parts.forEach(function(part, i) { if (i % 2 === 0) { frag.appendChild(document.createTextNode(part)); } else { var span = document.createElement('span'); span.className = 'userscript-highlight'; span.textContent = part; frag.appendChild(span); } }); node.parentNode.replaceChild(frag, node); } }); } else if (node.nodeType === 1 && node.childNodes) { // element var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT']; if (!skipTags.includes(node.tagName)) { Array.from(node.childNodes).forEach(highlight); } } } highlight(document.body); // Re-highlight on dynamic content var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1 || node.nodeType === 3) highlight(node); }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

fix(client): add missing Windows env vars to DEFAULT_INHERITED_ENV_VARS - #2043

Open
ChrisJr404 wants to merge 1 commit into
modelcontextprotocol:mainfrom
ChrisJr404:fix-default-inherited-env-vars-windows
Open

fix(client): add missing Windows env vars to DEFAULT_INHERITED_ENV_VARS#2043
ChrisJr404 wants to merge 1 commit into
modelcontextprotocol:mainfrom
ChrisJr404:fix-default-inherited-env-vars-windows

Conversation

@ChrisJr404

Copy link
Copy Markdown

Closes#2037.

On Windows, DEFAULT_INHERITED_ENV_VARS is missing a few variables that common dev tooling needs. The most impactful one is PATHEXT: without it, spawn('npm', ...) (and git, python, anything else that ships as .cmd/.exe/.bat) fails with ENOENT even when PATH is set, because Node has no extensions to try.

Added to the win32 branch:

  • PATHEXT — extensions Windows treats as executable. Fix for the spawn npm ENOENT symptom in the issue.
  • COMSPEC — path to cmd.exe; needed by spawn({ shell: true }) and anything that shells out.
  • PROGRAMFILES(X86) and PROGRAMW6432 — the other two Program Files paths. Tools that resolve install locations need at least one of these depending on whether the parent is 32-bit or 64-bit.
  • WINDIR — used by some legacy tooling that doesn't accept SYSTEMROOT.

Also sorted the array so future additions are easier to eyeball.

Test

Added a small assertion in stdio.test.ts that pins the expected list per platform, so a regression on either branch fails locally. pnpm test is green (365/365) and pnpm lint/pnpm typecheck are clean.

Changeset included as a patch bump on @modelcontextprotocol/client.

@ChrisJr404
ChrisJr404 requested a review from a team as a code ownerMay 11, 2026 13:55
@changeset-bot

changeset-botBot commented May 11, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: a379b7a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 6 packages
NameType
@modelcontextprotocol/clientPatch
@modelcontextprotocol/corePatch
@modelcontextprotocol/serverPatch
@modelcontextprotocol/server-legacyPatch
@modelcontextprotocol/codemodPatch
@modelcontextprotocol/core-internalPatch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@pkg-pr-new

pkg-pr-newBot commented May 11, 2026

Copy link
Copy Markdown

Open in StackBlitz

@modelcontextprotocol/client

npm i https://pkg.pr.new/@modelcontextprotocol/client@2043

@modelcontextprotocol/codemod

npm i https://pkg.pr.new/@modelcontextprotocol/codemod@2043

@modelcontextprotocol/core

npm i https://pkg.pr.new/@modelcontextprotocol/core@2043

@modelcontextprotocol/server

npm i https://pkg.pr.new/@modelcontextprotocol/server@2043

@modelcontextprotocol/server-legacy

npm i https://pkg.pr.new/@modelcontextprotocol/server-legacy@2043

@modelcontextprotocol/express

npm i https://pkg.pr.new/@modelcontextprotocol/express@2043

@modelcontextprotocol/fastify

npm i https://pkg.pr.new/@modelcontextprotocol/fastify@2043

@modelcontextprotocol/hono

npm i https://pkg.pr.new/@modelcontextprotocol/hono@2043

@modelcontextprotocol/node

npm i https://pkg.pr.new/@modelcontextprotocol/node@2043

commit: a379b7a

@daxian-dbw

Copy link
Copy Markdown

I can confirm this issue caused troubles to starting executables from within a local stdio MCP server, such as PowerShell, GitHub CLI, and etc.

Especially that PowerShell depends on PATHEXT to discover native executables. Without that environment variable, no native executable can be discovered within PowerShell on Windows.

@jspahrsummers and @anaisbetts, I found you made the decision to not include those environment vars in #36. Could you please give some attention to this fix?

@ChrisJr404

Copy link
Copy Markdown
Author

Rebased onto main. The only conflict was in stdio.test.ts from the import refactor and the new dispose/buffer tests — stdio.ts merged cleanly, all the new env vars are intact. daxian-dbw's confirmation about PowerShell/PATHEXT matches what we saw: without PATHEXT nothing native resolves. Ready for another look.

@ChrisJr404
ChrisJr404force-pushed the fix-default-inherited-env-vars-windows branch from 8ebeb0d to a379b7aCompareAugust 17, 2026 22:08
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

DEFAULT_INHERITED_ENV_VARS

2 participants

@ChrisJr404@daxian-dbw
, 'i'); if (__m === '*' || __re.test(location.href)) { // Strip utm_, fbclid, gclid, etc. from all links on page (function() { var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content', 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid', 'ref', 'ref_src', 'source', 'medium', 'campaign']; function cleanUrl(url) { try { var u = new URL(url, window.location.origin); var changed = false; trackingParams.forEach(function(p) { if (u.searchParams.has(p)) { u.searchParams.delete(p); changed = true; } }); return changed ? u.toString() : url; } catch (e) { return url; } } function cleanLinks() { document.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } cleanLinks(); var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1) { if (node.tagName === 'A') cleanLinks(); node.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + '
Skip to content

fix(client): add missing Windows env vars to DEFAULT_INHERITED_ENV_VARS - #2043

Open
ChrisJr404 wants to merge 1 commit into
modelcontextprotocol:mainfrom
ChrisJr404:fix-default-inherited-env-vars-windows
Open

fix(client): add missing Windows env vars to DEFAULT_INHERITED_ENV_VARS#2043
ChrisJr404 wants to merge 1 commit into
modelcontextprotocol:mainfrom
ChrisJr404:fix-default-inherited-env-vars-windows

Conversation

@ChrisJr404

Copy link
Copy Markdown

Closes#2037.

On Windows, DEFAULT_INHERITED_ENV_VARS is missing a few variables that common dev tooling needs. The most impactful one is PATHEXT: without it, spawn('npm', ...) (and git, python, anything else that ships as .cmd/.exe/.bat) fails with ENOENT even when PATH is set, because Node has no extensions to try.

Added to the win32 branch:

  • PATHEXT — extensions Windows treats as executable. Fix for the spawn npm ENOENT symptom in the issue.
  • COMSPEC — path to cmd.exe; needed by spawn({ shell: true }) and anything that shells out.
  • PROGRAMFILES(X86) and PROGRAMW6432 — the other two Program Files paths. Tools that resolve install locations need at least one of these depending on whether the parent is 32-bit or 64-bit.
  • WINDIR — used by some legacy tooling that doesn't accept SYSTEMROOT.

Also sorted the array so future additions are easier to eyeball.

Test

Added a small assertion in stdio.test.ts that pins the expected list per platform, so a regression on either branch fails locally. pnpm test is green (365/365) and pnpm lint/pnpm typecheck are clean.

Changeset included as a patch bump on @modelcontextprotocol/client.

@ChrisJr404
ChrisJr404 requested a review from a team as a code ownerMay 11, 2026 13:55
@changeset-bot

changeset-botBot commented May 11, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: a379b7a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 6 packages
NameType
@modelcontextprotocol/clientPatch
@modelcontextprotocol/corePatch
@modelcontextprotocol/serverPatch
@modelcontextprotocol/server-legacyPatch
@modelcontextprotocol/codemodPatch
@modelcontextprotocol/core-internalPatch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@pkg-pr-new

pkg-pr-newBot commented May 11, 2026

Copy link
Copy Markdown

Open in StackBlitz

@modelcontextprotocol/client

npm i https://pkg.pr.new/@modelcontextprotocol/client@2043

@modelcontextprotocol/codemod

npm i https://pkg.pr.new/@modelcontextprotocol/codemod@2043

@modelcontextprotocol/core

npm i https://pkg.pr.new/@modelcontextprotocol/core@2043

@modelcontextprotocol/server

npm i https://pkg.pr.new/@modelcontextprotocol/server@2043

@modelcontextprotocol/server-legacy

npm i https://pkg.pr.new/@modelcontextprotocol/server-legacy@2043

@modelcontextprotocol/express

npm i https://pkg.pr.new/@modelcontextprotocol/express@2043

@modelcontextprotocol/fastify

npm i https://pkg.pr.new/@modelcontextprotocol/fastify@2043

@modelcontextprotocol/hono

npm i https://pkg.pr.new/@modelcontextprotocol/hono@2043

@modelcontextprotocol/node

npm i https://pkg.pr.new/@modelcontextprotocol/node@2043

commit: a379b7a

@daxian-dbw

Copy link
Copy Markdown

I can confirm this issue caused troubles to starting executables from within a local stdio MCP server, such as PowerShell, GitHub CLI, and etc.

Especially that PowerShell depends on PATHEXT to discover native executables. Without that environment variable, no native executable can be discovered within PowerShell on Windows.

@jspahrsummers and @anaisbetts, I found you made the decision to not include those environment vars in #36. Could you please give some attention to this fix?

@ChrisJr404

Copy link
Copy Markdown
Author

Rebased onto main. The only conflict was in stdio.test.ts from the import refactor and the new dispose/buffer tests — stdio.ts merged cleanly, all the new env vars are intact. daxian-dbw's confirmation about PowerShell/PATHEXT matches what we saw: without PATHEXT nothing native resolves. Ready for another look.

@ChrisJr404
ChrisJr404force-pushed the fix-default-inherited-env-vars-windows branch from 8ebeb0d to a379b7aCompareAugust 17, 2026 22:08
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

DEFAULT_INHERITED_ENV_VARS

2 participants

@ChrisJr404@daxian-dbw
, 'i'); if (__m === '*' || __re.test(location.href)) { // Auto-enable theater mode on YouTube (function() { function tryTheater() { var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]'); if (btn && !btn.classList.contains('activated')) { btn.click(); } } // Try immediately tryTheater(); // Try after navigation (SPA) var lastUrl = location.href; setInterval(function() { if (location.href !== lastUrl) { lastUrl = location.href; setTimeout(tryTheater, 500); } }, 1000); // Also try on player load var observer = new MutationObserver(tryTheater); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

fix(client): add missing Windows env vars to DEFAULT_INHERITED_ENV_VARS - #2043

Open
ChrisJr404 wants to merge 1 commit into
modelcontextprotocol:mainfrom
ChrisJr404:fix-default-inherited-env-vars-windows
Open

fix(client): add missing Windows env vars to DEFAULT_INHERITED_ENV_VARS#2043
ChrisJr404 wants to merge 1 commit into
modelcontextprotocol:mainfrom
ChrisJr404:fix-default-inherited-env-vars-windows

Conversation

@ChrisJr404

Copy link
Copy Markdown

Closes#2037.

On Windows, DEFAULT_INHERITED_ENV_VARS is missing a few variables that common dev tooling needs. The most impactful one is PATHEXT: without it, spawn('npm', ...) (and git, python, anything else that ships as .cmd/.exe/.bat) fails with ENOENT even when PATH is set, because Node has no extensions to try.

Added to the win32 branch:

  • PATHEXT — extensions Windows treats as executable. Fix for the spawn npm ENOENT symptom in the issue.
  • COMSPEC — path to cmd.exe; needed by spawn({ shell: true }) and anything that shells out.
  • PROGRAMFILES(X86) and PROGRAMW6432 — the other two Program Files paths. Tools that resolve install locations need at least one of these depending on whether the parent is 32-bit or 64-bit.
  • WINDIR — used by some legacy tooling that doesn't accept SYSTEMROOT.

Also sorted the array so future additions are easier to eyeball.

Test

Added a small assertion in stdio.test.ts that pins the expected list per platform, so a regression on either branch fails locally. pnpm test is green (365/365) and pnpm lint/pnpm typecheck are clean.

Changeset included as a patch bump on @modelcontextprotocol/client.

@ChrisJr404
ChrisJr404 requested a review from a team as a code ownerMay 11, 2026 13:55
@changeset-bot

changeset-botBot commented May 11, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: a379b7a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 6 packages
NameType
@modelcontextprotocol/clientPatch
@modelcontextprotocol/corePatch
@modelcontextprotocol/serverPatch
@modelcontextprotocol/server-legacyPatch
@modelcontextprotocol/codemodPatch
@modelcontextprotocol/core-internalPatch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@pkg-pr-new

pkg-pr-newBot commented May 11, 2026

Copy link
Copy Markdown

Open in StackBlitz

@modelcontextprotocol/client

npm i https://pkg.pr.new/@modelcontextprotocol/client@2043

@modelcontextprotocol/codemod

npm i https://pkg.pr.new/@modelcontextprotocol/codemod@2043

@modelcontextprotocol/core

npm i https://pkg.pr.new/@modelcontextprotocol/core@2043

@modelcontextprotocol/server

npm i https://pkg.pr.new/@modelcontextprotocol/server@2043

@modelcontextprotocol/server-legacy

npm i https://pkg.pr.new/@modelcontextprotocol/server-legacy@2043

@modelcontextprotocol/express

npm i https://pkg.pr.new/@modelcontextprotocol/express@2043

@modelcontextprotocol/fastify

npm i https://pkg.pr.new/@modelcontextprotocol/fastify@2043

@modelcontextprotocol/hono

npm i https://pkg.pr.new/@modelcontextprotocol/hono@2043

@modelcontextprotocol/node

npm i https://pkg.pr.new/@modelcontextprotocol/node@2043

commit: a379b7a

@daxian-dbw

Copy link
Copy Markdown

I can confirm this issue caused troubles to starting executables from within a local stdio MCP server, such as PowerShell, GitHub CLI, and etc.

Especially that PowerShell depends on PATHEXT to discover native executables. Without that environment variable, no native executable can be discovered within PowerShell on Windows.

@jspahrsummers and @anaisbetts, I found you made the decision to not include those environment vars in #36. Could you please give some attention to this fix?

@ChrisJr404

Copy link
Copy Markdown
Author

Rebased onto main. The only conflict was in stdio.test.ts from the import refactor and the new dispose/buffer tests — stdio.ts merged cleanly, all the new env vars are intact. daxian-dbw's confirmation about PowerShell/PATHEXT matches what we saw: without PATHEXT nothing native resolves. Ready for another look.

@ChrisJr404
ChrisJr404force-pushed the fix-default-inherited-env-vars-windows branch from 8ebeb0d to a379b7aCompareAugust 17, 2026 22:08
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

DEFAULT_INHERITED_ENV_VARS

2 participants

@ChrisJr404@daxian-dbw
, 'i'); if (__m === '*' || __re.test(location.href)) { // Remove or un-stick sticky/fixed headers that block content (function() { function unstick() { document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) { if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') { el.style.position = 'static'; el.style.top = 'auto'; el.style.zIndex = 'auto'; } }); } unstick(); var observer = new MutationObserver(unstick); observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] }); })(); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

fix(client): add missing Windows env vars to DEFAULT_INHERITED_ENV_VARS - #2043

Open
ChrisJr404 wants to merge 1 commit into
modelcontextprotocol:mainfrom
ChrisJr404:fix-default-inherited-env-vars-windows
Open

fix(client): add missing Windows env vars to DEFAULT_INHERITED_ENV_VARS#2043
ChrisJr404 wants to merge 1 commit into
modelcontextprotocol:mainfrom
ChrisJr404:fix-default-inherited-env-vars-windows

Conversation

@ChrisJr404

Copy link
Copy Markdown

Closes#2037.

On Windows, DEFAULT_INHERITED_ENV_VARS is missing a few variables that common dev tooling needs. The most impactful one is PATHEXT: without it, spawn('npm', ...) (and git, python, anything else that ships as .cmd/.exe/.bat) fails with ENOENT even when PATH is set, because Node has no extensions to try.

Added to the win32 branch:

  • PATHEXT — extensions Windows treats as executable. Fix for the spawn npm ENOENT symptom in the issue.
  • COMSPEC — path to cmd.exe; needed by spawn({ shell: true }) and anything that shells out.
  • PROGRAMFILES(X86) and PROGRAMW6432 — the other two Program Files paths. Tools that resolve install locations need at least one of these depending on whether the parent is 32-bit or 64-bit.
  • WINDIR — used by some legacy tooling that doesn't accept SYSTEMROOT.

Also sorted the array so future additions are easier to eyeball.

Test

Added a small assertion in stdio.test.ts that pins the expected list per platform, so a regression on either branch fails locally. pnpm test is green (365/365) and pnpm lint/pnpm typecheck are clean.

Changeset included as a patch bump on @modelcontextprotocol/client.

@ChrisJr404
ChrisJr404 requested a review from a team as a code ownerMay 11, 2026 13:55
@changeset-bot

changeset-botBot commented May 11, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: a379b7a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 6 packages
NameType
@modelcontextprotocol/clientPatch
@modelcontextprotocol/corePatch
@modelcontextprotocol/serverPatch
@modelcontextprotocol/server-legacyPatch
@modelcontextprotocol/codemodPatch
@modelcontextprotocol/core-internalPatch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@pkg-pr-new

pkg-pr-newBot commented May 11, 2026

Copy link
Copy Markdown

Open in StackBlitz

@modelcontextprotocol/client

npm i https://pkg.pr.new/@modelcontextprotocol/client@2043

@modelcontextprotocol/codemod

npm i https://pkg.pr.new/@modelcontextprotocol/codemod@2043

@modelcontextprotocol/core

npm i https://pkg.pr.new/@modelcontextprotocol/core@2043

@modelcontextprotocol/server

npm i https://pkg.pr.new/@modelcontextprotocol/server@2043

@modelcontextprotocol/server-legacy

npm i https://pkg.pr.new/@modelcontextprotocol/server-legacy@2043

@modelcontextprotocol/express

npm i https://pkg.pr.new/@modelcontextprotocol/express@2043

@modelcontextprotocol/fastify

npm i https://pkg.pr.new/@modelcontextprotocol/fastify@2043

@modelcontextprotocol/hono

npm i https://pkg.pr.new/@modelcontextprotocol/hono@2043

@modelcontextprotocol/node

npm i https://pkg.pr.new/@modelcontextprotocol/node@2043

commit: a379b7a

@daxian-dbw

Copy link
Copy Markdown

I can confirm this issue caused troubles to starting executables from within a local stdio MCP server, such as PowerShell, GitHub CLI, and etc.

Especially that PowerShell depends on PATHEXT to discover native executables. Without that environment variable, no native executable can be discovered within PowerShell on Windows.

@jspahrsummers and @anaisbetts, I found you made the decision to not include those environment vars in #36. Could you please give some attention to this fix?

@ChrisJr404

Copy link
Copy Markdown
Author

Rebased onto main. The only conflict was in stdio.test.ts from the import refactor and the new dispose/buffer tests — stdio.ts merged cleanly, all the new env vars are intact. daxian-dbw's confirmation about PowerShell/PATHEXT matches what we saw: without PATHEXT nothing native resolves. Ready for another look.

@ChrisJr404
ChrisJr404force-pushed the fix-default-inherited-env-vars-windows branch from 8ebeb0d to a379b7aCompareAugust 17, 2026 22:08
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

DEFAULT_INHERITED_ENV_VARS

2 participants

@ChrisJr404@daxian-dbw
, 'i'); if (__m === '*' || __re.test(location.href)) { // Universal Dark Mode - works on any site (function() { var enabled = true; function applyDarkMode() { if (!enabled) return; // Create style element if it doesn't exist var style = document.getElementById('universal-dark-mode-style'); if (!style) { style = document.createElement('style'); style.id = 'universal-dark-mode-style'; document.head.appendChild(style); } // Dark mode CSS - inverts colors but preserves images/video style.textContent = ' /* Invert everything except media */ html { filter: invert(1) hue-rotate(180deg) !important; background: #1a1a2e !important; } /* Restore images, videos, iframes, canvas */ img, video, iframe, canvas, svg, picture, [style*="background-image"] { filter: invert(1) hue-rotate(180deg) !important; } /* Preserve specific elements that should not be inverted */ .no-dark-mode, .no-dark-mode *, [data-theme="light"], [data-theme="light"], .ace_editor, .ace_editor *, .CodeMirror, .CodeMirror *, .monaco-editor, .monaco-editor *, .markdown-body pre, .markdown-body pre *, .highlight, .highlight *, pre code, pre code * { filter: none !important; } /* Fix common UI elements */ .modal, .popup, .dropdown-menu, .tooltip, .popover { filter: invert(1) hue-rotate(180deg) !important; background: #2d2d44 !important; border-color: #444 !important; } /* Scrollbars */ ::-webkit-scrollbar { background: #1a1a2e !important; } ::-webkit-scrollbar-thumb { background: #444 !important; } ::-webkit-scrollbar-thumb:hover { background: #555 !important; } /* Selection */ ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; } ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; } '; } function removeDarkMode() { var style = document.getElementById('universal-dark-mode-style'); if (style) style.remove(); } // Toggle with Alt+Shift+D document.addEventListener('keydown', function(e) { if (e.altKey && e.shiftKey && e.key === 'D') { e.preventDefault(); enabled = !enabled; if (enabled) { applyDarkMode(); console.log('[Universal Dark Mode] Enabled'); } else { removeDarkMode(); console.log('[Universal Dark Mode] Disabled'); } } }); // Apply on load applyDarkMode(); // Re-apply on dynamic content var observer = new MutationObserver(function(mutations) { if (enabled && !document.getElementById('universal-dark-mode-style')) { applyDarkMode(); } }); observer.observe(document.head, { childList: true }); console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle'); })(); } } catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); } })(); })();
Skip to content

fix(client): add missing Windows env vars to DEFAULT_INHERITED_ENV_VARS - #2043

Open
ChrisJr404 wants to merge 1 commit into
modelcontextprotocol:mainfrom
ChrisJr404:fix-default-inherited-env-vars-windows
Open

fix(client): add missing Windows env vars to DEFAULT_INHERITED_ENV_VARS#2043
ChrisJr404 wants to merge 1 commit into
modelcontextprotocol:mainfrom
ChrisJr404:fix-default-inherited-env-vars-windows

Conversation

@ChrisJr404

Copy link
Copy Markdown

Closes#2037.

On Windows, DEFAULT_INHERITED_ENV_VARS is missing a few variables that common dev tooling needs. The most impactful one is PATHEXT: without it, spawn('npm', ...) (and git, python, anything else that ships as .cmd/.exe/.bat) fails with ENOENT even when PATH is set, because Node has no extensions to try.

Added to the win32 branch:

  • PATHEXT — extensions Windows treats as executable. Fix for the spawn npm ENOENT symptom in the issue.
  • COMSPEC — path to cmd.exe; needed by spawn({ shell: true }) and anything that shells out.
  • PROGRAMFILES(X86) and PROGRAMW6432 — the other two Program Files paths. Tools that resolve install locations need at least one of these depending on whether the parent is 32-bit or 64-bit.
  • WINDIR — used by some legacy tooling that doesn't accept SYSTEMROOT.

Also sorted the array so future additions are easier to eyeball.

Test

Added a small assertion in stdio.test.ts that pins the expected list per platform, so a regression on either branch fails locally. pnpm test is green (365/365) and pnpm lint/pnpm typecheck are clean.

Changeset included as a patch bump on @modelcontextprotocol/client.

@ChrisJr404
ChrisJr404 requested a review from a team as a code ownerMay 11, 2026 13:55
@changeset-bot

changeset-botBot commented May 11, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: a379b7a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 6 packages
NameType
@modelcontextprotocol/clientPatch
@modelcontextprotocol/corePatch
@modelcontextprotocol/serverPatch
@modelcontextprotocol/server-legacyPatch
@modelcontextprotocol/codemodPatch
@modelcontextprotocol/core-internalPatch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@pkg-pr-new

pkg-pr-newBot commented May 11, 2026

Copy link
Copy Markdown

Open in StackBlitz

@modelcontextprotocol/client

npm i https://pkg.pr.new/@modelcontextprotocol/client@2043

@modelcontextprotocol/codemod

npm i https://pkg.pr.new/@modelcontextprotocol/codemod@2043

@modelcontextprotocol/core

npm i https://pkg.pr.new/@modelcontextprotocol/core@2043

@modelcontextprotocol/server

npm i https://pkg.pr.new/@modelcontextprotocol/server@2043

@modelcontextprotocol/server-legacy

npm i https://pkg.pr.new/@modelcontextprotocol/server-legacy@2043

@modelcontextprotocol/express

npm i https://pkg.pr.new/@modelcontextprotocol/express@2043

@modelcontextprotocol/fastify

npm i https://pkg.pr.new/@modelcontextprotocol/fastify@2043

@modelcontextprotocol/hono

npm i https://pkg.pr.new/@modelcontextprotocol/hono@2043

@modelcontextprotocol/node

npm i https://pkg.pr.new/@modelcontextprotocol/node@2043

commit: a379b7a

@daxian-dbw

Copy link
Copy Markdown

I can confirm this issue caused troubles to starting executables from within a local stdio MCP server, such as PowerShell, GitHub CLI, and etc.

Especially that PowerShell depends on PATHEXT to discover native executables. Without that environment variable, no native executable can be discovered within PowerShell on Windows.

@jspahrsummers and @anaisbetts, I found you made the decision to not include those environment vars in #36. Could you please give some attention to this fix?

@ChrisJr404

Copy link
Copy Markdown
Author

Rebased onto main. The only conflict was in stdio.test.ts from the import refactor and the new dispose/buffer tests — stdio.ts merged cleanly, all the new env vars are intact. daxian-dbw's confirmation about PowerShell/PATHEXT matches what we saw: without PATHEXT nothing native resolves. Ready for another look.

@ChrisJr404
ChrisJr404force-pushed the fix-default-inherited-env-vars-windows branch from 8ebeb0d to a379b7aCompareAugust 17, 2026 22:08
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

DEFAULT_INHERITED_ENV_VARS

2 participants

@ChrisJr404@daxian-dbw