') + ')', 'gi'); if (regex.test(text)) { found = true; var frag = document.createDocumentFragment(); var parts = text.split(regex); parts.forEach(function(part, i) { if (i % 2 === 0) { frag.appendChild(document.createTextNode(part)); } else { var span = document.createElement('span'); span.className = 'userscript-highlight'; span.textContent = part; frag.appendChild(span); } }); node.parentNode.replaceChild(frag, node); } }); } else if (node.nodeType === 1 && node.childNodes) { // element var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT']; if (!skipTags.includes(node.tagName)) { Array.from(node.childNodes).forEach(highlight); } } } highlight(document.body); // Re-highlight on dynamic content var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1 || node.nodeType === 3) highlight(node); }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Strip utm_, fbclid, gclid, etc. from all links on page (function() { var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content', 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid', 'ref', 'ref_src', 'source', 'medium', 'campaign']; function cleanUrl(url) { try { var u = new URL(url, window.location.origin); var changed = false; trackingParams.forEach(function(p) { if (u.searchParams.has(p)) { u.searchParams.delete(p); changed = true; } }); return changed ? u.toString() : url; } catch (e) { return url; } } function cleanLinks() { document.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } cleanLinks(); var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1) { if (node.tagName === 'A') cleanLinks(); node.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Auto-enable theater mode on YouTube (function() { function tryTheater() { var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]'); if (btn && !btn.classList.contains('activated')) { btn.click(); } } // Try immediately tryTheater(); // Try after navigation (SPA) var lastUrl = location.href; setInterval(function() { if (location.href !== lastUrl) { lastUrl = location.href; setTimeout(tryTheater, 500); } }, 1000); // Also try on player load var observer = new MutationObserver(tryTheater); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Remove or un-stick sticky/fixed headers that block content (function() { function unstick() { document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) { if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') { el.style.position = 'static'; el.style.top = 'auto'; el.style.zIndex = 'auto'; } }); } unstick(); var observer = new MutationObserver(unstick); observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] }); })(); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); })(); fix sse endpoint path preservation by bhosmer-ant · Pull Request #504 · modelcontextprotocol/typescript-sdk · GitHub
Skip to content

fix sse endpoint path preservation - #504

Merged
bhosmer-ant merged 1 commit into
mainfrom
basil/fix_path_preservation
May 16, 2025
Merged

fix sse endpoint path preservation#504
bhosmer-ant merged 1 commit into
mainfrom
basil/fix_path_preservation

Conversation

@bhosmer-ant

@bhosmer-antbhosmer-ant commented May 16, 2025

Copy link
Copy Markdown
Contributor

Fix for the fix in #466, which was arbitrarily converting an "sse" endpoint suffix to a "messages" endpoint suffix.

Motivation and Context

bugfix

How Has This Been Tested?

updated erroneous existing test

Breaking Changes

no

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update

Checklist

  • I have read the MCP Documentation
  • My code follows the repository's style guidelines
  • New and existing tests pass locally
  • [] I have added appropriate error handling
  • I have added or updated documentation as needed

Additional context

@bhosmer-antbhosmer-ant mentioned this pull request May 16, 2025
Merged
3 tasks
@bhosmer-ant
bhosmer-ant requested a review from ihrprMay 16, 2025 21:00
jerome3o-anthropic
jerome3o-anthropic approved these changes May 16, 2025
View reviewed changes

@jerome3o-anthropicjerome3o-anthropic left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable to me

@bhosmer-ant
bhosmer-ant merged commit 6be4c60 into mainMay 16, 2025
@bhosmer-ant
bhosmer-ant deleted the basil/fix_path_preservation branch May 16, 2025 21:28
@bhosmer-antbhosmer-ant mentioned this pull request May 16, 2025
Closed
chrisdickinson
chrisdickinson reviewed May 16, 2025
View reviewed changes
Comment threadsrc/client/sse.ts
this._endpoint = new URL(messageEvent.data, this._url);

// If the original URL had a custom path, preserve it in the endpoint URL
const originalPath = this._url.pathname;

@chrisdickinsonchrisdickinsonMay 16, 2025

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this still might be incorrect, in the sense that the server can advertise any URI and expect the client to send POST messages there:

When a client connects, the server MUST send an endpoint event containing a URI for the client to use for sending messages. All subsequent client messages MUST be sent as HTTP POST requests to this endpoint.

spec link

I think the problem in modelcontextprotocol/inspector#313 et al is upstream of the client – specifically, the client should not be able to control the endpoint, but there's something in the inspector that's ignoring the correct endpoint (or the server transport is sending an incorrect endpoint value.)

@bhosmer-antbhosmer-ant mentioned this pull request May 16, 2025
Merged
@rwjblue-gleanrwjblue-glean mentioned this pull request May 19, 2025
Closed
Pizzaface pushed a commit to RewstApp/mcp-inspector that referenced this pull request Aug 20, 2025
@jerome3o-anthropic
Merge pull requestmodelcontextprotocol#504from modelcontextprotocol…
5bc0eed
…/jerome/fix/linting
Fixing linting issues from previous bug fix
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jerome3o-anthropicjerome3o-anthropicjerome3o-anthropic approved these changes
@ihrprihrprAwaiting requested review from ihrpr
+1 more reviewer
@chrisdickinsonchrisdickinsonchrisdickinson left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@bhosmer-ant@chrisdickinson@jerome3o-anthropic