Fix: Barrel file exports - #870

Closed
KKonstantinov wants to merge 11 commits into
modelcontextprotocol:mainfrom
KKonstantinov:feature/barrel-file-exports
Closed

Fix: Barrel file exports#870
KKonstantinov wants to merge 11 commits into
modelcontextprotocol:mainfrom
KKonstantinov:feature/barrel-file-exports

Conversation

@KKonstantinov

Copy link
Copy Markdown
Contributor

Extension to #851 and #511

Motivation and Context

The SDK currently exports from all files, which leads to users/implementors having to import from multiple places from the SDK.

Example:

import{StreamableHTTPServerTransport}from'@modelcontextprotocol/sdk/server/streamableHttp.js';import{McpServer}from'@modelcontextprotocol/sdk/server/mcp.js';import{isInitializeRequest,LoggingLevelSchema,SetLevelRequestSchema}from'@modelcontextprotocol/sdk/types.js';

This PR introduced index.ts barrel files under the following namespaces:

  • @modelcontextprotocol/sdk/server
  • @modelcontextprotocol/sdk/client
  • @modelcontextprotocol/sdk/shared (a new export added to package.json)

The above snippet would now look like:

import{StreamableHTTPServerTransport,McpServer}from'@modelcontextprotocol/sdk/server';import{isInitializeRequest,LoggingLevelSchema,SetLevelRequestSchema}from'@modelcontextprotocol/sdk/shared';

How Has This Been Tested?

Unit tests continue to run with no issues.

Breaking Changes

No, it's an improvement and not a breaking change.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update

Checklist

  • I have read the MCP Documentation
  • My code follows the repository's style guidelines
  • New and existing tests pass locally
  • I have added appropriate error handling
  • I have added or updated documentation as needed

Additional context

There are two files which were a bit controversial "./types.ts", and "./inMemory.ts". These are currently residing at the root level, although they are really "shared". Thus the shared namespace is re-exporting them.

Additionally, the previous client/index.ts contents was moved to client/client.ts and server/index.ts was moved to server/server.ts respectively. Since these two files are now re-exported by the index.ts files, there is no breaking change.

@KKonstantinov

KKonstantinov commented Aug 12, 2025

Copy link
Copy Markdown
ContributorAuthor

@cliffhall@ihrpr this is an extension to #851

@cliffhall

cliffhall commented Aug 12, 2025

Copy link
Copy Markdown
Member

This looks good to me in this view. One important thing for reviewers to do is make certain that the new server.ts and client.ts files contain exactly what their previous index.ts counterparts previously did. This is hard to do in the Files Changed diff view. It will have to be done locally in the IDE comparing to the historical content. I would do this now, but I have to prepare for a meeting.

@ihrprihrpr added this to the v2 milestone Aug 18, 2025
@ihrpr

Copy link
Copy Markdown
Contributor

Let's include it in V2

@ihrprihrpr mentioned this pull request Aug 18, 2025
Closed
23 tasks
@cliffhall

Copy link
Copy Markdown
Member

Let's include it in V2

@ihrpr maybe we could add a v2-feature label for PRs like this one.

@ihrpr

Copy link
Copy Markdown
Contributor

Let's include it in V2

@ihrpr maybe we could add a v2-feature label for PRs like this one.

I'm marking those PRs with V2 milestone

@joelachance

Copy link
Copy Markdown

I came here to open this PR :)

Thanks for doing this.
One suggestion, it's not clear to me what would be contained in 'shared'. Are those all types? If that's the case, I'd argue to continue using '/sdk/types'

@KKonstantinov

Copy link
Copy Markdown
ContributorAuthor

I have to say I was thinking of /sdk/types myself before comitting...

But if you do look at it, it really isn't just types that's in there.

The current sdk v1 unfortunately mixes types and runtime code in files. So even in your types.ts you will find runtime code.

And other files that are exported (from the shared folder) certainly have loads of runtime (and id say much more runtime than types)

Exporting something via /sdk/types "implies" as a user I would be able to put that in devDependencies let's say, or alternatively to be importing it via "import type * from @modelcontextprotocol/sdk/types". However its not the case here due to the majority of the code being runtime and not just types..

We could, still decide to do it via /sdk/types however I dont think the regular user will expect that, given what it actually contains. (Classes, schemas, methods etc. as opposed to the expectation implied which is it should be just types, interfaces etc)

I came here to open this PR :)

Thanks for doing this.
One suggestion, it's not clear to me what would be contained in 'shared'. Are those all types? If that's the case, I'd argue to continue using '/sdk/types'

@joelachance

Copy link
Copy Markdown

Exporting something via /sdk/types "implies" as a user I would be able to put that in devDependencies let's say, or alternatively to be importing it via "import type * from @modelcontextprotocol/sdk/types". However its not the case here due to the majority of the code being runtime and not just types..

We could, still decide to do it via /sdk/types however I dont think the regular user will expect that, given what it actually contains. (Classes, schemas, methods etc. as opposed to the expectation implied which is it should be just types, interfaces etc)

I have seen types 'mixed in' with everything else in other libraries, but I'm not sure I like it. There's no indicators (that I know of) that give you the hint that you could pull in something like:

import { type LoggingLevelSchema } from '@mcp/sdk'

To your point, and maybe eventually, there is an sdk/types but it only contains types and interfaces, and the rest to live in a /runtime or /shared.

Anyway, I'm not sure I have a horse in this race, but glad it's being worked on :)

@KKonstantinov

Copy link
Copy Markdown
ContributorAuthor

Due to prettier's merge, there's conflicts here which I'll resolve.

But there's another decision point here to make.

In package.json, we've got:

".": {
"import": "./dist/esm/index.js",
"require": "./dist/cjs/index.js"
}

Which is a non-existent file. So that has to be removed. Since exporting from /server and /client is already a fact, we couldn't go back to exporting just from @modelcontextprotocol/sdk because that would constitute a huge breaking change.

We also mustn't export the same files from both @modelcontextprotocol/sdk and /client or /server (or /shared), because that will end up being super confusing - stuff should get exported in an expected, standardized way and not duplicate exports.

Thus our option for now if we dont want breaking changes is to just remove the main export.

@KKonstantinov

KKonstantinov commented Oct 15, 2025

Copy link
Copy Markdown
ContributorAuthor

This has accumulated conflicts over time.

cc @ihrpr when we are close to doing the v2 milestone, I'll resolve all of them.

@cliffhall

Copy link
Copy Markdown
Member

This has accumulated conflicts over time.

cc @ihrpr when we are close to doing the v2 milestone, I'll resolve all of them.

Could you make this a draft for now?

@KKonstantinov
KKonstantinov requested review from a team as code ownersOctober 31, 2025 08:03
@KKonstantinov

Copy link
Copy Markdown
ContributorAuthor

Now up to date with main.

Have further removed the import that is breaking things for various people (and does not exist).

".": {
"import": "./dist/esm/index.js",
"require": "./dist/cjs/index.js"
}

I could see this being raised in more issues, maybe we could plan on when to release it? It does constitute breaking changes, so it'd have to be in a major version, v2 or else.

ECHO-HELLO-WORLD424 added a commit to ECHO-HELLO-WORLD424/neuropilot that referenced this pull request Nov 9, 2025
@pkg-pr-new

pkg-pr-newBot commented Nov 9, 2025

Copy link
Copy Markdown

Open in StackBlitz

npm i https://pkg.pr.new/modelcontextprotocol/typescript-sdk/@modelcontextprotocol/sdk@870

commit: 5957da3

Comment threadsrc/server/server.ts Outdated

protected assertRequestHandlerCapability(method: string): void {
switch (method) {
case 'sampling/createMessage':

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. This didn't belong here :)

@felixweinberger

felixweinberger commented Dec 19, 2025

Copy link
Copy Markdown
Contributor

Going through old PRs right now if anything can be cleaned up.

@KKonstantinov I think we can close this out now that we landed your monorepo refactor in #1279 which solves this problem right?

Feel free to reopen if you still wanted to land a version of this in v1.x though!

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@KKonstantinov@cliffhall@ihrpr@joelachance@felixweinberger
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
Skip to content

Fix: Barrel file exports - #870

Closed
KKonstantinov wants to merge 11 commits into
modelcontextprotocol:mainfrom
KKonstantinov:feature/barrel-file-exports
Closed

Fix: Barrel file exports#870
KKonstantinov wants to merge 11 commits into
modelcontextprotocol:mainfrom
KKonstantinov:feature/barrel-file-exports

Conversation

@KKonstantinov

Copy link
Copy Markdown
Contributor

Extension to #851 and #511

Motivation and Context

The SDK currently exports from all files, which leads to users/implementors having to import from multiple places from the SDK.

Example:

import{StreamableHTTPServerTransport}from'@modelcontextprotocol/sdk/server/streamableHttp.js';import{McpServer}from'@modelcontextprotocol/sdk/server/mcp.js';import{isInitializeRequest,LoggingLevelSchema,SetLevelRequestSchema}from'@modelcontextprotocol/sdk/types.js';

This PR introduced index.ts barrel files under the following namespaces:

  • @modelcontextprotocol/sdk/server
  • @modelcontextprotocol/sdk/client
  • @modelcontextprotocol/sdk/shared (a new export added to package.json)

The above snippet would now look like:

import{StreamableHTTPServerTransport,McpServer}from'@modelcontextprotocol/sdk/server';import{isInitializeRequest,LoggingLevelSchema,SetLevelRequestSchema}from'@modelcontextprotocol/sdk/shared';

How Has This Been Tested?

Unit tests continue to run with no issues.

Breaking Changes

No, it's an improvement and not a breaking change.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update

Checklist

  • I have read the MCP Documentation
  • My code follows the repository's style guidelines
  • New and existing tests pass locally
  • I have added appropriate error handling
  • I have added or updated documentation as needed

Additional context

There are two files which were a bit controversial "./types.ts", and "./inMemory.ts". These are currently residing at the root level, although they are really "shared". Thus the shared namespace is re-exporting them.

Additionally, the previous client/index.ts contents was moved to client/client.ts and server/index.ts was moved to server/server.ts respectively. Since these two files are now re-exported by the index.ts files, there is no breaking change.

@KKonstantinov

KKonstantinov commented Aug 12, 2025

Copy link
Copy Markdown
ContributorAuthor

@cliffhall@ihrpr this is an extension to #851

@cliffhall

cliffhall commented Aug 12, 2025

Copy link
Copy Markdown
Member

This looks good to me in this view. One important thing for reviewers to do is make certain that the new server.ts and client.ts files contain exactly what their previous index.ts counterparts previously did. This is hard to do in the Files Changed diff view. It will have to be done locally in the IDE comparing to the historical content. I would do this now, but I have to prepare for a meeting.

@ihrprihrpr added this to the v2 milestone Aug 18, 2025
@ihrpr

Copy link
Copy Markdown
Contributor

Let's include it in V2

@ihrprihrpr mentioned this pull request Aug 18, 2025
Closed
23 tasks
@cliffhall

Copy link
Copy Markdown
Member

Let's include it in V2

@ihrpr maybe we could add a v2-feature label for PRs like this one.

@ihrpr

Copy link
Copy Markdown
Contributor

Let's include it in V2

@ihrpr maybe we could add a v2-feature label for PRs like this one.

I'm marking those PRs with V2 milestone

@joelachance

Copy link
Copy Markdown

I came here to open this PR :)

Thanks for doing this.
One suggestion, it's not clear to me what would be contained in 'shared'. Are those all types? If that's the case, I'd argue to continue using '/sdk/types'

@KKonstantinov

Copy link
Copy Markdown
ContributorAuthor

I have to say I was thinking of /sdk/types myself before comitting...

But if you do look at it, it really isn't just types that's in there.

The current sdk v1 unfortunately mixes types and runtime code in files. So even in your types.ts you will find runtime code.

And other files that are exported (from the shared folder) certainly have loads of runtime (and id say much more runtime than types)

Exporting something via /sdk/types "implies" as a user I would be able to put that in devDependencies let's say, or alternatively to be importing it via "import type * from @modelcontextprotocol/sdk/types". However its not the case here due to the majority of the code being runtime and not just types..

We could, still decide to do it via /sdk/types however I dont think the regular user will expect that, given what it actually contains. (Classes, schemas, methods etc. as opposed to the expectation implied which is it should be just types, interfaces etc)

I came here to open this PR :)

Thanks for doing this.
One suggestion, it's not clear to me what would be contained in 'shared'. Are those all types? If that's the case, I'd argue to continue using '/sdk/types'

@joelachance

Copy link
Copy Markdown

Exporting something via /sdk/types "implies" as a user I would be able to put that in devDependencies let's say, or alternatively to be importing it via "import type * from @modelcontextprotocol/sdk/types". However its not the case here due to the majority of the code being runtime and not just types..

We could, still decide to do it via /sdk/types however I dont think the regular user will expect that, given what it actually contains. (Classes, schemas, methods etc. as opposed to the expectation implied which is it should be just types, interfaces etc)

I have seen types 'mixed in' with everything else in other libraries, but I'm not sure I like it. There's no indicators (that I know of) that give you the hint that you could pull in something like:

import { type LoggingLevelSchema } from '@mcp/sdk'

To your point, and maybe eventually, there is an sdk/types but it only contains types and interfaces, and the rest to live in a /runtime or /shared.

Anyway, I'm not sure I have a horse in this race, but glad it's being worked on :)

@KKonstantinov

Copy link
Copy Markdown
ContributorAuthor

Due to prettier's merge, there's conflicts here which I'll resolve.

But there's another decision point here to make.

In package.json, we've got:

".": {
"import": "./dist/esm/index.js",
"require": "./dist/cjs/index.js"
}

Which is a non-existent file. So that has to be removed. Since exporting from /server and /client is already a fact, we couldn't go back to exporting just from @modelcontextprotocol/sdk because that would constitute a huge breaking change.

We also mustn't export the same files from both @modelcontextprotocol/sdk and /client or /server (or /shared), because that will end up being super confusing - stuff should get exported in an expected, standardized way and not duplicate exports.

Thus our option for now if we dont want breaking changes is to just remove the main export.

@KKonstantinov

KKonstantinov commented Oct 15, 2025

Copy link
Copy Markdown
ContributorAuthor

This has accumulated conflicts over time.

cc @ihrpr when we are close to doing the v2 milestone, I'll resolve all of them.

@cliffhall

Copy link
Copy Markdown
Member

This has accumulated conflicts over time.

cc @ihrpr when we are close to doing the v2 milestone, I'll resolve all of them.

Could you make this a draft for now?

@KKonstantinov
KKonstantinov requested review from a team as code ownersOctober 31, 2025 08:03
@KKonstantinov

Copy link
Copy Markdown
ContributorAuthor

Now up to date with main.

Have further removed the import that is breaking things for various people (and does not exist).

".": {
"import": "./dist/esm/index.js",
"require": "./dist/cjs/index.js"
}

I could see this being raised in more issues, maybe we could plan on when to release it? It does constitute breaking changes, so it'd have to be in a major version, v2 or else.

ECHO-HELLO-WORLD424 added a commit to ECHO-HELLO-WORLD424/neuropilot that referenced this pull request Nov 9, 2025
@pkg-pr-new

pkg-pr-newBot commented Nov 9, 2025

Copy link
Copy Markdown

Open in StackBlitz

npm i https://pkg.pr.new/modelcontextprotocol/typescript-sdk/@modelcontextprotocol/sdk@870

commit: 5957da3

Comment threadsrc/server/server.ts Outdated

protected assertRequestHandlerCapability(method: string): void {
switch (method) {
case 'sampling/createMessage':

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. This didn't belong here :)

@felixweinberger

felixweinberger commented Dec 19, 2025

Copy link
Copy Markdown
Contributor

Going through old PRs right now if anything can be cleaned up.

@KKonstantinov I think we can close this out now that we landed your monorepo refactor in #1279 which solves this problem right?

Feel free to reopen if you still wanted to land a version of this in v1.x though!

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@KKonstantinov@cliffhall@ihrpr@joelachance@felixweinberger
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix"); } } catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

Fix: Barrel file exports - #870

Closed
KKonstantinov wants to merge 11 commits into
modelcontextprotocol:mainfrom
KKonstantinov:feature/barrel-file-exports
Closed

Fix: Barrel file exports#870
KKonstantinov wants to merge 11 commits into
modelcontextprotocol:mainfrom
KKonstantinov:feature/barrel-file-exports

Conversation

@KKonstantinov

Copy link
Copy Markdown
Contributor

Extension to #851 and #511

Motivation and Context

The SDK currently exports from all files, which leads to users/implementors having to import from multiple places from the SDK.

Example:

import{StreamableHTTPServerTransport}from'@modelcontextprotocol/sdk/server/streamableHttp.js';import{McpServer}from'@modelcontextprotocol/sdk/server/mcp.js';import{isInitializeRequest,LoggingLevelSchema,SetLevelRequestSchema}from'@modelcontextprotocol/sdk/types.js';

This PR introduced index.ts barrel files under the following namespaces:

  • @modelcontextprotocol/sdk/server
  • @modelcontextprotocol/sdk/client
  • @modelcontextprotocol/sdk/shared (a new export added to package.json)

The above snippet would now look like:

import{StreamableHTTPServerTransport,McpServer}from'@modelcontextprotocol/sdk/server';import{isInitializeRequest,LoggingLevelSchema,SetLevelRequestSchema}from'@modelcontextprotocol/sdk/shared';

How Has This Been Tested?

Unit tests continue to run with no issues.

Breaking Changes

No, it's an improvement and not a breaking change.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update

Checklist

  • I have read the MCP Documentation
  • My code follows the repository's style guidelines
  • New and existing tests pass locally
  • I have added appropriate error handling
  • I have added or updated documentation as needed

Additional context

There are two files which were a bit controversial "./types.ts", and "./inMemory.ts". These are currently residing at the root level, although they are really "shared". Thus the shared namespace is re-exporting them.

Additionally, the previous client/index.ts contents was moved to client/client.ts and server/index.ts was moved to server/server.ts respectively. Since these two files are now re-exported by the index.ts files, there is no breaking change.

@KKonstantinov

KKonstantinov commented Aug 12, 2025

Copy link
Copy Markdown
ContributorAuthor

@cliffhall@ihrpr this is an extension to #851

@cliffhall

cliffhall commented Aug 12, 2025

Copy link
Copy Markdown
Member

This looks good to me in this view. One important thing for reviewers to do is make certain that the new server.ts and client.ts files contain exactly what their previous index.ts counterparts previously did. This is hard to do in the Files Changed diff view. It will have to be done locally in the IDE comparing to the historical content. I would do this now, but I have to prepare for a meeting.

@ihrprihrpr added this to the v2 milestone Aug 18, 2025
@ihrpr

Copy link
Copy Markdown
Contributor

Let's include it in V2

@ihrprihrpr mentioned this pull request Aug 18, 2025
Closed
23 tasks
@cliffhall

Copy link
Copy Markdown
Member

Let's include it in V2

@ihrpr maybe we could add a v2-feature label for PRs like this one.

@ihrpr

Copy link
Copy Markdown
Contributor

Let's include it in V2

@ihrpr maybe we could add a v2-feature label for PRs like this one.

I'm marking those PRs with V2 milestone

@joelachance

Copy link
Copy Markdown

I came here to open this PR :)

Thanks for doing this.
One suggestion, it's not clear to me what would be contained in 'shared'. Are those all types? If that's the case, I'd argue to continue using '/sdk/types'

@KKonstantinov

Copy link
Copy Markdown
ContributorAuthor

I have to say I was thinking of /sdk/types myself before comitting...

But if you do look at it, it really isn't just types that's in there.

The current sdk v1 unfortunately mixes types and runtime code in files. So even in your types.ts you will find runtime code.

And other files that are exported (from the shared folder) certainly have loads of runtime (and id say much more runtime than types)

Exporting something via /sdk/types "implies" as a user I would be able to put that in devDependencies let's say, or alternatively to be importing it via "import type * from @modelcontextprotocol/sdk/types". However its not the case here due to the majority of the code being runtime and not just types..

We could, still decide to do it via /sdk/types however I dont think the regular user will expect that, given what it actually contains. (Classes, schemas, methods etc. as opposed to the expectation implied which is it should be just types, interfaces etc)

I came here to open this PR :)

Thanks for doing this.
One suggestion, it's not clear to me what would be contained in 'shared'. Are those all types? If that's the case, I'd argue to continue using '/sdk/types'

@joelachance

Copy link
Copy Markdown

Exporting something via /sdk/types "implies" as a user I would be able to put that in devDependencies let's say, or alternatively to be importing it via "import type * from @modelcontextprotocol/sdk/types". However its not the case here due to the majority of the code being runtime and not just types..

We could, still decide to do it via /sdk/types however I dont think the regular user will expect that, given what it actually contains. (Classes, schemas, methods etc. as opposed to the expectation implied which is it should be just types, interfaces etc)

I have seen types 'mixed in' with everything else in other libraries, but I'm not sure I like it. There's no indicators (that I know of) that give you the hint that you could pull in something like:

import { type LoggingLevelSchema } from '@mcp/sdk'

To your point, and maybe eventually, there is an sdk/types but it only contains types and interfaces, and the rest to live in a /runtime or /shared.

Anyway, I'm not sure I have a horse in this race, but glad it's being worked on :)

@KKonstantinov

Copy link
Copy Markdown
ContributorAuthor

Due to prettier's merge, there's conflicts here which I'll resolve.

But there's another decision point here to make.

In package.json, we've got:

".": {
"import": "./dist/esm/index.js",
"require": "./dist/cjs/index.js"
}

Which is a non-existent file. So that has to be removed. Since exporting from /server and /client is already a fact, we couldn't go back to exporting just from @modelcontextprotocol/sdk because that would constitute a huge breaking change.

We also mustn't export the same files from both @modelcontextprotocol/sdk and /client or /server (or /shared), because that will end up being super confusing - stuff should get exported in an expected, standardized way and not duplicate exports.

Thus our option for now if we dont want breaking changes is to just remove the main export.

@KKonstantinov

KKonstantinov commented Oct 15, 2025

Copy link
Copy Markdown
ContributorAuthor

This has accumulated conflicts over time.

cc @ihrpr when we are close to doing the v2 milestone, I'll resolve all of them.

@cliffhall

Copy link
Copy Markdown
Member

This has accumulated conflicts over time.

cc @ihrpr when we are close to doing the v2 milestone, I'll resolve all of them.

Could you make this a draft for now?

@KKonstantinov
KKonstantinov requested review from a team as code ownersOctober 31, 2025 08:03
@KKonstantinov

Copy link
Copy Markdown
ContributorAuthor

Now up to date with main.

Have further removed the import that is breaking things for various people (and does not exist).

".": {
"import": "./dist/esm/index.js",
"require": "./dist/cjs/index.js"
}

I could see this being raised in more issues, maybe we could plan on when to release it? It does constitute breaking changes, so it'd have to be in a major version, v2 or else.

ECHO-HELLO-WORLD424 added a commit to ECHO-HELLO-WORLD424/neuropilot that referenced this pull request Nov 9, 2025
@pkg-pr-new

pkg-pr-newBot commented Nov 9, 2025

Copy link
Copy Markdown

Open in StackBlitz

npm i https://pkg.pr.new/modelcontextprotocol/typescript-sdk/@modelcontextprotocol/sdk@870

commit: 5957da3

Comment threadsrc/server/server.ts Outdated

protected assertRequestHandlerCapability(method: string): void {
switch (method) {
case 'sampling/createMessage':

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. This didn't belong here :)

@felixweinberger

felixweinberger commented Dec 19, 2025

Copy link
Copy Markdown
Contributor

Going through old PRs right now if anything can be cleaned up.

@KKonstantinov I think we can close this out now that we landed your monorepo refactor in #1279 which solves this problem right?

Feel free to reopen if you still wanted to land a version of this in v1.x though!

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@KKonstantinov@cliffhall@ihrpr@joelachance@felixweinberger
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms"); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

Fix: Barrel file exports - #870

Closed
KKonstantinov wants to merge 11 commits into
modelcontextprotocol:mainfrom
KKonstantinov:feature/barrel-file-exports
Closed

Fix: Barrel file exports#870
KKonstantinov wants to merge 11 commits into
modelcontextprotocol:mainfrom
KKonstantinov:feature/barrel-file-exports

Conversation

@KKonstantinov

Copy link
Copy Markdown
Contributor

Extension to #851 and #511

Motivation and Context

The SDK currently exports from all files, which leads to users/implementors having to import from multiple places from the SDK.

Example:

import{StreamableHTTPServerTransport}from'@modelcontextprotocol/sdk/server/streamableHttp.js';import{McpServer}from'@modelcontextprotocol/sdk/server/mcp.js';import{isInitializeRequest,LoggingLevelSchema,SetLevelRequestSchema}from'@modelcontextprotocol/sdk/types.js';

This PR introduced index.ts barrel files under the following namespaces:

  • @modelcontextprotocol/sdk/server
  • @modelcontextprotocol/sdk/client
  • @modelcontextprotocol/sdk/shared (a new export added to package.json)

The above snippet would now look like:

import{StreamableHTTPServerTransport,McpServer}from'@modelcontextprotocol/sdk/server';import{isInitializeRequest,LoggingLevelSchema,SetLevelRequestSchema}from'@modelcontextprotocol/sdk/shared';

How Has This Been Tested?

Unit tests continue to run with no issues.

Breaking Changes

No, it's an improvement and not a breaking change.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update

Checklist

  • I have read the MCP Documentation
  • My code follows the repository's style guidelines
  • New and existing tests pass locally
  • I have added appropriate error handling
  • I have added or updated documentation as needed

Additional context

There are two files which were a bit controversial "./types.ts", and "./inMemory.ts". These are currently residing at the root level, although they are really "shared". Thus the shared namespace is re-exporting them.

Additionally, the previous client/index.ts contents was moved to client/client.ts and server/index.ts was moved to server/server.ts respectively. Since these two files are now re-exported by the index.ts files, there is no breaking change.

@KKonstantinov

KKonstantinov commented Aug 12, 2025

Copy link
Copy Markdown
ContributorAuthor

@cliffhall@ihrpr this is an extension to #851

@cliffhall

cliffhall commented Aug 12, 2025

Copy link
Copy Markdown
Member

This looks good to me in this view. One important thing for reviewers to do is make certain that the new server.ts and client.ts files contain exactly what their previous index.ts counterparts previously did. This is hard to do in the Files Changed diff view. It will have to be done locally in the IDE comparing to the historical content. I would do this now, but I have to prepare for a meeting.

@ihrprihrpr added this to the v2 milestone Aug 18, 2025
@ihrpr

Copy link
Copy Markdown
Contributor

Let's include it in V2

@ihrprihrpr mentioned this pull request Aug 18, 2025
Closed
23 tasks
@cliffhall

Copy link
Copy Markdown
Member

Let's include it in V2

@ihrpr maybe we could add a v2-feature label for PRs like this one.

@ihrpr

Copy link
Copy Markdown
Contributor

Let's include it in V2

@ihrpr maybe we could add a v2-feature label for PRs like this one.

I'm marking those PRs with V2 milestone

@joelachance

Copy link
Copy Markdown

I came here to open this PR :)

Thanks for doing this.
One suggestion, it's not clear to me what would be contained in 'shared'. Are those all types? If that's the case, I'd argue to continue using '/sdk/types'

@KKonstantinov

Copy link
Copy Markdown
ContributorAuthor

I have to say I was thinking of /sdk/types myself before comitting...

But if you do look at it, it really isn't just types that's in there.

The current sdk v1 unfortunately mixes types and runtime code in files. So even in your types.ts you will find runtime code.

And other files that are exported (from the shared folder) certainly have loads of runtime (and id say much more runtime than types)

Exporting something via /sdk/types "implies" as a user I would be able to put that in devDependencies let's say, or alternatively to be importing it via "import type * from @modelcontextprotocol/sdk/types". However its not the case here due to the majority of the code being runtime and not just types..

We could, still decide to do it via /sdk/types however I dont think the regular user will expect that, given what it actually contains. (Classes, schemas, methods etc. as opposed to the expectation implied which is it should be just types, interfaces etc)

I came here to open this PR :)

Thanks for doing this.
One suggestion, it's not clear to me what would be contained in 'shared'. Are those all types? If that's the case, I'd argue to continue using '/sdk/types'

@joelachance

Copy link
Copy Markdown

Exporting something via /sdk/types "implies" as a user I would be able to put that in devDependencies let's say, or alternatively to be importing it via "import type * from @modelcontextprotocol/sdk/types". However its not the case here due to the majority of the code being runtime and not just types..

We could, still decide to do it via /sdk/types however I dont think the regular user will expect that, given what it actually contains. (Classes, schemas, methods etc. as opposed to the expectation implied which is it should be just types, interfaces etc)

I have seen types 'mixed in' with everything else in other libraries, but I'm not sure I like it. There's no indicators (that I know of) that give you the hint that you could pull in something like:

import { type LoggingLevelSchema } from '@mcp/sdk'

To your point, and maybe eventually, there is an sdk/types but it only contains types and interfaces, and the rest to live in a /runtime or /shared.

Anyway, I'm not sure I have a horse in this race, but glad it's being worked on :)

@KKonstantinov

Copy link
Copy Markdown
ContributorAuthor

Due to prettier's merge, there's conflicts here which I'll resolve.

But there's another decision point here to make.

In package.json, we've got:

".": {
"import": "./dist/esm/index.js",
"require": "./dist/cjs/index.js"
}

Which is a non-existent file. So that has to be removed. Since exporting from /server and /client is already a fact, we couldn't go back to exporting just from @modelcontextprotocol/sdk because that would constitute a huge breaking change.

We also mustn't export the same files from both @modelcontextprotocol/sdk and /client or /server (or /shared), because that will end up being super confusing - stuff should get exported in an expected, standardized way and not duplicate exports.

Thus our option for now if we dont want breaking changes is to just remove the main export.

@KKonstantinov

KKonstantinov commented Oct 15, 2025

Copy link
Copy Markdown
ContributorAuthor

This has accumulated conflicts over time.

cc @ihrpr when we are close to doing the v2 milestone, I'll resolve all of them.

@cliffhall

Copy link
Copy Markdown
Member

This has accumulated conflicts over time.

cc @ihrpr when we are close to doing the v2 milestone, I'll resolve all of them.

Could you make this a draft for now?

@KKonstantinov
KKonstantinov requested review from a team as code ownersOctober 31, 2025 08:03
@KKonstantinov

Copy link
Copy Markdown
ContributorAuthor

Now up to date with main.

Have further removed the import that is breaking things for various people (and does not exist).

".": {
"import": "./dist/esm/index.js",
"require": "./dist/cjs/index.js"
}

I could see this being raised in more issues, maybe we could plan on when to release it? It does constitute breaking changes, so it'd have to be in a major version, v2 or else.

ECHO-HELLO-WORLD424 added a commit to ECHO-HELLO-WORLD424/neuropilot that referenced this pull request Nov 9, 2025
@pkg-pr-new

pkg-pr-newBot commented Nov 9, 2025

Copy link
Copy Markdown

Open in StackBlitz

npm i https://pkg.pr.new/modelcontextprotocol/typescript-sdk/@modelcontextprotocol/sdk@870

commit: 5957da3

Comment threadsrc/server/server.ts Outdated

protected assertRequestHandlerCapability(method: string): void {
switch (method) {
case 'sampling/createMessage':

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. This didn't belong here :)

@felixweinberger

felixweinberger commented Dec 19, 2025

Copy link
Copy Markdown
Contributor

Going through old PRs right now if anything can be cleaned up.

@KKonstantinov I think we can close this out now that we landed your monorepo refactor in #1279 which solves this problem right?

Feel free to reopen if you still wanted to land a version of this in v1.x though!

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@KKonstantinov@cliffhall@ihrpr@joelachance@felixweinberger
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links"); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + '
Skip to content

Fix: Barrel file exports - #870

Closed
KKonstantinov wants to merge 11 commits into
modelcontextprotocol:mainfrom
KKonstantinov:feature/barrel-file-exports
Closed

Fix: Barrel file exports#870
KKonstantinov wants to merge 11 commits into
modelcontextprotocol:mainfrom
KKonstantinov:feature/barrel-file-exports

Conversation

@KKonstantinov

Copy link
Copy Markdown
Contributor

Extension to #851 and #511

Motivation and Context

The SDK currently exports from all files, which leads to users/implementors having to import from multiple places from the SDK.

Example:

import{StreamableHTTPServerTransport}from'@modelcontextprotocol/sdk/server/streamableHttp.js';import{McpServer}from'@modelcontextprotocol/sdk/server/mcp.js';import{isInitializeRequest,LoggingLevelSchema,SetLevelRequestSchema}from'@modelcontextprotocol/sdk/types.js';

This PR introduced index.ts barrel files under the following namespaces:

  • @modelcontextprotocol/sdk/server
  • @modelcontextprotocol/sdk/client
  • @modelcontextprotocol/sdk/shared (a new export added to package.json)

The above snippet would now look like:

import{StreamableHTTPServerTransport,McpServer}from'@modelcontextprotocol/sdk/server';import{isInitializeRequest,LoggingLevelSchema,SetLevelRequestSchema}from'@modelcontextprotocol/sdk/shared';

How Has This Been Tested?

Unit tests continue to run with no issues.

Breaking Changes

No, it's an improvement and not a breaking change.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update

Checklist

  • I have read the MCP Documentation
  • My code follows the repository's style guidelines
  • New and existing tests pass locally
  • I have added appropriate error handling
  • I have added or updated documentation as needed

Additional context

There are two files which were a bit controversial "./types.ts", and "./inMemory.ts". These are currently residing at the root level, although they are really "shared". Thus the shared namespace is re-exporting them.

Additionally, the previous client/index.ts contents was moved to client/client.ts and server/index.ts was moved to server/server.ts respectively. Since these two files are now re-exported by the index.ts files, there is no breaking change.

@KKonstantinov

KKonstantinov commented Aug 12, 2025

Copy link
Copy Markdown
ContributorAuthor

@cliffhall@ihrpr this is an extension to #851

@cliffhall

cliffhall commented Aug 12, 2025

Copy link
Copy Markdown
Member

This looks good to me in this view. One important thing for reviewers to do is make certain that the new server.ts and client.ts files contain exactly what their previous index.ts counterparts previously did. This is hard to do in the Files Changed diff view. It will have to be done locally in the IDE comparing to the historical content. I would do this now, but I have to prepare for a meeting.

@ihrprihrpr added this to the v2 milestone Aug 18, 2025
@ihrpr

Copy link
Copy Markdown
Contributor

Let's include it in V2

@ihrprihrpr mentioned this pull request Aug 18, 2025
Closed
23 tasks
@cliffhall

Copy link
Copy Markdown
Member

Let's include it in V2

@ihrpr maybe we could add a v2-feature label for PRs like this one.

@ihrpr

Copy link
Copy Markdown
Contributor

Let's include it in V2

@ihrpr maybe we could add a v2-feature label for PRs like this one.

I'm marking those PRs with V2 milestone

@joelachance

Copy link
Copy Markdown

I came here to open this PR :)

Thanks for doing this.
One suggestion, it's not clear to me what would be contained in 'shared'. Are those all types? If that's the case, I'd argue to continue using '/sdk/types'

@KKonstantinov

Copy link
Copy Markdown
ContributorAuthor

I have to say I was thinking of /sdk/types myself before comitting...

But if you do look at it, it really isn't just types that's in there.

The current sdk v1 unfortunately mixes types and runtime code in files. So even in your types.ts you will find runtime code.

And other files that are exported (from the shared folder) certainly have loads of runtime (and id say much more runtime than types)

Exporting something via /sdk/types "implies" as a user I would be able to put that in devDependencies let's say, or alternatively to be importing it via "import type * from @modelcontextprotocol/sdk/types". However its not the case here due to the majority of the code being runtime and not just types..

We could, still decide to do it via /sdk/types however I dont think the regular user will expect that, given what it actually contains. (Classes, schemas, methods etc. as opposed to the expectation implied which is it should be just types, interfaces etc)

I came here to open this PR :)

Thanks for doing this.
One suggestion, it's not clear to me what would be contained in 'shared'. Are those all types? If that's the case, I'd argue to continue using '/sdk/types'

@joelachance

Copy link
Copy Markdown

Exporting something via /sdk/types "implies" as a user I would be able to put that in devDependencies let's say, or alternatively to be importing it via "import type * from @modelcontextprotocol/sdk/types". However its not the case here due to the majority of the code being runtime and not just types..

We could, still decide to do it via /sdk/types however I dont think the regular user will expect that, given what it actually contains. (Classes, schemas, methods etc. as opposed to the expectation implied which is it should be just types, interfaces etc)

I have seen types 'mixed in' with everything else in other libraries, but I'm not sure I like it. There's no indicators (that I know of) that give you the hint that you could pull in something like:

import { type LoggingLevelSchema } from '@mcp/sdk'

To your point, and maybe eventually, there is an sdk/types but it only contains types and interfaces, and the rest to live in a /runtime or /shared.

Anyway, I'm not sure I have a horse in this race, but glad it's being worked on :)

@KKonstantinov

Copy link
Copy Markdown
ContributorAuthor

Due to prettier's merge, there's conflicts here which I'll resolve.

But there's another decision point here to make.

In package.json, we've got:

".": {
"import": "./dist/esm/index.js",
"require": "./dist/cjs/index.js"
}

Which is a non-existent file. So that has to be removed. Since exporting from /server and /client is already a fact, we couldn't go back to exporting just from @modelcontextprotocol/sdk because that would constitute a huge breaking change.

We also mustn't export the same files from both @modelcontextprotocol/sdk and /client or /server (or /shared), because that will end up being super confusing - stuff should get exported in an expected, standardized way and not duplicate exports.

Thus our option for now if we dont want breaking changes is to just remove the main export.

@KKonstantinov

KKonstantinov commented Oct 15, 2025

Copy link
Copy Markdown
ContributorAuthor

This has accumulated conflicts over time.

cc @ihrpr when we are close to doing the v2 milestone, I'll resolve all of them.

@cliffhall

Copy link
Copy Markdown
Member

This has accumulated conflicts over time.

cc @ihrpr when we are close to doing the v2 milestone, I'll resolve all of them.

Could you make this a draft for now?

@KKonstantinov
KKonstantinov requested review from a team as code ownersOctober 31, 2025 08:03
@KKonstantinov

Copy link
Copy Markdown
ContributorAuthor

Now up to date with main.

Have further removed the import that is breaking things for various people (and does not exist).

".": {
"import": "./dist/esm/index.js",
"require": "./dist/cjs/index.js"
}

I could see this being raised in more issues, maybe we could plan on when to release it? It does constitute breaking changes, so it'd have to be in a major version, v2 or else.

ECHO-HELLO-WORLD424 added a commit to ECHO-HELLO-WORLD424/neuropilot that referenced this pull request Nov 9, 2025
@pkg-pr-new

pkg-pr-newBot commented Nov 9, 2025

Copy link
Copy Markdown

Open in StackBlitz

npm i https://pkg.pr.new/modelcontextprotocol/typescript-sdk/@modelcontextprotocol/sdk@870

commit: 5957da3

Comment threadsrc/server/server.ts Outdated

protected assertRequestHandlerCapability(method: string): void {
switch (method) {
case 'sampling/createMessage':

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. This didn't belong here :)

@felixweinberger

felixweinberger commented Dec 19, 2025

Copy link
Copy Markdown
Contributor

Going through old PRs right now if anything can be cleaned up.

@KKonstantinov I think we can close this out now that we landed your monorepo refactor in #1279 which solves this problem right?

Feel free to reopen if you still wanted to land a version of this in v1.x though!

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@KKonstantinov@cliffhall@ihrpr@joelachance@felixweinberger
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default"); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

Fix: Barrel file exports - #870

Closed
KKonstantinov wants to merge 11 commits into
modelcontextprotocol:mainfrom
KKonstantinov:feature/barrel-file-exports
Closed

Fix: Barrel file exports#870
KKonstantinov wants to merge 11 commits into
modelcontextprotocol:mainfrom
KKonstantinov:feature/barrel-file-exports

Conversation

@KKonstantinov

Copy link
Copy Markdown
Contributor

Extension to #851 and #511

Motivation and Context

The SDK currently exports from all files, which leads to users/implementors having to import from multiple places from the SDK.

Example:

import{StreamableHTTPServerTransport}from'@modelcontextprotocol/sdk/server/streamableHttp.js';import{McpServer}from'@modelcontextprotocol/sdk/server/mcp.js';import{isInitializeRequest,LoggingLevelSchema,SetLevelRequestSchema}from'@modelcontextprotocol/sdk/types.js';

This PR introduced index.ts barrel files under the following namespaces:

  • @modelcontextprotocol/sdk/server
  • @modelcontextprotocol/sdk/client
  • @modelcontextprotocol/sdk/shared (a new export added to package.json)

The above snippet would now look like:

import{StreamableHTTPServerTransport,McpServer}from'@modelcontextprotocol/sdk/server';import{isInitializeRequest,LoggingLevelSchema,SetLevelRequestSchema}from'@modelcontextprotocol/sdk/shared';

How Has This Been Tested?

Unit tests continue to run with no issues.

Breaking Changes

No, it's an improvement and not a breaking change.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update

Checklist

  • I have read the MCP Documentation
  • My code follows the repository's style guidelines
  • New and existing tests pass locally
  • I have added appropriate error handling
  • I have added or updated documentation as needed

Additional context

There are two files which were a bit controversial "./types.ts", and "./inMemory.ts". These are currently residing at the root level, although they are really "shared". Thus the shared namespace is re-exporting them.

Additionally, the previous client/index.ts contents was moved to client/client.ts and server/index.ts was moved to server/server.ts respectively. Since these two files are now re-exported by the index.ts files, there is no breaking change.

@KKonstantinov

KKonstantinov commented Aug 12, 2025

Copy link
Copy Markdown
ContributorAuthor

@cliffhall@ihrpr this is an extension to #851

@cliffhall

cliffhall commented Aug 12, 2025

Copy link
Copy Markdown
Member

This looks good to me in this view. One important thing for reviewers to do is make certain that the new server.ts and client.ts files contain exactly what their previous index.ts counterparts previously did. This is hard to do in the Files Changed diff view. It will have to be done locally in the IDE comparing to the historical content. I would do this now, but I have to prepare for a meeting.

@ihrprihrpr added this to the v2 milestone Aug 18, 2025
@ihrpr

Copy link
Copy Markdown
Contributor

Let's include it in V2

@ihrprihrpr mentioned this pull request Aug 18, 2025
Closed
23 tasks
@cliffhall

Copy link
Copy Markdown
Member

Let's include it in V2

@ihrpr maybe we could add a v2-feature label for PRs like this one.

@ihrpr

Copy link
Copy Markdown
Contributor

Let's include it in V2

@ihrpr maybe we could add a v2-feature label for PRs like this one.

I'm marking those PRs with V2 milestone

@joelachance

Copy link
Copy Markdown

I came here to open this PR :)

Thanks for doing this.
One suggestion, it's not clear to me what would be contained in 'shared'. Are those all types? If that's the case, I'd argue to continue using '/sdk/types'

@KKonstantinov

Copy link
Copy Markdown
ContributorAuthor

I have to say I was thinking of /sdk/types myself before comitting...

But if you do look at it, it really isn't just types that's in there.

The current sdk v1 unfortunately mixes types and runtime code in files. So even in your types.ts you will find runtime code.

And other files that are exported (from the shared folder) certainly have loads of runtime (and id say much more runtime than types)

Exporting something via /sdk/types "implies" as a user I would be able to put that in devDependencies let's say, or alternatively to be importing it via "import type * from @modelcontextprotocol/sdk/types". However its not the case here due to the majority of the code being runtime and not just types..

We could, still decide to do it via /sdk/types however I dont think the regular user will expect that, given what it actually contains. (Classes, schemas, methods etc. as opposed to the expectation implied which is it should be just types, interfaces etc)

I came here to open this PR :)

Thanks for doing this.
One suggestion, it's not clear to me what would be contained in 'shared'. Are those all types? If that's the case, I'd argue to continue using '/sdk/types'

@joelachance

Copy link
Copy Markdown

Exporting something via /sdk/types "implies" as a user I would be able to put that in devDependencies let's say, or alternatively to be importing it via "import type * from @modelcontextprotocol/sdk/types". However its not the case here due to the majority of the code being runtime and not just types..

We could, still decide to do it via /sdk/types however I dont think the regular user will expect that, given what it actually contains. (Classes, schemas, methods etc. as opposed to the expectation implied which is it should be just types, interfaces etc)

I have seen types 'mixed in' with everything else in other libraries, but I'm not sure I like it. There's no indicators (that I know of) that give you the hint that you could pull in something like:

import { type LoggingLevelSchema } from '@mcp/sdk'

To your point, and maybe eventually, there is an sdk/types but it only contains types and interfaces, and the rest to live in a /runtime or /shared.

Anyway, I'm not sure I have a horse in this race, but glad it's being worked on :)

@KKonstantinov

Copy link
Copy Markdown
ContributorAuthor

Due to prettier's merge, there's conflicts here which I'll resolve.

But there's another decision point here to make.

In package.json, we've got:

".": {
"import": "./dist/esm/index.js",
"require": "./dist/cjs/index.js"
}

Which is a non-existent file. So that has to be removed. Since exporting from /server and /client is already a fact, we couldn't go back to exporting just from @modelcontextprotocol/sdk because that would constitute a huge breaking change.

We also mustn't export the same files from both @modelcontextprotocol/sdk and /client or /server (or /shared), because that will end up being super confusing - stuff should get exported in an expected, standardized way and not duplicate exports.

Thus our option for now if we dont want breaking changes is to just remove the main export.

@KKonstantinov

KKonstantinov commented Oct 15, 2025

Copy link
Copy Markdown
ContributorAuthor

This has accumulated conflicts over time.

cc @ihrpr when we are close to doing the v2 milestone, I'll resolve all of them.

@cliffhall

Copy link
Copy Markdown
Member

This has accumulated conflicts over time.

cc @ihrpr when we are close to doing the v2 milestone, I'll resolve all of them.

Could you make this a draft for now?

@KKonstantinov
KKonstantinov requested review from a team as code ownersOctober 31, 2025 08:03
@KKonstantinov

Copy link
Copy Markdown
ContributorAuthor

Now up to date with main.

Have further removed the import that is breaking things for various people (and does not exist).

".": {
"import": "./dist/esm/index.js",
"require": "./dist/cjs/index.js"
}

I could see this being raised in more issues, maybe we could plan on when to release it? It does constitute breaking changes, so it'd have to be in a major version, v2 or else.

ECHO-HELLO-WORLD424 added a commit to ECHO-HELLO-WORLD424/neuropilot that referenced this pull request Nov 9, 2025
@pkg-pr-new

pkg-pr-newBot commented Nov 9, 2025

Copy link
Copy Markdown

Open in StackBlitz

npm i https://pkg.pr.new/modelcontextprotocol/typescript-sdk/@modelcontextprotocol/sdk@870

commit: 5957da3

Comment threadsrc/server/server.ts Outdated

protected assertRequestHandlerCapability(method: string): void {
switch (method) {
case 'sampling/createMessage':

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. This didn't belong here :)

@felixweinberger

felixweinberger commented Dec 19, 2025

Copy link
Copy Markdown
Contributor

Going through old PRs right now if anything can be cleaned up.

@KKonstantinov I think we can close this out now that we landed your monorepo refactor in #1279 which solves this problem right?

Feel free to reopen if you still wanted to land a version of this in v1.x though!

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@KKonstantinov@cliffhall@ihrpr@joelachance@felixweinberger
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers"); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

Fix: Barrel file exports - #870

Closed
KKonstantinov wants to merge 11 commits into
modelcontextprotocol:mainfrom
KKonstantinov:feature/barrel-file-exports
Closed

Fix: Barrel file exports#870
KKonstantinov wants to merge 11 commits into
modelcontextprotocol:mainfrom
KKonstantinov:feature/barrel-file-exports

Conversation

@KKonstantinov

Copy link
Copy Markdown
Contributor

Extension to #851 and #511

Motivation and Context

The SDK currently exports from all files, which leads to users/implementors having to import from multiple places from the SDK.

Example:

import{StreamableHTTPServerTransport}from'@modelcontextprotocol/sdk/server/streamableHttp.js';import{McpServer}from'@modelcontextprotocol/sdk/server/mcp.js';import{isInitializeRequest,LoggingLevelSchema,SetLevelRequestSchema}from'@modelcontextprotocol/sdk/types.js';

This PR introduced index.ts barrel files under the following namespaces:

  • @modelcontextprotocol/sdk/server
  • @modelcontextprotocol/sdk/client
  • @modelcontextprotocol/sdk/shared (a new export added to package.json)

The above snippet would now look like:

import{StreamableHTTPServerTransport,McpServer}from'@modelcontextprotocol/sdk/server';import{isInitializeRequest,LoggingLevelSchema,SetLevelRequestSchema}from'@modelcontextprotocol/sdk/shared';

How Has This Been Tested?

Unit tests continue to run with no issues.

Breaking Changes

No, it's an improvement and not a breaking change.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update

Checklist

  • I have read the MCP Documentation
  • My code follows the repository's style guidelines
  • New and existing tests pass locally
  • I have added appropriate error handling
  • I have added or updated documentation as needed

Additional context

There are two files which were a bit controversial "./types.ts", and "./inMemory.ts". These are currently residing at the root level, although they are really "shared". Thus the shared namespace is re-exporting them.

Additionally, the previous client/index.ts contents was moved to client/client.ts and server/index.ts was moved to server/server.ts respectively. Since these two files are now re-exported by the index.ts files, there is no breaking change.

@KKonstantinov

KKonstantinov commented Aug 12, 2025

Copy link
Copy Markdown
ContributorAuthor

@cliffhall@ihrpr this is an extension to #851

@cliffhall

cliffhall commented Aug 12, 2025

Copy link
Copy Markdown
Member

This looks good to me in this view. One important thing for reviewers to do is make certain that the new server.ts and client.ts files contain exactly what their previous index.ts counterparts previously did. This is hard to do in the Files Changed diff view. It will have to be done locally in the IDE comparing to the historical content. I would do this now, but I have to prepare for a meeting.

@ihrprihrpr added this to the v2 milestone Aug 18, 2025
@ihrpr

Copy link
Copy Markdown
Contributor

Let's include it in V2

@ihrprihrpr mentioned this pull request Aug 18, 2025
Closed
23 tasks
@cliffhall

Copy link
Copy Markdown
Member

Let's include it in V2

@ihrpr maybe we could add a v2-feature label for PRs like this one.

@ihrpr

Copy link
Copy Markdown
Contributor

Let's include it in V2

@ihrpr maybe we could add a v2-feature label for PRs like this one.

I'm marking those PRs with V2 milestone

@joelachance

Copy link
Copy Markdown

I came here to open this PR :)

Thanks for doing this.
One suggestion, it's not clear to me what would be contained in 'shared'. Are those all types? If that's the case, I'd argue to continue using '/sdk/types'

@KKonstantinov

Copy link
Copy Markdown
ContributorAuthor

I have to say I was thinking of /sdk/types myself before comitting...

But if you do look at it, it really isn't just types that's in there.

The current sdk v1 unfortunately mixes types and runtime code in files. So even in your types.ts you will find runtime code.

And other files that are exported (from the shared folder) certainly have loads of runtime (and id say much more runtime than types)

Exporting something via /sdk/types "implies" as a user I would be able to put that in devDependencies let's say, or alternatively to be importing it via "import type * from @modelcontextprotocol/sdk/types". However its not the case here due to the majority of the code being runtime and not just types..

We could, still decide to do it via /sdk/types however I dont think the regular user will expect that, given what it actually contains. (Classes, schemas, methods etc. as opposed to the expectation implied which is it should be just types, interfaces etc)

I came here to open this PR :)

Thanks for doing this.
One suggestion, it's not clear to me what would be contained in 'shared'. Are those all types? If that's the case, I'd argue to continue using '/sdk/types'

@joelachance

Copy link
Copy Markdown

Exporting something via /sdk/types "implies" as a user I would be able to put that in devDependencies let's say, or alternatively to be importing it via "import type * from @modelcontextprotocol/sdk/types". However its not the case here due to the majority of the code being runtime and not just types..

We could, still decide to do it via /sdk/types however I dont think the regular user will expect that, given what it actually contains. (Classes, schemas, methods etc. as opposed to the expectation implied which is it should be just types, interfaces etc)

I have seen types 'mixed in' with everything else in other libraries, but I'm not sure I like it. There's no indicators (that I know of) that give you the hint that you could pull in something like:

import { type LoggingLevelSchema } from '@mcp/sdk'

To your point, and maybe eventually, there is an sdk/types but it only contains types and interfaces, and the rest to live in a /runtime or /shared.

Anyway, I'm not sure I have a horse in this race, but glad it's being worked on :)

@KKonstantinov

Copy link
Copy Markdown
ContributorAuthor

Due to prettier's merge, there's conflicts here which I'll resolve.

But there's another decision point here to make.

In package.json, we've got:

".": {
"import": "./dist/esm/index.js",
"require": "./dist/cjs/index.js"
}

Which is a non-existent file. So that has to be removed. Since exporting from /server and /client is already a fact, we couldn't go back to exporting just from @modelcontextprotocol/sdk because that would constitute a huge breaking change.

We also mustn't export the same files from both @modelcontextprotocol/sdk and /client or /server (or /shared), because that will end up being super confusing - stuff should get exported in an expected, standardized way and not duplicate exports.

Thus our option for now if we dont want breaking changes is to just remove the main export.

@KKonstantinov

KKonstantinov commented Oct 15, 2025

Copy link
Copy Markdown
ContributorAuthor

This has accumulated conflicts over time.

cc @ihrpr when we are close to doing the v2 milestone, I'll resolve all of them.

@cliffhall

Copy link
Copy Markdown
Member

This has accumulated conflicts over time.

cc @ihrpr when we are close to doing the v2 milestone, I'll resolve all of them.

Could you make this a draft for now?

@KKonstantinov
KKonstantinov requested review from a team as code ownersOctober 31, 2025 08:03
@KKonstantinov

Copy link
Copy Markdown
ContributorAuthor

Now up to date with main.

Have further removed the import that is breaking things for various people (and does not exist).

".": {
"import": "./dist/esm/index.js",
"require": "./dist/cjs/index.js"
}

I could see this being raised in more issues, maybe we could plan on when to release it? It does constitute breaking changes, so it'd have to be in a major version, v2 or else.

ECHO-HELLO-WORLD424 added a commit to ECHO-HELLO-WORLD424/neuropilot that referenced this pull request Nov 9, 2025
@pkg-pr-new

pkg-pr-newBot commented Nov 9, 2025

Copy link
Copy Markdown

Open in StackBlitz

npm i https://pkg.pr.new/modelcontextprotocol/typescript-sdk/@modelcontextprotocol/sdk@870

commit: 5957da3

Comment threadsrc/server/server.ts Outdated

protected assertRequestHandlerCapability(method: string): void {
switch (method) {
case 'sampling/createMessage':

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. This didn't belong here :)

@felixweinberger

felixweinberger commented Dec 19, 2025

Copy link
Copy Markdown
Contributor

Going through old PRs right now if anything can be cleaned up.

@KKonstantinov I think we can close this out now that we landed your monorepo refactor in #1279 which solves this problem right?

Feel free to reopen if you still wanted to land a version of this in v1.x though!

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@KKonstantinov@cliffhall@ihrpr@joelachance@felixweinberger
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode"); } } catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); } })(); })();
Skip to content

Fix: Barrel file exports - #870

Closed
KKonstantinov wants to merge 11 commits into
modelcontextprotocol:mainfrom
KKonstantinov:feature/barrel-file-exports
Closed

Fix: Barrel file exports#870
KKonstantinov wants to merge 11 commits into
modelcontextprotocol:mainfrom
KKonstantinov:feature/barrel-file-exports

Conversation

@KKonstantinov

Copy link
Copy Markdown
Contributor

Extension to #851 and #511

Motivation and Context

The SDK currently exports from all files, which leads to users/implementors having to import from multiple places from the SDK.

Example:

import{StreamableHTTPServerTransport}from'@modelcontextprotocol/sdk/server/streamableHttp.js';import{McpServer}from'@modelcontextprotocol/sdk/server/mcp.js';import{isInitializeRequest,LoggingLevelSchema,SetLevelRequestSchema}from'@modelcontextprotocol/sdk/types.js';

This PR introduced index.ts barrel files under the following namespaces:

  • @modelcontextprotocol/sdk/server
  • @modelcontextprotocol/sdk/client
  • @modelcontextprotocol/sdk/shared (a new export added to package.json)

The above snippet would now look like:

import{StreamableHTTPServerTransport,McpServer}from'@modelcontextprotocol/sdk/server';import{isInitializeRequest,LoggingLevelSchema,SetLevelRequestSchema}from'@modelcontextprotocol/sdk/shared';

How Has This Been Tested?

Unit tests continue to run with no issues.

Breaking Changes

No, it's an improvement and not a breaking change.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update

Checklist

  • I have read the MCP Documentation
  • My code follows the repository's style guidelines
  • New and existing tests pass locally
  • I have added appropriate error handling
  • I have added or updated documentation as needed

Additional context

There are two files which were a bit controversial "./types.ts", and "./inMemory.ts". These are currently residing at the root level, although they are really "shared". Thus the shared namespace is re-exporting them.

Additionally, the previous client/index.ts contents was moved to client/client.ts and server/index.ts was moved to server/server.ts respectively. Since these two files are now re-exported by the index.ts files, there is no breaking change.

@KKonstantinov

KKonstantinov commented Aug 12, 2025

Copy link
Copy Markdown
ContributorAuthor

@cliffhall@ihrpr this is an extension to #851

@cliffhall

cliffhall commented Aug 12, 2025

Copy link
Copy Markdown
Member

This looks good to me in this view. One important thing for reviewers to do is make certain that the new server.ts and client.ts files contain exactly what their previous index.ts counterparts previously did. This is hard to do in the Files Changed diff view. It will have to be done locally in the IDE comparing to the historical content. I would do this now, but I have to prepare for a meeting.

@ihrprihrpr added this to the v2 milestone Aug 18, 2025
@ihrpr

Copy link
Copy Markdown
Contributor

Let's include it in V2

@ihrprihrpr mentioned this pull request Aug 18, 2025
Closed
23 tasks
@cliffhall

Copy link
Copy Markdown
Member

Let's include it in V2

@ihrpr maybe we could add a v2-feature label for PRs like this one.

@ihrpr

Copy link
Copy Markdown
Contributor

Let's include it in V2

@ihrpr maybe we could add a v2-feature label for PRs like this one.

I'm marking those PRs with V2 milestone

@joelachance

Copy link
Copy Markdown

I came here to open this PR :)

Thanks for doing this.
One suggestion, it's not clear to me what would be contained in 'shared'. Are those all types? If that's the case, I'd argue to continue using '/sdk/types'

@KKonstantinov

Copy link
Copy Markdown
ContributorAuthor

I have to say I was thinking of /sdk/types myself before comitting...

But if you do look at it, it really isn't just types that's in there.

The current sdk v1 unfortunately mixes types and runtime code in files. So even in your types.ts you will find runtime code.

And other files that are exported (from the shared folder) certainly have loads of runtime (and id say much more runtime than types)

Exporting something via /sdk/types "implies" as a user I would be able to put that in devDependencies let's say, or alternatively to be importing it via "import type * from @modelcontextprotocol/sdk/types". However its not the case here due to the majority of the code being runtime and not just types..

We could, still decide to do it via /sdk/types however I dont think the regular user will expect that, given what it actually contains. (Classes, schemas, methods etc. as opposed to the expectation implied which is it should be just types, interfaces etc)

I came here to open this PR :)

Thanks for doing this.
One suggestion, it's not clear to me what would be contained in 'shared'. Are those all types? If that's the case, I'd argue to continue using '/sdk/types'

@joelachance

Copy link
Copy Markdown

Exporting something via /sdk/types "implies" as a user I would be able to put that in devDependencies let's say, or alternatively to be importing it via "import type * from @modelcontextprotocol/sdk/types". However its not the case here due to the majority of the code being runtime and not just types..

We could, still decide to do it via /sdk/types however I dont think the regular user will expect that, given what it actually contains. (Classes, schemas, methods etc. as opposed to the expectation implied which is it should be just types, interfaces etc)

I have seen types 'mixed in' with everything else in other libraries, but I'm not sure I like it. There's no indicators (that I know of) that give you the hint that you could pull in something like:

import { type LoggingLevelSchema } from '@mcp/sdk'

To your point, and maybe eventually, there is an sdk/types but it only contains types and interfaces, and the rest to live in a /runtime or /shared.

Anyway, I'm not sure I have a horse in this race, but glad it's being worked on :)

@KKonstantinov

Copy link
Copy Markdown
ContributorAuthor

Due to prettier's merge, there's conflicts here which I'll resolve.

But there's another decision point here to make.

In package.json, we've got:

".": {
"import": "./dist/esm/index.js",
"require": "./dist/cjs/index.js"
}

Which is a non-existent file. So that has to be removed. Since exporting from /server and /client is already a fact, we couldn't go back to exporting just from @modelcontextprotocol/sdk because that would constitute a huge breaking change.

We also mustn't export the same files from both @modelcontextprotocol/sdk and /client or /server (or /shared), because that will end up being super confusing - stuff should get exported in an expected, standardized way and not duplicate exports.

Thus our option for now if we dont want breaking changes is to just remove the main export.

@KKonstantinov

KKonstantinov commented Oct 15, 2025

Copy link
Copy Markdown
ContributorAuthor

This has accumulated conflicts over time.

cc @ihrpr when we are close to doing the v2 milestone, I'll resolve all of them.

@cliffhall

Copy link
Copy Markdown
Member

This has accumulated conflicts over time.

cc @ihrpr when we are close to doing the v2 milestone, I'll resolve all of them.

Could you make this a draft for now?

@KKonstantinov
KKonstantinov requested review from a team as code ownersOctober 31, 2025 08:03
@KKonstantinov

Copy link
Copy Markdown
ContributorAuthor

Now up to date with main.

Have further removed the import that is breaking things for various people (and does not exist).

".": {
"import": "./dist/esm/index.js",
"require": "./dist/cjs/index.js"
}

I could see this being raised in more issues, maybe we could plan on when to release it? It does constitute breaking changes, so it'd have to be in a major version, v2 or else.

ECHO-HELLO-WORLD424 added a commit to ECHO-HELLO-WORLD424/neuropilot that referenced this pull request Nov 9, 2025
@pkg-pr-new

pkg-pr-newBot commented Nov 9, 2025

Copy link
Copy Markdown

Open in StackBlitz

npm i https://pkg.pr.new/modelcontextprotocol/typescript-sdk/@modelcontextprotocol/sdk@870

commit: 5957da3

Comment threadsrc/server/server.ts Outdated

protected assertRequestHandlerCapability(method: string): void {
switch (method) {
case 'sampling/createMessage':

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. This didn't belong here :)

@felixweinberger

felixweinberger commented Dec 19, 2025

Copy link
Copy Markdown
Contributor

Going through old PRs right now if anything can be cleaned up.

@KKonstantinov I think we can close this out now that we landed your monorepo refactor in #1279 which solves this problem right?

Feel free to reopen if you still wanted to land a version of this in v1.x though!

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@KKonstantinov@cliffhall@ihrpr@joelachance@felixweinberger