Add sandbox file transfer API - #13

Merged
Yunnglin merged 2 commits into
mainfrom
add-sandbox-file-transfer-api
Jul 7, 2026
Merged

Add sandbox file transfer API#13
Yunnglin merged 2 commits into
mainfrom
add-sandbox-file-transfer-api

Conversation

@Yunnglin

@YunnglinYunnglin commented Jul 7, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • add sandbox-level put_archive, put_dir, and put_file APIs
  • expose manager-level local and HTTP directory transfer through the same archive path
  • reuse sandbox put_file in existing tool implementations instead of duplicating tar upload logic
  • add real local and HTTP Docker file-transfer tests

Validation

  • PATH=/Users/yunlin/miniconda3/envs/eval/bin:$PATH pre-commit run --all-files
  • DOCKER_HOST=unix:///Users/yunlin/.colima/default/docker.sock /Users/yunlin/miniconda3/envs/eval/bin/python -m pytest tests/test_manager.py::TestSandboxFileTransfer -q -s
  • DOCKER_HOST=unix:///Users/yunlin/.colima/default/docker.sock /Users/yunlin/miniconda3/envs/eval/bin/python -m pytest tests/test_manager.py::TestLocalSandboxManager tests/test_manager.py::TestSandboxFileTransfer -q -s

gemini-code-assist[bot]
gemini-code-assistBot reviewed Jul 7, 2026
View reviewed changes

@gemini-code-assistgemini-code-assistBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces native file and directory transfer capabilities (put_archive, put_dir, and put_file) across the sandbox interface, Docker sandbox, and sandbox managers, replacing custom in-memory tar implementations in various execution tools. The review feedback suggests several key improvements: allowing active statuses like IDLE and BUSY in sandbox state checks, offloading synchronous archiving operations to a separate thread to avoid blocking the asyncio event loop, validating absolute file paths, securing the mkdir command against option injection, setting explicit modification times on tar files, and refining HTTP error mapping to distinguish validation errors from resource-not-found errors.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment threadms_enclave/sandbox/manager/local_manager.py
Comment threadms_enclave/sandbox/boxes/base.py Outdated
Comment threadms_enclave/sandbox/manager/http_manager.py Outdated
Comment threadms_enclave/sandbox/boxes/base.py
Comment threadms_enclave/sandbox/boxes/docker_sandbox.py Outdated
Comment threadms_enclave/sandbox/utils/archive.py
Comment threadms_enclave/sandbox/server/server.py
@Yunnglin
Yunnglin marked this pull request as ready for review July 7, 2026 03:49
CopilotAI review requested due to automatic review settings July 7, 2026 03:49
CopilotAI reviewed Jul 7, 2026
View reviewed changes

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds first-class sandbox file-transfer APIs (put_archive, put_dir, put_file) to the sandbox abstraction and exposes archive upload through both local and HTTP managers, then refactors existing tools to reuse the new put_file path and adds real Docker-backed file-transfer tests.

Changes:

  • Add tar archive helpers and sandbox-level file transfer APIs (put_archive / put_dir / put_file).
  • Expose archive upload via FastAPI (POST /sandbox/{id}/archive) and add corresponding HTTP/local manager methods.
  • Refactor tool implementations to use sandbox_context.put_file(...) and add local + HTTP Docker integration tests for put_dir.

Reviewed changes

Copilot reviewed 12 out of 12 changed files in this pull request and generated 2 comments.

Show a summary per file
FileDescription
tests/test_manager.pyAdds real local/HTTP Docker integration tests for manager-level directory transfer.
ms_enclave/sandbox/utils/archive.pyIntroduces in-memory tar helpers used by put_dir / put_file.
ms_enclave/sandbox/utils/init.pyAdds utils package initializer.
ms_enclave/sandbox/tools/sandbox_tools/python_executor.pySwitches to sandbox put_file instead of bespoke tar upload.
ms_enclave/sandbox/tools/sandbox_tools/multi_code_executor.pySwitches to sandbox put_file instead of bespoke tar upload.
ms_enclave/sandbox/tools/sandbox_tools/file_operation.pySwitches to sandbox put_file for temp writes instead of bespoke tar upload.
ms_enclave/sandbox/server/server.pyAdds HTTP endpoint to upload/extract tar archives into a sandbox.
ms_enclave/sandbox/manager/local_manager.pyAdds local manager put_archive / put_dir forwarding to sandbox implementations.
ms_enclave/sandbox/manager/http_manager.pyAdds HTTP manager put_archive / put_dir implemented via the new server route.
ms_enclave/sandbox/manager/base.pyAdds default (unsupported) manager API surface for put_archive / put_dir.
ms_enclave/sandbox/boxes/docker_sandbox.pyImplements Docker-backed put_archive with mkdir -p + container.put_archive.
ms_enclave/sandbox/boxes/base.pyAdds sandbox-level put_archive / put_dir / put_file APIs and shared tar-based implementations.

Comment threadms_enclave/sandbox/utils/archive.py
Comment threadtests/test_manager.py
@Yunnglin
Yunnglin merged commit e36d8d1 into mainJul 7, 2026
1 check passed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code reviewCopilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
+1 more reviewer
@gemini-code-assistgemini-code-assist[bot]gemini-code-assist[bot] left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Yunnglin
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all 
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '

Skip to content
Add sandbox file transfer API - #13
Merged
Yunnglin merged 2 commits into
mainfrom 
add-sandbox-file-transfer-api
Jul 7, 2026
Merged
Add sandbox file transfer API#13
Yunnglin merged 2 commits into
mainfrom 
add-sandbox-file-transfer-api
Conversation
@Yunnglin
@YunnglinYunnglin
commented
Jul 7, 2026

Copy link


Copy Markdown

Collaborator
Summary
  • add sandbox-level put_archive, put_dir, and put_file APIs
  • expose manager-level local and HTTP directory transfer through the same archive path
  • reuse sandbox put_file in existing tool implementations instead of duplicating tar upload logic
  • add real local and HTTP Docker file-transfer tests
Validation
  • PATH=/Users/yunlin/miniconda3/envs/eval/bin:$PATH pre-commit run --all-files
  • DOCKER_HOST=unix:///Users/yunlin/.colima/default/docker.sock /Users/yunlin/miniconda3/envs/eval/bin/python -m pytest tests/test_manager.py::TestSandboxFileTransfer -q -s
  • DOCKER_HOST=unix:///Users/yunlin/.colima/default/docker.sock /Users/yunlin/miniconda3/envs/eval/bin/python -m pytest tests/test_manager.py::TestLocalSandboxManager tests/test_manager.py::TestSandboxFileTransfer -q -s
gemini-code-assist[bot]
gemini-code-assistBot
reviewed
Jul 7, 2026
View reviewed changes
@gemini-code-assistgemini-code-assistBot
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review
This pull request introduces native file and directory transfer capabilities (put_archive, put_dir, and put_file) across the sandbox interface, Docker sandbox, and sandbox managers, replacing custom in-memory tar implementations in various execution tools. The review feedback suggests several key improvements: allowing active statuses like IDLE and BUSY in sandbox state checks, offloading synchronous archiving operations to a separate thread to avoid blocking the asyncio event loop, validating absolute file paths, securing the mkdir command against option injection, setting explicit modification times on tar files, and refining HTTP error mapping to distinguish validation errors from resource-not-found errors.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.

For more details on the timeline and next steps, please review the Help Documentation.
Comment threadms_enclave/sandbox/manager/local_manager.py
Comment threadms_enclave/sandbox/boxes/base.py
Outdated

Comment threadms_enclave/sandbox/manager/http_manager.py
Outdated

Comment threadms_enclave/sandbox/boxes/base.py
Comment threadms_enclave/sandbox/boxes/docker_sandbox.py
Outdated

Comment threadms_enclave/sandbox/utils/archive.py
Comment threadms_enclave/sandbox/server/server.py
@Yunnglin
Yunnglin
marked this pull request as ready for review
July 7, 2026 03:49
CopilotAI
review requested due to automatic review settings
July 7, 2026 03:49
CopilotAI
reviewed
Jul 7, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview
This PR adds first-class sandbox file-transfer APIs (put_archive, put_dir, put_file) to the sandbox abstraction and exposes archive upload through both local and HTTP managers, then refactors existing tools to reuse the new put_file path and adds real Docker-backed file-transfer tests.
Changes:
  • Add tar archive helpers and sandbox-level file transfer APIs (put_archive / put_dir / put_file).
  • Expose archive upload via FastAPI (POST /sandbox/{id}/archive) and add corresponding HTTP/local manager methods.
  • Refactor tool implementations to use sandbox_context.put_file(...) and add local + HTTP Docker integration tests for put_dir.
Reviewed changes
Copilot reviewed 12 out of 12 changed files in this pull request and generated 2 comments.
Show a summary per file
FileDescription
tests/test_manager.pyAdds real local/HTTP Docker integration tests for manager-level directory transfer.
ms_enclave/sandbox/utils/archive.pyIntroduces in-memory tar helpers used by put_dir / put_file.
ms_enclave/sandbox/utils/init.pyAdds utils package initializer.
ms_enclave/sandbox/tools/sandbox_tools/python_executor.pySwitches to sandbox put_file instead of bespoke tar upload.
ms_enclave/sandbox/tools/sandbox_tools/multi_code_executor.pySwitches to sandbox put_file instead of bespoke tar upload.
ms_enclave/sandbox/tools/sandbox_tools/file_operation.pySwitches to sandbox put_file for temp writes instead of bespoke tar upload.
ms_enclave/sandbox/server/server.pyAdds HTTP endpoint to upload/extract tar archives into a sandbox.
ms_enclave/sandbox/manager/local_manager.pyAdds local manager put_archive / put_dir forwarding to sandbox implementations.
ms_enclave/sandbox/manager/http_manager.pyAdds HTTP manager put_archive / put_dir implemented via the new server route.
ms_enclave/sandbox/manager/base.pyAdds default (unsupported) manager API surface for put_archive / put_dir.
ms_enclave/sandbox/boxes/docker_sandbox.pyImplements Docker-backed put_archive with mkdir -p + container.put_archive.
ms_enclave/sandbox/boxes/base.pyAdds sandbox-level put_archive / put_dir / put_file APIs and shared tar-based implementations.
Comment threadms_enclave/sandbox/utils/archive.py
Comment threadtests/test_manager.py
@Yunnglin
Yunnglin
merged commit e36d8d1
into
mainJul 7, 2026

1 check passed

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

Copilot code reviewCopilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments

+1 more reviewer

@gemini-code-assistgemini-code-assist[bot]gemini-code-assist[bot] left review comments
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@Yunnglin

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Force GitHub README to respect dark mode
(function() {
var style = document.createElement('style');
style.textContent = '
.markdown-body {
color-scheme: dark light;
}
.markdown-body pre { background: #161b22 !important; }
.markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }
.markdown-body table th, .markdown-body table td { border-color: #30363d !important; }
.markdown-body img { background: #0d1117; }
.markdown-body blockquote { border-left-color: #8b949e; }
.markdown-body hr { border-color: #30363d; }
';
document.head.appendChild(style);
})();
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Add sandbox file transfer API - #13
Merged
Yunnglin merged 2 commits into
mainfrom 
add-sandbox-file-transfer-api
Jul 7, 2026
Merged
Add sandbox file transfer API#13
Yunnglin merged 2 commits into
mainfrom 
add-sandbox-file-transfer-api
Conversation
@Yunnglin
@YunnglinYunnglin
commented
Jul 7, 2026

Copy link


Copy Markdown

Collaborator
Summary
  • add sandbox-level put_archive, put_dir, and put_file APIs
  • expose manager-level local and HTTP directory transfer through the same archive path
  • reuse sandbox put_file in existing tool implementations instead of duplicating tar upload logic
  • add real local and HTTP Docker file-transfer tests
Validation
  • PATH=/Users/yunlin/miniconda3/envs/eval/bin:$PATH pre-commit run --all-files
  • DOCKER_HOST=unix:///Users/yunlin/.colima/default/docker.sock /Users/yunlin/miniconda3/envs/eval/bin/python -m pytest tests/test_manager.py::TestSandboxFileTransfer -q -s
  • DOCKER_HOST=unix:///Users/yunlin/.colima/default/docker.sock /Users/yunlin/miniconda3/envs/eval/bin/python -m pytest tests/test_manager.py::TestLocalSandboxManager tests/test_manager.py::TestSandboxFileTransfer -q -s
gemini-code-assist[bot]
gemini-code-assistBot
reviewed
Jul 7, 2026
View reviewed changes
@gemini-code-assistgemini-code-assistBot
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review
This pull request introduces native file and directory transfer capabilities (put_archive, put_dir, and put_file) across the sandbox interface, Docker sandbox, and sandbox managers, replacing custom in-memory tar implementations in various execution tools. The review feedback suggests several key improvements: allowing active statuses like IDLE and BUSY in sandbox state checks, offloading synchronous archiving operations to a separate thread to avoid blocking the asyncio event loop, validating absolute file paths, securing the mkdir command against option injection, setting explicit modification times on tar files, and refining HTTP error mapping to distinguish validation errors from resource-not-found errors.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.

For more details on the timeline and next steps, please review the Help Documentation.
Comment threadms_enclave/sandbox/manager/local_manager.py
Comment threadms_enclave/sandbox/boxes/base.py
Outdated

Comment threadms_enclave/sandbox/manager/http_manager.py
Outdated

Comment threadms_enclave/sandbox/boxes/base.py
Comment threadms_enclave/sandbox/boxes/docker_sandbox.py
Outdated

Comment threadms_enclave/sandbox/utils/archive.py
Comment threadms_enclave/sandbox/server/server.py
@Yunnglin
Yunnglin
marked this pull request as ready for review
July 7, 2026 03:49
CopilotAI
review requested due to automatic review settings
July 7, 2026 03:49
CopilotAI
reviewed
Jul 7, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview
This PR adds first-class sandbox file-transfer APIs (put_archive, put_dir, put_file) to the sandbox abstraction and exposes archive upload through both local and HTTP managers, then refactors existing tools to reuse the new put_file path and adds real Docker-backed file-transfer tests.
Changes:
  • Add tar archive helpers and sandbox-level file transfer APIs (put_archive / put_dir / put_file).
  • Expose archive upload via FastAPI (POST /sandbox/{id}/archive) and add corresponding HTTP/local manager methods.
  • Refactor tool implementations to use sandbox_context.put_file(...) and add local + HTTP Docker integration tests for put_dir.
Reviewed changes
Copilot reviewed 12 out of 12 changed files in this pull request and generated 2 comments.
Show a summary per file
FileDescription
tests/test_manager.pyAdds real local/HTTP Docker integration tests for manager-level directory transfer.
ms_enclave/sandbox/utils/archive.pyIntroduces in-memory tar helpers used by put_dir / put_file.
ms_enclave/sandbox/utils/init.pyAdds utils package initializer.
ms_enclave/sandbox/tools/sandbox_tools/python_executor.pySwitches to sandbox put_file instead of bespoke tar upload.
ms_enclave/sandbox/tools/sandbox_tools/multi_code_executor.pySwitches to sandbox put_file instead of bespoke tar upload.
ms_enclave/sandbox/tools/sandbox_tools/file_operation.pySwitches to sandbox put_file for temp writes instead of bespoke tar upload.
ms_enclave/sandbox/server/server.pyAdds HTTP endpoint to upload/extract tar archives into a sandbox.
ms_enclave/sandbox/manager/local_manager.pyAdds local manager put_archive / put_dir forwarding to sandbox implementations.
ms_enclave/sandbox/manager/http_manager.pyAdds HTTP manager put_archive / put_dir implemented via the new server route.
ms_enclave/sandbox/manager/base.pyAdds default (unsupported) manager API surface for put_archive / put_dir.
ms_enclave/sandbox/boxes/docker_sandbox.pyImplements Docker-backed put_archive with mkdir -p + container.put_archive.
ms_enclave/sandbox/boxes/base.pyAdds sandbox-level put_archive / put_dir / put_file APIs and shared tar-based implementations.
Comment threadms_enclave/sandbox/utils/archive.py
Comment threadtests/test_manager.py
@Yunnglin
Yunnglin
merged commit e36d8d1
into
mainJul 7, 2026

1 check passed

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

Copilot code reviewCopilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments

+1 more reviewer

@gemini-code-assistgemini-code-assist[bot]gemini-code-assist[bot] left review comments
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@Yunnglin

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Highlight search terms from Google/DuckDuckGo/Bing referrer
(function() {
var ref = document.referrer;
var terms = [];
if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {
var url = new URL(ref);
var q = url.searchParams.get('q') || url.searchParams.get('p');
if (q) {
terms = q.split(/\s+/).filter(function(t) { return t.length > 2; });
}
}
if (terms.length === 0) return;
var style = document.createElement('style');
style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';
document.head.appendChild(style);
function highlight(node) {
if (node.nodeType === 3) { // text node
var text = node.textContent;
var found = false;
terms.forEach(function(term) {
var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi');
if (regex.test(text)) {
found = true;
var frag = document.createDocumentFragment();
var parts = text.split(regex);
parts.forEach(function(part, i) {
if (i % 2 === 0) {
frag.appendChild(document.createTextNode(part));
} else {
var span = document.createElement('span');
span.className = 'userscript-highlight';
span.textContent = part;
frag.appendChild(span);
}
});
node.parentNode.replaceChild(frag, node);
}
});
} else if (node.nodeType === 1 && node.childNodes) { // element
var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];
if (!skipTags.includes(node.tagName)) {
Array.from(node.childNodes).forEach(highlight);
}
}
}
highlight(document.body);
// Re-highlight on dynamic content
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1 || node.nodeType === 3) highlight(node);
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Add sandbox file transfer API - #13
Merged
Yunnglin merged 2 commits into
mainfrom 
add-sandbox-file-transfer-api
Jul 7, 2026
Merged
Add sandbox file transfer API#13
Yunnglin merged 2 commits into
mainfrom 
add-sandbox-file-transfer-api
Conversation
@Yunnglin
@YunnglinYunnglin
commented
Jul 7, 2026

Copy link


Copy Markdown

Collaborator
Summary
  • add sandbox-level put_archive, put_dir, and put_file APIs
  • expose manager-level local and HTTP directory transfer through the same archive path
  • reuse sandbox put_file in existing tool implementations instead of duplicating tar upload logic
  • add real local and HTTP Docker file-transfer tests
Validation
  • PATH=/Users/yunlin/miniconda3/envs/eval/bin:$PATH pre-commit run --all-files
  • DOCKER_HOST=unix:///Users/yunlin/.colima/default/docker.sock /Users/yunlin/miniconda3/envs/eval/bin/python -m pytest tests/test_manager.py::TestSandboxFileTransfer -q -s
  • DOCKER_HOST=unix:///Users/yunlin/.colima/default/docker.sock /Users/yunlin/miniconda3/envs/eval/bin/python -m pytest tests/test_manager.py::TestLocalSandboxManager tests/test_manager.py::TestSandboxFileTransfer -q -s
gemini-code-assist[bot]
gemini-code-assistBot
reviewed
Jul 7, 2026
View reviewed changes
@gemini-code-assistgemini-code-assistBot
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review
This pull request introduces native file and directory transfer capabilities (put_archive, put_dir, and put_file) across the sandbox interface, Docker sandbox, and sandbox managers, replacing custom in-memory tar implementations in various execution tools. The review feedback suggests several key improvements: allowing active statuses like IDLE and BUSY in sandbox state checks, offloading synchronous archiving operations to a separate thread to avoid blocking the asyncio event loop, validating absolute file paths, securing the mkdir command against option injection, setting explicit modification times on tar files, and refining HTTP error mapping to distinguish validation errors from resource-not-found errors.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.

For more details on the timeline and next steps, please review the Help Documentation.
Comment threadms_enclave/sandbox/manager/local_manager.py
Comment threadms_enclave/sandbox/boxes/base.py
Outdated

Comment threadms_enclave/sandbox/manager/http_manager.py
Outdated

Comment threadms_enclave/sandbox/boxes/base.py
Comment threadms_enclave/sandbox/boxes/docker_sandbox.py
Outdated

Comment threadms_enclave/sandbox/utils/archive.py
Comment threadms_enclave/sandbox/server/server.py
@Yunnglin
Yunnglin
marked this pull request as ready for review
July 7, 2026 03:49
CopilotAI
review requested due to automatic review settings
July 7, 2026 03:49
CopilotAI
reviewed
Jul 7, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview
This PR adds first-class sandbox file-transfer APIs (put_archive, put_dir, put_file) to the sandbox abstraction and exposes archive upload through both local and HTTP managers, then refactors existing tools to reuse the new put_file path and adds real Docker-backed file-transfer tests.
Changes:
  • Add tar archive helpers and sandbox-level file transfer APIs (put_archive / put_dir / put_file).
  • Expose archive upload via FastAPI (POST /sandbox/{id}/archive) and add corresponding HTTP/local manager methods.
  • Refactor tool implementations to use sandbox_context.put_file(...) and add local + HTTP Docker integration tests for put_dir.
Reviewed changes
Copilot reviewed 12 out of 12 changed files in this pull request and generated 2 comments.
Show a summary per file
FileDescription
tests/test_manager.pyAdds real local/HTTP Docker integration tests for manager-level directory transfer.
ms_enclave/sandbox/utils/archive.pyIntroduces in-memory tar helpers used by put_dir / put_file.
ms_enclave/sandbox/utils/init.pyAdds utils package initializer.
ms_enclave/sandbox/tools/sandbox_tools/python_executor.pySwitches to sandbox put_file instead of bespoke tar upload.
ms_enclave/sandbox/tools/sandbox_tools/multi_code_executor.pySwitches to sandbox put_file instead of bespoke tar upload.
ms_enclave/sandbox/tools/sandbox_tools/file_operation.pySwitches to sandbox put_file for temp writes instead of bespoke tar upload.
ms_enclave/sandbox/server/server.pyAdds HTTP endpoint to upload/extract tar archives into a sandbox.
ms_enclave/sandbox/manager/local_manager.pyAdds local manager put_archive / put_dir forwarding to sandbox implementations.
ms_enclave/sandbox/manager/http_manager.pyAdds HTTP manager put_archive / put_dir implemented via the new server route.
ms_enclave/sandbox/manager/base.pyAdds default (unsupported) manager API surface for put_archive / put_dir.
ms_enclave/sandbox/boxes/docker_sandbox.pyImplements Docker-backed put_archive with mkdir -p + container.put_archive.
ms_enclave/sandbox/boxes/base.pyAdds sandbox-level put_archive / put_dir / put_file APIs and shared tar-based implementations.
Comment threadms_enclave/sandbox/utils/archive.py
Comment threadtests/test_manager.py
@Yunnglin
Yunnglin
merged commit e36d8d1
into
mainJul 7, 2026

1 check passed

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

Copilot code reviewCopilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments

+1 more reviewer

@gemini-code-assistgemini-code-assist[bot]gemini-code-assist[bot] left review comments
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@Yunnglin

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Strip utm_, fbclid, gclid, etc. from all links on page
(function() {
var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',
'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',
'ref', 'ref_src', 'source', 'medium', 'campaign'];
function cleanUrl(url) {
try {
var u = new URL(url, window.location.origin);
var changed = false;
trackingParams.forEach(function(p) {
if (u.searchParams.has(p)) {
u.searchParams.delete(p);
changed = true;
}
});
return changed ? u.toString() : url;
} catch (e) {
return url;
}
}
function cleanLinks() {
document.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
cleanLinks();
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1) {
if (node.tagName === 'A') cleanLinks();
node.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '

Skip to content
Add sandbox file transfer API - #13
Merged
Yunnglin merged 2 commits into
mainfrom 
add-sandbox-file-transfer-api
Jul 7, 2026
Merged
Add sandbox file transfer API#13
Yunnglin merged 2 commits into
mainfrom 
add-sandbox-file-transfer-api
Conversation
@Yunnglin
@YunnglinYunnglin
commented
Jul 7, 2026

Copy link


Copy Markdown

Collaborator
Summary
  • add sandbox-level put_archive, put_dir, and put_file APIs
  • expose manager-level local and HTTP directory transfer through the same archive path
  • reuse sandbox put_file in existing tool implementations instead of duplicating tar upload logic
  • add real local and HTTP Docker file-transfer tests
Validation
  • PATH=/Users/yunlin/miniconda3/envs/eval/bin:$PATH pre-commit run --all-files
  • DOCKER_HOST=unix:///Users/yunlin/.colima/default/docker.sock /Users/yunlin/miniconda3/envs/eval/bin/python -m pytest tests/test_manager.py::TestSandboxFileTransfer -q -s
  • DOCKER_HOST=unix:///Users/yunlin/.colima/default/docker.sock /Users/yunlin/miniconda3/envs/eval/bin/python -m pytest tests/test_manager.py::TestLocalSandboxManager tests/test_manager.py::TestSandboxFileTransfer -q -s
gemini-code-assist[bot]
gemini-code-assistBot
reviewed
Jul 7, 2026
View reviewed changes
@gemini-code-assistgemini-code-assistBot
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review
This pull request introduces native file and directory transfer capabilities (put_archive, put_dir, and put_file) across the sandbox interface, Docker sandbox, and sandbox managers, replacing custom in-memory tar implementations in various execution tools. The review feedback suggests several key improvements: allowing active statuses like IDLE and BUSY in sandbox state checks, offloading synchronous archiving operations to a separate thread to avoid blocking the asyncio event loop, validating absolute file paths, securing the mkdir command against option injection, setting explicit modification times on tar files, and refining HTTP error mapping to distinguish validation errors from resource-not-found errors.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.

For more details on the timeline and next steps, please review the Help Documentation.
Comment threadms_enclave/sandbox/manager/local_manager.py
Comment threadms_enclave/sandbox/boxes/base.py
Outdated

Comment threadms_enclave/sandbox/manager/http_manager.py
Outdated

Comment threadms_enclave/sandbox/boxes/base.py
Comment threadms_enclave/sandbox/boxes/docker_sandbox.py
Outdated

Comment threadms_enclave/sandbox/utils/archive.py
Comment threadms_enclave/sandbox/server/server.py
@Yunnglin
Yunnglin
marked this pull request as ready for review
July 7, 2026 03:49
CopilotAI
review requested due to automatic review settings
July 7, 2026 03:49
CopilotAI
reviewed
Jul 7, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview
This PR adds first-class sandbox file-transfer APIs (put_archive, put_dir, put_file) to the sandbox abstraction and exposes archive upload through both local and HTTP managers, then refactors existing tools to reuse the new put_file path and adds real Docker-backed file-transfer tests.
Changes:
  • Add tar archive helpers and sandbox-level file transfer APIs (put_archive / put_dir / put_file).
  • Expose archive upload via FastAPI (POST /sandbox/{id}/archive) and add corresponding HTTP/local manager methods.
  • Refactor tool implementations to use sandbox_context.put_file(...) and add local + HTTP Docker integration tests for put_dir.
Reviewed changes
Copilot reviewed 12 out of 12 changed files in this pull request and generated 2 comments.
Show a summary per file
FileDescription
tests/test_manager.pyAdds real local/HTTP Docker integration tests for manager-level directory transfer.
ms_enclave/sandbox/utils/archive.pyIntroduces in-memory tar helpers used by put_dir / put_file.
ms_enclave/sandbox/utils/init.pyAdds utils package initializer.
ms_enclave/sandbox/tools/sandbox_tools/python_executor.pySwitches to sandbox put_file instead of bespoke tar upload.
ms_enclave/sandbox/tools/sandbox_tools/multi_code_executor.pySwitches to sandbox put_file instead of bespoke tar upload.
ms_enclave/sandbox/tools/sandbox_tools/file_operation.pySwitches to sandbox put_file for temp writes instead of bespoke tar upload.
ms_enclave/sandbox/server/server.pyAdds HTTP endpoint to upload/extract tar archives into a sandbox.
ms_enclave/sandbox/manager/local_manager.pyAdds local manager put_archive / put_dir forwarding to sandbox implementations.
ms_enclave/sandbox/manager/http_manager.pyAdds HTTP manager put_archive / put_dir implemented via the new server route.
ms_enclave/sandbox/manager/base.pyAdds default (unsupported) manager API surface for put_archive / put_dir.
ms_enclave/sandbox/boxes/docker_sandbox.pyImplements Docker-backed put_archive with mkdir -p + container.put_archive.
ms_enclave/sandbox/boxes/base.pyAdds sandbox-level put_archive / put_dir / put_file APIs and shared tar-based implementations.
Comment threadms_enclave/sandbox/utils/archive.py
Comment threadtests/test_manager.py
@Yunnglin
Yunnglin
merged commit e36d8d1
into
mainJul 7, 2026

1 check passed

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

Copilot code reviewCopilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments

+1 more reviewer

@gemini-code-assistgemini-code-assist[bot]gemini-code-assist[bot] left review comments
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@Yunnglin

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Auto-enable theater mode on YouTube
(function() {
function tryTheater() {
var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]');
if (btn && !btn.classList.contains('activated')) {
btn.click();
}
}
// Try immediately
tryTheater();
// Try after navigation (SPA)
var lastUrl = location.href;
setInterval(function() {
if (location.href !== lastUrl) {
lastUrl = location.href;
setTimeout(tryTheater, 500);
}
}, 1000);
// Also try on player load
var observer = new MutationObserver(tryTheater);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Add sandbox file transfer API - #13
Merged
Yunnglin merged 2 commits into
mainfrom 
add-sandbox-file-transfer-api
Jul 7, 2026
Merged
Add sandbox file transfer API#13
Yunnglin merged 2 commits into
mainfrom 
add-sandbox-file-transfer-api
Conversation
@Yunnglin
@YunnglinYunnglin
commented
Jul 7, 2026

Copy link


Copy Markdown

Collaborator
Summary
  • add sandbox-level put_archive, put_dir, and put_file APIs
  • expose manager-level local and HTTP directory transfer through the same archive path
  • reuse sandbox put_file in existing tool implementations instead of duplicating tar upload logic
  • add real local and HTTP Docker file-transfer tests
Validation
  • PATH=/Users/yunlin/miniconda3/envs/eval/bin:$PATH pre-commit run --all-files
  • DOCKER_HOST=unix:///Users/yunlin/.colima/default/docker.sock /Users/yunlin/miniconda3/envs/eval/bin/python -m pytest tests/test_manager.py::TestSandboxFileTransfer -q -s
  • DOCKER_HOST=unix:///Users/yunlin/.colima/default/docker.sock /Users/yunlin/miniconda3/envs/eval/bin/python -m pytest tests/test_manager.py::TestLocalSandboxManager tests/test_manager.py::TestSandboxFileTransfer -q -s
gemini-code-assist[bot]
gemini-code-assistBot
reviewed
Jul 7, 2026
View reviewed changes
@gemini-code-assistgemini-code-assistBot
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review
This pull request introduces native file and directory transfer capabilities (put_archive, put_dir, and put_file) across the sandbox interface, Docker sandbox, and sandbox managers, replacing custom in-memory tar implementations in various execution tools. The review feedback suggests several key improvements: allowing active statuses like IDLE and BUSY in sandbox state checks, offloading synchronous archiving operations to a separate thread to avoid blocking the asyncio event loop, validating absolute file paths, securing the mkdir command against option injection, setting explicit modification times on tar files, and refining HTTP error mapping to distinguish validation errors from resource-not-found errors.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.

For more details on the timeline and next steps, please review the Help Documentation.
Comment threadms_enclave/sandbox/manager/local_manager.py
Comment threadms_enclave/sandbox/boxes/base.py
Outdated

Comment threadms_enclave/sandbox/manager/http_manager.py
Outdated

Comment threadms_enclave/sandbox/boxes/base.py
Comment threadms_enclave/sandbox/boxes/docker_sandbox.py
Outdated

Comment threadms_enclave/sandbox/utils/archive.py
Comment threadms_enclave/sandbox/server/server.py
@Yunnglin
Yunnglin
marked this pull request as ready for review
July 7, 2026 03:49
CopilotAI
review requested due to automatic review settings
July 7, 2026 03:49
CopilotAI
reviewed
Jul 7, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview
This PR adds first-class sandbox file-transfer APIs (put_archive, put_dir, put_file) to the sandbox abstraction and exposes archive upload through both local and HTTP managers, then refactors existing tools to reuse the new put_file path and adds real Docker-backed file-transfer tests.
Changes:
  • Add tar archive helpers and sandbox-level file transfer APIs (put_archive / put_dir / put_file).
  • Expose archive upload via FastAPI (POST /sandbox/{id}/archive) and add corresponding HTTP/local manager methods.
  • Refactor tool implementations to use sandbox_context.put_file(...) and add local + HTTP Docker integration tests for put_dir.
Reviewed changes
Copilot reviewed 12 out of 12 changed files in this pull request and generated 2 comments.
Show a summary per file
FileDescription
tests/test_manager.pyAdds real local/HTTP Docker integration tests for manager-level directory transfer.
ms_enclave/sandbox/utils/archive.pyIntroduces in-memory tar helpers used by put_dir / put_file.
ms_enclave/sandbox/utils/init.pyAdds utils package initializer.
ms_enclave/sandbox/tools/sandbox_tools/python_executor.pySwitches to sandbox put_file instead of bespoke tar upload.
ms_enclave/sandbox/tools/sandbox_tools/multi_code_executor.pySwitches to sandbox put_file instead of bespoke tar upload.
ms_enclave/sandbox/tools/sandbox_tools/file_operation.pySwitches to sandbox put_file for temp writes instead of bespoke tar upload.
ms_enclave/sandbox/server/server.pyAdds HTTP endpoint to upload/extract tar archives into a sandbox.
ms_enclave/sandbox/manager/local_manager.pyAdds local manager put_archive / put_dir forwarding to sandbox implementations.
ms_enclave/sandbox/manager/http_manager.pyAdds HTTP manager put_archive / put_dir implemented via the new server route.
ms_enclave/sandbox/manager/base.pyAdds default (unsupported) manager API surface for put_archive / put_dir.
ms_enclave/sandbox/boxes/docker_sandbox.pyImplements Docker-backed put_archive with mkdir -p + container.put_archive.
ms_enclave/sandbox/boxes/base.pyAdds sandbox-level put_archive / put_dir / put_file APIs and shared tar-based implementations.
Comment threadms_enclave/sandbox/utils/archive.py
Comment threadtests/test_manager.py
@Yunnglin
Yunnglin
merged commit e36d8d1
into
mainJul 7, 2026

1 check passed

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

Copilot code reviewCopilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments

+1 more reviewer

@gemini-code-assistgemini-code-assist[bot]gemini-code-assist[bot] left review comments
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@Yunnglin

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Remove or un-stick sticky/fixed headers that block content
(function() {
function unstick() {
document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) {
if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {
el.style.position = 'static';
el.style.top = 'auto';
el.style.zIndex = 'auto';
}
});
}
unstick();
var observer = new MutationObserver(unstick);
observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });
})();
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Add sandbox file transfer API - #13
Merged
Yunnglin merged 2 commits into
mainfrom 
add-sandbox-file-transfer-api
Jul 7, 2026
Merged
Add sandbox file transfer API#13
Yunnglin merged 2 commits into
mainfrom 
add-sandbox-file-transfer-api
Conversation
@Yunnglin
@YunnglinYunnglin
commented
Jul 7, 2026

Copy link


Copy Markdown

Collaborator
Summary
  • add sandbox-level put_archive, put_dir, and put_file APIs
  • expose manager-level local and HTTP directory transfer through the same archive path
  • reuse sandbox put_file in existing tool implementations instead of duplicating tar upload logic
  • add real local and HTTP Docker file-transfer tests
Validation
  • PATH=/Users/yunlin/miniconda3/envs/eval/bin:$PATH pre-commit run --all-files
  • DOCKER_HOST=unix:///Users/yunlin/.colima/default/docker.sock /Users/yunlin/miniconda3/envs/eval/bin/python -m pytest tests/test_manager.py::TestSandboxFileTransfer -q -s
  • DOCKER_HOST=unix:///Users/yunlin/.colima/default/docker.sock /Users/yunlin/miniconda3/envs/eval/bin/python -m pytest tests/test_manager.py::TestLocalSandboxManager tests/test_manager.py::TestSandboxFileTransfer -q -s
gemini-code-assist[bot]
gemini-code-assistBot
reviewed
Jul 7, 2026
View reviewed changes
@gemini-code-assistgemini-code-assistBot
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review
This pull request introduces native file and directory transfer capabilities (put_archive, put_dir, and put_file) across the sandbox interface, Docker sandbox, and sandbox managers, replacing custom in-memory tar implementations in various execution tools. The review feedback suggests several key improvements: allowing active statuses like IDLE and BUSY in sandbox state checks, offloading synchronous archiving operations to a separate thread to avoid blocking the asyncio event loop, validating absolute file paths, securing the mkdir command against option injection, setting explicit modification times on tar files, and refining HTTP error mapping to distinguish validation errors from resource-not-found errors.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.

For more details on the timeline and next steps, please review the Help Documentation.
Comment threadms_enclave/sandbox/manager/local_manager.py
Comment threadms_enclave/sandbox/boxes/base.py
Outdated

Comment threadms_enclave/sandbox/manager/http_manager.py
Outdated

Comment threadms_enclave/sandbox/boxes/base.py
Comment threadms_enclave/sandbox/boxes/docker_sandbox.py
Outdated

Comment threadms_enclave/sandbox/utils/archive.py
Comment threadms_enclave/sandbox/server/server.py
@Yunnglin
Yunnglin
marked this pull request as ready for review
July 7, 2026 03:49
CopilotAI
review requested due to automatic review settings
July 7, 2026 03:49
CopilotAI
reviewed
Jul 7, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview
This PR adds first-class sandbox file-transfer APIs (put_archive, put_dir, put_file) to the sandbox abstraction and exposes archive upload through both local and HTTP managers, then refactors existing tools to reuse the new put_file path and adds real Docker-backed file-transfer tests.
Changes:
  • Add tar archive helpers and sandbox-level file transfer APIs (put_archive / put_dir / put_file).
  • Expose archive upload via FastAPI (POST /sandbox/{id}/archive) and add corresponding HTTP/local manager methods.
  • Refactor tool implementations to use sandbox_context.put_file(...) and add local + HTTP Docker integration tests for put_dir.
Reviewed changes
Copilot reviewed 12 out of 12 changed files in this pull request and generated 2 comments.
Show a summary per file
FileDescription
tests/test_manager.pyAdds real local/HTTP Docker integration tests for manager-level directory transfer.
ms_enclave/sandbox/utils/archive.pyIntroduces in-memory tar helpers used by put_dir / put_file.
ms_enclave/sandbox/utils/init.pyAdds utils package initializer.
ms_enclave/sandbox/tools/sandbox_tools/python_executor.pySwitches to sandbox put_file instead of bespoke tar upload.
ms_enclave/sandbox/tools/sandbox_tools/multi_code_executor.pySwitches to sandbox put_file instead of bespoke tar upload.
ms_enclave/sandbox/tools/sandbox_tools/file_operation.pySwitches to sandbox put_file for temp writes instead of bespoke tar upload.
ms_enclave/sandbox/server/server.pyAdds HTTP endpoint to upload/extract tar archives into a sandbox.
ms_enclave/sandbox/manager/local_manager.pyAdds local manager put_archive / put_dir forwarding to sandbox implementations.
ms_enclave/sandbox/manager/http_manager.pyAdds HTTP manager put_archive / put_dir implemented via the new server route.
ms_enclave/sandbox/manager/base.pyAdds default (unsupported) manager API surface for put_archive / put_dir.
ms_enclave/sandbox/boxes/docker_sandbox.pyImplements Docker-backed put_archive with mkdir -p + container.put_archive.
ms_enclave/sandbox/boxes/base.pyAdds sandbox-level put_archive / put_dir / put_file APIs and shared tar-based implementations.
Comment threadms_enclave/sandbox/utils/archive.py
Comment threadtests/test_manager.py
@Yunnglin
Yunnglin
merged commit e36d8d1
into
mainJul 7, 2026

1 check passed

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

Copilot code reviewCopilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments

+1 more reviewer

@gemini-code-assistgemini-code-assist[bot]gemini-code-assist[bot] left review comments
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@Yunnglin

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Universal Dark Mode - works on any site
(function() {
var enabled = true;
function applyDarkMode() {
if (!enabled) return;
// Create style element if it doesn't exist
var style = document.getElementById('universal-dark-mode-style');
if (!style) {
style = document.createElement('style');
style.id = 'universal-dark-mode-style';
document.head.appendChild(style);
}
// Dark mode CSS - inverts colors but preserves images/video
style.textContent = '
/* Invert everything except media */
html {
filter: invert(1) hue-rotate(180deg) !important;
background: #1a1a2e !important;
}
/* Restore images, videos, iframes, canvas */
img, video, iframe, canvas, svg, picture, [style*="background-image"] {
filter: invert(1) hue-rotate(180deg) !important;
}
/* Preserve specific elements that should not be inverted */
.no-dark-mode, .no-dark-mode *,
[data-theme="light"], [data-theme="light"],
.ace_editor, .ace_editor *,
.CodeMirror, .CodeMirror *,
.monaco-editor, .monaco-editor *,
.markdown-body pre, .markdown-body pre *,
.highlight, .highlight *,
pre code, pre code * {
filter: none !important;
}
/* Fix common UI elements */
.modal, .popup, .dropdown-menu, .tooltip, .popover {
filter: invert(1) hue-rotate(180deg) !important;
background: #2d2d44 !important;
border-color: #444 !important;
}
/* Scrollbars */
::-webkit-scrollbar { background: #1a1a2e !important; }
::-webkit-scrollbar-thumb { background: #444 !important; }
::-webkit-scrollbar-thumb:hover { background: #555 !important; }
/* Selection */
::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
';
}
function removeDarkMode() {
var style = document.getElementById('universal-dark-mode-style');
if (style) style.remove();
}
// Toggle with Alt+Shift+D
document.addEventListener('keydown', function(e) {
if (e.altKey && e.shiftKey && e.key === 'D') {
e.preventDefault();
enabled = !enabled;
if (enabled) {
applyDarkMode();
console.log('[Universal Dark Mode] Enabled');
} else {
removeDarkMode();
console.log('[Universal Dark Mode] Disabled');
}
}
});
// Apply on load
applyDarkMode();
// Re-apply on dynamic content
var observer = new MutationObserver(function(mutations) {
if (enabled && !document.getElementById('universal-dark-mode-style')) {
applyDarkMode();
}
});
observer.observe(document.head, { childList: true });
console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');
})();
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();

Skip to content
Add sandbox file transfer API - #13
Merged
Yunnglin merged 2 commits into
mainfrom 
add-sandbox-file-transfer-api
Jul 7, 2026
Merged
Add sandbox file transfer API#13
Yunnglin merged 2 commits into
mainfrom 
add-sandbox-file-transfer-api
Conversation
@Yunnglin
@YunnglinYunnglin
commented
Jul 7, 2026

Copy link


Copy Markdown

Collaborator
Summary
  • add sandbox-level put_archive, put_dir, and put_file APIs
  • expose manager-level local and HTTP directory transfer through the same archive path
  • reuse sandbox put_file in existing tool implementations instead of duplicating tar upload logic
  • add real local and HTTP Docker file-transfer tests
Validation
  • PATH=/Users/yunlin/miniconda3/envs/eval/bin:$PATH pre-commit run --all-files
  • DOCKER_HOST=unix:///Users/yunlin/.colima/default/docker.sock /Users/yunlin/miniconda3/envs/eval/bin/python -m pytest tests/test_manager.py::TestSandboxFileTransfer -q -s
  • DOCKER_HOST=unix:///Users/yunlin/.colima/default/docker.sock /Users/yunlin/miniconda3/envs/eval/bin/python -m pytest tests/test_manager.py::TestLocalSandboxManager tests/test_manager.py::TestSandboxFileTransfer -q -s
gemini-code-assist[bot]
gemini-code-assistBot
reviewed
Jul 7, 2026
View reviewed changes
@gemini-code-assistgemini-code-assistBot
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review
This pull request introduces native file and directory transfer capabilities (put_archive, put_dir, and put_file) across the sandbox interface, Docker sandbox, and sandbox managers, replacing custom in-memory tar implementations in various execution tools. The review feedback suggests several key improvements: allowing active statuses like IDLE and BUSY in sandbox state checks, offloading synchronous archiving operations to a separate thread to avoid blocking the asyncio event loop, validating absolute file paths, securing the mkdir command against option injection, setting explicit modification times on tar files, and refining HTTP error mapping to distinguish validation errors from resource-not-found errors.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.

For more details on the timeline and next steps, please review the Help Documentation.
Comment threadms_enclave/sandbox/manager/local_manager.py
Comment threadms_enclave/sandbox/boxes/base.py
Outdated

Comment threadms_enclave/sandbox/manager/http_manager.py
Outdated

Comment threadms_enclave/sandbox/boxes/base.py
Comment threadms_enclave/sandbox/boxes/docker_sandbox.py
Outdated

Comment threadms_enclave/sandbox/utils/archive.py
Comment threadms_enclave/sandbox/server/server.py
@Yunnglin
Yunnglin
marked this pull request as ready for review
July 7, 2026 03:49
CopilotAI
review requested due to automatic review settings
July 7, 2026 03:49
CopilotAI
reviewed
Jul 7, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview
This PR adds first-class sandbox file-transfer APIs (put_archive, put_dir, put_file) to the sandbox abstraction and exposes archive upload through both local and HTTP managers, then refactors existing tools to reuse the new put_file path and adds real Docker-backed file-transfer tests.
Changes:
  • Add tar archive helpers and sandbox-level file transfer APIs (put_archive / put_dir / put_file).
  • Expose archive upload via FastAPI (POST /sandbox/{id}/archive) and add corresponding HTTP/local manager methods.
  • Refactor tool implementations to use sandbox_context.put_file(...) and add local + HTTP Docker integration tests for put_dir.
Reviewed changes
Copilot reviewed 12 out of 12 changed files in this pull request and generated 2 comments.
Show a summary per file
FileDescription
tests/test_manager.pyAdds real local/HTTP Docker integration tests for manager-level directory transfer.
ms_enclave/sandbox/utils/archive.pyIntroduces in-memory tar helpers used by put_dir / put_file.
ms_enclave/sandbox/utils/init.pyAdds utils package initializer.
ms_enclave/sandbox/tools/sandbox_tools/python_executor.pySwitches to sandbox put_file instead of bespoke tar upload.
ms_enclave/sandbox/tools/sandbox_tools/multi_code_executor.pySwitches to sandbox put_file instead of bespoke tar upload.
ms_enclave/sandbox/tools/sandbox_tools/file_operation.pySwitches to sandbox put_file for temp writes instead of bespoke tar upload.
ms_enclave/sandbox/server/server.pyAdds HTTP endpoint to upload/extract tar archives into a sandbox.
ms_enclave/sandbox/manager/local_manager.pyAdds local manager put_archive / put_dir forwarding to sandbox implementations.
ms_enclave/sandbox/manager/http_manager.pyAdds HTTP manager put_archive / put_dir implemented via the new server route.
ms_enclave/sandbox/manager/base.pyAdds default (unsupported) manager API surface for put_archive / put_dir.
ms_enclave/sandbox/boxes/docker_sandbox.pyImplements Docker-backed put_archive with mkdir -p + container.put_archive.
ms_enclave/sandbox/boxes/base.pyAdds sandbox-level put_archive / put_dir / put_file APIs and shared tar-based implementations.
Comment threadms_enclave/sandbox/utils/archive.py
Comment threadtests/test_manager.py
@Yunnglin
Yunnglin
merged commit e36d8d1
into
mainJul 7, 2026

1 check passed

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

Copilot code reviewCopilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments

+1 more reviewer

@gemini-code-assistgemini-code-assist[bot]gemini-code-assist[bot] left review comments
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@Yunnglin