Uh oh!
There was an error while loading. Please reload this page.
chore: speed up pre-commit skill asset sync - #96
Merged
Conversation
- Modified the `sync:skill-assets` script in `package.json` to remove the dependency on building `bailian-cli-core` before generating references and syncing skill versions.
CI runs sync:skill-assets before vp check without pre-commit's vp staged, so reference markdown must be formatted in the shared sync script.
release/check.mjs calls generate:reference directly then git diff --exit-code on skills/bailian-cli/reference/. Formatting must stay on that script; root sync:skill-assets should not duplicate it.
Uh oh!
There was an error while loading. Please reload this page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
bailian-cli-coresource instead ofdist, sosync:skill-assetsno longer needs a package build.Locally,
pnpm run sync:skill-assetsdropped from ~12.6s to ~4.0–4.6s (~63% faster). Generated reference content stays equivalent after formatting.Test plan
pnpm run sync:skill-assetsand confirm it completes without building core/runtime/commandsskills/bailian-cli/reference/content matches the previous output aftervp check --fixvp checkon the touched filesgit commit --allow-empty) or a small staged change and confirm the hook still regenerates skill assets then runsvp staged