Uh oh!
There was an error while loading. Please reload this page.
feat(desktop): land Tauri parity and update bridge - #84
Merged
Conversation
* feat(desktop): complete OpenWork Tauri parity * fix(ci): align desktop workflows with YAML lint * chore(ci): retry sensitive scan * chore(repo): define OpenWork upstream boundary * fix(desktop): close release blockers
* fix(desktop): preserve Electron to Tauri upgrades * test(desktop): satisfy bridge contract lint
Contributor
Code Coverage Summary
CLI Package - Full Text ReportCore Package - Full Text ReportFor detailed HTML reports, please see the 'coverage-reports-22.x-ubuntu-latest' artifact from the main CI run. |
yiliang114
marked this pull request as ready for review
August 17, 2026 07:44
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit:53382baa5c
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| disabled, | ||
| }: WebShellComposerToolbarRenderInfo) { | ||
| const { t } = useI18n(); | ||
| const [effort, setEffort] = useState('default'); |
There was a problem hiding this comment.
The selector always initializes to default and never reads the session's configured reasoning effort. When a user starts with a persisted tier such as high, switches sessions/models, or changes effort through another command surface, the toolbar displays a different value from the one used for subsequent turns, which can invalidate reasoning-effort comparisons. Populate this state from the active configuration and update it when that configuration changes.
Useful? React with 👍 / 👎.
Comment on lines
+571
to
+575
| useEffect(() => { | ||
| applyOpenWorkPreferences(preferences); | ||
| void invokeOpenWork('set_interface_zoom', { | ||
| percent: preferences.zoom, | ||
| }).catch(() => undefined); |
There was a problem hiding this comment.
When the standalone Web Shell is opened in an ordinary browser, window.__TAURI__ is absent, so this invocation resolves to undefined; applyOpenWorkPreferences also does not apply the stored zoom value. Because OpenWorkDesktopLayer and its zoom selector/shortcuts are mounted unconditionally in StandaloneApp, browser users can change a working-looking setting that never affects the interface. Gate the native-only control or provide a browser zoom implementation.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Pull request overview
This PR lands the remaining stacked desktop migration work (#82/#83) onto main, completing OpenWork’s Tauri + Qwen Web Shell parity, enabling the Electron→Tauri update bridge, adding legacy data migration, and restoring a bounded/explicit GitHub Actions workflow set suitable for OpenWork.
Changes:
- Finalize desktop runtime/release infrastructure: Tauri updater + cross-platform packaging, Electron compatibility bridge, runtime integrity checks, and first-launch legacy migration.
- Add OpenWork Web Shell desktop layer features: preferences (theme/zoom/text size/contrast/motion), command palette + recents, link routing into a docked browser, settings/help search, and improved copy feedback.
- Extend channels and management: Telegram management metadata, new WhatsApp adapter/plugin, and safer channel state deletion; improve multi-workspace session restore routing.
Reviewed changes
Copilot reviewed 97 out of 102 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| scripts/tests/no-ak-integration-ci.test.js | Tightens CI workflow assertions for OpenWork-specific job gating and Windows runner routing. |
| scripts/clean-package-build-artifacts.js | Includes WhatsApp channel package in artifact cleanup set. |
| scripts/build.js | Includes WhatsApp channel package in the build order. |
| packages/web-shell/client/styles/standalone.css | Adds high-contrast and reduced-motion overrides for the standalone shell. |
| packages/web-shell/client/openwork/themes.ts | Introduces OpenWork theme catalog and theme application logic. |
| packages/web-shell/client/openwork/preferences.ts | Adds persistent OpenWork desktop preference storage + sanitization + application. |
| packages/web-shell/client/openwork/preferences.test.ts | Tests preference sanitization and theme application. |
| packages/web-shell/client/openwork/OpenWorkDesktopLayer.test.ts | Tests desktop-only link routing and deep-link drain concurrency. |
| packages/web-shell/client/openwork/OpenWorkDesktopLayer.module.css | Styles for OpenWork starters, palette, browser dock toolbar, and preference UI. |
| packages/web-shell/client/openwork/command-recents.ts | Adds storage-backed “recent command” tracking with dedupe/capping. |
| packages/web-shell/client/openwork/command-recents.test.ts | Tests recent command ordering/deduping/capping behavior. |
| packages/web-shell/client/main.tsx | Wires OpenWork desktop layer into the standalone shell (refs, link routing, notifications, streaming state). |
| packages/web-shell/client/i18n.openwork.test.ts | Verifies locale normalization and legacy OpenWork keys. |
| packages/web-shell/client/hooks/useComposerCore.dom.test.tsx | Stabilizes image-ingestion tests using a waitFor helper. |
| packages/web-shell/client/customization.tsx | Extends customization surface (link handling) and refines composer render info types. |
| packages/web-shell/client/components/skills/SkillsManagerPage.tsx | Adds curated OpenWork marketplace cards with install flow + notice tone handling. |
| packages/web-shell/client/components/RootErrorFallback.tsx | Adjusts language copy table typing to ensure en is always present. |
| packages/web-shell/client/components/messages/UserMessage.module.css | Applies OpenWork chat text scale variable to user messages. |
| packages/web-shell/client/components/messages/SettingsMessage.tsx | Adds settings search, OpenWork appearance section, and expands chat width options. |
| packages/web-shell/client/components/messages/SettingsMessage.dom.test.tsx | Updates defaults and tests filtering across settings + OpenWork appearance controls. |
| packages/web-shell/client/components/messages/Markdown.tsx | Allows host interception of safe external links. |
| packages/web-shell/client/components/messages/Markdown.test.ts | Tests host link routing behavior. |
| packages/web-shell/client/components/messages/Markdown.module.css | Applies OpenWork chat text scale variable to rendered markdown. |
| packages/web-shell/client/components/messages/AssistantMessage.tsx | Improves copy UX with failure feedback and an aria-live status announcement. |
| packages/web-shell/client/components/messages/AssistantMessage.test.tsx | Tests copy success/failure feedback and raw markdown copy. |
| packages/web-shell/client/components/dialogs/HelpDialog.tsx | Adds command palette shortcut, and enables search filtering on the General tab too. |
| packages/web-shell/client/components/dialogs/HelpDialog.test.tsx | Tests filtering of General shortcuts via help search. |
| packages/web-shell/client/components/ChatEditor.tsx | Expands chat width modes and exposes toolbar command execution without submitting drafts. |
| packages/web-shell/client/components/ChatEditor.test.tsx | Adds coverage for toolbar command execution vs draft submission. |
| packages/web-shell/client/components/channels/ChannelsManagerPage.test.tsx | Updates expectations for expanded channel catalog visibility (Telegram included). |
| packages/web-shell/client/components/channels/channel-platform.ts | Adds Telegram/WhatsApp platform support + marks + type guard updates. |
| packages/web-shell/client/components/channels/channel-platform.test.ts | Updates tests for expanded supported channel allowlist. |
| packages/web-shell/client/App.tsx | Adds external shell APIs (settings/skills/channels/shortcuts/worktree sessions), chat width persistence expansion, and improved open-session routing by workspaceId. |
| packages/web-shell/client/App.test.tsx | Tests new external shell APIs and session routing behavior. |
| packages/desktop-shell/src-tauri/windows/electron-migration.nsh | Adds NSIS preinstall hook to uninstall prior Electron install (current-user) during update. |
| packages/desktop-shell/src-tauri/tauri.conf.json | Bumps app version to 0.2.0, enables asset protocol for pets, adds updater/deep-link config, and expands capabilities. |
| packages/desktop-shell/src-tauri/src/runtime.rs | Runs legacy migration on runtime start and wires document-tool environment (uv/scripts/PATH) into the bundled daemon spawn. |
| packages/desktop-shell/src-tauri/Cargo.toml | Bumps version and enables new Tauri features/plugins (deep-link, updater, notification). |
| packages/desktop-shell/src-tauri/capabilities/runtime.json | Defines runtime capability set for loopback Web Shell desktop integrations (browser, pet, updates, state sync). |
| packages/desktop-shell/src-tauri/capabilities/pet.json | Adds pet webview capability and permissions for sprite resolving + dragging. |
| packages/desktop-shell/src-tauri/capabilities/bootstrap.json | Expands bootstrap capability to manage runtime lifecycle actions. |
| packages/desktop-shell/src-tauri/build.rs | Declares explicit command allowlist into the generated app manifest. |
| packages/desktop-shell/scripts/test-migration.js | Adds a Node-based migration/rollback test harness for legacy import behavior. |
| packages/desktop-shell/scripts/smoke-runtime.js | Extends runtime smoke verification to include uv + document tool launchers + migration entrypoint. |
| packages/desktop-shell/scripts/prepare-runtime.js | Bundles document tools + pinned uv runtime, supports checksum refresh, and generalizes archive extraction. |
| packages/desktop-shell/README.md | Documents uv/tools bundling, migration behavior, pets, and the release workflow expectations. |
| packages/desktop-shell/package.json | Bumps to 0.2.0 and adds migration test script. |
| packages/desktop-shell/package-lock.json | Aligns lockfile version metadata to 0.2.0. |
| packages/desktop-shell/migration/openwork-migrate.mjs | Implements one-time, idempotent legacy data migration with audit report + rollback support. |
| packages/desktop-shell/bootstrap/pet.js | Allows loading non-default pet sprites via Tauri invoke. |
| packages/desktop-shell/bootstrap/pet.html | Adds isolated pet webview HTML/CSP and reduced-motion behavior. |
| packages/desktop-shell/bootstrap/index.html | Improves bootstrap “starting” state styling and accessibility of the OpenWork mark. |
| packages/desktop-shell/bootstrap/bootstrap.js | Adds explicit bootstrap state transitions and workspace snapshot behavior during startup/retry. |
| packages/cli/src/ui/commands/effort-command.ts | Adds /effort default to clear override and persist provider/model default. |
| packages/cli/src/ui/commands/effort-command.test.ts | Tests the new /effort default behavior. |
| packages/cli/src/serve/routes/session.ts | Strengthens session restore routing across multi-workspace: avoid primary fallback, resolve persisted owner, and enforce explicit-workspace conflicts. |
| packages/cli/src/serve/multi-workspace-sessions.test.ts | Adds coverage for restoring dormant sessions via persisted workspace ownership and no-primary-fallback for unknown sessions. |
| packages/cli/src/serve/channel-management-service.ts | Ensures adapter state dir is removed when deleting a channel instance, with staging + rollback on settings write failure. |
| packages/cli/src/serve/channel-management-service.test.ts | Tests channel deletion state cleanup and rollback behavior on failure. |
| packages/cli/src/commands/channel/daemon-worker.ts | Adds terminal adapter disconnect signaling to supervisor (worker exits to trigger restart). |
| packages/cli/src/commands/channel/daemon-worker.test.ts | Tests terminal disconnect propagation and supervisor restart exit path. |
| packages/cli/src/commands/channel/channel-registry.ts | Registers WhatsApp as a built-in channel plugin. |
| packages/cli/src/commands/channel/channel-registry.test.ts | Updates catalog/manageable channel expectations to include Telegram/WhatsApp. |
| packages/cli/src/commands/channel/channel-registry-builtins.test.ts | Updates manageable built-ins expectations (Telegram/WhatsApp). |
| packages/cli/package.json | Adds workspace dependency on @qwen-code/channel-whatsapp. |
| packages/channels/whatsapp/vitest.config.ts | Adds vitest config for the WhatsApp channel package. |
| packages/channels/whatsapp/tsconfig.json | Adds TS project config for the WhatsApp channel package. |
| packages/channels/whatsapp/src/WhatsAppAdapter.ts | Implements WhatsApp channel adapter (Baileys) with auth-state hardening, reconnects, echo filtering, and terminal disconnect handling. |
| packages/channels/whatsapp/src/WhatsAppAdapter.test.ts | Tests WhatsApp connection readiness, auth hardening (non-win32), and terminal disconnect semantics. |
| packages/channels/whatsapp/src/message.ts | Adds message parsing and inbound filtering helpers for WhatsApp. |
| packages/channels/whatsapp/src/message.test.ts | Tests WhatsApp message parsing/filtering behavior. |
| packages/channels/whatsapp/src/index.ts | Exposes WhatsApp channel plugin with manageable fields + validation. |
| packages/channels/whatsapp/package.json | Adds WhatsApp channel package metadata + deps/scripts. |
| packages/channels/telegram/src/index.ts | Adds management metadata for Telegram (bot token as secret/env-resolvable). |
| packages/channels/base/src/ChannelBase.ts | Adds an optional onTerminalDisconnect callback to channel adapter options. |
| package.json | Adds WhatsApp channel package to workspace list. |
| docs/developers/openwork-upstream-maintenance.md | Documents upstream merge workflow and OpenWork workflow policy boundaries. |
| docs/design/openwork-tauri-pr2.md | Captures PR2 scope, security boundaries, and verification plan for the parity landing. |
| docs/design/openwork-tauri-customization-audit.md | Updates customization audit status to reflect parity decisions. |
| docs/design/desktop-electron-to-tauri-update-bridge.md | Updates design doc to OpenWork-specific Electron→Tauri bridge contract. |
| docs/design/2026-07-31-desktop-web-shell-release.md | Updates design doc to fixed desktop-latest/latest.json feed semantics. |
| CONTRIBUTING.md | Updates cloning and desktop build instructions for OpenWork repo structure. |
| .gitignore | Ignores autogenerated desktop-shell permission artifacts. |
| .github/workflows/desktop-release.yml | Adds Desktop Release workflow with dry-run default and optional Electron bridge publishing. |
| .github/workflows/ci.yml | Renames CI, adds workflow inventory test, gates model-backed integration job to QwenLM/qwen-code, and pins OpenWork Windows runner routing. |
| .github/scripts/openwork-workflows.test.mjs | Enforces explicit review allowlist for checked-in workflows. |
| .github/scripts/create-electron-bridge-manifest.mjs | Generalizes manifest generation by platform patterns and requires --platform. |
| .github/actionlint.yaml | Adds a self-hosted runner label used by desktop workflows. |
| .agents/skills/desktop-pet/SKILL.md | Updates pet creator skill docs to Tauri pet window + scoped asset protocol behavior. |
| .agents/skills/desktop-develop/SKILL.md | Updates desktop dev harness docs from Electron to Tauri/Web Shell workflow. |
| .agents/skills/desktop-brand-builder/SKILL.md | Updates branding skill docs to target the Tauri desktop shell and bundle outputs. |
Files not reviewed (1)
- packages/desktop-shell/package-lock.json: Generated file
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+1
to
+15
| import catppuccin from '../../../desktop/apps/electron/resources/themes/catppuccin.json'; | ||
| import defaultTheme from '../../../desktop/apps/electron/resources/themes/default.json'; | ||
| import dracula from '../../../desktop/apps/electron/resources/themes/dracula.json'; | ||
| import ghostty from '../../../desktop/apps/electron/resources/themes/ghostty.json'; | ||
| import github from '../../../desktop/apps/electron/resources/themes/github.json'; | ||
| import gruvbox from '../../../desktop/apps/electron/resources/themes/gruvbox.json'; | ||
| import haze from '../../../desktop/apps/electron/resources/themes/haze.json'; | ||
| import nightOwl from '../../../desktop/apps/electron/resources/themes/night-owl.json'; | ||
| import nord from '../../../desktop/apps/electron/resources/themes/nord.json'; | ||
| import oneDarkPro from '../../../desktop/apps/electron/resources/themes/one-dark-pro.json'; | ||
| import pierre from '../../../desktop/apps/electron/resources/themes/pierre.json'; | ||
| import rosePine from '../../../desktop/apps/electron/resources/themes/rose-pine.json'; | ||
| import solarized from '../../../desktop/apps/electron/resources/themes/solarized.json'; | ||
| import tokyoNight from '../../../desktop/apps/electron/resources/themes/tokyo-night.json'; | ||
| import vitesse from '../../../desktop/apps/electron/resources/themes/vitesse.json'; |
Comment on lines
+741
to
+745
| onClick={(event) => { | ||
| if (safeHref && markdown?.onOpenLink?.(safeHref)) { | ||
| event.preventDefault(); | ||
| } | ||
| }} |
Uh oh!
There was an error while loading. Please reload this page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does
This PR completes the OpenWork Tauri landing that stopped after #81 reached
main. It lands the final #82 and #83 results on the default-branch baseline, including Tauri/Web Shell product parity, safe legacy-data migration, desktop-native integration, workspace and channel behavior, four-platform packaging, the Tauri updater, and the one-time Electron-to-Tauri compatibility bridge.It also restores a bounded OpenWork workflow set. Qwen-owned workflow files remain in the repository for upstream maintenance but stay disabled in GitHub Actions; SDK Java is now disabled at repository level without deleting its workflow file. Desktop Release remains active and defaults to a non-publishing dry run.
Why it's needed
#81 was merged into
mainbefore #82 and #83 were merged into their parent feature branches. GitHub therefore showed the stacked PRs as merged even though only the first layer reached the default branch. This PR makesmaincontain the complete reviewed desktop stack and leaves one tested release path that can build installers after merge without publishing by default.Reviewer Test Plan
How to verify
main, including migration, updater, release, workspace, channel, and desktop-native paths.Evidence (Before & After)
The UI baseline and screenshots are in PR1 (#81). This integration PR adds no separate visual redesign; its new evidence is the successful cross-platform installer matrix and browser smoke run linked above.
Tested on
Environment (optional)
GitHub-hosted macOS Apple Silicon, macOS Intel, Windows x64, and Linux x64 runners; OpenWork desktop version
0.2.0;electron_bridge=true;dry_run=true. Four installer artifact sets were uploaded with 14-day retention. No GitHub Release was created, no stable updater feed was changed, and no formal desktop app was published.Risk & Scope
0.2.0. The legacyOpenWork_0.1.0_aarch64.dmgis stale and is not a release candidate. Legacy data migration fails closed on unreadable or malformed source data, and Electron compatibility assets are generated only when the release bridge is enabled.Linked Issues
Related to #80, #81, #82, and #83. The upstream Qwen Electron-to-Tauri bridge is QwenLM/qwen-code#8392.
中文说明
本 PR 做了什么
这个 PR 补全了只将 #81 合入
main后中断的 OpenWork Tauri 落地。它把 #82 和 #83 的最终结果真正合入默认分支基线，包含 Tauri/Web Shell 产品能力对齐、安全的旧数据迁移、桌面原生集成、工作区和频道行为、四平台打包、Tauri updater，以及一次性的 Electron 到 Tauri 兼容升级桥。它同时恢复了边界清晰的 OpenWork workflow 集合。继承自 Qwen 的 workflow 文件继续保留在仓库中以便后续同步维护，但在 GitHub Actions 中保持禁用；SDK Java 也已在仓库层面禁用，没有删除 workflow 文件。Desktop Release 保持启用，并默认执行不发布的 dry run。
为什么需要
#81 先合入了
main，随后 #82 和 #83 分别合入各自的父功能分支。因此 GitHub 显示堆叠 PR 都已合并，但真正进入默认分支的只有第一层。这个 PR 让main包含完整且已审核的桌面端堆栈，并留下一个经过验证的发布路径：合入后可以直接构建安装包，默认不会发布。Reviewer 测试计划
如何验证
main上完整包含 feat(desktop): complete OpenWork Tauri parity #82 和 fix(desktop): preserve Electron to Tauri upgrades #83 的行为，包括迁移、更新、发布、工作区、频道和桌面原生路径。Electron -> Tauri -> 更新版 Tauri链路；不要把 dry-run artifacts 当作正式更新包。证据（Before & After）
UI 基线和截图已放在 PR1（#81）中。这个集成 PR 没有再引入独立的视觉重设计；新增证据是上面链接的跨平台安装包矩阵和浏览器 smoke 运行。
测试平台
环境（可选）
GitHub 托管的 macOS Apple Silicon、macOS Intel、Windows x64 和 Linux x64 runner；OpenWork 桌面版本
0.2.0；electron_bridge=true；dry_run=true。四组安装包 artifacts 已上传并保留 14 天。没有创建 GitHub Release，没有更新稳定 updater feed，也没有发布正式桌面应用。风险与范围
Electron -> Tauri -> 下一版 Tauri更新链。这些仍是使用真实 secrets 和隔离更新源的发布前 canary 门槛。0.2.0的 Tauri/Web Shell 应用。旧的OpenWork_0.1.0_aarch64.dmg已过期，不能作为候选发布包。旧数据遇到不可读或格式错误时会安全失败；只有启用发布桥时才生成 Electron 兼容资产。关联内容
关联 #80、#81、#82 和 #83。上游 Qwen 的 Electron 到 Tauri 桥接为 QwenLM/qwen-code#8392。