add define to supress macro warnings Wimplicit-fallthrough for Clang - #2
Conversation
|
|
||
| #include "coroutine.hpp" | ||
|
|
||
| #if defined(__clang__) |
There was a problem hiding this comment.
Do we need something that's compiler-portable here rather than just the GCC pragma? Should we be using Hedley to handle the suppression? I'm not sure that this pragma will work on PS or Switch which use clang.
Given that we include yield.hpp at the top and unyield.hpp at the bottom, I'm wondering if we should make our own wrappers for those files in the SDK itself which handle these warnings and can use Hedley to handle this more portably.
There was a problem hiding this comment.
Hedley dont contains anything to handle the warning suppresion for Implicit-fallthough, only HEDLEY_FALL_THROUGH but i dont work for macro.
I also tried to add the push/diagnostic ignored wimplicit in yield.hpp and pop in unyield.hpp , it will also supress the warnings who are not contained in the macro, do we really want that ?
what i will suggest, will be to modify the macro i created to make it more compiler-portable.
What do you think @stephenwhittle ?
There was a problem hiding this comment.
Yep, making it more compiler portable will be fine and then this will be approved
|
Update, @stephenwhittle , tested it on NX and Linux |
Link to task : https://app.clickup.com/t/9003015469/GF_CPP-731
Supress the warnings in the coroutine macro that was causing +400 warnings.