Add remove(int) functionality to clear long running tasks.

[sdesalas]

Hiya Moin 👋 .

I've been using your library on an arduino-clone AVR project I started recently. Thanks for making it available.

While applying the async/scheduled tasks to my code I realized that there was some functionality missing that I needed. The ability to cancel long-running tasks.

So I exposed remove(int taskId) (previously private method removeTask(int taskId)) to allow cancelling existing tasks by id (wether its repeated task or otherwise). And also added the ability to return int task ids at creation time (using once() or repeat() methods) so they could be cancelled later.

I also changed the taskId type from int to unsigned int to make all task Ids positive. This is probably not critical since without the change the taskId++ will just wrap-around due to overflow when you hit 32K and start asigning negative task Ids. But it makes things a bit easier to understand and use, specially for logging purposes.

I thought I'd let you know about my changes and give you a chance to merge them upstream if you think them useful. There is also a couple of corrections to the README to reflect the above, as well as the use of .loop() instead of .run() which was incorrect originally.

Kind Regards,
Steven

[sdesalas]

Hiya Moin 👋 .

I've been using your library on an arduino-clone AVR project I started recently. Thanks for making it available.

While applying the async/scheduled tasks to my code I realized that there was some functionality missing that I needed. The ability to cancel long-running tasks.

So I exposed remove(int taskId) (previously private method removeTask(int taskId)) to allow cancelling existing tasks by id (wether its repeated task or otherwise). And also added the ability to return int task ids at creation time (using once() or repeat() methods) so they could be cancelled later.

I also changed the taskId type from int to unsigned int to make all task Ids positive. This is probably not critical since without the change the taskId++ will just wrap-around due to overflow when you hit 32K and start asigning negative task Ids. But it makes things a bit easier to understand and use, specially for logging purposes.

I thought I'd let you know about my changes and give you a chance to merge them upstream if you think them useful. There is also a couple of corrections to the README to reflect the above, as well as the use of .loop() instead of .run() which was incorrect originally.

Kind Regards,
Steven

[sdesalas]

Hiya Moin 👋 .

I've been using your library on an arduino-clone AVR project I started recently. Thanks for making it available.

While applying the async/scheduled tasks to my code I realized that there was some functionality missing that I needed. The ability to cancel long-running tasks.

So I exposed remove(int taskId) (previously private method removeTask(int taskId)) to allow cancelling existing tasks by id (wether its repeated task or otherwise). And also added the ability to return int task ids at creation time (using once() or repeat() methods) so they could be cancelled later.

I also changed the taskId type from int to unsigned int to make all task Ids positive. This is probably not critical since without the change the taskId++ will just wrap-around due to overflow when you hit 32K and start asigning negative task Ids. But it makes things a bit easier to understand and use, specially for logging purposes.

I thought I'd let you know about my changes and give you a chance to merge them upstream if you think them useful. There is also a couple of corrections to the README to reflect the above, as well as the use of .loop() instead of .run() which was incorrect originally.

Kind Regards,
Steven

[sdesalas]

Hiya Moin 👋 .

I've been using your library on an arduino-clone AVR project I started recently. Thanks for making it available.

While applying the async/scheduled tasks to my code I realized that there was some functionality missing that I needed. The ability to cancel long-running tasks.

So I exposed remove(int taskId) (previously private method removeTask(int taskId)) to allow cancelling existing tasks by id (wether its repeated task or otherwise). And also added the ability to return int task ids at creation time (using once() or repeat() methods) so they could be cancelled later.

I also changed the taskId type from int to unsigned int to make all task Ids positive. This is probably not critical since without the change the taskId++ will just wrap-around due to overflow when you hit 32K and start asigning negative task Ids. But it makes things a bit easier to understand and use, specially for logging purposes.

I thought I'd let you know about my changes and give you a chance to merge them upstream if you think them useful. There is also a couple of corrections to the README to reflect the above, as well as the use of .loop() instead of .run() which was incorrect originally.

Kind Regards,
Steven

[sdesalas]

Hiya Moin 👋 .

I've been using your library on an arduino-clone AVR project I started recently. Thanks for making it available.

While applying the async/scheduled tasks to my code I realized that there was some functionality missing that I needed. The ability to cancel long-running tasks.

So I exposed remove(int taskId) (previously private method removeTask(int taskId)) to allow cancelling existing tasks by id (wether its repeated task or otherwise). And also added the ability to return int task ids at creation time (using once() or repeat() methods) so they could be cancelled later.

I also changed the taskId type from int to unsigned int to make all task Ids positive. This is probably not critical since without the change the taskId++ will just wrap-around due to overflow when you hit 32K and start asigning negative task Ids. But it makes things a bit easier to understand and use, specially for logging purposes.

I thought I'd let you know about my changes and give you a chance to merge them upstream if you think them useful. There is also a couple of corrections to the README to reflect the above, as well as the use of .loop() instead of .run() which was incorrect originally.

Kind Regards,
Steven

[sdesalas]

Hiya Moin 👋 .

I've been using your library on an arduino-clone AVR project I started recently. Thanks for making it available.

While applying the async/scheduled tasks to my code I realized that there was some functionality missing that I needed. The ability to cancel long-running tasks.

So I exposed remove(int taskId) (previously private method removeTask(int taskId)) to allow cancelling existing tasks by id (wether its repeated task or otherwise). And also added the ability to return int task ids at creation time (using once() or repeat() methods) so they could be cancelled later.

I also changed the taskId type from int to unsigned int to make all task Ids positive. This is probably not critical since without the change the taskId++ will just wrap-around due to overflow when you hit 32K and start asigning negative task Ids. But it makes things a bit easier to understand and use, specially for logging purposes.

I thought I'd let you know about my changes and give you a chance to merge them upstream if you think them useful. There is also a couple of corrections to the README to reflect the above, as well as the use of .loop() instead of .run() which was incorrect originally.

Kind Regards,
Steven

[sdesalas]

Hiya Moin 👋 .

I've been using your library on an arduino-clone AVR project I started recently. Thanks for making it available.

While applying the async/scheduled tasks to my code I realized that there was some functionality missing that I needed. The ability to cancel long-running tasks.

So I exposed remove(int taskId) (previously private method removeTask(int taskId)) to allow cancelling existing tasks by id (wether its repeated task or otherwise). And also added the ability to return int task ids at creation time (using once() or repeat() methods) so they could be cancelled later.

I also changed the taskId type from int to unsigned int to make all task Ids positive. This is probably not critical since without the change the taskId++ will just wrap-around due to overflow when you hit 32K and start asigning negative task Ids. But it makes things a bit easier to understand and use, specially for logging purposes.

I thought I'd let you know about my changes and give you a chance to merge them upstream if you think them useful. There is also a couple of corrections to the README to reflect the above, as well as the use of .loop() instead of .run() which was incorrect originally.

Kind Regards,
Steven

[sdesalas]

Hiya Moin 👋 .

I've been using your library on an arduino-clone AVR project I started recently. Thanks for making it available.

While applying the async/scheduled tasks to my code I realized that there was some functionality missing that I needed. The ability to cancel long-running tasks.

So I exposed remove(int taskId) (previously private method removeTask(int taskId)) to allow cancelling existing tasks by id (wether its repeated task or otherwise). And also added the ability to return int task ids at creation time (using once() or repeat() methods) so they could be cancelled later.

I also changed the taskId type from int to unsigned int to make all task Ids positive. This is probably not critical since without the change the taskId++ will just wrap-around due to overflow when you hit 32K and start asigning negative task Ids. But it makes things a bit easier to understand and use, specially for logging purposes.

I thought I'd let you know about my changes and give you a chance to merge them upstream if you think them useful. There is also a couple of corrections to the README to reflect the above, as well as the use of .loop() instead of .run() which was incorrect originally.

Kind Regards,
Steven