Uh oh!
There was an error while loading. Please reload this page.
fix: Slow and Steady Challenge Authentication (@AnnaBuchholz) - #6319
Merged
Conversation
…re already in this file and the British English spellings were already in the britishenglish file)
…d the American spelling was already in this file as well.
…as already in this file and in the britishenglish file)
…if the 25k already had the common American spelling
AnnaBuchholz
commented
Feb 27, 2025
ContributorAuthor
I think I just needed to update the legacy naming to fix the challenge authentication, but if I missed other places I need to change, please let me know. |
fehmer
commented
Feb 28, 2025
Member
can you verify the fix is working locally? |
AnnaBuchholz
commented
Feb 28, 2025
ContributorAuthor
I just tried doing the Slow and Steady challenge on localhost, but at the end there were no notifications at all (of challenge success or failure). It seems like I might need to be logged in to test the challenge authentication but I'm not sure how to log in as a user to test the challenge on the test site. Any idea what I could do to test it? |
AnnaBuchholz
commented
Mar 2, 2025
ContributorAuthor
Alright, I posted some proof in the Discord. If there's anything else I need to do, please let me know. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
I changed the Slow and Steady authentication to check if "liveSpeedStyle" is "off" rather than checking the if the legacy "showLiveWpm" was "false". This allows people to actually get the Slow and Steady challenge role automatically instead of getting a failure error even when they had liveSpeedStyle off.
Checks
Closes #