impr(commandline): improve performance (@fehmer) by fehmer · Pull Request #6559 · monkeytypegame/monkeytype

fehmer · 2025-05-13T09:23:17Z

No description provided.

sentry · 2025-05-13T09:23:32Z

🔍 Existing Issues For Review

Your pull request is modifying functions with the following pre-existing issues:

📄 File: frontend/src/ts/commandline/commandline.ts

Function	Unhandled Issue
`runActiveCommand`	TypeError: null is not an object (evaluating 'e.webkitEnterFullscreen') ... `Event Count:`1`Affected Users:`1
`showCommands`	Error: Commandline element not found / `Event Count:`1`Affected Users:`2

_{Did you find this useful? React with a 👍 or 👎}

sentry · 2025-05-15T13:14:15Z

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

‼️Error: Commandline element not found/View Issue

_{Did you find this useful? React with a 👍 or 👎}

…@byseif21

…@byseif21, @fehmer) (#6586) ### Description Previously, when selecting a language via the text button on the test page, the checkmark (fa-check) in the commandline language list wouldn't update until a page refresh. This was due to the commandline's caching mechanism not detecting changes triggered outside its own control. Although it first appeared to be a language-specific issue, it was later identified that the caching logic was generally insufficient — it didn’t account for updates to the active command state or configuration flags like usingSingleList. ## Solution Fixed the caching logic in the commandline module by tracking a more complete internal state. The system now correctly detects changes in the command list, active state, and configuration, and rebuilds the list UI when necessary. ## Technical Details - The commandline uses a caching mechanism (`lastList`) to avoid rebuilding the HTML if the list hasn't changed done in #6559 - Replaced the old lastList cache with a new lastState object that stores: the list of commands, each with its isActive flag, the usingSingleList configuration flag - Improved the cache comparison logic, uses areSortedArraysEqual to compare command lists including active state ,compares the usingSingleList flag - Previously, this cache wasn't being cleared when the language changed through the text button - Now we clear the cache on changes, forcing a rebuild of the list with the correct checkmark ## Performance Impact - Minimal performance impact - The list is only rebuilt when: 1. The language actually changes 2. The list content changes 3. The input value changes - The caching mechanism still prevents unnecessary rebuilds in all other cases ## Testing - [x] Language selection through text button updates checkmark immediately - [x] Language selection through commandline works as before - [x] No unnecessary rebuilds when language hasn't changed - [x] Checkmark appears next to correct language in all cases

…@byseif21

…@byseif21, @fehmer) (monkeytypegame#6586) ### Description Previously, when selecting a language via the text button on the test page, the checkmark (fa-check) in the commandline language list wouldn't update until a page refresh. This was due to the commandline's caching mechanism not detecting changes triggered outside its own control. Although it first appeared to be a language-specific issue, it was later identified that the caching logic was generally insufficient — it didn’t account for updates to the active command state or configuration flags like usingSingleList. ## Solution Fixed the caching logic in the commandline module by tracking a more complete internal state. The system now correctly detects changes in the command list, active state, and configuration, and rebuilds the list UI when necessary. ## Technical Details - The commandline uses a caching mechanism (`lastList`) to avoid rebuilding the HTML if the list hasn't changed done in monkeytypegame#6559 - Replaced the old lastList cache with a new lastState object that stores: the list of commands, each with its isActive flag, the usingSingleList configuration flag - Improved the cache comparison logic, uses areSortedArraysEqual to compare command lists including active state ,compares the usingSingleList flag - Previously, this cache wasn't being cleared when the language changed through the text button - Now we clear the cache on changes, forcing a rebuild of the list with the correct checkmark ## Performance Impact - Minimal performance impact - The list is only rebuilt when: 1. The language actually changes 2. The list content changes 3. The input value changes - The caching mechanism still prevents unnecessary rebuilds in all other cases ## Testing - [x] Language selection through text button updates checkmark immediately - [x] Language selection through commandline works as before - [x] No unnecessary rebuilds when language hasn't changed - [x] Checkmark appears next to correct language in all cases

fehmer · 2025-05-13T09:23:17Z

No description provided.

sentry · 2025-05-13T09:23:32Z

🔍 Existing Issues For Review

Your pull request is modifying functions with the following pre-existing issues:

📄 File: frontend/src/ts/commandline/commandline.ts

Function	Unhandled Issue
`runActiveCommand`	TypeError: null is not an object (evaluating 'e.webkitEnterFullscreen') ... `Event Count:`1`Affected Users:`1
`showCommands`	Error: Commandline element not found / `Event Count:`1`Affected Users:`2

_{Did you find this useful? React with a 👍 or 👎}

sentry · 2025-05-15T13:14:15Z

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

‼️Error: Commandline element not found/View Issue

_{Did you find this useful? React with a 👍 or 👎}

…@byseif21

…@byseif21, @fehmer) (#6586) ### Description Previously, when selecting a language via the text button on the test page, the checkmark (fa-check) in the commandline language list wouldn't update until a page refresh. This was due to the commandline's caching mechanism not detecting changes triggered outside its own control. Although it first appeared to be a language-specific issue, it was later identified that the caching logic was generally insufficient — it didn’t account for updates to the active command state or configuration flags like usingSingleList. ## Solution Fixed the caching logic in the commandline module by tracking a more complete internal state. The system now correctly detects changes in the command list, active state, and configuration, and rebuilds the list UI when necessary. ## Technical Details - The commandline uses a caching mechanism (`lastList`) to avoid rebuilding the HTML if the list hasn't changed done in #6559 - Replaced the old lastList cache with a new lastState object that stores: the list of commands, each with its isActive flag, the usingSingleList configuration flag - Improved the cache comparison logic, uses areSortedArraysEqual to compare command lists including active state ,compares the usingSingleList flag - Previously, this cache wasn't being cleared when the language changed through the text button - Now we clear the cache on changes, forcing a rebuild of the list with the correct checkmark ## Performance Impact - Minimal performance impact - The list is only rebuilt when: 1. The language actually changes 2. The list content changes 3. The input value changes - The caching mechanism still prevents unnecessary rebuilds in all other cases ## Testing - [x] Language selection through text button updates checkmark immediately - [x] Language selection through commandline works as before - [x] No unnecessary rebuilds when language hasn't changed - [x] Checkmark appears next to correct language in all cases

…@byseif21

…@byseif21, @fehmer) (monkeytypegame#6586) ### Description Previously, when selecting a language via the text button on the test page, the checkmark (fa-check) in the commandline language list wouldn't update until a page refresh. This was due to the commandline's caching mechanism not detecting changes triggered outside its own control. Although it first appeared to be a language-specific issue, it was later identified that the caching logic was generally insufficient — it didn’t account for updates to the active command state or configuration flags like usingSingleList. ## Solution Fixed the caching logic in the commandline module by tracking a more complete internal state. The system now correctly detects changes in the command list, active state, and configuration, and rebuilds the list UI when necessary. ## Technical Details - The commandline uses a caching mechanism (`lastList`) to avoid rebuilding the HTML if the list hasn't changed done in monkeytypegame#6559 - Replaced the old lastList cache with a new lastState object that stores: the list of commands, each with its isActive flag, the usingSingleList configuration flag - Improved the cache comparison logic, uses areSortedArraysEqual to compare command lists including active state ,compares the usingSingleList flag - Previously, this cache wasn't being cleared when the language changed through the text button - Now we clear the cache on changes, forcing a rebuild of the list with the correct checkmark ## Performance Impact - Minimal performance impact - The list is only rebuilt when: 1. The language actually changes 2. The list content changes 3. The input value changes - The caching mechanism still prevents unnecessary rebuilds in all other cases ## Testing - [x] Language selection through text button updates checkmark immediately - [x] Language selection through commandline works as before - [x] No unnecessary rebuilds when language hasn't changed - [x] Checkmark appears next to correct language in all cases

fehmer · 2025-05-13T09:23:17Z

No description provided.

sentry · 2025-05-13T09:23:32Z

🔍 Existing Issues For Review

Your pull request is modifying functions with the following pre-existing issues:

📄 File: frontend/src/ts/commandline/commandline.ts

Function	Unhandled Issue
`runActiveCommand`	TypeError: null is not an object (evaluating 'e.webkitEnterFullscreen') ... `Event Count:`1`Affected Users:`1
`showCommands`	Error: Commandline element not found / `Event Count:`1`Affected Users:`2

_{Did you find this useful? React with a 👍 or 👎}

sentry · 2025-05-15T13:14:15Z

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

‼️Error: Commandline element not found/View Issue

_{Did you find this useful? React with a 👍 or 👎}

…@byseif21

…@byseif21, @fehmer) (#6586) ### Description Previously, when selecting a language via the text button on the test page, the checkmark (fa-check) in the commandline language list wouldn't update until a page refresh. This was due to the commandline's caching mechanism not detecting changes triggered outside its own control. Although it first appeared to be a language-specific issue, it was later identified that the caching logic was generally insufficient — it didn’t account for updates to the active command state or configuration flags like usingSingleList. ## Solution Fixed the caching logic in the commandline module by tracking a more complete internal state. The system now correctly detects changes in the command list, active state, and configuration, and rebuilds the list UI when necessary. ## Technical Details - The commandline uses a caching mechanism (`lastList`) to avoid rebuilding the HTML if the list hasn't changed done in #6559 - Replaced the old lastList cache with a new lastState object that stores: the list of commands, each with its isActive flag, the usingSingleList configuration flag - Improved the cache comparison logic, uses areSortedArraysEqual to compare command lists including active state ,compares the usingSingleList flag - Previously, this cache wasn't being cleared when the language changed through the text button - Now we clear the cache on changes, forcing a rebuild of the list with the correct checkmark ## Performance Impact - Minimal performance impact - The list is only rebuilt when: 1. The language actually changes 2. The list content changes 3. The input value changes - The caching mechanism still prevents unnecessary rebuilds in all other cases ## Testing - [x] Language selection through text button updates checkmark immediately - [x] Language selection through commandline works as before - [x] No unnecessary rebuilds when language hasn't changed - [x] Checkmark appears next to correct language in all cases

…@byseif21

…@byseif21, @fehmer) (monkeytypegame#6586) ### Description Previously, when selecting a language via the text button on the test page, the checkmark (fa-check) in the commandline language list wouldn't update until a page refresh. This was due to the commandline's caching mechanism not detecting changes triggered outside its own control. Although it first appeared to be a language-specific issue, it was later identified that the caching logic was generally insufficient — it didn’t account for updates to the active command state or configuration flags like usingSingleList. ## Solution Fixed the caching logic in the commandline module by tracking a more complete internal state. The system now correctly detects changes in the command list, active state, and configuration, and rebuilds the list UI when necessary. ## Technical Details - The commandline uses a caching mechanism (`lastList`) to avoid rebuilding the HTML if the list hasn't changed done in monkeytypegame#6559 - Replaced the old lastList cache with a new lastState object that stores: the list of commands, each with its isActive flag, the usingSingleList configuration flag - Improved the cache comparison logic, uses areSortedArraysEqual to compare command lists including active state ,compares the usingSingleList flag - Previously, this cache wasn't being cleared when the language changed through the text button - Now we clear the cache on changes, forcing a rebuild of the list with the correct checkmark ## Performance Impact - Minimal performance impact - The list is only rebuilt when: 1. The language actually changes 2. The list content changes 3. The input value changes - The caching mechanism still prevents unnecessary rebuilds in all other cases ## Testing - [x] Language selection through text button updates checkmark immediately - [x] Language selection through commandline works as before - [x] No unnecessary rebuilds when language hasn't changed - [x] Checkmark appears next to correct language in all cases

fehmer · 2025-05-13T09:23:17Z

No description provided.

sentry · 2025-05-13T09:23:32Z

🔍 Existing Issues For Review

Your pull request is modifying functions with the following pre-existing issues:

📄 File: frontend/src/ts/commandline/commandline.ts

Function	Unhandled Issue
`runActiveCommand`	TypeError: null is not an object (evaluating 'e.webkitEnterFullscreen') ... `Event Count:`1`Affected Users:`1
`showCommands`	Error: Commandline element not found / `Event Count:`1`Affected Users:`2

_{Did you find this useful? React with a 👍 or 👎}

sentry · 2025-05-15T13:14:15Z

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

‼️Error: Commandline element not found/View Issue

_{Did you find this useful? React with a 👍 or 👎}

…@byseif21

…@byseif21, @fehmer) (#6586) ### Description Previously, when selecting a language via the text button on the test page, the checkmark (fa-check) in the commandline language list wouldn't update until a page refresh. This was due to the commandline's caching mechanism not detecting changes triggered outside its own control. Although it first appeared to be a language-specific issue, it was later identified that the caching logic was generally insufficient — it didn’t account for updates to the active command state or configuration flags like usingSingleList. ## Solution Fixed the caching logic in the commandline module by tracking a more complete internal state. The system now correctly detects changes in the command list, active state, and configuration, and rebuilds the list UI when necessary. ## Technical Details - The commandline uses a caching mechanism (`lastList`) to avoid rebuilding the HTML if the list hasn't changed done in #6559 - Replaced the old lastList cache with a new lastState object that stores: the list of commands, each with its isActive flag, the usingSingleList configuration flag - Improved the cache comparison logic, uses areSortedArraysEqual to compare command lists including active state ,compares the usingSingleList flag - Previously, this cache wasn't being cleared when the language changed through the text button - Now we clear the cache on changes, forcing a rebuild of the list with the correct checkmark ## Performance Impact - Minimal performance impact - The list is only rebuilt when: 1. The language actually changes 2. The list content changes 3. The input value changes - The caching mechanism still prevents unnecessary rebuilds in all other cases ## Testing - [x] Language selection through text button updates checkmark immediately - [x] Language selection through commandline works as before - [x] No unnecessary rebuilds when language hasn't changed - [x] Checkmark appears next to correct language in all cases

…@byseif21

…@byseif21, @fehmer) (monkeytypegame#6586) ### Description Previously, when selecting a language via the text button on the test page, the checkmark (fa-check) in the commandline language list wouldn't update until a page refresh. This was due to the commandline's caching mechanism not detecting changes triggered outside its own control. Although it first appeared to be a language-specific issue, it was later identified that the caching logic was generally insufficient — it didn’t account for updates to the active command state or configuration flags like usingSingleList. ## Solution Fixed the caching logic in the commandline module by tracking a more complete internal state. The system now correctly detects changes in the command list, active state, and configuration, and rebuilds the list UI when necessary. ## Technical Details - The commandline uses a caching mechanism (`lastList`) to avoid rebuilding the HTML if the list hasn't changed done in monkeytypegame#6559 - Replaced the old lastList cache with a new lastState object that stores: the list of commands, each with its isActive flag, the usingSingleList configuration flag - Improved the cache comparison logic, uses areSortedArraysEqual to compare command lists including active state ,compares the usingSingleList flag - Previously, this cache wasn't being cleared when the language changed through the text button - Now we clear the cache on changes, forcing a rebuild of the list with the correct checkmark ## Performance Impact - Minimal performance impact - The list is only rebuilt when: 1. The language actually changes 2. The list content changes 3. The input value changes - The caching mechanism still prevents unnecessary rebuilds in all other cases ## Testing - [x] Language selection through text button updates checkmark immediately - [x] Language selection through commandline works as before - [x] No unnecessary rebuilds when language hasn't changed - [x] Checkmark appears next to correct language in all cases

fehmer · 2025-05-13T09:23:17Z

No description provided.

sentry · 2025-05-13T09:23:32Z

🔍 Existing Issues For Review

Your pull request is modifying functions with the following pre-existing issues:

📄 File: frontend/src/ts/commandline/commandline.ts

Function	Unhandled Issue
`runActiveCommand`	TypeError: null is not an object (evaluating 'e.webkitEnterFullscreen') ... `Event Count:`1`Affected Users:`1
`showCommands`	Error: Commandline element not found / `Event Count:`1`Affected Users:`2

_{Did you find this useful? React with a 👍 or 👎}

sentry · 2025-05-15T13:14:15Z

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

‼️Error: Commandline element not found/View Issue

_{Did you find this useful? React with a 👍 or 👎}

…@byseif21

…@byseif21, @fehmer) (#6586) ### Description Previously, when selecting a language via the text button on the test page, the checkmark (fa-check) in the commandline language list wouldn't update until a page refresh. This was due to the commandline's caching mechanism not detecting changes triggered outside its own control. Although it first appeared to be a language-specific issue, it was later identified that the caching logic was generally insufficient — it didn’t account for updates to the active command state or configuration flags like usingSingleList. ## Solution Fixed the caching logic in the commandline module by tracking a more complete internal state. The system now correctly detects changes in the command list, active state, and configuration, and rebuilds the list UI when necessary. ## Technical Details - The commandline uses a caching mechanism (`lastList`) to avoid rebuilding the HTML if the list hasn't changed done in #6559 - Replaced the old lastList cache with a new lastState object that stores: the list of commands, each with its isActive flag, the usingSingleList configuration flag - Improved the cache comparison logic, uses areSortedArraysEqual to compare command lists including active state ,compares the usingSingleList flag - Previously, this cache wasn't being cleared when the language changed through the text button - Now we clear the cache on changes, forcing a rebuild of the list with the correct checkmark ## Performance Impact - Minimal performance impact - The list is only rebuilt when: 1. The language actually changes 2. The list content changes 3. The input value changes - The caching mechanism still prevents unnecessary rebuilds in all other cases ## Testing - [x] Language selection through text button updates checkmark immediately - [x] Language selection through commandline works as before - [x] No unnecessary rebuilds when language hasn't changed - [x] Checkmark appears next to correct language in all cases

…@byseif21

…@byseif21, @fehmer) (monkeytypegame#6586) ### Description Previously, when selecting a language via the text button on the test page, the checkmark (fa-check) in the commandline language list wouldn't update until a page refresh. This was due to the commandline's caching mechanism not detecting changes triggered outside its own control. Although it first appeared to be a language-specific issue, it was later identified that the caching logic was generally insufficient — it didn’t account for updates to the active command state or configuration flags like usingSingleList. ## Solution Fixed the caching logic in the commandline module by tracking a more complete internal state. The system now correctly detects changes in the command list, active state, and configuration, and rebuilds the list UI when necessary. ## Technical Details - The commandline uses a caching mechanism (`lastList`) to avoid rebuilding the HTML if the list hasn't changed done in monkeytypegame#6559 - Replaced the old lastList cache with a new lastState object that stores: the list of commands, each with its isActive flag, the usingSingleList configuration flag - Improved the cache comparison logic, uses areSortedArraysEqual to compare command lists including active state ,compares the usingSingleList flag - Previously, this cache wasn't being cleared when the language changed through the text button - Now we clear the cache on changes, forcing a rebuild of the list with the correct checkmark ## Performance Impact - Minimal performance impact - The list is only rebuilt when: 1. The language actually changes 2. The list content changes 3. The input value changes - The caching mechanism still prevents unnecessary rebuilds in all other cases ## Testing - [x] Language selection through text button updates checkmark immediately - [x] Language selection through commandline works as before - [x] No unnecessary rebuilds when language hasn't changed - [x] Checkmark appears next to correct language in all cases

fehmer · 2025-05-13T09:23:17Z

No description provided.

sentry · 2025-05-13T09:23:32Z

🔍 Existing Issues For Review

Your pull request is modifying functions with the following pre-existing issues:

📄 File: frontend/src/ts/commandline/commandline.ts

Function	Unhandled Issue
`runActiveCommand`	TypeError: null is not an object (evaluating 'e.webkitEnterFullscreen') ... `Event Count:`1`Affected Users:`1
`showCommands`	Error: Commandline element not found / `Event Count:`1`Affected Users:`2

_{Did you find this useful? React with a 👍 or 👎}

sentry · 2025-05-15T13:14:15Z

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

‼️Error: Commandline element not found/View Issue

_{Did you find this useful? React with a 👍 or 👎}

…@byseif21

…@byseif21, @fehmer) (#6586) ### Description Previously, when selecting a language via the text button on the test page, the checkmark (fa-check) in the commandline language list wouldn't update until a page refresh. This was due to the commandline's caching mechanism not detecting changes triggered outside its own control. Although it first appeared to be a language-specific issue, it was later identified that the caching logic was generally insufficient — it didn’t account for updates to the active command state or configuration flags like usingSingleList. ## Solution Fixed the caching logic in the commandline module by tracking a more complete internal state. The system now correctly detects changes in the command list, active state, and configuration, and rebuilds the list UI when necessary. ## Technical Details - The commandline uses a caching mechanism (`lastList`) to avoid rebuilding the HTML if the list hasn't changed done in #6559 - Replaced the old lastList cache with a new lastState object that stores: the list of commands, each with its isActive flag, the usingSingleList configuration flag - Improved the cache comparison logic, uses areSortedArraysEqual to compare command lists including active state ,compares the usingSingleList flag - Previously, this cache wasn't being cleared when the language changed through the text button - Now we clear the cache on changes, forcing a rebuild of the list with the correct checkmark ## Performance Impact - Minimal performance impact - The list is only rebuilt when: 1. The language actually changes 2. The list content changes 3. The input value changes - The caching mechanism still prevents unnecessary rebuilds in all other cases ## Testing - [x] Language selection through text button updates checkmark immediately - [x] Language selection through commandline works as before - [x] No unnecessary rebuilds when language hasn't changed - [x] Checkmark appears next to correct language in all cases

…@byseif21

…@byseif21, @fehmer) (monkeytypegame#6586) ### Description Previously, when selecting a language via the text button on the test page, the checkmark (fa-check) in the commandline language list wouldn't update until a page refresh. This was due to the commandline's caching mechanism not detecting changes triggered outside its own control. Although it first appeared to be a language-specific issue, it was later identified that the caching logic was generally insufficient — it didn’t account for updates to the active command state or configuration flags like usingSingleList. ## Solution Fixed the caching logic in the commandline module by tracking a more complete internal state. The system now correctly detects changes in the command list, active state, and configuration, and rebuilds the list UI when necessary. ## Technical Details - The commandline uses a caching mechanism (`lastList`) to avoid rebuilding the HTML if the list hasn't changed done in monkeytypegame#6559 - Replaced the old lastList cache with a new lastState object that stores: the list of commands, each with its isActive flag, the usingSingleList configuration flag - Improved the cache comparison logic, uses areSortedArraysEqual to compare command lists including active state ,compares the usingSingleList flag - Previously, this cache wasn't being cleared when the language changed through the text button - Now we clear the cache on changes, forcing a rebuild of the list with the correct checkmark ## Performance Impact - Minimal performance impact - The list is only rebuilt when: 1. The language actually changes 2. The list content changes 3. The input value changes - The caching mechanism still prevents unnecessary rebuilds in all other cases ## Testing - [x] Language selection through text button updates checkmark immediately - [x] Language selection through commandline works as before - [x] No unnecessary rebuilds when language hasn't changed - [x] Checkmark appears next to correct language in all cases

fehmer · 2025-05-13T09:23:17Z

No description provided.

sentry · 2025-05-13T09:23:32Z

🔍 Existing Issues For Review

Your pull request is modifying functions with the following pre-existing issues:

📄 File: frontend/src/ts/commandline/commandline.ts

Function	Unhandled Issue
`runActiveCommand`	TypeError: null is not an object (evaluating 'e.webkitEnterFullscreen') ... `Event Count:`1`Affected Users:`1
`showCommands`	Error: Commandline element not found / `Event Count:`1`Affected Users:`2

_{Did you find this useful? React with a 👍 or 👎}

sentry · 2025-05-15T13:14:15Z

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

‼️Error: Commandline element not found/View Issue

_{Did you find this useful? React with a 👍 or 👎}

…@byseif21

…@byseif21, @fehmer) (#6586) ### Description Previously, when selecting a language via the text button on the test page, the checkmark (fa-check) in the commandline language list wouldn't update until a page refresh. This was due to the commandline's caching mechanism not detecting changes triggered outside its own control. Although it first appeared to be a language-specific issue, it was later identified that the caching logic was generally insufficient — it didn’t account for updates to the active command state or configuration flags like usingSingleList. ## Solution Fixed the caching logic in the commandline module by tracking a more complete internal state. The system now correctly detects changes in the command list, active state, and configuration, and rebuilds the list UI when necessary. ## Technical Details - The commandline uses a caching mechanism (`lastList`) to avoid rebuilding the HTML if the list hasn't changed done in #6559 - Replaced the old lastList cache with a new lastState object that stores: the list of commands, each with its isActive flag, the usingSingleList configuration flag - Improved the cache comparison logic, uses areSortedArraysEqual to compare command lists including active state ,compares the usingSingleList flag - Previously, this cache wasn't being cleared when the language changed through the text button - Now we clear the cache on changes, forcing a rebuild of the list with the correct checkmark ## Performance Impact - Minimal performance impact - The list is only rebuilt when: 1. The language actually changes 2. The list content changes 3. The input value changes - The caching mechanism still prevents unnecessary rebuilds in all other cases ## Testing - [x] Language selection through text button updates checkmark immediately - [x] Language selection through commandline works as before - [x] No unnecessary rebuilds when language hasn't changed - [x] Checkmark appears next to correct language in all cases

…@byseif21

…@byseif21, @fehmer) (monkeytypegame#6586) ### Description Previously, when selecting a language via the text button on the test page, the checkmark (fa-check) in the commandline language list wouldn't update until a page refresh. This was due to the commandline's caching mechanism not detecting changes triggered outside its own control. Although it first appeared to be a language-specific issue, it was later identified that the caching logic was generally insufficient — it didn’t account for updates to the active command state or configuration flags like usingSingleList. ## Solution Fixed the caching logic in the commandline module by tracking a more complete internal state. The system now correctly detects changes in the command list, active state, and configuration, and rebuilds the list UI when necessary. ## Technical Details - The commandline uses a caching mechanism (`lastList`) to avoid rebuilding the HTML if the list hasn't changed done in monkeytypegame#6559 - Replaced the old lastList cache with a new lastState object that stores: the list of commands, each with its isActive flag, the usingSingleList configuration flag - Improved the cache comparison logic, uses areSortedArraysEqual to compare command lists including active state ,compares the usingSingleList flag - Previously, this cache wasn't being cleared when the language changed through the text button - Now we clear the cache on changes, forcing a rebuild of the list with the correct checkmark ## Performance Impact - Minimal performance impact - The list is only rebuilt when: 1. The language actually changes 2. The list content changes 3. The input value changes - The caching mechanism still prevents unnecessary rebuilds in all other cases ## Testing - [x] Language selection through text button updates checkmark immediately - [x] Language selection through commandline works as before - [x] No unnecessary rebuilds when language hasn't changed - [x] Checkmark appears next to correct language in all cases

fehmer · 2025-05-13T09:23:17Z

No description provided.

sentry · 2025-05-13T09:23:32Z

🔍 Existing Issues For Review

Your pull request is modifying functions with the following pre-existing issues:

📄 File: frontend/src/ts/commandline/commandline.ts

Function	Unhandled Issue
`runActiveCommand`	TypeError: null is not an object (evaluating 'e.webkitEnterFullscreen') ... `Event Count:`1`Affected Users:`1
`showCommands`	Error: Commandline element not found / `Event Count:`1`Affected Users:`2

_{Did you find this useful? React with a 👍 or 👎}

sentry · 2025-05-15T13:14:15Z

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

‼️Error: Commandline element not found/View Issue

_{Did you find this useful? React with a 👍 or 👎}

…@byseif21

…@byseif21, @fehmer) (#6586) ### Description Previously, when selecting a language via the text button on the test page, the checkmark (fa-check) in the commandline language list wouldn't update until a page refresh. This was due to the commandline's caching mechanism not detecting changes triggered outside its own control. Although it first appeared to be a language-specific issue, it was later identified that the caching logic was generally insufficient — it didn’t account for updates to the active command state or configuration flags like usingSingleList. ## Solution Fixed the caching logic in the commandline module by tracking a more complete internal state. The system now correctly detects changes in the command list, active state, and configuration, and rebuilds the list UI when necessary. ## Technical Details - The commandline uses a caching mechanism (`lastList`) to avoid rebuilding the HTML if the list hasn't changed done in #6559 - Replaced the old lastList cache with a new lastState object that stores: the list of commands, each with its isActive flag, the usingSingleList configuration flag - Improved the cache comparison logic, uses areSortedArraysEqual to compare command lists including active state ,compares the usingSingleList flag - Previously, this cache wasn't being cleared when the language changed through the text button - Now we clear the cache on changes, forcing a rebuild of the list with the correct checkmark ## Performance Impact - Minimal performance impact - The list is only rebuilt when: 1. The language actually changes 2. The list content changes 3. The input value changes - The caching mechanism still prevents unnecessary rebuilds in all other cases ## Testing - [x] Language selection through text button updates checkmark immediately - [x] Language selection through commandline works as before - [x] No unnecessary rebuilds when language hasn't changed - [x] Checkmark appears next to correct language in all cases

…@byseif21

…@byseif21, @fehmer) (monkeytypegame#6586) ### Description Previously, when selecting a language via the text button on the test page, the checkmark (fa-check) in the commandline language list wouldn't update until a page refresh. This was due to the commandline's caching mechanism not detecting changes triggered outside its own control. Although it first appeared to be a language-specific issue, it was later identified that the caching logic was generally insufficient — it didn’t account for updates to the active command state or configuration flags like usingSingleList. ## Solution Fixed the caching logic in the commandline module by tracking a more complete internal state. The system now correctly detects changes in the command list, active state, and configuration, and rebuilds the list UI when necessary. ## Technical Details - The commandline uses a caching mechanism (`lastList`) to avoid rebuilding the HTML if the list hasn't changed done in monkeytypegame#6559 - Replaced the old lastList cache with a new lastState object that stores: the list of commands, each with its isActive flag, the usingSingleList configuration flag - Improved the cache comparison logic, uses areSortedArraysEqual to compare command lists including active state ,compares the usingSingleList flag - Previously, this cache wasn't being cleared when the language changed through the text button - Now we clear the cache on changes, forcing a rebuild of the list with the correct checkmark ## Performance Impact - Minimal performance impact - The list is only rebuilt when: 1. The language actually changes 2. The list content changes 3. The input value changes - The caching mechanism still prevents unnecessary rebuilds in all other cases ## Testing - [x] Language selection through text button updates checkmark immediately - [x] Language selection through commandline works as before - [x] No unnecessary rebuilds when language hasn't changed - [x] Checkmark appears next to correct language in all cases

impr(commandline): improve performance (@fehmer)
9db6468

monkeytypegeorge added the frontend User interface or web stuff label May 13, 2025

skip showing the same commandlist again
ae72552

fehmer commented May 13, 2025
View reviewed changes

Comment threadfrontend/src/ts/commandline/commandline.ts

fehmer commented May 13, 2025
View reviewed changes

Comment threadfrontend/src/ts/commandline/commandline.ts

fehmer commented May 13, 2025
View reviewed changes

Comment threadfrontend/src/ts/commandline/commandline.ts

fehmer added 7 commits May 13, 2025 12:03

fix mouse events
27976c6

fix mouse events
23b24db

debouce commandline
6223dc6

debouce commandline
3c9b12d

fix html not set after empty list
96ae52c

same, but better
032ab33

add radix
e347fd1

Miodec merged commit 98f1273 into masterMay 13, 2025

Miodec deleted the feature/commandline-refactor branch May 13, 2025 14:41

byseif21 mentioned this pull request May 22, 2025
fix(commandline): improve caching to fix stale checkmark and UI state (@byseif21, @fehmer) #6586
Merged
4 tasks

impr(commandline): improve performance (@fehmer)
9db6468

monkeytypegeorge added the frontend User interface or web stuff label May 13, 2025

skip showing the same commandlist again
ae72552

fehmer commented May 13, 2025
View reviewed changes

Comment threadfrontend/src/ts/commandline/commandline.ts

fehmer commented May 13, 2025
View reviewed changes

Comment threadfrontend/src/ts/commandline/commandline.ts

fehmer commented May 13, 2025
View reviewed changes

Comment threadfrontend/src/ts/commandline/commandline.ts

fehmer added 7 commits May 13, 2025 12:03

fix mouse events
27976c6

fix mouse events
23b24db

debouce commandline
6223dc6

debouce commandline
3c9b12d

fix html not set after empty list
96ae52c

same, but better
032ab33

add radix
e347fd1

Miodec merged commit 98f1273 into masterMay 13, 2025

Miodec deleted the feature/commandline-refactor branch May 13, 2025 14:41

byseif21 mentioned this pull request May 22, 2025
fix(commandline): improve caching to fix stale checkmark and UI state (@byseif21, @fehmer) #6586
Merged
4 tasks

impr(commandline): improve performance (@fehmer)
9db6468

monkeytypegeorge added the frontend User interface or web stuff label May 13, 2025

skip showing the same commandlist again
ae72552

fehmer commented May 13, 2025
View reviewed changes

Comment threadfrontend/src/ts/commandline/commandline.ts

fehmer commented May 13, 2025
View reviewed changes

Comment threadfrontend/src/ts/commandline/commandline.ts

fehmer commented May 13, 2025
View reviewed changes

Comment threadfrontend/src/ts/commandline/commandline.ts

fehmer added 7 commits May 13, 2025 12:03

fix mouse events
27976c6

fix mouse events
23b24db

debouce commandline
6223dc6

debouce commandline
3c9b12d

fix html not set after empty list
96ae52c

same, but better
032ab33

add radix
e347fd1

Miodec merged commit 98f1273 into masterMay 13, 2025

Miodec deleted the feature/commandline-refactor branch May 13, 2025 14:41

byseif21 mentioned this pull request May 22, 2025
fix(commandline): improve caching to fix stale checkmark and UI state (@byseif21, @fehmer) #6586
Merged
4 tasks

impr(commandline): improve performance (@fehmer)
9db6468

monkeytypegeorge added the frontend User interface or web stuff label May 13, 2025

skip showing the same commandlist again
ae72552

fehmer commented May 13, 2025
View reviewed changes

Comment threadfrontend/src/ts/commandline/commandline.ts

fehmer commented May 13, 2025
View reviewed changes

Comment threadfrontend/src/ts/commandline/commandline.ts

fehmer commented May 13, 2025
View reviewed changes

Comment threadfrontend/src/ts/commandline/commandline.ts

fehmer added 7 commits May 13, 2025 12:03

fix mouse events
27976c6

fix mouse events
23b24db

debouce commandline
6223dc6

debouce commandline
3c9b12d

fix html not set after empty list
96ae52c

same, but better
032ab33

add radix
e347fd1

Miodec merged commit 98f1273 into masterMay 13, 2025

Miodec deleted the feature/commandline-refactor branch May 13, 2025 14:41

byseif21 mentioned this pull request May 22, 2025
fix(commandline): improve caching to fix stale checkmark and UI state (@byseif21, @fehmer) #6586
Merged
4 tasks

impr(commandline): improve performance (@fehmer)
9db6468

monkeytypegeorge added the frontend User interface or web stuff label May 13, 2025

skip showing the same commandlist again
ae72552

fehmer commented May 13, 2025
View reviewed changes

Comment threadfrontend/src/ts/commandline/commandline.ts

fehmer commented May 13, 2025
View reviewed changes

Comment threadfrontend/src/ts/commandline/commandline.ts

fehmer commented May 13, 2025
View reviewed changes

Comment threadfrontend/src/ts/commandline/commandline.ts

fehmer added 7 commits May 13, 2025 12:03

fix mouse events
27976c6

fix mouse events
23b24db

debouce commandline
6223dc6

debouce commandline
3c9b12d

fix html not set after empty list
96ae52c

same, but better
032ab33

add radix
e347fd1

Miodec merged commit 98f1273 into masterMay 13, 2025

Miodec deleted the feature/commandline-refactor branch May 13, 2025 14:41

byseif21 mentioned this pull request May 22, 2025
fix(commandline): improve caching to fix stale checkmark and UI state (@byseif21, @fehmer) #6586
Merged
4 tasks

impr(commandline): improve performance (@fehmer)
9db6468

monkeytypegeorge added the frontend User interface or web stuff label May 13, 2025

skip showing the same commandlist again
ae72552

fehmer commented May 13, 2025
View reviewed changes

Comment threadfrontend/src/ts/commandline/commandline.ts

fehmer commented May 13, 2025
View reviewed changes

Comment threadfrontend/src/ts/commandline/commandline.ts

fehmer commented May 13, 2025
View reviewed changes

Comment threadfrontend/src/ts/commandline/commandline.ts

fehmer added 7 commits May 13, 2025 12:03

fix mouse events
27976c6

fix mouse events
23b24db

debouce commandline
6223dc6

debouce commandline
3c9b12d

fix html not set after empty list
96ae52c

same, but better
032ab33

add radix
e347fd1

Miodec merged commit 98f1273 into masterMay 13, 2025

Miodec deleted the feature/commandline-refactor branch May 13, 2025 14:41

byseif21 mentioned this pull request May 22, 2025
fix(commandline): improve caching to fix stale checkmark and UI state (@byseif21, @fehmer) #6586
Merged
4 tasks

impr(commandline): improve performance (@fehmer)
9db6468

monkeytypegeorge added the frontend User interface or web stuff label May 13, 2025

skip showing the same commandlist again
ae72552

fehmer commented May 13, 2025
View reviewed changes

Comment threadfrontend/src/ts/commandline/commandline.ts

fehmer commented May 13, 2025
View reviewed changes

Comment threadfrontend/src/ts/commandline/commandline.ts

fehmer commented May 13, 2025
View reviewed changes

Comment threadfrontend/src/ts/commandline/commandline.ts

fehmer added 7 commits May 13, 2025 12:03

fix mouse events
27976c6

fix mouse events
23b24db

debouce commandline
6223dc6

debouce commandline
3c9b12d

fix html not set after empty list
96ae52c

same, but better
032ab33

add radix
e347fd1

Miodec merged commit 98f1273 into masterMay 13, 2025

Miodec deleted the feature/commandline-refactor branch May 13, 2025 14:41

byseif21 mentioned this pull request May 22, 2025
fix(commandline): improve caching to fix stale checkmark and UI state (@byseif21, @fehmer) #6586
Merged
4 tasks

impr(commandline): improve performance (@fehmer)
9db6468

monkeytypegeorge added the frontend User interface or web stuff label May 13, 2025

skip showing the same commandlist again
ae72552

fehmer commented May 13, 2025
View reviewed changes

Comment threadfrontend/src/ts/commandline/commandline.ts

fehmer commented May 13, 2025
View reviewed changes

Comment threadfrontend/src/ts/commandline/commandline.ts

fehmer commented May 13, 2025
View reviewed changes

Comment threadfrontend/src/ts/commandline/commandline.ts

fehmer added 7 commits May 13, 2025 12:03

fix mouse events
27976c6

fix mouse events
23b24db

debouce commandline
6223dc6

debouce commandline
3c9b12d

fix html not set after empty list
96ae52c

same, but better
032ab33

add radix
e347fd1

Miodec merged commit 98f1273 into masterMay 13, 2025

Miodec deleted the feature/commandline-refactor branch May 13, 2025 14:41

byseif21 mentioned this pull request May 22, 2025
fix(commandline): improve caching to fix stale checkmark and UI state (@byseif21, @fehmer) #6586
Merged
4 tasks

Uh oh!

Uh oh!

Conversation

fehmer commented May 13, 2025

Uh oh!

sentryBot commented May 13, 2025

🔍 Existing Issues For Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

sentryBot commented May 15, 2025

Suspect Issues

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Uh oh!

Conversation

fehmer commented May 13, 2025

Uh oh!

sentryBot commented May 13, 2025

🔍 Existing Issues For Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

sentryBot commented May 15, 2025

Suspect Issues

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Uh oh!

Conversation

fehmer commented May 13, 2025

Uh oh!

sentryBot commented May 13, 2025

🔍 Existing Issues For Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

sentryBot commented May 15, 2025

Suspect Issues

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Uh oh!

Conversation

fehmer commented May 13, 2025

Uh oh!

sentryBot commented May 13, 2025

🔍 Existing Issues For Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

sentryBot commented May 15, 2025

Suspect Issues

Uh oh!