Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork 3.3k
impr: support more filetypes for text import (@fehmer)#8322
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base:master
Are you sure you want to change the base?
Uh oh!
There was an error while loading. Please reload this page.
Changes from all commits
File filter
Filter by extension
Conversations
Uh oh!
There was an error while loading. Please reload this page.
Jump to
Uh oh!
There was an error while loading. Please reload this page.
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,55 @@ | ||
| let officeparser: typeof import("officeparser") | null = null; | ||
| async function loadOfficeparser(): Promise<typeof import("officeparser")> { | ||
| officeparser ??= await import("officeparser"); | ||
| return officeparser; | ||
| } | ||
| type SupportedFileType = "docx" | "odt" | "pdf" | "rtf" | "md" | "epub"; | ||
| const EXTENSION_MAP: Record<string, SupportedFileType> = { | ||
| docx: "docx", | ||
| doc: "docx", | ||
| odt: "odt", | ||
| pdf: "pdf", | ||
| rtf: "rtf", | ||
| md: "md", | ||
| epub: "epub", | ||
| }; | ||
| const MIME_TYPE_MAP: Record<string, SupportedFileType> = { | ||
| "application/vnd.openxmlformats-officedocument.wordprocessingml.document": | ||
| "docx", | ||
| "application/vnd.oasis.opendocument.text": "odt", | ||
| "application/pdf": "pdf", | ||
| "application/rtf": "rtf", | ||
| "text/markdown": "md", | ||
| "text/x-markdown": "md", | ||
| "application/epub+zip": "epub", | ||
| }; | ||
| function detectFiletype( | ||
| filename: string, | ||
| filetype: string, | ||
| ): SupportedFileType | null { | ||
| const ext = filename.split(".").pop()?.toLowerCase() ?? ""; | ||
| if (EXTENSION_MAP[ext]) return EXTENSION_MAP[ext]; | ||
| if (MIME_TYPE_MAP[filetype]) return MIME_TYPE_MAP[filetype]; | ||
| return null; | ||
| } | ||
| export async function convertToText( | ||
| file: File, | ||
| filename: string, | ||
| filetype: string, | ||
| ): Promise<string> { | ||
| const { parseOffice } = await loadOfficeparser(); | ||
| const buffer = await file.arrayBuffer(); | ||
| const fileType = detectFiletype(filename, filetype); | ||
| const ast = await parseOffice(buffer, { fileType }); | ||
| const { value } = await ast.to("text", { | ||
| includeImages: false, | ||
| textConfig: { preserveLayout: false, renderNotes: false }, | ||
| }); | ||
| return value; | ||
| } |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -25,7 +25,6 @@ import { VitePWA } from "vite-plugin-pwa"; | ||
| import { sentryVitePlugin } from "@sentry/vite-plugin"; | ||
| import { KnownFontName } from "@monkeytype/schemas/fonts"; | ||
| import solidPlugin from "vite-plugin-solid"; | ||
| import devtools from "solid-devtools/vite"; | ||
| import tailwindcss from "@tailwindcss/vite"; | ||
| function getFontsConfig(): string { | ||
| @@ -103,9 +102,6 @@ function getPlugins({ | ||
| tailwindcss(), | ||
| solidPlugin(), | ||
| devtools({ | ||
MemberAuthor There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. devtools breaks officeparser on load, figure out why | ||
| autoname: true, | ||
| }), | ||
| ]; | ||
| const devPlugins: PluginOption[] = [ | ||
| @@ -267,6 +263,10 @@ function getBuildOptions({ | ||
| name: "monkeytype-utils", | ||
| test: /src\/ts\/utils\//, | ||
| }, | ||
| { | ||
| name: "vendor-officeparser", | ||
| test: /node_modules\/officeparser/, | ||
| }, | ||
| { | ||
| name: "vendor", | ||
| test: /node_modules\//, | ||
| @@ -368,7 +368,7 @@ export default defineConfig(({ mode }): UserConfig => { | ||
| root: "src", | ||
| publicDir: "../static", | ||
| optimizeDeps: { | ||
| exclude: ["@fortawesome/fontawesome-free"], | ||
| exclude: ["@fortawesome/fontawesome-free", "officeparser"], | ||
| }, | ||
| }; | ||
| }); | ||
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
adds a cool 840kb zipped :(