Skip to content

ADCS/SBCS - #59

Merged
monoid merged 1 commit into
masterfrom
feat/adcs/sbcs
Jul 10, 2026
Merged

ADCS/SBCS#59
monoid merged 1 commit into
masterfrom
feat/adcs/sbcs

Conversation

@monoid

@monoidmonoid commented Jul 10, 2026•
edited by coderabbitai Bot
Loading

Copy link
Copy Markdown
Owner

Summary by CodeRabbit

  • New Features
    • Added support for AArch64 add-with-carry (ADCS) instructions.
    • Added support for AArch64 subtract-with-carry (SBCS) instructions.
    • Supports both 32-bit and 64-bit registers, including zero-register operands.
    • Added instruction encoding coverage for the new arithmetic operations.

@monoidmonoid self-assigned this Jul 10, 2026
@monoidmonoid added enhancement New feature or request harm The `harm` dynamic assembler labels Jul 10, 2026
@coderabbitai

coderabbitaiBot commented Jul 10, 2026•
edited
Loading

Copy link
Copy Markdown

Review Change Stack

📝 Walkthrough

Walkthrough

Added public ADCS and SBCS AArch64 instruction wrappers with generic constructors, register and zero-register operand forms, carry-aware encoding support, unit tests, and module exports.

Changes

Carry-aware arithmetic instructions

Layer / File(s)Summary
ADCS instruction wrapper
harm/src/instructions/arith.rs, harm/src/instructions/arith/adcs.rs		Exports ADCS, defines its generic constructor and sealed operand-construction API, supports 32-bit and 64-bit register or zero-register forms, and tests emitted encodings.
SBCS instruction wrapper
harm/src/instructions/arith/sbcs.rs		Defines the SBCS constructor and sealed operand-construction API, supports 32-bit and 64-bit register or zero-register forms, and tests emitted encodings.

Estimated code review effort: 3 (Moderate) | ~20 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check nameStatusExplanation
Description Check✅ PassedCheck skipped - CodeRabbit’s high-level summary is enabled.
Title check✅ PassedThe title names the two new instruction wrappers added in this PR and is directly related to the main change.
Docstring Coverage✅ PassedNo functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check✅ PassedCheck skipped because no linked issues were found for this pull request.
Out of Scope Changes check✅ PassedCheck skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feat/adcs/sbcs

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@monoid

monoid commented Jul 10, 2026

Copy link
Copy Markdown
OwnerAuthor

@coderabbitai review

@coderabbitai

coderabbitaiBot commented Jul 10, 2026•
edited
Loading

Copy link
Copy Markdown
✅ Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

coderabbitai[bot]
coderabbitaiBot reviewed Jul 10, 2026
View reviewed changes

@coderabbitaicoderabbitaiBot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick comments (1)
harm/src/instructions/arith/sbcs.rs (1)

17-61: 📐 Maintainability & Code Quality | 🔵 Trivial | 💤 Low value

Consider reducing duplication between adcs.rs and sbcs.rs.

These two files are near-identical, differing only in instruction name and encoding module. If the existing adc/sbc instructions follow the same pattern, this duplication is an established convention — but a shared macro or generic factory could eliminate the repeated boilerplate (function, trait, struct, sealed impl, direct impls) across all carry-arithmetic instructions.

🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@harm/src/instructions/arith/sbcs.rs` around lines 17 - 61, Reduce duplicated
carry-arithmetic boilerplate shared by adcs.rs and sbcs.rs by introducing a
reusable macro or generic factory covering the public constructor, Make* trait,
instruction struct, Sealed implementation, and Reg32/Reg64 direct
implementations. Apply it consistently to Adcs/Sbcs and align with the existing
adc/sbc pattern, while preserving each instruction’s distinct name and encoding
module.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In `@harm/src/instructions/arith/sbcs.rs`:
- Around line 17-61: Reduce duplicated carry-arithmetic boilerplate shared by
adcs.rs and sbcs.rs by introducing a reusable macro or generic factory covering
the public constructor, Make* trait, instruction struct, Sealed implementation,
and Reg32/Reg64 direct implementations. Apply it consistently to Adcs/Sbcs and
align with the existing adc/sbc pattern, while preserving each instruction’s
distinct name and encoding module.
ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 4c7c56ee-65b6-4a96-9fcf-e5a6291e662c

📥 Commits

Reviewing files that changed from the base of the PR and between 71684c7 and 2021d61.

📒 Files selected for processing (3)
  • harm/src/instructions/arith.rs
  • harm/src/instructions/arith/adcs.rs
  • harm/src/instructions/arith/sbcs.rs

@monoid
monoid merged commit 377525c into masterJul 10, 2026
1 check passed
@monoid
monoid deleted the feat/adcs/sbcs branch July 10, 2026 17:40
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@coderabbitaicoderabbitai[bot]coderabbitai[bot] left review comments

Assignees

@monoidmonoid

Labels

enhancementNew feature or requestharmThe `harm` dynamic assembler

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@monoid
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all 
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
ADCS/SBCS by monoid · Pull Request #59 · monoid/harm · GitHub
Skip to content
ADCS/SBCS - #59
Merged
monoid merged 1 commit into
masterfrom 
feat/adcs/sbcs
Jul 10, 2026
Merged
ADCS/SBCS#59
monoid merged 1 commit into
masterfrom 
feat/adcs/sbcs
Conversation
@monoid
@monoidmonoid
commented
Jul 10, 2026•

edited by coderabbitai
Bot
Loading

Copy link


Copy Markdown

Owner
Summary by CodeRabbit
  • New Features
    • Added support for AArch64 add-with-carry (ADCS) instructions.
    • Added support for AArch64 subtract-with-carry (SBCS) instructions.
    • Supports both 32-bit and 64-bit registers, including zero-register operands.
    • Added instruction encoding coverage for the new arithmetic operations.
@monoidmonoid
self-assigned this
Jul 10, 2026
@monoidmonoid
added

enhancement
New feature or request
harm
The `harm` dynamic assembler
labels
Jul 10, 2026
@coderabbitai
coderabbitaiBot
commented
Jul 10, 2026•

edited

Loading

Copy link


Copy Markdown

Review Change Stack
📝 Walkthrough
Walkthrough
Added public ADCS and SBCS AArch64 instruction wrappers with generic constructors, register and zero-register operand forms, carry-aware encoding support, unit tests, and module exports.
Changes
Carry-aware arithmetic instructions
Layer / File(s)Summary
ADCS instruction wrapper
harm/src/instructions/arith.rs, harm/src/instructions/arith/adcs.rs		Exports ADCS, defines its generic constructor and sealed operand-construction API, supports 32-bit and 64-bit register or zero-register forms, and tests emitted encodings.
SBCS instruction wrapper
harm/src/instructions/arith/sbcs.rs		Defines the SBCS constructor and sealed operand-construction API, supports 32-bit and 64-bit register or zero-register forms, and tests emitted encodings.
Estimated code review effort: 3 (Moderate) | ~20 minutes
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check nameStatusExplanation
Description Check✅ PassedCheck skipped - CodeRabbit’s high-level summary is enabled.
Title check✅ PassedThe title names the two new instruction wrappers added in this PR and is directly related to the main change.
Docstring Coverage✅ PassedNo functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check✅ PassedCheck skipped because no linked issues were found for this pull request.
Out of Scope Changes check✅ PassedCheck skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  •  Create stacked PR
  •  Commit on current branch
🧪 Generate unit tests (beta)
  •  Create PR with unit tests
  •  Commit unit tests in branch feat/adcs/sbcs
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
❤️ Share
Comment @coderabbitai help to get the list of available commands.
@monoid
monoid
commented
Jul 10, 2026

Copy link


Copy Markdown

OwnerAuthor
@coderabbitai review
@coderabbitai
coderabbitaiBot
commented
Jul 10, 2026•

edited

Loading

Copy link


Copy Markdown

✅ Action performed
Review finished.
Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.
coderabbitai[bot]
coderabbitaiBot
reviewed
Jul 10, 2026
View reviewed changes
@coderabbitaicoderabbitaiBot
left a comment


Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick comments (1)
harm/src/instructions/arith/sbcs.rs (1)
17-61: 📐 Maintainability & Code Quality | 🔵 Trivial | 💤 Low value
Consider reducing duplication between adcs.rs and sbcs.rs.
These two files are near-identical, differing only in instruction name and encoding module. If the existing adc/sbc instructions follow the same pattern, this duplication is an established convention — but a shared macro or generic factory could eliminate the repeated boilerplate (function, trait, struct, sealed impl, direct impls) across all carry-arithmetic instructions.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@harm/src/instructions/arith/sbcs.rs` around lines 17 - 61, Reduce duplicated
carry-arithmetic boilerplate shared by adcs.rs and sbcs.rs by introducing a
reusable macro or generic factory covering the public constructor, Make* trait,
instruction struct, Sealed implementation, and Reg32/Reg64 direct
implementations. Apply it consistently to Adcs/Sbcs and align with the existing
adc/sbc pattern, while preserving each instruction’s distinct name and encoding
module.

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In `@harm/src/instructions/arith/sbcs.rs`:
- Around line 17-61: Reduce duplicated carry-arithmetic boilerplate shared by
adcs.rs and sbcs.rs by introducing a reusable macro or generic factory covering
the public constructor, Make* trait, instruction struct, Sealed implementation,
and Reg32/Reg64 direct implementations. Apply it consistently to Adcs/Sbcs and
align with the existing adc/sbc pattern, while preserving each instruction’s
distinct name and encoding module.

ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 4c7c56ee-65b6-4a96-9fcf-e5a6291e662c
📥 Commits
Reviewing files that changed from the base of the PR and between 71684c7 and 2021d61.
📒 Files selected for processing (3)
  • harm/src/instructions/arith.rs
  • harm/src/instructions/arith/adcs.rs
  • harm/src/instructions/arith/sbcs.rs
@monoid
monoid
merged commit 377525c
into
masterJul 10, 2026

1 check passed

@monoid
monoid
deleted the

feat/adcs/sbcs

branch
July 10, 2026 17:40
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@coderabbitaicoderabbitai[bot]coderabbitai[bot] left review comments

Assignees

@monoidmonoid

Labels

enhancementNew feature or requestharmThe `harm` dynamic assembler

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

1 participant

@monoid

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Force GitHub README to respect dark mode
(function() {
var style = document.createElement('style');
style.textContent = '
.markdown-body {
color-scheme: dark light;
}
.markdown-body pre { background: #161b22 !important; }
.markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }
.markdown-body table th, .markdown-body table td { border-color: #30363d !important; }
.markdown-body img { background: #0d1117; }
.markdown-body blockquote { border-left-color: #8b949e; }
.markdown-body hr { border-color: #30363d; }
';
document.head.appendChild(style);
})();
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
ADCS/SBCS by monoid · Pull Request #59 · monoid/harm · GitHub
Skip to content
ADCS/SBCS - #59
Merged
monoid merged 1 commit into
masterfrom 
feat/adcs/sbcs
Jul 10, 2026
Merged
ADCS/SBCS#59
monoid merged 1 commit into
masterfrom 
feat/adcs/sbcs
Conversation
@monoid
@monoidmonoid
commented
Jul 10, 2026•

edited by coderabbitai
Bot
Loading

Copy link


Copy Markdown

Owner
Summary by CodeRabbit
  • New Features
    • Added support for AArch64 add-with-carry (ADCS) instructions.
    • Added support for AArch64 subtract-with-carry (SBCS) instructions.
    • Supports both 32-bit and 64-bit registers, including zero-register operands.
    • Added instruction encoding coverage for the new arithmetic operations.
@monoidmonoid
self-assigned this
Jul 10, 2026
@monoidmonoid
added

enhancement
New feature or request
harm
The `harm` dynamic assembler
labels
Jul 10, 2026
@coderabbitai
coderabbitaiBot
commented
Jul 10, 2026•

edited

Loading

Copy link


Copy Markdown

Review Change Stack
📝 Walkthrough
Walkthrough
Added public ADCS and SBCS AArch64 instruction wrappers with generic constructors, register and zero-register operand forms, carry-aware encoding support, unit tests, and module exports.
Changes
Carry-aware arithmetic instructions
Layer / File(s)Summary
ADCS instruction wrapper
harm/src/instructions/arith.rs, harm/src/instructions/arith/adcs.rs		Exports ADCS, defines its generic constructor and sealed operand-construction API, supports 32-bit and 64-bit register or zero-register forms, and tests emitted encodings.
SBCS instruction wrapper
harm/src/instructions/arith/sbcs.rs		Defines the SBCS constructor and sealed operand-construction API, supports 32-bit and 64-bit register or zero-register forms, and tests emitted encodings.
Estimated code review effort: 3 (Moderate) | ~20 minutes
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check nameStatusExplanation
Description Check✅ PassedCheck skipped - CodeRabbit’s high-level summary is enabled.
Title check✅ PassedThe title names the two new instruction wrappers added in this PR and is directly related to the main change.
Docstring Coverage✅ PassedNo functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check✅ PassedCheck skipped because no linked issues were found for this pull request.
Out of Scope Changes check✅ PassedCheck skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  •  Create stacked PR
  •  Commit on current branch
🧪 Generate unit tests (beta)
  •  Create PR with unit tests
  •  Commit unit tests in branch feat/adcs/sbcs
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
❤️ Share
Comment @coderabbitai help to get the list of available commands.
@monoid
monoid
commented
Jul 10, 2026

Copy link


Copy Markdown

OwnerAuthor
@coderabbitai review
@coderabbitai
coderabbitaiBot
commented
Jul 10, 2026•

edited

Loading

Copy link


Copy Markdown

✅ Action performed
Review finished.
Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.
coderabbitai[bot]
coderabbitaiBot
reviewed
Jul 10, 2026
View reviewed changes
@coderabbitaicoderabbitaiBot
left a comment


Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick comments (1)
harm/src/instructions/arith/sbcs.rs (1)
17-61: 📐 Maintainability & Code Quality | 🔵 Trivial | 💤 Low value
Consider reducing duplication between adcs.rs and sbcs.rs.
These two files are near-identical, differing only in instruction name and encoding module. If the existing adc/sbc instructions follow the same pattern, this duplication is an established convention — but a shared macro or generic factory could eliminate the repeated boilerplate (function, trait, struct, sealed impl, direct impls) across all carry-arithmetic instructions.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@harm/src/instructions/arith/sbcs.rs` around lines 17 - 61, Reduce duplicated
carry-arithmetic boilerplate shared by adcs.rs and sbcs.rs by introducing a
reusable macro or generic factory covering the public constructor, Make* trait,
instruction struct, Sealed implementation, and Reg32/Reg64 direct
implementations. Apply it consistently to Adcs/Sbcs and align with the existing
adc/sbc pattern, while preserving each instruction’s distinct name and encoding
module.

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In `@harm/src/instructions/arith/sbcs.rs`:
- Around line 17-61: Reduce duplicated carry-arithmetic boilerplate shared by
adcs.rs and sbcs.rs by introducing a reusable macro or generic factory covering
the public constructor, Make* trait, instruction struct, Sealed implementation,
and Reg32/Reg64 direct implementations. Apply it consistently to Adcs/Sbcs and
align with the existing adc/sbc pattern, while preserving each instruction’s
distinct name and encoding module.

ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 4c7c56ee-65b6-4a96-9fcf-e5a6291e662c
📥 Commits
Reviewing files that changed from the base of the PR and between 71684c7 and 2021d61.
📒 Files selected for processing (3)
  • harm/src/instructions/arith.rs
  • harm/src/instructions/arith/adcs.rs
  • harm/src/instructions/arith/sbcs.rs
@monoid
monoid
merged commit 377525c
into
masterJul 10, 2026

1 check passed

@monoid
monoid
deleted the

feat/adcs/sbcs

branch
July 10, 2026 17:40
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@coderabbitaicoderabbitai[bot]coderabbitai[bot] left review comments

Assignees

@monoidmonoid

Labels

enhancementNew feature or requestharmThe `harm` dynamic assembler

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

1 participant

@monoid

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Highlight search terms from Google/DuckDuckGo/Bing referrer
(function() {
var ref = document.referrer;
var terms = [];
if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {
var url = new URL(ref);
var q = url.searchParams.get('q') || url.searchParams.get('p');
if (q) {
terms = q.split(/\s+/).filter(function(t) { return t.length > 2; });
}
}
if (terms.length === 0) return;
var style = document.createElement('style');
style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';
document.head.appendChild(style);
function highlight(node) {
if (node.nodeType === 3) { // text node
var text = node.textContent;
var found = false;
terms.forEach(function(term) {
var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi');
if (regex.test(text)) {
found = true;
var frag = document.createDocumentFragment();
var parts = text.split(regex);
parts.forEach(function(part, i) {
if (i % 2 === 0) {
frag.appendChild(document.createTextNode(part));
} else {
var span = document.createElement('span');
span.className = 'userscript-highlight';
span.textContent = part;
frag.appendChild(span);
}
});
node.parentNode.replaceChild(frag, node);
}
});
} else if (node.nodeType === 1 && node.childNodes) { // element
var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];
if (!skipTags.includes(node.tagName)) {
Array.from(node.childNodes).forEach(highlight);
}
}
}
highlight(document.body);
// Re-highlight on dynamic content
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1 || node.nodeType === 3) highlight(node);
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
ADCS/SBCS by monoid · Pull Request #59 · monoid/harm · GitHub
Skip to content
ADCS/SBCS - #59
Merged
monoid merged 1 commit into
masterfrom 
feat/adcs/sbcs
Jul 10, 2026
Merged
ADCS/SBCS#59
monoid merged 1 commit into
masterfrom 
feat/adcs/sbcs
Conversation
@monoid
@monoidmonoid
commented
Jul 10, 2026•

edited by coderabbitai
Bot
Loading

Copy link


Copy Markdown

Owner
Summary by CodeRabbit
  • New Features
    • Added support for AArch64 add-with-carry (ADCS) instructions.
    • Added support for AArch64 subtract-with-carry (SBCS) instructions.
    • Supports both 32-bit and 64-bit registers, including zero-register operands.
    • Added instruction encoding coverage for the new arithmetic operations.
@monoidmonoid
self-assigned this
Jul 10, 2026
@monoidmonoid
added

enhancement
New feature or request
harm
The `harm` dynamic assembler
labels
Jul 10, 2026
@coderabbitai
coderabbitaiBot
commented
Jul 10, 2026•

edited

Loading

Copy link


Copy Markdown

Review Change Stack
📝 Walkthrough
Walkthrough
Added public ADCS and SBCS AArch64 instruction wrappers with generic constructors, register and zero-register operand forms, carry-aware encoding support, unit tests, and module exports.
Changes
Carry-aware arithmetic instructions
Layer / File(s)Summary
ADCS instruction wrapper
harm/src/instructions/arith.rs, harm/src/instructions/arith/adcs.rs		Exports ADCS, defines its generic constructor and sealed operand-construction API, supports 32-bit and 64-bit register or zero-register forms, and tests emitted encodings.
SBCS instruction wrapper
harm/src/instructions/arith/sbcs.rs		Defines the SBCS constructor and sealed operand-construction API, supports 32-bit and 64-bit register or zero-register forms, and tests emitted encodings.
Estimated code review effort: 3 (Moderate) | ~20 minutes
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check nameStatusExplanation
Description Check✅ PassedCheck skipped - CodeRabbit’s high-level summary is enabled.
Title check✅ PassedThe title names the two new instruction wrappers added in this PR and is directly related to the main change.
Docstring Coverage✅ PassedNo functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check✅ PassedCheck skipped because no linked issues were found for this pull request.
Out of Scope Changes check✅ PassedCheck skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  •  Create stacked PR
  •  Commit on current branch
🧪 Generate unit tests (beta)
  •  Create PR with unit tests
  •  Commit unit tests in branch feat/adcs/sbcs
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
❤️ Share
Comment @coderabbitai help to get the list of available commands.
@monoid
monoid
commented
Jul 10, 2026

Copy link


Copy Markdown

OwnerAuthor
@coderabbitai review
@coderabbitai
coderabbitaiBot
commented
Jul 10, 2026•

edited

Loading

Copy link


Copy Markdown

✅ Action performed
Review finished.
Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.
coderabbitai[bot]
coderabbitaiBot
reviewed
Jul 10, 2026
View reviewed changes
@coderabbitaicoderabbitaiBot
left a comment


Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick comments (1)
harm/src/instructions/arith/sbcs.rs (1)
17-61: 📐 Maintainability & Code Quality | 🔵 Trivial | 💤 Low value
Consider reducing duplication between adcs.rs and sbcs.rs.
These two files are near-identical, differing only in instruction name and encoding module. If the existing adc/sbc instructions follow the same pattern, this duplication is an established convention — but a shared macro or generic factory could eliminate the repeated boilerplate (function, trait, struct, sealed impl, direct impls) across all carry-arithmetic instructions.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@harm/src/instructions/arith/sbcs.rs` around lines 17 - 61, Reduce duplicated
carry-arithmetic boilerplate shared by adcs.rs and sbcs.rs by introducing a
reusable macro or generic factory covering the public constructor, Make* trait,
instruction struct, Sealed implementation, and Reg32/Reg64 direct
implementations. Apply it consistently to Adcs/Sbcs and align with the existing
adc/sbc pattern, while preserving each instruction’s distinct name and encoding
module.

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In `@harm/src/instructions/arith/sbcs.rs`:
- Around line 17-61: Reduce duplicated carry-arithmetic boilerplate shared by
adcs.rs and sbcs.rs by introducing a reusable macro or generic factory covering
the public constructor, Make* trait, instruction struct, Sealed implementation,
and Reg32/Reg64 direct implementations. Apply it consistently to Adcs/Sbcs and
align with the existing adc/sbc pattern, while preserving each instruction’s
distinct name and encoding module.

ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 4c7c56ee-65b6-4a96-9fcf-e5a6291e662c
📥 Commits
Reviewing files that changed from the base of the PR and between 71684c7 and 2021d61.
📒 Files selected for processing (3)
  • harm/src/instructions/arith.rs
  • harm/src/instructions/arith/adcs.rs
  • harm/src/instructions/arith/sbcs.rs
@monoid
monoid
merged commit 377525c
into
masterJul 10, 2026

1 check passed

@monoid
monoid
deleted the

feat/adcs/sbcs

branch
July 10, 2026 17:40
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@coderabbitaicoderabbitai[bot]coderabbitai[bot] left review comments

Assignees

@monoidmonoid

Labels

enhancementNew feature or requestharmThe `harm` dynamic assembler

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

1 participant

@monoid

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Strip utm_, fbclid, gclid, etc. from all links on page
(function() {
var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',
'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',
'ref', 'ref_src', 'source', 'medium', 'campaign'];
function cleanUrl(url) {
try {
var u = new URL(url, window.location.origin);
var changed = false;
trackingParams.forEach(function(p) {
if (u.searchParams.has(p)) {
u.searchParams.delete(p);
changed = true;
}
});
return changed ? u.toString() : url;
} catch (e) {
return url;
}
}
function cleanLinks() {
document.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
cleanLinks();
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1) {
if (node.tagName === 'A') cleanLinks();
node.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '
ADCS/SBCS by monoid · Pull Request #59 · monoid/harm · GitHub
Skip to content
ADCS/SBCS - #59
Merged
monoid merged 1 commit into
masterfrom 
feat/adcs/sbcs
Jul 10, 2026
Merged
ADCS/SBCS#59
monoid merged 1 commit into
masterfrom 
feat/adcs/sbcs
Conversation
@monoid
@monoidmonoid
commented
Jul 10, 2026•

edited by coderabbitai
Bot
Loading

Copy link


Copy Markdown

Owner
Summary by CodeRabbit
  • New Features
    • Added support for AArch64 add-with-carry (ADCS) instructions.
    • Added support for AArch64 subtract-with-carry (SBCS) instructions.
    • Supports both 32-bit and 64-bit registers, including zero-register operands.
    • Added instruction encoding coverage for the new arithmetic operations.
@monoidmonoid
self-assigned this
Jul 10, 2026
@monoidmonoid
added

enhancement
New feature or request
harm
The `harm` dynamic assembler
labels
Jul 10, 2026
@coderabbitai
coderabbitaiBot
commented
Jul 10, 2026•

edited

Loading

Copy link


Copy Markdown

Review Change Stack
📝 Walkthrough
Walkthrough
Added public ADCS and SBCS AArch64 instruction wrappers with generic constructors, register and zero-register operand forms, carry-aware encoding support, unit tests, and module exports.
Changes
Carry-aware arithmetic instructions
Layer / File(s)Summary
ADCS instruction wrapper
harm/src/instructions/arith.rs, harm/src/instructions/arith/adcs.rs		Exports ADCS, defines its generic constructor and sealed operand-construction API, supports 32-bit and 64-bit register or zero-register forms, and tests emitted encodings.
SBCS instruction wrapper
harm/src/instructions/arith/sbcs.rs		Defines the SBCS constructor and sealed operand-construction API, supports 32-bit and 64-bit register or zero-register forms, and tests emitted encodings.
Estimated code review effort: 3 (Moderate) | ~20 minutes
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check nameStatusExplanation
Description Check✅ PassedCheck skipped - CodeRabbit’s high-level summary is enabled.
Title check✅ PassedThe title names the two new instruction wrappers added in this PR and is directly related to the main change.
Docstring Coverage✅ PassedNo functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check✅ PassedCheck skipped because no linked issues were found for this pull request.
Out of Scope Changes check✅ PassedCheck skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  •  Create stacked PR
  •  Commit on current branch
🧪 Generate unit tests (beta)
  •  Create PR with unit tests
  •  Commit unit tests in branch feat/adcs/sbcs
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
❤️ Share
Comment @coderabbitai help to get the list of available commands.
@monoid
monoid
commented
Jul 10, 2026

Copy link


Copy Markdown

OwnerAuthor
@coderabbitai review
@coderabbitai
coderabbitaiBot
commented
Jul 10, 2026•

edited

Loading

Copy link


Copy Markdown

✅ Action performed
Review finished.
Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.
coderabbitai[bot]
coderabbitaiBot
reviewed
Jul 10, 2026
View reviewed changes
@coderabbitaicoderabbitaiBot
left a comment


Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick comments (1)
harm/src/instructions/arith/sbcs.rs (1)
17-61: 📐 Maintainability & Code Quality | 🔵 Trivial | 💤 Low value
Consider reducing duplication between adcs.rs and sbcs.rs.
These two files are near-identical, differing only in instruction name and encoding module. If the existing adc/sbc instructions follow the same pattern, this duplication is an established convention — but a shared macro or generic factory could eliminate the repeated boilerplate (function, trait, struct, sealed impl, direct impls) across all carry-arithmetic instructions.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@harm/src/instructions/arith/sbcs.rs` around lines 17 - 61, Reduce duplicated
carry-arithmetic boilerplate shared by adcs.rs and sbcs.rs by introducing a
reusable macro or generic factory covering the public constructor, Make* trait,
instruction struct, Sealed implementation, and Reg32/Reg64 direct
implementations. Apply it consistently to Adcs/Sbcs and align with the existing
adc/sbc pattern, while preserving each instruction’s distinct name and encoding
module.

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In `@harm/src/instructions/arith/sbcs.rs`:
- Around line 17-61: Reduce duplicated carry-arithmetic boilerplate shared by
adcs.rs and sbcs.rs by introducing a reusable macro or generic factory covering
the public constructor, Make* trait, instruction struct, Sealed implementation,
and Reg32/Reg64 direct implementations. Apply it consistently to Adcs/Sbcs and
align with the existing adc/sbc pattern, while preserving each instruction’s
distinct name and encoding module.

ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 4c7c56ee-65b6-4a96-9fcf-e5a6291e662c
📥 Commits
Reviewing files that changed from the base of the PR and between 71684c7 and 2021d61.
📒 Files selected for processing (3)
  • harm/src/instructions/arith.rs
  • harm/src/instructions/arith/adcs.rs
  • harm/src/instructions/arith/sbcs.rs
@monoid
monoid
merged commit 377525c
into
masterJul 10, 2026

1 check passed

@monoid
monoid
deleted the

feat/adcs/sbcs

branch
July 10, 2026 17:40
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@coderabbitaicoderabbitai[bot]coderabbitai[bot] left review comments

Assignees

@monoidmonoid

Labels

enhancementNew feature or requestharmThe `harm` dynamic assembler

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

1 participant

@monoid

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Auto-enable theater mode on YouTube
(function() {
function tryTheater() {
var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]');
if (btn && !btn.classList.contains('activated')) {
btn.click();
}
}
// Try immediately
tryTheater();
// Try after navigation (SPA)
var lastUrl = location.href;
setInterval(function() {
if (location.href !== lastUrl) {
lastUrl = location.href;
setTimeout(tryTheater, 500);
}
}, 1000);
// Also try on player load
var observer = new MutationObserver(tryTheater);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
ADCS/SBCS by monoid · Pull Request #59 · monoid/harm · GitHub
Skip to content
ADCS/SBCS - #59
Merged
monoid merged 1 commit into
masterfrom 
feat/adcs/sbcs
Jul 10, 2026
Merged
ADCS/SBCS#59
monoid merged 1 commit into
masterfrom 
feat/adcs/sbcs
Conversation
@monoid
@monoidmonoid
commented
Jul 10, 2026•

edited by coderabbitai
Bot
Loading

Copy link


Copy Markdown

Owner
Summary by CodeRabbit
  • New Features
    • Added support for AArch64 add-with-carry (ADCS) instructions.
    • Added support for AArch64 subtract-with-carry (SBCS) instructions.
    • Supports both 32-bit and 64-bit registers, including zero-register operands.
    • Added instruction encoding coverage for the new arithmetic operations.
@monoidmonoid
self-assigned this
Jul 10, 2026
@monoidmonoid
added

enhancement
New feature or request
harm
The `harm` dynamic assembler
labels
Jul 10, 2026
@coderabbitai
coderabbitaiBot
commented
Jul 10, 2026•

edited

Loading

Copy link


Copy Markdown

Review Change Stack
📝 Walkthrough
Walkthrough
Added public ADCS and SBCS AArch64 instruction wrappers with generic constructors, register and zero-register operand forms, carry-aware encoding support, unit tests, and module exports.
Changes
Carry-aware arithmetic instructions
Layer / File(s)Summary
ADCS instruction wrapper
harm/src/instructions/arith.rs, harm/src/instructions/arith/adcs.rs		Exports ADCS, defines its generic constructor and sealed operand-construction API, supports 32-bit and 64-bit register or zero-register forms, and tests emitted encodings.
SBCS instruction wrapper
harm/src/instructions/arith/sbcs.rs		Defines the SBCS constructor and sealed operand-construction API, supports 32-bit and 64-bit register or zero-register forms, and tests emitted encodings.
Estimated code review effort: 3 (Moderate) | ~20 minutes
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check nameStatusExplanation
Description Check✅ PassedCheck skipped - CodeRabbit’s high-level summary is enabled.
Title check✅ PassedThe title names the two new instruction wrappers added in this PR and is directly related to the main change.
Docstring Coverage✅ PassedNo functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check✅ PassedCheck skipped because no linked issues were found for this pull request.
Out of Scope Changes check✅ PassedCheck skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  •  Create stacked PR
  •  Commit on current branch
🧪 Generate unit tests (beta)
  •  Create PR with unit tests
  •  Commit unit tests in branch feat/adcs/sbcs
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
❤️ Share
Comment @coderabbitai help to get the list of available commands.
@monoid
monoid
commented
Jul 10, 2026

Copy link


Copy Markdown

OwnerAuthor
@coderabbitai review
@coderabbitai
coderabbitaiBot
commented
Jul 10, 2026•

edited

Loading

Copy link


Copy Markdown

✅ Action performed
Review finished.
Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.
coderabbitai[bot]
coderabbitaiBot
reviewed
Jul 10, 2026
View reviewed changes
@coderabbitaicoderabbitaiBot
left a comment


Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick comments (1)
harm/src/instructions/arith/sbcs.rs (1)
17-61: 📐 Maintainability & Code Quality | 🔵 Trivial | 💤 Low value
Consider reducing duplication between adcs.rs and sbcs.rs.
These two files are near-identical, differing only in instruction name and encoding module. If the existing adc/sbc instructions follow the same pattern, this duplication is an established convention — but a shared macro or generic factory could eliminate the repeated boilerplate (function, trait, struct, sealed impl, direct impls) across all carry-arithmetic instructions.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@harm/src/instructions/arith/sbcs.rs` around lines 17 - 61, Reduce duplicated
carry-arithmetic boilerplate shared by adcs.rs and sbcs.rs by introducing a
reusable macro or generic factory covering the public constructor, Make* trait,
instruction struct, Sealed implementation, and Reg32/Reg64 direct
implementations. Apply it consistently to Adcs/Sbcs and align with the existing
adc/sbc pattern, while preserving each instruction’s distinct name and encoding
module.

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In `@harm/src/instructions/arith/sbcs.rs`:
- Around line 17-61: Reduce duplicated carry-arithmetic boilerplate shared by
adcs.rs and sbcs.rs by introducing a reusable macro or generic factory covering
the public constructor, Make* trait, instruction struct, Sealed implementation,
and Reg32/Reg64 direct implementations. Apply it consistently to Adcs/Sbcs and
align with the existing adc/sbc pattern, while preserving each instruction’s
distinct name and encoding module.

ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 4c7c56ee-65b6-4a96-9fcf-e5a6291e662c
📥 Commits
Reviewing files that changed from the base of the PR and between 71684c7 and 2021d61.
📒 Files selected for processing (3)
  • harm/src/instructions/arith.rs
  • harm/src/instructions/arith/adcs.rs
  • harm/src/instructions/arith/sbcs.rs
@monoid
monoid
merged commit 377525c
into
masterJul 10, 2026

1 check passed

@monoid
monoid
deleted the

feat/adcs/sbcs

branch
July 10, 2026 17:40
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@coderabbitaicoderabbitai[bot]coderabbitai[bot] left review comments

Assignees

@monoidmonoid

Labels

enhancementNew feature or requestharmThe `harm` dynamic assembler

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

1 participant

@monoid

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Remove or un-stick sticky/fixed headers that block content
(function() {
function unstick() {
document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) {
if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {
el.style.position = 'static';
el.style.top = 'auto';
el.style.zIndex = 'auto';
}
});
}
unstick();
var observer = new MutationObserver(unstick);
observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });
})();
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
})();
ADCS/SBCS by monoid · Pull Request #59 · monoid/harm · GitHub
Skip to content
ADCS/SBCS - #59
Merged
monoid merged 1 commit into
masterfrom 
feat/adcs/sbcs
Jul 10, 2026
Merged
ADCS/SBCS#59
monoid merged 1 commit into
masterfrom 
feat/adcs/sbcs
Conversation
@monoid
@monoidmonoid
commented
Jul 10, 2026•

edited by coderabbitai
Bot
Loading

Copy link


Copy Markdown

Owner
Summary by CodeRabbit
  • New Features
    • Added support for AArch64 add-with-carry (ADCS) instructions.
    • Added support for AArch64 subtract-with-carry (SBCS) instructions.
    • Supports both 32-bit and 64-bit registers, including zero-register operands.
    • Added instruction encoding coverage for the new arithmetic operations.
@monoidmonoid
self-assigned this
Jul 10, 2026
@monoidmonoid
added

enhancement
New feature or request
harm
The `harm` dynamic assembler
labels
Jul 10, 2026
@coderabbitai
coderabbitaiBot
commented
Jul 10, 2026•

edited

Loading

Copy link


Copy Markdown

Review Change Stack
📝 Walkthrough
Walkthrough
Added public ADCS and SBCS AArch64 instruction wrappers with generic constructors, register and zero-register operand forms, carry-aware encoding support, unit tests, and module exports.
Changes
Carry-aware arithmetic instructions
Layer / File(s)Summary
ADCS instruction wrapper
harm/src/instructions/arith.rs, harm/src/instructions/arith/adcs.rs		Exports ADCS, defines its generic constructor and sealed operand-construction API, supports 32-bit and 64-bit register or zero-register forms, and tests emitted encodings.
SBCS instruction wrapper
harm/src/instructions/arith/sbcs.rs		Defines the SBCS constructor and sealed operand-construction API, supports 32-bit and 64-bit register or zero-register forms, and tests emitted encodings.
Estimated code review effort: 3 (Moderate) | ~20 minutes
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check nameStatusExplanation
Description Check✅ PassedCheck skipped - CodeRabbit’s high-level summary is enabled.
Title check✅ PassedThe title names the two new instruction wrappers added in this PR and is directly related to the main change.
Docstring Coverage✅ PassedNo functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check✅ PassedCheck skipped because no linked issues were found for this pull request.
Out of Scope Changes check✅ PassedCheck skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  •  Create stacked PR
  •  Commit on current branch
🧪 Generate unit tests (beta)
  •  Create PR with unit tests
  •  Commit unit tests in branch feat/adcs/sbcs
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
❤️ Share
Comment @coderabbitai help to get the list of available commands.
@monoid
monoid
commented
Jul 10, 2026

Copy link


Copy Markdown

OwnerAuthor
@coderabbitai review
@coderabbitai
coderabbitaiBot
commented
Jul 10, 2026•

edited

Loading

Copy link


Copy Markdown

✅ Action performed
Review finished.
Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.
coderabbitai[bot]
coderabbitaiBot
reviewed
Jul 10, 2026
View reviewed changes
@coderabbitaicoderabbitaiBot
left a comment


Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick comments (1)
harm/src/instructions/arith/sbcs.rs (1)
17-61: 📐 Maintainability & Code Quality | 🔵 Trivial | 💤 Low value
Consider reducing duplication between adcs.rs and sbcs.rs.
These two files are near-identical, differing only in instruction name and encoding module. If the existing adc/sbc instructions follow the same pattern, this duplication is an established convention — but a shared macro or generic factory could eliminate the repeated boilerplate (function, trait, struct, sealed impl, direct impls) across all carry-arithmetic instructions.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@harm/src/instructions/arith/sbcs.rs` around lines 17 - 61, Reduce duplicated
carry-arithmetic boilerplate shared by adcs.rs and sbcs.rs by introducing a
reusable macro or generic factory covering the public constructor, Make* trait,
instruction struct, Sealed implementation, and Reg32/Reg64 direct
implementations. Apply it consistently to Adcs/Sbcs and align with the existing
adc/sbc pattern, while preserving each instruction’s distinct name and encoding
module.

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In `@harm/src/instructions/arith/sbcs.rs`:
- Around line 17-61: Reduce duplicated carry-arithmetic boilerplate shared by
adcs.rs and sbcs.rs by introducing a reusable macro or generic factory covering
the public constructor, Make* trait, instruction struct, Sealed implementation,
and Reg32/Reg64 direct implementations. Apply it consistently to Adcs/Sbcs and
align with the existing adc/sbc pattern, while preserving each instruction’s
distinct name and encoding module.

ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 4c7c56ee-65b6-4a96-9fcf-e5a6291e662c
📥 Commits
Reviewing files that changed from the base of the PR and between 71684c7 and 2021d61.
📒 Files selected for processing (3)
  • harm/src/instructions/arith.rs
  • harm/src/instructions/arith/adcs.rs
  • harm/src/instructions/arith/sbcs.rs
@monoid
monoid
merged commit 377525c
into
masterJul 10, 2026

1 check passed

@monoid
monoid
deleted the

feat/adcs/sbcs

branch
July 10, 2026 17:40
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@coderabbitaicoderabbitai[bot]coderabbitai[bot] left review comments

Assignees

@monoidmonoid

Labels

enhancementNew feature or requestharmThe `harm` dynamic assembler

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

1 participant

@monoid