Uh oh!
There was an error while loading. Please reload this page.
[docs] migrate Behat page - #270
Conversation
✅ Deploy Preview for moodledevdocs ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site settings. |
⚡️ Lighthouse report for the deploy preview of this PR
|
sarjona
left a comment
There was a problem hiding this comment.
Hi @ilyatregubov!
Thanks for migrating this page :-) As you'll see, I've raised a few comments, so feel free to review/fix them whenever you can :-)
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
d78baa2 to
d1daaa1Compareilyatregubov
commented
Jul 5, 2022
Hi @sarjona !! Thanks for review. I addressed you comments. I think the request is ready for another round |
sarjona
left a comment
There was a problem hiding this comment.
Hi Ilya!
Thanks a lot for reviewing and improving the Behat docs! As you'll see, only minor changes are required ;-) We're almost there!!
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
ilyatregubov
commented
Jul 6, 2022
Thanks @sarjona ! |
sarjona
left a comment
There was a problem hiding this comment.
Hi @ilyatregubov!
Thanks for improving the patch and adding one more page! It looks great! As you'll see, only one minor change and we'll be able to merge it! ;-)
Uh oh!
There was an error while loading. Please reload this page.
ilyatregubov
commented
Jul 8, 2022
Thanks @sarjona ! Done! |
There is Information to re-home section that needs to be moved once we migrate subpage for writing Behat tests