Skip to content

[docs] migrate Behat page - #270

Merged
sarjona merged 4 commits into
moodle:mainfrom
ilyatregubov:behatpage
Jul 8, 2022
Merged

[docs] migrate Behat page#270
sarjona merged 4 commits into
moodle:mainfrom
ilyatregubov:behatpage

Conversation

@ilyatregubov

@ilyatregubovilyatregubov commented Jun 30, 2022

Copy link
Copy Markdown
Contributor

There is Information to re-home section that needs to be moved once we migrate subpage for writing Behat tests

@netlify

netlifyBot commented Jun 30, 2022

Copy link
Copy Markdown

Deploy Preview for moodledevdocs ready!

Built without sensitive environment variables

NameLink
🔨 Latest commite723a65
🔍 Latest deploy loghttps://app.netlify.com/sites/moodledevdocs/deploys/62c7c49d8b398700083b2e64
😎 Deploy Previewhttps://deploy-preview-270--moodledevdocs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions

github-actionsBot commented Jun 30, 2022

Copy link
Copy Markdown
Contributor

⚡️ Lighthouse report for the deploy preview of this PR

URLPerformanceAccessibilityBest PracticesSEOPWAReport
/🟠 71🟢 98🟢 100🟢 90🟢 100Report
/docs/apis/commonfiles🟠 70🟢 96🟢 100🟢 100🟢 100Report
/general/development/gettingstarted🟠 85🟢 96🟢 100🟢 90🟢 100Report
/general/releases🟠 86🟢 96🟢 100🟢 100🟢 100Report

@sarjonasarjona left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @ilyatregubov!
Thanks for migrating this page :-) As you'll see, I've raised a few comments, so feel free to review/fix them whenever you can :-)

Comment threadgeneral/development/tools/behat.md Outdated
Comment threadgeneral/development/tools/behat.md Outdated
Comment threadgeneral/development/tools/behat.md Outdated
Comment threadgeneral/development/tools/behat.md Outdated
Comment threadgeneral/development/tools/behat.md
Comment threadgeneral/development/tools/behat.md Outdated
Comment threadgeneral/development/tools/behat.md Outdated
Comment threadgeneral/development/tools/behat.md Outdated
Comment threadgeneral/development/tools/behat.md Outdated
Comment threadgeneral/development/tools/behat.md Outdated
@ilyatregubov
ilyatregubovforce-pushed the behatpage branch 2 times, most recently from d78baa2 to d1daaa1CompareJuly 5, 2022 13:21
@ilyatregubov

Copy link
Copy Markdown
ContributorAuthor

Hi @sarjona !!

Thanks for review. I addressed you comments. I think the request is ready for another round

@sarjonasarjona linked an issue Jul 6, 2022 that may be closed by this pull request

@sarjonasarjona left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Ilya!
Thanks a lot for reviewing and improving the Behat docs! As you'll see, only minor changes are required ;-) We're almost there!!

Comment threadgeneral/development/tools/behat/index.md Outdated
Comment threadgeneral/development/tools/behat/index.md Outdated
Comment threadgeneral/development/tools/behat/index.md Outdated
Comment threadgeneral/development/tools/behat/index.md
Comment threadgeneral/development/tools/behat/index.md Outdated
Comment threadgeneral/development/tools/behat/writing.md
Comment threadgeneral/development/tools/behat/writing.md Outdated
Comment threadgeneral/development/tools/behat/browsers.md
Comment threadgeneral/development/tools/behat/browsers.md Outdated
Comment threadgeneral/development/tools/behat/browsers.md Outdated
@ilyatregubov

Copy link
Copy Markdown
ContributorAuthor

Thanks @sarjona !
Fixed. Also added one more page for supported browsers

@sarjonasarjona left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @ilyatregubov!
Thanks for improving the patch and adding one more page! It looks great! As you'll see, only one minor change and we'll be able to merge it! ;-)

Comment threadgeneral/development/tools/behat/browsers/supportedbrowsers.md Outdated
@ilyatregubov

Copy link
Copy Markdown
ContributorAuthor

Thanks @sarjona !

Done!

@sarjonasarjona left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Ilya! :-)

@sarjona
sarjona merged commit e9300cb into moodle:mainJul 8, 2022
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

https://docs.moodle.org/dev/Running_acceptance_test

2 participants

@ilyatregubov@sarjona