Skip to content

[Docs] Migrate Tag API - #274

Merged
sarjona merged 2 commits into
moodle:mainfrom
Chocolate-lightning:tagapi
Nov 29, 2022
Merged

[Docs] Migrate Tag API#274
sarjona merged 2 commits into
moodle:mainfrom
Chocolate-lightning:tagapi

Conversation

@Chocolate-lightning

@Chocolate-lightningChocolate-lightning commented Jul 3, 2022

Copy link
Copy Markdown
Collaborator

No description provided.

@netlify

netlifyBot commented Jul 3, 2022•
edited
Loading

Copy link
Copy Markdown

✅ Deploy Preview for moodledevdocs ready!

NameLink
🔨 Latest commit1e115b5
🔍 Latest deploy loghttps://app.netlify.com/sites/moodledevdocs/deploys/6385d50553cb410009c171ed
😎 Deploy Previewhttps://deploy-preview-274--moodledevdocs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@Chocolate-lightningChocolate-lightning mentioned this pull request Jul 3, 2022
Open
45 tasks
andrewnicols
andrewnicols previously requested changes Jul 5, 2022
View reviewed changes
Comment threaddocs/apis/subsystems/tag/index.md Outdated
Comment threaddocs/apis/subsystems/tag/index.md Outdated
Comment threaddocs/apis/subsystems/tag/index.md Outdated
Comment threaddocs/apis/subsystems/tag/index.md Outdated
Comment threaddocs/apis/subsystems/tag/index.md Outdated
Comment threaddocs/apis/subsystems/tag/index.md Outdated
Comment threaddocs/apis/subsystems/tag/index.md Outdated
Comment threaddocs/apis/subsystems/tag/index.md Outdated
Comment threaddocs/apis/subsystems/tag/index.md Outdated
Comment threaddocs/apis/subsystems/tag/index.md Outdated
@github-actions

github-actionsBot commented Jul 5, 2022•
edited
Loading

Copy link
Copy Markdown
Contributor

⚡️ Lighthouse report for the deploy preview of this PR

URLPerformanceAccessibilityBest PracticesSEOPWAReport
/🟢 92🟢 95🟢 100🟢 90🟢 100Report
/docs/apis/commonfiles🟠 67🟢 93🟢 100🟢 100🟢 100Report
/general/development/gettingstarted🟢 91🟢 95🟢 100🟢 90🟢 100Report
/general/releases🟠 86🟢 95🟢 100🟢 100🟢 100Report

@andrewnicolsandrewnicols linked an issue Jul 8, 2022 that may be closed by this pull request
https://docs.moodle.org/dev/Tag_API to to /docs/apis/subsystems/tag/index.md #287
Closed
@sarjona

sarjona commented Oct 18, 2022

Copy link
Copy Markdown
Member

@Chocolate-lightning it would be great if you could find some time to address the points raised by Andrew!! Thanks in advance for your help!!! :-*

@Chocolate-lightning

Chocolate-lightning commented Oct 21, 2022

Copy link
Copy Markdown
CollaboratorAuthor

Pretty sure I have addressed the items but it has been a while so my memory is foggy. Would be nice to get some fresh eyes on the current iteration.

Many thanks.

sarjona
sarjona requested changes Oct 25, 2022
View reviewed changes

@sarjonasarjona left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

HI @Chocolate-lightning!
Thanks for reviewing the points raised by Andrew! As you'll see, we're almost there and only a few minor improvements/changes have been requested to integrate it!

Comment threaddocs/apis/commonfiles/tag.php/index.md Outdated
Comment threaddocs/apis/subsystems/tag/index.md Outdated
Comment threaddocs/apis/subsystems/tag/index.md Outdated
Comment threaddocs/apis/subsystems/tag/index.md Outdated
Comment threaddocs/apis/subsystems/tag/index.md Outdated
Comment threaddocs/apis/subsystems/tag/index.md Outdated
Comment threaddocs/apis/subsystems/tag/index.md Outdated
Comment threaddocs/apis/subsystems/tag/index.md Outdated
@Chocolate-lightning
Chocolate-lightningforce-pushed the tagapi branch 2 times, most recently from 78ae052 to 038ae96CompareOctober 26, 2022 03:22
@Chocolate-lightning
Chocolate-lightning requested review from sarjona and removed request for andrewnicolsOctober 26, 2022 03:30
sarjona
sarjona approved these changes Oct 26, 2022
View reviewed changes

@sarjonasarjona left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Matt! The patch looks great and I'm more than happy to approve and merge it! Yupiiiii! :-)

@sarjona

sarjona commented Oct 26, 2022

Copy link
Copy Markdown
Member

@Chocolate-lightning whenever you can, it would be great if you could rebase your branch ;-)

@sarjona
sarjona dismissed andrewnicols’s stale reviewNovember 29, 2022 09:47

This changes were reviewed in the past :-)

@sarjona
sarjona merged commit f4c4784 into moodle:mainNov 29, 2022
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sarjonasarjonasarjona approved these changes
@andrewnicolsandrewnicolsandrewnicols left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

https://docs.moodle.org/dev/Tag_API to to /docs/apis/subsystems/tag/index.md

3 participants

@Chocolate-lightning@sarjona@andrewnicols