Skip to content

[Docs] Migrate Time API - #275

Merged
andrewnicols merged 3 commits into
moodle:mainfrom
Chocolate-lightning:timeapi
Jul 6, 2022
Merged

[Docs] Migrate Time API#275
andrewnicols merged 3 commits into
moodle:mainfrom
Chocolate-lightning:timeapi

Conversation

@Chocolate-lightning

@Chocolate-lightningChocolate-lightning commented Jul 3, 2022

Copy link
Copy Markdown
Collaborator

No description provided.

@netlify

netlifyBot commented Jul 3, 2022•
edited
Loading

Copy link
Copy Markdown

✅ Deploy Preview for moodledevdocs ready!

Built without sensitive environment variables

NameLink
🔨 Latest commit4c54fec
🔍 Latest deploy loghttps://app.netlify.com/sites/moodledevdocs/deploys/62c50fbc90885a00082cf7cb
😎 Deploy Previewhttps://deploy-preview-275--moodledevdocs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@Chocolate-lightningChocolate-lightning mentioned this pull request Jul 3, 2022
Open
45 tasks
@andrewnicols

andrewnicols commented Jul 5, 2022

Copy link
Copy Markdown
Member

Did you forget to check in the migrated page? I only see the migratedPages.yml file, and the fixed references to it.

@Chocolate-lightning

Chocolate-lightning commented Jul 5, 2022

Copy link
Copy Markdown
CollaboratorAuthor

Heh, oh my, that is a bit embarrassing. It seems my brain fell out on the floor as I was committing the changes. Checking now I have attached the file...

@github-actions

github-actionsBot commented Jul 5, 2022•
edited
Loading

Copy link
Copy Markdown
Contributor

⚡️ Lighthouse report for the deploy preview of this PR

URLPerformanceAccessibilityBest PracticesSEOPWAReport
/🟠 74🟢 98🟢 100🟢 90🟢 100Report
/docs/apis/commonfiles🟠 71🟢 96🟢 100🟢 100🟢 100Report
/general/development/gettingstarted🟢 91🟢 96🟢 100🟢 90🟢 100Report
/general/releases🟠 84🟢 96🟢 100🟢 100🟢 100Report

andrewnicols
andrewnicols requested changes Jul 5, 2022
View reviewed changes

@andrewnicolsandrewnicols left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of minor things and this is good to go.

Comment threaddocs/apis/subsystems/time/index.md Outdated
Comment threaddocs/apis/subsystems/time/index.md Outdated
Comment threaddocs/apis/subsystems/time/index.md
Comment threaddocs/apis/subsystems/time/index.md Outdated
@andrewnicols
andrewnicols enabled auto-merge July 6, 2022 04:34
@andrewnicols
andrewnicols merged commit 44ce233 into moodle:mainJul 6, 2022
@andrewnicolsandrewnicols linked an issue Jul 8, 2022 that may be closed by this pull request
https://docs.moodle.org/dev/Time_API #289
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@andrewnicolsandrewnicolsandrewnicols approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

https://docs.moodle.org/dev/Time_API

2 participants

@Chocolate-lightning@andrewnicols