Skip to content

[docs] Migrate Experience_API_(xAPI) - #560

Merged
paulholden merged 1 commit into
moodle:mainfrom
sarjona:xapi
Mar 20, 2023
Merged

[docs] Migrate Experience_API_(xAPI)#560
paulholden merged 1 commit into
moodle:mainfrom
sarjona:xapi

Conversation

@sarjona

@sarjonasarjona commented Feb 24, 2023•
edited by gitpod-io Bot
Loading

Copy link
Copy Markdown
Member

@netlify

netlifyBot commented Feb 24, 2023•
edited
Loading

Copy link
Copy Markdown

✅ Deploy Preview for moodledevdocs ready!

NameLink
🔨 Latest commitffdda8c
🔍 Latest deploy loghttps://app.netlify.com/sites/moodledevdocs/deploys/64183f392902c600070e56af
😎 Deploy Previewhttps://deploy-preview-560--moodledevdocs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@sarjonasarjona linked an issue Feb 24, 2023 that may be closed by this pull request
https://docs.moodle.org/dev/Experience_API_(xAPI) #561
Closed
@github-actions

github-actionsBot commented Feb 24, 2023•
edited
Loading

Copy link
Copy Markdown
Contributor

⚡️ Lighthouse report for the deploy preview of this PR

URLPerformanceAccessibilityBest PracticesSEOPWAReport
/🟠 64🟠 87🟢 100🟢 90🟢 100Report
/docs/apis/commonfiles🔴 48🟠 85🟢 100🟢 100🟢 100Report
/general/development/gettingstarted🟠 55🟠 87🟢 100🟢 90🟢 100Report
/general/releases🔴 49🟠 87🟢 100🟢 100🟢 100Report

paulholden
paulholden requested changes Mar 20, 2023
View reviewed changes

@paulholdenpaulholden left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First time I actually read what the x in xAPI actually stood for

There's a few grammatical errors that would be worth addressing here I think, thanks Sara!

Comment threaddocs/apis/subsystems/xapi/index.md Outdated
Comment threaddocs/apis/subsystems/xapi/index.md Outdated
Comment threaddocs/apis/subsystems/xapi/index.md
Comment threaddocs/apis/subsystems/xapi/index.md Outdated
Comment threaddocs/apis/subsystems/xapi/index.md Outdated
Comment threaddocs/apis/subsystems/xapi/index.md Outdated
Comment threaddocs/apis/subsystems/xapi/index.md Outdated
@sarjona
sarjona requested a review from paulholdenMarch 20, 2023 11:11
@sarjona

sarjona commented Mar 20, 2023

Copy link
Copy Markdown
MemberAuthor

Hi @paulholden!
Thanks a lot for reviewing this patch and raising all these points. I've addressed them so, hopefully, it should be now ready to land :-)

paulholden
paulholden approved these changes Mar 20, 2023
View reviewed changes

@paulholdenpaulholden left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super!

@paulholden
paulholden added this pull request to the merge queueMar 20, 2023
@paulholden
paulholden merged commit 4ab94f0 into moodle:mainMar 20, 2023
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@paulholdenpaulholdenpaulholden approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

https://docs.moodle.org/dev/Experience_API_(xAPI)

2 participants

@sarjona@paulholden