-
Notifications
You must be signed in to change notification settings - Fork 62
Fix style #108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix style #108
Changes from all commits
82838ce
e4be7f3
9b365a6
cca7413
2e76866
7a3c004
9b8fe52
5deb6f1
a9b5186
6368d30
7212b42
82f23e8
b65fe5b
2c64ef9
c6b86c3
3704275
8aa9e13
21ac09f
620e14d
53d2c39
b316d75
c9d3fcc
4cc24f2
2fd6688
7105cfd
b9224ed
83c0ba3
060eb59
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -22,3 +22,8 @@ logs | |
| npm-debug.log* | ||
| yarn-debug.log* | ||
| yarn-error.log* | ||
|
|
||
| .anima | ||
| data | ||
| build | ||
| scripts | ||
| Original file line number | Diff line number | Diff line change | ||||||||||||||||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
|
|
@@ -11,19 +11,19 @@ Our decentralized sequencer design and innovative Layer 2 approach address block | |||||||||||||||||||||||||||||||||||
| 1. [What is & Why Responsive Validity Proof?](https://docs.morphl2.io/docs/how-morph-works/optimistic-zkevm) | ||||||||||||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||||||||||||
| 2. [How Does RVP Run in Morph?](https://medium.com/@morphlayer2/how-does-rvp-run-in-morph-6025233a21cc) | ||||||||||||||||||||||||||||||||||||
| 2. [How Does RVP Run in Morph?](https://medium.com/@morphlayer/how-does-rvp-run-in-morph-6025233a21cc) | ||||||||||||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||||||||||||
| 3. [Morph's Origins and Aspirations](https://medium.com/@morphlayer2/morphys-origins-and-aspirations-7afc0280a8e2) | ||||||||||||||||||||||||||||||||||||
| 3. [Morph's Origins and Aspirations](https://medium.com/@morphlayer/morphys-origins-and-aspirations-7afc0280a8e2) | ||||||||||||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||||||||||||
| ## Learn more | ||||||||||||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||||||||||||
| Website: https://www.morphl2.io/ | ||||||||||||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||||||||||||
| Twitter: https://x.com/MorphLayer | ||||||||||||||||||||||||||||||||||||
| Twitter: https://x.com/MorphNetwork | ||||||||||||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||||||||||||
| Medium: [Morph – Medium](https://medium.com/@morphlayer2) | ||||||||||||||||||||||||||||||||||||
| Medium: [Morph – Medium](https://medium.com/@morphlayer) | ||||||||||||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||||||||||||
| Telegram: https://t.me/MorphL2official | ||||||||||||||||||||||||||||||||||||
| Telegram: https://t.me/MorphGlobal | ||||||||||||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||||||||||||
|
Comment on lines
21
to
28
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Fix markdownlint MD034: avoid bare URLs in README -Website: https://www.morphl2.io/
+Website: [morphl2.io](https://www.morphl2.io/)
-Twitter: https://x.com/MorphNetwork
+Twitter: [x.com/MorphNetwork](https://x.com/MorphNetwork)
Medium: [Morph – Medium](https://medium.com/@morphlayer)
-Telegram: https://t.me/MorphGlobal
+Telegram: [t.me/MorphGlobal](https://t.me/MorphGlobal)📝 Committable suggestion
Suggested change
🧰 Tools🪛 markdownlint-cli2 (0.18.1)21-21: Bare URL used (MD034, no-bare-urls) 23-23: Bare URL used (MD034, no-bare-urls) 27-27: Bare URL used (MD034, no-bare-urls) 🤖 Prompt for AI Agents |
||||||||||||||||||||||||||||||||||||
| Gmail: official@morphl2.io | ||||||||||||||||||||||||||||||||||||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -95,18 +95,14 @@ Find detailed API methods, contract addresses, and other useful resources. | |
| href="/docs/build-on-morph/developer-resources/dapp-examples-on-morph" | ||
| icon="/img/cards/guide.svg" | ||
| text="Dapp Examples" /> | ||
| <Card | ||
| href="/docs/build-on-morph/developer-resources/morph-json-rpc-api-methods" | ||
| icon="/img/cards/tools.svg" | ||
| text="Morph JSON-RPC API" /> | ||
| </CardGroup> | ||
|
|
||
| ### Engage in Our Developer Community | ||
|
|
||
| We are actively enhancing the network with more integrations and support infrastructure as we progress toward our mainnet launch. | ||
| Join our developer community: | ||
|
|
||
| - [Discord](https://discord.com/invite/MorphLayer) | ||
| - [Discord](https://discord.gg/invite/MorphNetwork) | ||
| - [𝕏](https://twitter.com/MorphLayer) | ||
| - [Morph Builder X](https://x.com/MorphDevs) | ||
|
|
||
|
Comment on lines
+105
to
108
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🧩 Analysis chain🌐 Web query:
💡 Result: Your example is malformed. Valid Discord invite URLs use one of these formats:
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -180,6 +180,6 @@ Once succeeded, you can check your contract and the deployment transaction on [M | |
|
|
||
| ## Questions and Feedback | ||
|
|
||
| Thank you for participating in and developing on the Morph Hoodi Testnet! If you encounter any issues, join our [Discord](https://discord.com/invite/MorphLayer) and find us at #dev-support channel. | ||
| Thank you for participating in and developing on the Morph Hoodi Testnet! If you encounter any issues, join our [Discord](https://discord.gg/invite/MorphNetwork) and find us at #dev-support channel. | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🧩 Analysis chain🌐 Web query:
💡 Result: Short answer: Both are valid invite URLs and point to the same invite code. discord.gg/
|
||
|
|
||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -55,7 +55,7 @@ Currently, each Discord user can only request tokens once every 24 hours. | |
| You can obtain Morph’s version of USDT on Hoodi through our Discord faucet. Here’s how: | ||
|
|
||
|
|
||
| 1. Join our Discord server using this [link](https://discord.com/invite/MorphLayer). | ||
| 1. Join our Discord server using this [link](https://discord.gg/invite/MorphNetwork). | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🧩 Analysis chain🏁 Script executed: # Check if the file exists and read the relevant section
head -n 60 docs/quick-start/3-faucet.md | tail -n 10Repository: morph-l2/morph-doc Length of output: 368 🌐 Web query:
💡 Result: MD059 (descriptive-link-text) — rule: "Link text should be descriptive." It flags links whose anchor text is non‑descriptive (e.g., "click here", "here", "this", raw URLs shown as link text) and recommends using meaningful text that explains the link target. [1][2] Quick notes:
Sources: markdownlint repo (rules/config/docs). [1] GitHub — DavidAnson/markdownlint; [2] GitLab issue discussing MD059 and examples. 🌐 Web query:
💡 Result: No — "discord.gg/invite" is not a valid invite. Valid invite URLs use a code after either:
The invite_code is the server’s alphanumeric code (case‑sensitive). See Discord support on invite links and invalid invites. [1][2] Sources: Citations:
Fix non-descriptive link text and correct invalid Discord URL MD059 is correct—replace "this [link]" with descriptive text. However, the Discord invite URL format is invalid. -1. Join our Discord server using this [link](https://discord.gg/invite/MorphNetwork).
+1. Join our [MorphNetwork Discord server](https://discord.gg/<correct_invite_code>).Replace
🧰 Tools🪛 markdownlint-cli2 (0.18.1)58-58: Link text should be descriptive (MD059, descriptive-link-text) 🤖 Prompt for AI Agents |
||
|
|
||
| 2. Navigate to the *#| discord-faucet* channel. | ||
|
|
||
|
|
||
| Original file line number | Diff line number | Diff line change | ||||||||||||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
|
|
@@ -17,22 +17,38 @@ server { | |||||||||||||||||||||||||||||||
| gzip_types text/plain text/css application/json application/javascript text/xml application/xml application/xml+rss text/javascript; | ||||||||||||||||||||||||||||||||
| gzip_min_length 1000; | ||||||||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||||||||
| # Security headers | ||||||||||||||||||||||||||||||||
| add_header X-Frame-Options "SAMEORIGIN" always; | ||||||||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||||||||
| location ~ ^/docs/(about-morph|build-on-morph|how-morph-works|quick-start)(/.*)?$ { | ||||||||||||||||||||||||||||||||
| if ($request_uri !~ ^(.+)/$) { | ||||||||||||||||||||||||||||||||
| rewrite ^(.*[^/])$ https://$host$1/ permanent; | ||||||||||||||||||||||||||||||||
| } | ||||||||||||||||||||||||||||||||
| try_files $uri $uri/ /index.html; | ||||||||||||||||||||||||||||||||
| add_header Cache-Control "max-age=0, no-cache, no-store, must-revalidate"; | ||||||||||||||||||||||||||||||||
| add_header X-Frame-Options "SAMEORIGIN" always; | ||||||||||||||||||||||||||||||||
| charset utf-8; | ||||||||||||||||||||||||||||||||
| } | ||||||||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||||||||
| # HTML files with short cache (60 seconds) | ||||||||||||||||||||||||||||||||
| location ~* \.html?$ { | ||||||||||||||||||||||||||||||||
| add_header Cache-Control "max-age=0, no-cache, no-store, must-revalidate"; | ||||||||||||||||||||||||||||||||
| add_header X-Frame-Options "SAMEORIGIN" always; | ||||||||||||||||||||||||||||||||
| charset utf-8; | ||||||||||||||||||||||||||||||||
| try_files $uri =404; | ||||||||||||||||||||||||||||||||
| } | ||||||||||||||||||||||||||||||||
|
Comment on lines
+33
to
39
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Potential SPA regression: - # HTML files with short cache (60 seconds)
+ # HTML files (no-store)
location ~* \.html?$ {
add_header Cache-Control "max-age=0, no-cache, no-store, must-revalidate";
add_header X-Frame-Options "SAMEORIGIN" always;
charset utf-8;
- try_files $uri =404;
+ # If SPA routing is expected for .html paths, keep the fallback:
+ try_files $uri /index.html;
}📝 Committable suggestion
Suggested change
🤖 Prompt for AI Agents |
||||||||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||||||||
| location / { | ||||||||||||||||||||||||||||||||
| try_files $uri $uri.html $uri/ /index.html; | ||||||||||||||||||||||||||||||||
| expires 7d; | ||||||||||||||||||||||||||||||||
| add_header Cache-Control "public, no-transform"; | ||||||||||||||||||||||||||||||||
| add_header Cache-Control "max-age=0, no-cache, no-store, must-revalidate"; | ||||||||||||||||||||||||||||||||
| add_header X-Frame-Options "SAMEORIGIN" always; | ||||||||||||||||||||||||||||||||
| charset utf-8; | ||||||||||||||||||||||||||||||||
| } | ||||||||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||||||||
| # Static assets with long cache (30 days) | ||||||||||||||||||||||||||||||||
| location ~ ^/(assets|fonts|img|logo|lottie|share)/ { | ||||||||||||||||||||||||||||||||
| expires 30d; | ||||||||||||||||||||||||||||||||
| add_header Cache-Control "public, no-transform"; | ||||||||||||||||||||||||||||||||
| add_header Cache-Control "public, immutable, max-age=2592000"; | ||||||||||||||||||||||||||||||||
| add_header X-Frame-Options "SAMEORIGIN" always; | ||||||||||||||||||||||||||||||||
| access_log off; | ||||||||||||||||||||||||||||||||
| } | ||||||||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||||||||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -17,22 +17,38 @@ server { | |
| gzip_types text/plain text/css application/json application/javascript text/xml application/xml application/xml+rss text/javascript; | ||
| gzip_min_length 1000; | ||
|
|
||
| # Security headers | ||
| add_header X-Frame-Options "SAMEORIGIN" always; | ||
|
|
||
| location ~ ^/docs/(about-morph|build-on-morph|how-morph-works|quick-start)(/.*)?$ { | ||
| if ($request_uri !~ ^(.+)/$) { | ||
| rewrite ^(.*[^/])$ https://$host$1/ permanent; | ||
| } | ||
| try_files $uri $uri/ /index.html; | ||
| add_header Cache-Control "max-age=0, no-cache, no-store, must-revalidate"; | ||
| add_header X-Frame-Options "SAMEORIGIN" always; | ||
| charset utf-8; | ||
| } | ||
|
|
||
| # HTML files with short cache (60 seconds) | ||
| location ~* \.html?$ { | ||
| add_header Cache-Control "max-age=0, no-cache, no-store, must-revalidate"; | ||
| add_header X-Frame-Options "SAMEORIGIN" always; | ||
| charset utf-8; | ||
| try_files $uri =404; | ||
| } | ||
|
Comment on lines
+33
to
39
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Same SPA risk as mainnet: 🤖 Prompt for AI Agents |
||
|
|
||
| location / { | ||
| try_files $uri $uri.html $uri/ /index.html; | ||
| expires 7d; | ||
| add_header Cache-Control "public, no-transform"; | ||
| add_header Cache-Control "max-age=0, no-cache, no-store, must-revalidate"; | ||
| add_header X-Frame-Options "SAMEORIGIN" always; | ||
| charset utf-8; | ||
| } | ||
|
|
||
| # Static assets with long cache (30 days) | ||
| location ~ ^/(assets|fonts|img|logo|lottie|share)/ { | ||
| expires 30d; | ||
| add_header Cache-Control "public, no-transform"; | ||
| add_header Cache-Control "public, immutable, max-age=2592000"; | ||
| add_header X-Frame-Options "SAMEORIGIN" always; | ||
| access_log off; | ||
| } | ||
|
|
||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -45,18 +45,18 @@ export const links = { | |
| explorerApi: 'https://explorer-api.morphl2.io', // /api/v2/stats | ||
| bridge: 'https://bridge.morphl2.io', | ||
|
|
||
| holeskyWalletSetup: 'https://morphl2.io/docs/quick-start/wallet-setup/', | ||
| holeskyApiDocs: 'https://explorer-holesky.morphl2.io/api-docs', | ||
| holeskyExplorer: 'https://explorer-holesky.morphl2.io', | ||
| holeskyExplorerApi: 'https://explorer-api-holesky.morphl2.io', | ||
| holeskyBridge: 'https://bridge-holesky.morphl2.io', | ||
| hoodiWalletSetup: 'https://morphl2.io/docs/quick-start/wallet-setup/', | ||
| hoodiApiDocs: 'https://explorer-hoodi.morphl2.io/api-docs', | ||
| hoodiExplorer: 'https://explorer-hoodi.morphl2.io', | ||
| hoodiExplorerApi: 'https://explorer-api-hoodi.morphl2.io', | ||
| hoodiBridge: 'https://bridge-hoodi.morphl2.io', | ||
|
|
||
| // social | ||
| medium: 'https://blog.morphl2.io/', | ||
| twitter: 'https://x.com/MorphLayer', | ||
| telegram: 'https://t.me/MorphL2official', | ||
| twitter: 'https://x.com/MorphNetwork', | ||
| telegram: 'https://t.me/MorphGlobal', | ||
| // 'https://t.me/+qslsWvH2_-1iMTdl', | ||
| discord: 'https://discord.com/invite/MorphLayer', | ||
| discord: 'https://discord.gg/invite/MorphNetwork', | ||
| linkedIn: 'http://www.linkedin.com/company/morphl2', | ||
|
Comment on lines
+56
to
60
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🧩 Analysis chain🏁 Script executed: cat -n src/components/config.js | head -85Repository: morph-l2/morph-doc Length of output: 3848 🏁 Script executed: rg 'discord' src/components/config.js -iRepository: morph-l2/morph-doc Length of output: 285 🌐 Web query:
💡 Result: Valid Discord invite URL formats: What {code} looks like:
Is discord.gg/invite valid?
Security note (brief): expired/deleted invites can be reused/misused, so verify sources before clicking. (research.checkpoint.com) Citations:
🏁 Script executed: # Check what the intended vanity invite code might be
grep -n "MorphNetwork\|MorphGlobal" src/components/config.jsRepository: morph-l2/morph-doc Length of output: 250 Fix Discord invite URL format at line 59 The URL 🤖 Prompt for AI Agents |
||
|
|
||
| facebook: 'https://www.facebook.com/profile.php?id=61554448708419', | ||
|
|
@@ -70,10 +70,10 @@ export const links = { | |
|
|
||
| faucet: '', | ||
|
|
||
| holeskyUSDT: 'https://discord.com/channels/1156486804661338162/1199665829730582620', | ||
| holeskyETH: "https://holesky-faucet.pk910.de/", | ||
| hoodiUSDT: 'https://discord.com/channels/1156486804661338162/1199665829730582620', | ||
| hoodiETH: "https://hoodi-faucet.pk910.de/", | ||
| sepoliafaucet: "https://sepoliafaucet.com/", | ||
| usdtfaucet: "https://discord.com/channels/1156486804661338162/1199665829730582620", | ||
|
|
||
| community: 'https://x.com/MorphLayer', | ||
| community: 'https://x.com/MorphNetwork', | ||
| } | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Avoid ignoring a generic
scripts/directory (high risk of hiding real repo tooling).If you meant only generated artifacts, prefer a more specific pattern (e.g.,
scripts/generated/), and remove the redundantbuildentry.📝 Committable suggestion
🤖 Prompt for AI Agents