-
Notifications
You must be signed in to change notification settings - Fork 62
update blocksec audit report #117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
|
|
@@ -78,6 +78,9 @@ We commissioned a full security audit from Sherlock, and the results are publicl | |||||||||||||
|
|
||||||||||||||
| The Trail of Bits team conducted an in-depth audit of our codebase, including verification of implemented fixes. The complete report is available here [Trail of Bits Audit Report](https://github.com/morph-l2/audits/blob/main/tob/Morph%20-%20Comprehensive%20Report%20with%20Fix%20Review.pdf). | ||||||||||||||
|
|
||||||||||||||
| ### Blocksec Audit Report: | ||||||||||||||
|
|
||||||||||||||
| We commissioned Blocksec to conduct a full security audit of Morph’s EmeraId upgrade. The audit assessed the upgrade’s robustness and adherence to security best practices and was executed according to an agreed scope and testing plan tailored for this implementation. The audit report is available here [Blocksec Audit Report](https://github.com/morph-l2/audits/blob/main/blocksec/blocksec_morph_emerald_upgrade_v1.0-signed.pdf). | ||||||||||||||
|
Comment on lines
+81
to
+83
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Fix spelling error: "EmeraId" → "Emerald" The feature name is misspelled as "EmeraId" but the actual report filename uses the correct spelling "emerald_upgrade_v1.0". Update the text to match. 🔎 Proposed fix- We commissioned Blocksec to conduct a full security audit of Morph's EmeraId upgrade. The audit assessed the upgrade's robustness and adherence to security best practices and was executed according to an agreed scope and testing plan tailored for this implementation. The audit report is available here [Blocksec Audit Report](https://github.com/morph-l2/audits/blob/main/blocksec/blocksec_morph_emerald_upgrade_v1.0-signed.pdf).
+ We commissioned Blocksec to conduct a full security audit of Morph's Emerald upgrade. The audit assessed the upgrade's robustness and adherence to security best practices and was executed according to an agreed scope and testing plan tailored for this implementation. The audit report is available here [Blocksec Audit Report](https://github.com/morph-l2/audits/blob/main/blocksec/blocksec_morph_emerald_upgrade_v1.0-signed.pdf).📝 Committable suggestion
Suggested change
🧰 Tools🪛 LanguageTool[grammar] ~83-~83: Ensure spelling is correct (QB_NEW_EN_ORTHOGRAPHY_ERROR_IDS_1) 🤖 Prompt for AI Agents |
||||||||||||||
|
|
||||||||||||||
| ### Audit Scope: | ||||||||||||||
|
|
||||||||||||||
|
|
||||||||||||||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix spelling errors: "EmeraId" → "Emerald" and standardize section header capitalization
The feature name is misspelled as "EmeraId" in two places (lines 293 and 298), but the actual report filename uses the correct spelling "emerald_upgrade_v1.0". Additionally, the section header uses lowercase "report" whereas the corresponding section in docs/about-morph/4-morphs-architecture.md uses uppercase "Report" for consistency.
🔎 Proposed fix
📝 Committable suggestion
🧰 Tools
🪛 LanguageTool
[grammar] ~293-~293: Ensure spelling is correct
Context: ...onduct a full security audit of Morph’s EmeraId implementation, initiated on November 2...
(QB_NEW_EN_ORTHOGRAPHY_ERROR_IDS_1)
[grammar] ~298-~298: Ensure spelling is correct
Context: ...l Blocksec report: [Access the Blocksec EmeraId Audit Report](https://github.com/morph-...
(QB_NEW_EN_ORTHOGRAPHY_ERROR_IDS_1)
🤖 Prompt for AI Agents